public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/40667] [4.4/4.5 Regression] stack frames are generated even with -fomit-frame-pointer
Date: Thu, 09 Jul 2009 13:25:00 -0000 [thread overview]
Message-ID: <20090709132520.23808.qmail@sourceware.org> (raw)
In-Reply-To: <bug-40667-1600@http.gcc.gnu.org/bugzilla/>
------- Comment #8 from jakub at gcc dot gnu dot org 2009-07-09 13:25 -------
Created an attachment (id=18170)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18170&action=view)
gcc45-pr40667.patch
Very ugly patch which just shows that changing these 3 spots helps both of
these testcases. It uses minimum of the currently used alignment and
LOCAL_ALIGNMENT/LOCAL_DECL_ALIGNMENT/STACK_SLOT_ALIGNMENT, so only when these
functions return smaller alignment than expected they change anything. As only
i386/x86_64 is SUPPORTS_STACK_ALIGNMENT supporting platform and only for DImode
on -m32 we ever decrease the stack alignment, this shouldn't break anything.
BTW, the patch also changes something that looks like a thinko to me:
unsigned int align = FUNCTION_ARG_BOUNDARY (data.promoted_mode,
data.passed_type);
if (TYPE_ALIGN (data.nominal_type) > align)
align = TYPE_ALIGN (data.passed_type);
data.passed_type has already been used in FUNCTION_BOUNDARY computation, so it
really surprises me it doesn't use nominal_type's TYPE_ALIGN instead.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40667
next prev parent reply other threads:[~2009-07-09 13:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 2:25 [Bug regression/40667] New: Performance regression: " mikulas at artax dot karlin dot mff dot cuni dot cz
2009-07-07 9:07 ` [Bug regression/40667] " rguenth at gcc dot gnu dot org
2009-07-07 14:41 ` hjl dot tools at gmail dot com
2009-07-07 16:48 ` mikulas at artax dot karlin dot mff dot cuni dot cz
2009-07-09 9:05 ` [Bug rtl-optimization/40667] [4.4/4.5 Regression] " ubizjak at gmail dot com
2009-07-09 9:20 ` ubizjak at gmail dot com
2009-07-09 11:45 ` jakub at gcc dot gnu dot org
2009-07-09 12:05 ` jakub at gcc dot gnu dot org
2009-07-09 12:56 ` jakub at gcc dot gnu dot org
2009-07-09 13:25 ` jakub at gcc dot gnu dot org [this message]
2009-07-09 13:58 ` hjl dot tools at gmail dot com
2009-07-09 15:49 ` rguenth at gcc dot gnu dot org
2009-07-09 16:24 ` jakub at gcc dot gnu dot org
2009-07-09 16:35 ` hjl dot tools at gmail dot com
2009-07-11 17:40 ` jakub at gcc dot gnu dot org
2009-07-11 19:06 ` jakub at gcc dot gnu dot org
2009-07-11 19:07 ` jakub at gcc dot gnu dot org
2009-07-23 11:13 ` mikulas at artax dot karlin dot mff dot cuni dot cz
2009-07-23 11:18 ` mikulas at artax dot karlin dot mff dot cuni dot cz
2009-07-23 11:36 ` jakub at gcc dot gnu dot org
2009-07-23 12:17 ` mikulas at artax dot karlin dot mff dot cuni dot cz
2009-07-23 12:34 ` jakub at gcc dot gnu dot org
2009-07-23 13:28 ` mikulas at artax dot karlin dot mff dot cuni dot cz
2009-08-08 10:41 ` mikulas at artax dot karlin dot mff dot cuni dot cz
2009-08-08 11:45 ` hjl dot tools at gmail dot com
2009-08-08 14:15 ` mikulas at artax dot karlin dot mff dot cuni dot cz
2009-08-11 21:01 ` mikulas at artax dot karlin dot mff dot cuni dot cz
2010-02-15 4:23 ` [Bug target/40667] " pinskia at gcc dot gnu dot org
2010-02-15 10:34 ` mikulas at artax dot karlin dot mff dot cuni dot cz
2010-06-29 21:17 ` [Bug target/40667] [4.4/4.5/4.6 " pinskia at gcc dot gnu dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090709132520.23808.qmail@sourceware.org \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).