[Bug c++/40752] New: -Wconversion generates false warnings

[Bug c++/40752] New: -Wconversion generates false warnings

[photon at seznam dot cz]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 636 bytes --]

-Wconversion generates false warnings for the following clean code:

{
        char c = 1;
        char c2 = 2;

        // warning: conversion to ‘char’ from ‘int’ may alter its value
        c >>= 1;
        c += (char) 1;
        c += c2;
        c = ~c2;
}


-- 
           Summary: -Wconversion generates false warnings
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: photon at seznam dot cz


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion generates false warnings

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2009-07-14 19:21 -------
Theses are not false warnings:
        c >>= 1;

is really c = (int)c >> 1;

        c += (char) 1;

c =  (int)c + (int)(char)1;

        c += c2;

c = (int)c + (int) c2;


        c = ~c2;

c = ~(int)c2;

Only the last one might be a false warning depending on if c2 is negative or
unsigned or not.  The rest are correct because of the way C/C++ define
arithmetic operations and automatic promotions.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion generates false warnings

[manu at gcc dot gnu dot org]

------- Comment #2 from manu at gcc dot gnu dot org  2009-07-14 20:55 -------
Andrew, what you say is true, but in this case the warning is not very useful.
I'd prefer to warn only when the operator is larger than the target of the
assignment. I would like to hear other opinions.


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |iant at google dot com, manu
                   |                            |at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion generates false warnings

[manu at gcc dot gnu dot org]

------- Comment #3 from manu at gcc dot gnu dot org  2009-07-14 20:56 -------
Joseph, could you comment on this?


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joseph at codesourcery dot
                   |                            |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion generates false warnings

[ian at airs dot com]

------- Comment #4 from ian at airs dot com  2009-07-14 22:23 -------
Manu, I agree that these warnings are in some sense technically correct but
they are not useful.  They can't point to any actual bug.  I guess would be
that if every input to the expression has the size of the target of the
expression, then the warning should be suppressed.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion: do not warn for operands not larger than target type

[manu at gcc dot gnu dot org]

------- Comment #5 from manu at gcc dot gnu dot org  2009-07-14 22:30 -------
Then, let's keep this around as an enhancement request. 


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-07-14 22:30:09
               date|                            |
            Summary|-Wconversion generates false|-Wconversion: do not warn
                   |warnings                    |for operands not larger than
                   |                            |target type


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion: do not warn for operands not larger than target type

[photon at seznam dot cz]

------- Comment #6 from photon at seznam dot cz  2009-07-15 07:50 -------
(In reply to comment #1)
> Theses are not false warnings:
>         c >>= 1;
> 
> is really c = (int)c >> 1;

They are false warnings. The implicit conversion cannot alter the value.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion: do not warn for operands not larger than target type

[photon at seznam dot cz]

------- Comment #7 from photon at seznam dot cz  2009-07-15 07:54 -------
(In reply to comment #5)
> Then, let's keep this around as an enhancement request. 
> 

I think this is actually a bug as the specification of the warning is: Warn for
implicit conversions that may alter a value. This is not the case here.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion: do not warn for operands not larger than target type

[pinskia at gcc dot gnu dot org]

------- Comment #8 from pinskia at gcc dot gnu dot org  2009-07-15 08:13 -------
For:

        c += (char) 1;

The value can change as you have a wrapping if c is CHAR_MAX.

Likewise with:
    c += c2;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion: do not warn for operands not larger than target type

[ian at airs dot com]

------- Comment #9 from ian at airs dot com  2009-07-15 14:00 -------
Sure, it can wrap, but -Wconversion is not for wrapping warnings.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion: do not warn for operands not larger than target type

[joseph at codesourcery dot com]

------- Comment #10 from joseph at codesourcery dot com  2009-07-15 14:15 -------
Subject: Re:  -Wconversion: do not warn for operands not larger
 than target type

On Wed, 15 Jul 2009, ian at airs dot com wrote:

> Sure, it can wrap, but -Wconversion is not for wrapping warnings.

It's for warnings about implicit conversions changing a value; the 
arithmetic, in a wider type (deliberately or otherwise), does not wrap, 
but the value gets changed by the implicit conversion back to char.  If 
the user had explicit casts to int in their arithmetic, there could be no 
doubt that the warning is appropriate.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion: do not warn for operands not larger than target type

[photon at seznam dot cz]

------- Comment #11 from photon at seznam dot cz  2009-07-15 16:55 -------
(In reply to comment #8)
> For:
> 
>         c += (char) 1;
> 
> The value can change as you have a wrapping if c is CHAR_MAX.
> 
> Likewise with:
>     c += c2;
> 

The value cannot change even if an overflow occurs.

{
        unsigned char c = 0xff;
        c += 1;
        // c is 0 here

        c = 0xff;
        c = (unsigned int)c + 1;
        // c is 0 here
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion: do not warn for operands not larger than target type

[pinskia at gcc dot gnu dot org]

------- Comment #12 from pinskia at gcc dot gnu dot org  2009-07-15 16:58 -------
Except it does alter its value from 0x100 to 0x00 :).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion: do not warn for operands not larger than target type

[pinskia at gcc dot gnu dot org]

------- Comment #13 from pinskia at gcc dot gnu dot org  2009-07-15 17:00 -------
Or rather from SCHAR_MAX + 1 to SCHAR_MIN :).  Since it is 0x7F + 1 ==
(int)0x80.  So we have a negative value now from a positive value.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion: do not warn for operands not larger than target type

[photon at seznam dot cz]

------- Comment #14 from photon at seznam dot cz  2009-07-15 18:24 -------
(In reply to comment #13)
> Or rather from SCHAR_MAX + 1 to SCHAR_MIN :).  Since it is 0x7F + 1 ==
> (int)0x80.  So we have a negative value now from a positive value.
> 

This occurs regardless of the implicit conversion. The implicit conversion
cannot alter the result. Therefore, the warning is false in this case too.

{
        char c = 0x7f;
        ++c;
        // c is 0x80 here

        c = 0x7f;
        c = (int)c + 1;
        // c is 0x80 here
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion generates false warnings for operands not larger than target type

[photon at seznam dot cz]

-- 

photon at seznam dot cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
            Summary|-Wconversion: do not warn   |-Wconversion generates false
                   |for operands not larger than|warnings for operands not
                   |target type                 |larger than target type


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion generates false warnings for operands not larger than target type

[manu at gcc dot gnu dot org]

------- Comment #15 from manu at gcc dot gnu dot org  2009-07-23 15:35 -------
Patch: http://gcc.gnu.org/ml/gcc-patches/2009-07/msg01179.html


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2009-
                   |                            |07/msg01179.html


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion generates false warnings for operands not larger than target type

[manu at gcc dot gnu dot org]

------- Comment #16 from manu at gcc dot gnu dot org  2009-09-05 14:05 -------
*** Bug 41274 has been marked as a duplicate of this bug. ***


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ashaduri at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion generates false warnings for operands not larger than target type

[manu at gcc dot gnu dot org]

------- Comment #17 from manu at gcc dot gnu dot org  2010-06-11 20:22 -------
The patch was rejected but it may be accepted by using a new -Wno-* option to
disable these warnings. Perhaps -Wno-conversion-after-promotion?

Suggestions are welcome.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752

[Bug c++/40752] -Wconversion generates false warnings for operands not larger than target type

[photon at seznam dot cz]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]



------- Comment #18 from photon at seznam dot cz  2010-06-12 16:46 -------
(In reply to comment #17)
> The patch was rejected but it may be accepted by using a new -Wno-* option to
> disable these warnings. Perhaps -Wno-conversion-after-promotion?
> 
> Suggestions are welcome.
> 


-Wconversion should be fixed to work as specified. No warning should be
generated for the following code:

char c = 2;
// warning: conversion to ‘char’ from ‘int’ may alter its value
c >>= 1;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40752