public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "carrot at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/40730] redundant memory load
Date: Wed, 15 Jul 2009 08:07:00 -0000	[thread overview]
Message-ID: <20090715080710.2057.qmail@sourceware.org> (raw)
In-Reply-To: <bug-40730-17659@http.gcc.gnu.org/bugzilla/>



------- Comment #7 from carrot at google dot com  2009-07-15 08:07 -------
(In reply to comment #6)
> Carrot, can you please try this test case with my patch
> "crossjump_abstract.diff" from Bug 20070 applied?
> 

I tried your patch. It did remove the redundant memory load. Following is the
output

        push    {lr}
        ldr     r3, [r1]
.L6:
        str     r3, [r0]
        mov     r2, r3          // M
        cmp     r3, #0
        bne     .L5
        b       .L3
.L4:
        ldr     r3, [r3, #8]
        b       .L6
.L5:
        ldr     r1, [r3, #4]
        cmp     r1, #0
        beq     .L4
.L3:
        str     r2, [r0, #12]
        @ sp needed for prologue
        pop     {pc}

In pass ifcvt it noticed the difference of two stores is the different pseudo
register number and there is no conflict between the two pseudo registers, so
it rename one of them to the same as another and do basic block cross jump on
them earlier. Then pass iterate.c.161r.cse2 detected the redundant load and
remove it.

But it introduced another redundant move instruction marked as M. At the place
r2 is used, r3 still contain the same result as r2, so we can also use r3
there. I think this is another problem.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40730


  parent reply	other threads:[~2009-07-15  8:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-13  8:57 [Bug target/40730] New: " carrot at google dot com
2009-07-13  8:58 ` [Bug target/40730] " carrot at google dot com
2009-07-13  9:51 ` rguenth at gcc dot gnu dot org
2009-07-13 10:10 ` steven at gcc dot gnu dot org
2009-07-14  9:14 ` carrot at google dot com
2009-07-14  9:18 ` steven at gcc dot gnu dot org
2009-07-14  9:20 ` steven at gcc dot gnu dot org
2009-07-15  8:07 ` carrot at google dot com [this message]
2009-07-15  9:47 ` steven at gcc dot gnu dot org
2010-01-08  9:34 ` steven at gcc dot gnu dot org
2010-01-11  6:47 ` carrot at google dot com
2010-01-11  8:23 ` stevenb dot gcc at gmail dot com
2010-01-11  8:56 ` carrot at google dot com
     [not found] <bug-40730-4@http.gcc.gnu.org/bugzilla/>
2023-05-15  0:10 ` pinskia at gcc dot gnu.org
2023-05-15  0:24 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090715080710.2057.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).