[Bug c++/40092] New: -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[Bug c++/40092] New: -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[cppljevans at suddenlink dot net]

When compile trysto expand:

  : seq
  < integral_c
    < Integral
    , Vals
    >...

the error diagnostic prints integral_c<T, val> instead of 
integral_c<Integral,Vals>.  The integral_constant template
is derived from integral_c and does have T and val args:

struct integral_constant:public mpl::integral_c < T, val >

However, when that is replaced with:

struct integral_constant;//:public mpl::integral_c < T, val >

Compilation succeeds.


-- 
           Summary: -std=gnu++0x expansion pattern fails with error about
                    derived template instead of actual template
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: cppljevans at suddenlink dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[cppljevans at suddenlink dot net]

------- Comment #1 from cppljevans at suddenlink dot net  2009-05-10 16:22 -------
Created an attachment (id=17844)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17844&action=view)
The .ii file


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[cppljevans at suddenlink dot net]

------- Comment #2 from cppljevans at suddenlink dot net  2009-05-10 16:22 -------
Created an attachment (id=17845)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17845&action=view)
compilation output


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[cppljevans at suddenlink dot net]

------- Comment #3 from cppljevans at suddenlink dot net  2009-05-10 16:24 -------
Created an attachment (id=17846)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17846&action=view)
system type


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[cppljevans at suddenlink dot net]

------- Comment #4 from cppljevans at suddenlink dot net  2009-05-15 01:19 -------
Created an attachment (id=17869)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17869&action=view)
Much simpler code showing problem

Code has #defines which can be enabled or disabled to 
show or hide bug.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

Re: [Bug c++/40092] -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[Larry Evans]

On 05/14/09 20:19, cppljevans at suddenlink dot net wrote:
> ------- Comment #4 from cppljevans at suddenlink dot net  2009-05-15 01:19 -------
> Created an attachment (id=17869)
>  --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17869&action=view)
> Much simpler code showing problem
> 
> Code has #defines which can be enabled or disabled to 
> show or hide bug.
> 
> 

The same error occurs with snapshot:

ftp://gcc.gnu.org/pub/gcc/snapshots/4.4-20090519/gcc-4.4-20090519.tar.bz2

The error message is from gcc/cp/pt.c:2692.  I suspect there's some
problem in find_parameter_packs_r used as arg a few lines up as:

   cp_walk_tree (&arg, &find_parameter_packs_r, &ppd, ppd.visited);

I've tried using gdb stepping to see where the problem is; however,
it's so hard to understand the tree structure and which type of
tree is supposed to be valid with a given TREE_CODE(t), that I
haven't had much success yet.

Help on how to debug this would be appreciated.

[Bug c++/40092] -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[cppljevans at suddenlink dot net]

------- Comment #5 from cppljevans at suddenlink dot net  2009-06-11 21:24 -------
Created an attachment (id=17984)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17984&action=view)
another version of earlier attach with a little different code but similar
error msg

This version shows a little different error.  The compiler error msg
suggests compiler is looking at wrong subtree.  In this version
it appears to think Values is the expansion pattern; however,
integral_c<Integral,Values> is the actual expansion pattern.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[cppljevans at suddenlink dot net]

------- Comment #6 from cppljevans at suddenlink dot net  2009-07-13 12:48 -------
Created an attachment (id=18184)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18184&action=view)
Similar but simpler source (no Tail... in impl_front specialization)

Same error message, but no Tail... in impl_front template.
Compile output in separate attachment.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[cppljevans at suddenlink dot net]

------- Comment #7 from cppljevans at suddenlink dot net  2009-07-13 12:50 -------
Created an attachment (id=18185)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18185&action=view)
compilation using gcc-4.5-20090702

Compiler source from:

ftp://gcc.gnu.org/pub/gcc/snapshots/4.5-20090702/gcc-4.5-20090702.tar.bz2


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[cppljevans at suddenlink dot net]

------- Comment #8 from cppljevans at suddenlink dot net  2009-08-03 12:08 -------
Created an attachment (id=18288)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18288&action=view)
Shows Value_0 fail but Value_1 pass

Since Value_0 and Value_1 only differ in argument number, hopefully
this gives some further hint about where problem lies.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

Re: [Bug c++/40092] solution in cp_tree_equal (was Re: [Bug c++/40092] New: -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[Larry Evans]

On 05/10/09 11:20, cppljevans at suddenlink dot net wrote:
> When compile trysto expand:
> 
>   : seq
>   < integral_c
>     < Integral
>     , Vals
>     >...
> 
> the error diagnostic prints integral_c<T, val> instead of 
> integral_c<Integral,Vals>.  The integral_constant template
> is derived from integral_c and does have T and val args:
> 
> struct integral_constant:public mpl::integral_c < T, val >
> 
> However, when that is replaced with:
> 
> struct integral_constant;//:public mpl::integral_c < T, val >
> 
> Compilation succeeds.
> 
> 

When cp_tree_equal in cp/tree.c at around line 1903 is changed to:

>     case TEMPLATE_PARM_INDEX:
>       {
>         if (TEMPLATE_PARM_IDX (t1) != TEMPLATE_PARM_IDX (t2)) return false;
> 	if (TEMPLATE_PARM_LEVEL (t1) != TEMPLATE_PARM_LEVEL (t2)) return false;
>       #if 1
> 	if (TEMPLATE_PARM_PARAMETER_PACK (t1) != TEMPLATE_PARM_PARAMETER_PACK (t2)) return false;
>       #endif
> 	return same_type_p ( TREE_TYPE (TEMPLATE_PARM_DECL (t1)),
> 			     TREE_TYPE (TEMPLATE_PARM_DECL (t2)));
>       }
> 

the test passes.  Apparently, when the test:

> 	  if (comp_template_args (TREE_PURPOSE (spec), args))

at around line pt.c:962 is executed, it passes when it shouldn't
and selects a previous instantiation with different value for
TEMPLATE_PARM_PARAMETER_PACK.  This different instantiation leads
to the failure of the test in:

>       if (TEMPLATE_PARM_PARAMETER_PACK (t))
>         parameter_pack_p = true;

at round pt.c:2463 which causes the error message.

[Bug c++/40092] -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[cppljevans at suddenlink dot net]

------- Comment #9 from cppljevans at suddenlink dot net  2009-08-12 19:15 -------
As indicated here:

http://article.gmane.org/gmane.comp.gcc.bugs/254672

the problem occurs because an additional test is needed
in cp_tree_equal.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[cppljevans at suddenlink dot net]

------- Comment #10 from cppljevans at suddenlink dot net  2009-08-13 19:15 -------
Created an attachment (id=18356)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18356&action=view)
minimal test case demonstrating bug

The comments at bottom show that wrong template instance is being
selected by cp_tree_equal.  For example, with:

  //#define INTEGRAL0_C

cp_tree_equal tries to select the integral_c<,Values> from struct package_c for
integral1_c<,Value_1>::type_1; however, since Value_1
is not a parameter pack, compiler gives confusing error message about
Values not being expanded, 

OTOH, with:

  #define INTEGRAL0_C

the compiler tries to use the type of integral0_c<,Value_0>::type_0
for the integral<,Values> in the supertype of package_c; however, since,
in this case, Value_0 is not a parameter pack, compiler gives error
about no contained argument packs.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[cppljevans at suddenlink dot net]

------- Comment #11 from cppljevans at suddenlink dot net  2009-08-15 15:44 -------
Created an attachment (id=18371)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18371&action=view)
test case for gcc/testsuite/g++.dg/cpp0x with gcc-4.5 compile 

This is even a "more minimal" test case.  This is modelled after
the other files in gcc/testsuite/g++.dg/cpp0x.

Would someone conform this as a bug or briefly explain why it's
not a bug?

TIA.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[cppljevans at suddenlink dot net]

------- Comment #12 from cppljevans at suddenlink dot net  2009-08-16 13:44 -------
Created an attachment (id=18375)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18375&action=view)
compare of `make -k check-c++` before and after patch

The attached .zip file contains the diffs between gcc/cp/tree.c
before and after the `make -k check-c++` runs shown in other
element of the diffs file.

These diffs of check-c++ before and after the patch were made according
to the instructions here:

  http://gcc.gnu.org/contribute.html#testing

Does anything else need to be done before the patch is accepted?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] -std=gnu++0x expansion pattern fails with error about derived template instead of actual template

[paolo dot carlini at oracle dot com]

------- Comment #13 from paolo dot carlini at oracle dot com  2009-08-16 15:45 -------
(In reply to comment #12)
> Does anything else need to be done before the patch is accepted?

Yes, patch + testcase must be sent to the gcc-patches mailing list. If the
changes are not trivial, of course you need a Copyright assignment.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] [c++0x] expansion pattern fails with error about derived template instead of actual template

[cppljevans at suddenlink dot net]

------- Comment #14 from cppljevans at suddenlink dot net  2009-08-17 14:07 -------
Subject: Re:  -std=gnu++0x expansion pattern fails with error
 about derived template instead of actual template

On 08/16/09 10:45, paolo dot carlini at oracle dot com wrote:
> ------- Comment #13 from paolo dot carlini at oracle dot com  2009-08-16 15:45 -------
> (In reply to comment #12)
>   
>> Does anything else need to be done before the patch is accepted?
>>     
>
> Yes, patch + testcase must be sent to the gcc-patches mailing list. If the
> changes are not trivial, of course you need a Copyright assignment.
>   
Thank you; however, I'm having problems with libstdc++ tests.

I downloaded from svn the trunk:

<---cut here---
-*- mode: compilation; default-directory: "~/download/gcc/svn/trunk/" -*-
Compilation started at Mon Aug 17 09:05:35

svn info
Path: .
URL: svn://gcc.gnu.org/svn/gcc/trunk
Repository Root: svn://gcc.gnu.org/svn/gcc
Repository UUID: 138bc75d-0d04-0410-961f-82ee72b054a4
Revision: 150807
Node Kind: directory
Schedule: normal
Last Changed Author: jason
Last Changed Rev: 150807
Last Changed Date: 2009-08-16 12:42:56 -0500 (Sun, 16 Aug 2009)


Compilation finished at Mon Aug 17 09:05:35
 >---cut here---

However, the libstdc++ tests failed:

<---cut here---
Test Run By evansl on Mon Aug 17 08:05:33 2009
Native configuration is x86_64-unknown-linux-gnu

        === libstdc++ tests ===

Schedule of variations:
    unix

Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file 
for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for 
target.
Using 
/home/evansl/download/gcc/svn/src/libstdc++-v3/testsuite/config/default.exp 
as tool-and-target-specific interface file.
Running 
/home/evansl/download/gcc/svn/src/libstdc++-v3/testsuite/libstdc++-abi/abi.exp 
...
FAIL: abi_check
Running 
/home/evansl/download/gcc/svn/src/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp 
...
FAIL: 17_intro/headers/c++1998/all.cc (test for excess errors)
FAIL: 17_intro/headers/c++1998/all_c++200x_compatibility.cc (test for 
excess errors)
FAIL: 17_intro/headers/c++1998/all_no_exceptions.cc (test for excess errors)
FAIL: 17_intro/headers/c++1998/all_pedantic_errors.cc (test for excess 
errors)
FAIL: 17_intro/headers/c++1998/stdc++.cc (test for excess errors)
FAIL: 17_intro/headers/c++1998/stdc++_assert_neg.cc  (test for errors, 
line 34)
FAIL: 17_intro/headers/c++1998/stdc++_assert_neg.cc (test for excess errors)
FAIL: 17_intro/headers/c++1998/stdc++_multiple_inclusion.cc (test for 
excess errors)
FAIL: 17_intro/headers/c++200x/all_no_exceptions.cc (test for excess errors)
FAIL: 17_intro/headers/c++200x/all_pedantic_errors.cc (test for excess 
errors)
FAIL: 17_intro/headers/c++200x/stdc++.cc (test for excess errors)
FAIL: 17_intro/headers/c++200x/stdc++_multiple_inclusion.cc (test for 
excess errors)

        === libstdc++ Summary ===

# of expected passes        6296
# of unexpected failures    13
# of expected failures        85
# of unsupported tests        335
make[2]: *** [check-DEJAGNU] Error 1
make[2]: Leaving directory 
`/home/evansl/download/gcc/svn/build/x86_64-unknown-linux-gnu/libstdc++-v3/testsuite'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory 
`/home/evansl/download/gcc/svn/build/x86_64-unknown-linux-gnu/libstdc++-v3/testsuite'
make: *** [check-recursive] Error 1
 >---cut here---

The .log file contents suggest some missing files:
<---cut here---
-*- mode: compilation; default-directory: 
"~/download/gcc/svn/build/x86_64-unknown-linux-gnu/libstdc++-v3/testsuite/" 
-*-
Compilation started at Mon Aug 17 09:22:51

head --lines=1684 libstdc++.log|tail --lines=10
compilation terminated.
compiler exited with status 1
output is:
/home/evansl/download/gcc/svn/src/libstdc++-v3/testsuite/17_intro/headers/c++1998/all.cc:20:25: 
error: one or more PCH files were found, but they were invalid
/home/evansl/download/gcc/svn/src/libstdc++-v3/testsuite/17_intro/headers/c++1998/all.cc:20:25: 
error: use -Winvalid-pch for more information
/home/evansl/download/gcc/svn/src/libstdc++-v3/testsuite/17_intro/headers/c++1998/all.cc:20:25: 
fatal error: bits/extc++.h: No such file or directory
compilation terminated.

FAIL: 17_intro/headers/c++1998/all.cc (test for excess errors)
Excess errors:

Compilation finished at Mon Aug 17 09:22:51

 >---cut here---

Could you give me some hint on how to correct this?
I did do all the steps outlined here:

  http://gcc.gnu.org/contribute.html#testing

i.e.

    make clean-target-libstdc++-v3                    # clean libstdc++ and ...
    test -d */libjava && make -C */libjava clean-nat  # ... parts of libjava
    make all-target-libstdc++-v3 all-target-libjava   # rebuild compiler and
libraries
    make -k check-c++                                 # run C++/libstdc++
testsuite


So, I've no idea how to proceed.

Any help would be appreciated.

TIA.
-Larry


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] [c++0x] expansion pattern fails with error about derived template instead of actual template

[paolo dot carlini at oracle dot com]

------- Comment #15 from paolo dot carlini at oracle dot com  2009-08-17 14:23 -------
Yes, just try removing everything in the build dir and rebuild the whole
compiler from scratch (probably I experienced your same problem a couple of
days ago, looks like we have some thingies in make clean wrong lately)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] [c++0x] expansion pattern fails with error about derived template instead of actual template

[jason at gcc dot gnu dot org]

------- Comment #16 from jason at gcc dot gnu dot org  2009-10-14 06:27 -------
Subject: Bug 40092

Author: jason
Date: Wed Oct 14 06:27:41 2009
New Revision: 152751

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=152751
Log:
        PR c++/40092
        * tree.c (cp_tree_equal): Add test for TEMPLATE_PARM_PARAMETER_PACK
        equality.

Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/vt-40092.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/tree.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] [c++0x] expansion pattern fails with error about derived template instead of actual template

[jason at gcc dot gnu dot org]

------- Comment #17 from jason at gcc dot gnu dot org  2009-10-18 05:13 -------
Subject: Bug 40092

Author: jason
Date: Sun Oct 18 05:13:05 2009
New Revision: 152966

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=152966
Log:
        PR c++/38798
        * parser.c (CP_PARSER_FLAGS_NO_TYPE_DEFINITIONS): New.
        (cp_parser_type_specifier): Don't try to parse a class-specifier
        or enum-specifier in that case.
        (cp_parser_trailing_type_id): New.
        (cp_parser_late_return_type_opt): Call it.
        (cp_parser_type_id_1): Add is_trailing_return parm.
        (cp_parser_type_specifier_seq): Likewise.

        PR c++/40092
        * tree.c (cp_tree_equal): Add test for TEMPLATE_PARM_PARAMETER_PACK
        equality.

        PR c++/37875
        * parser.c (cp_parser_decltype): Set greater_than_is_operator_p.

        PR c++/37766
        * pt.c (type_unification_real): Call convert_template_argument
        for function default template arguments.
        (check_default_tmpl_args): Suggest -std=c++0x when function default
        template args seen in C++98 mode.

        PR c++/37204
        * typeck.c (build_reinterpret_cast_1): Handle rvalue refs
        properly.


Added:
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/cpp0x/decltype18.C
      - copied unchanged from r152686,
trunk/gcc/testsuite/g++.dg/cpp0x/decltype18.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/cpp0x/fntmpdefarg1.C
      - copied unchanged from r152686,
trunk/gcc/testsuite/g++.dg/cpp0x/fntmpdefarg1.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/cpp0x/rv-reinterpret.C
      - copied unchanged from r152661,
trunk/gcc/testsuite/g++.dg/cpp0x/rv-reinterpret.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/cpp0x/trailing1.C
      - copied unchanged from r152924,
trunk/gcc/testsuite/g++.dg/cpp0x/trailing1.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/cpp0x/trailing2.C
      - copied unchanged from r152924,
trunk/gcc/testsuite/g++.dg/cpp0x/trailing2.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/cpp0x/trailing3.C
      - copied unchanged from r152924,
trunk/gcc/testsuite/g++.dg/cpp0x/trailing3.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/cpp0x/trailing4.C
      - copied unchanged from r152924,
trunk/gcc/testsuite/g++.dg/cpp0x/trailing4.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/cpp0x/trailing5.C
      - copied unchanged from r152924,
trunk/gcc/testsuite/g++.dg/cpp0x/trailing5.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/cpp0x/vt-40092.C
      - copied unchanged from r152751,
trunk/gcc/testsuite/g++.dg/cpp0x/vt-40092.C
Removed:
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/cpp0x/auto12.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/cpp0x/auto13.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/cpp0x/auto6.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/cpp0x/auto8.C
Modified:
    branches/gcc-4_4-branch/gcc/cp/ChangeLog
    branches/gcc-4_4-branch/gcc/cp/parser.c
    branches/gcc-4_4-branch/gcc/cp/pt.c
    branches/gcc-4_4-branch/gcc/cp/tree.c
    branches/gcc-4_4-branch/gcc/cp/typeck.c
    branches/gcc-4_4-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092

[Bug c++/40092] [c++0x] expansion pattern fails with error about derived template instead of actual template

[jason at gcc dot gnu dot org]

------- Comment #18 from jason at gcc dot gnu dot org  2009-10-18 05:19 -------
Fixed for 4.4.3.


-- 

jason at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at gcc dot gnu dot org
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40092