[Bug debug/19192] [4.0/4.1 Regression] Current development gcc generates inaccurate line info for example code

[Bug debug/19192] [4.0/4.1 Regression] Current development gcc generates inaccurate line info for example code

[mmitchel at gcc dot gnu dot org]

------- Comment #5 from mmitchel at gcc dot gnu dot org  2005-10-31 02:09 -------
Marked as P5; this will never be release-critical.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.0/4.1/4.2 Regression] Current development gcc generates inaccurate line info for example code

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.3                       |4.0.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.0/4.1/4.2/4.3 Regression] Current development gcc generates inaccurate line info for example code

[gdr at gcc dot gnu dot org]

------- Comment #6 from gdr at gcc dot gnu dot org  2007-01-18 03:35 -------
won't fix for GCC-4.0.x


-- 

gdr at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.4                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.0/4.1/4.2/4.3 Regression] Current development gcc generates inaccurate line info for example code

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.0/4.1/4.2/4.3 Regression] Current development gcc generates inaccurate line info for example code

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.2                       |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.2/4.3/4.4 Regression] Current development gcc generates inaccurate line info for example code

[jsm28 at gcc dot gnu dot org]

------- Comment #7 from jsm28 at gcc dot gnu dot org  2008-07-04 16:48 -------
Closing 4.1 branch.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.1/4.2/4.3/4.4 Regression]|[4.2/4.3/4.4 Regression]
                   |Current development gcc     |Current development gcc
                   |generates inaccurate line   |generates inaccurate line
                   |info for example code       |info for example code
   Target Milestone|4.1.3                       |4.2.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.3/4.4/4.5 Regression] Current development gcc generates inaccurate line info for example code

[jsm28 at gcc dot gnu dot org]

------- Comment #8 from jsm28 at gcc dot gnu dot org  2009-03-31 16:44 -------
Closing 4.2 branch.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.2/4.3/4.4/4.5 Regression]|[4.3/4.4/4.5 Regression]
                   |Current development gcc     |Current development gcc
                   |generates inaccurate line   |generates inaccurate line
                   |info for example code       |info for example code
   Target Milestone|4.2.5                       |4.3.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.3/4.4/4.5 Regression] Current development gcc generates inaccurate line info for example code

[rguenth at gcc dot gnu dot org]

------- Comment #9 from rguenth at gcc dot gnu dot org  2009-08-04 12:26 -------
GCC 4.3.4 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.4                       |4.3.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.3/4.4/4.5 Regression] Current development gcc generates inaccurate line info for example code

[steven at gcc dot gnu dot org]

------- Comment #10 from steven at gcc dot gnu dot org  2010-03-21 12:22 -------
With all attention going out to debug info in GCC 4.5, and with TER
more-or-less rewritten for GCC 4.5 -- perhaps re-evaluate this bug's priority?


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu dot
                   |                            |org, matz at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.3/4.4/4.5 Regression] Current development gcc generates inaccurate line info for example code

[steven at gcc dot gnu dot org]

-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5                          |P3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.3/4.4/4.5 Regression] Current development gcc generates inaccurate line info for example code

[rguenth at gcc dot gnu dot org]

------- Comment #11 from rguenth at gcc dot gnu dot org  2010-03-23 13:37 -------
Unassinging Andrew.  Raising priority to P2.

At -O2 we now optimize main () to

main ()
{
<bb 2>:
  # DEBUG a => 2
  # DEBUG b => 3
  # DEBUG c => 4
  # DEBUG a => 3
  # DEBUG b => 4
  [t.c : 13:22] printf ([t.c : 13] &[t.c : 13] "%d\n"[0], 9); [tail call]
  [t.c : 14:13] return;

}

at -O1 we get

<bb 2>:
  # DEBUG a => 2
  # DEBUG b => 3
  # DEBUG c => 4
  [t.c : 8:32] D.2741_4 = add2 (3, 4);
  [t.c : 8:15] D.2740_5 = D.2741_4 + 2;
  [t.c : 13:22] printf ([t.c : 13] &[t.c : 13] "%d\n"[0], D.2740_5);
  [t.c : 14:13] return;

which seems to be close to the reported case.  the + 2 has line 8 and thus
is ok before TER.  We still expand to

(insn 12 11 13 t.c:13 (parallel [
            (set (reg:SI 61)
                (plus:SI (reg:SI 58 [ D.2741 ])
                    (const_int 2 [0x2])))
            (clobber (reg:CC 17 flags))
        ]) -1 (nil))

(insn 13 12 14 t.c:13 (set (reg:SI 4 si)
        (reg:SI 61)) -1 (nil))

(insn 14 13 15 t.c:13 (set (reg:DI 5 di)
        (symbol_ref/f:DI ("*.LC0") [flags 0x2] <string_cst 0x7ffff5b36820>)) -1
(nil))

(insn 15 14 16 t.c:13 (set (reg:QI 0 ax)
        (const_int 0 [0x0])) -1 (nil))

(call_insn 16 15 0 t.c:13 (set (reg:SI 0 ax)
        (call (mem:QI (symbol_ref:DI ("printf") [flags 0x41] <function_decl
0x7ffff7efc000 printf>) [0 S1 A8])
            (const_int 0 [0x0]))) -1 (nil)
    (expr_list:REG_DEP_TRUE (use (reg:QI 0 ax))
        (expr_list:REG_DEP_TRUE (use (reg:DI 5 di))

thus expanding a TERd expression does not properly reset location infromation.

CC'ing Micha.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|amacleod at redhat dot com  |unassigned at gcc dot gnu
                   |                            |dot org
             Status|ASSIGNED                    |NEW


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.3/4.4/4.5 Regression] Current development gcc generates inaccurate line info for example code

[jakub at gcc dot gnu dot org]

------- Comment #12 from jakub at gcc dot gnu dot org  2010-03-23 15:22 -------
Thus we are talking about:
extern int printf (const char *, ...);

__attribute__((noinline))
int add2 (int a, int b)
{
  return a + b;
}

static inline int add3 (int a, int b, int c)
{
  return a + add2 (b, c);
}

int
main ()
{
  printf ("%d\n", add3 (2, 3, 4));
  return 0;
}

right?  Seems get_gimple_for_ssa_name indeed provides correct location on the
created trees, it is just that the expansion ignores it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.3/4.4/4.5 Regression] Current development gcc generates inaccurate line info for example code

[jakub at gcc dot gnu dot org]

------- Comment #13 from jakub at gcc dot gnu dot org  2010-03-23 15:56 -------
Created an attachment (id=20169)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20169&action=view)
gcc45-pr19192.patch

Untested fix.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.3/4.4/4.5 Regression] Current development gcc generates inaccurate line info for example code

[jakub at gcc dot gnu dot org]

------- Comment #15 from jakub at gcc dot gnu dot org  2010-03-23 16:17 -------
Created an attachment (id=20170)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20170&action=view)
gcc45-pr19192.patch

Updated patch that also fixes
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43479#c1
testcase.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20169|0                           |1
        is obsolete|                            |
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.3/4.4/4.5 Regression] Current development gcc generates inaccurate line info for example code

[matz at gcc dot gnu dot org]

------- Comment #14 from matz at gcc dot gnu dot org  2010-03-23 16:16 -------
Simply replace the recursive call to expand_expr_real_1 with a call to
expand_expr_real.  That's the wrapper setting locations.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.3/4.4/4.5 Regression] Current development gcc generates inaccurate line info for example code

[jakub at gcc dot gnu dot org]

------- Comment #16 from jakub at gcc dot gnu dot org  2010-03-23 16:19 -------
Actually it is not, it restores neither curr_insn_block or
curr_insn_source_location.
Perhaps the fix would be to fix that function though.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.3/4.4/4.5 Regression] Current development gcc generates inaccurate line info for example code

[jakub at gcc dot gnu dot org]

------- Comment #17 from jakub at gcc dot gnu dot org  2010-03-23 16:37 -------
Created an attachment (id=20171)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20171&action=view)
gcc45-pr19192.patch

Patch that does that.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.3/4.4/4.5 Regression] Current development gcc generates inaccurate line info for example code

[matz at gcc dot gnu dot org]

------- Comment #18 from matz at gcc dot gnu dot org  2010-03-23 16:46 -------
It should mostly not matter anymore as expand_expr_real_[12] and friends use
an explicit location parameter, stored away before expanding operands.
But to be safe, yes, expand_expr_real() should instead also restore
the old location.  You don't need to check for NULL gimple_block(),
set_curr_insn_block does that.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.3/4.4/4.5 Regression] Current development gcc generates inaccurate line info for example code

[jakub at gcc dot gnu dot org]

------- Comment #19 from jakub at gcc dot gnu dot org  2010-03-24 13:41 -------
Subject: Bug 19192

Author: jakub
Date: Wed Mar 24 13:41:30 2010
New Revision: 157693

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=157693
Log:
        PR debug/19192
        PR debug/43479
        * cfgexpand.c (gimple_assign_rhs_to_tree): Also set TREE_BLOCK
        from gimple_block.
        * expr.c (expand_expr_real): Restore previous
        curr_insn_source_location and curr_insn_block after
        expand_expr_real_1 call.
        (expand_expr_real_1) <case SSA_NAME>: Call expand_expr_real
        instead of expand_expr_real_1.

        * gcc.dg/guality/pr43479.c: New test.
        * gcc.dg/debug/dwarf2/inline2.c (third): Make a a global var
        and add volatile keyword.

Added:
    trunk/gcc/testsuite/gcc.dg/guality/pr43479.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cfgexpand.c
    trunk/gcc/expr.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/debug/dwarf2/inline2.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.3/4.4/4.5 Regression] Current development gcc generates inaccurate line info for example code

[jakub at gcc dot gnu dot org]

------- Comment #20 from jakub at gcc dot gnu dot org  2010-03-24 13:51 -------
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192

[Bug debug/19192] [4.3/4.4/4.5 Regression] Current development gcc generates inaccurate line info for example code

[rguenth at gcc dot gnu dot org]

------- Comment #21 from rguenth at gcc dot gnu dot org  2010-03-24 14:48 -------
For 4.5.0.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.5                       |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19192