[Bug objc++/32052] New: [4.3 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[Bug objc++/32052] New: [4.3 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[pinskia at gcc dot gnu dot org]

encode-2.mm produces "Vec=ffi" for its enconding of @encode(Vec<float>).
which is wrong, it should produce "Vec<float>=ffi". 

This was caused by:
2007-02-22  Michael Matz  <matz@suse.de>

        PR c++/29433
        * cp-tree.h (TFF_UNQUALIFIED_NAME): New formatting flag.
        * error.c (dump_aggr_type, dump_simple_decl, dump_decl,
        dump_function_decl): Guard emitting outer scopes by new flag.
        * cp-lang.c (cxx_dwarf_name): New function.
        (LANG_HOOKS_DWARF_NAME): Define to cxx_dwarf_name.
        * pt.c (classtype_mangled_name, mangle_class_name_for_template):
        Remove functions.
        (push_template_decl_real, lookup_template_class): Remove calls
        to above functions.


-- 
           Summary: [4.3 Regression] encode-2.mm, encode-3.mm fail on at
                    least powerpc-darwin
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: objc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org
GCC target triplet: powerpc-darwin
 BugsThisDependsOn: 29433


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[matz at gcc dot gnu dot org]

------- Comment #1 from matz at gcc dot gnu dot org  2007-05-23 09:36 -------
The ObjC frontend seems to use IDENTIFIER_POINTER directly to produce
this encoding.  This doesn't contain template arguments anymore.  And from
quick reading of obj-act.c it's also not clear if it was really expecting
funny characters like '<' in those identifiers.  It happily uses these
names to construct other identifiers.  This works fine in C, but in C++,
when they still contained template args the new identifiers would contain "<"
and ",", surely not something you expect from normal identifiers.

I would suggest auditing objc-act.c carefully, if using IDENTIFIER_POINTER
is really correct everywhere.

Additionally, someone knowledgable in Obj-C++ should define once and for
all what the encoding of such types should be.  If it is supposed to
include template args, then you need to use a different mean than
accessing IDENTIFIER_POINTER.  One way would be
  decl_as_string (t, TFF_DECL_SPECIFIERS | TFF_UNQUALIFIED_NAME);
(Or leaving out TFF_UNQUALIFIED_NAME if you also need toplevel namespaces
in there).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[danglin at gcc dot gnu dot org]

------- Comment #2 from danglin at gcc dot gnu dot org  2007-11-22 14:07 -------
Also, see these on hppa64-hp-hpux11.11.


-- 

danglin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2008-01-13 14:52 -------
Confirmed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-01-13 14:52:00
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[ghazi at gcc dot gnu dot org]

------- Comment #4 from ghazi at gcc dot gnu dot org  2008-02-08 02:01 -------
I also see these regressions on mainline on i686 and x86_64:

http://gcc.gnu.org/ml/gcc-testresults/2008-02/msg00441.html
http://gcc.gnu.org/ml/gcc-testresults/2008-02/msg00466.html


-- 

ghazi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ghazi at gcc dot gnu dot
                   |                            |org, mrs at apple dot com
      Known to fail|                            |4.3.0
   Last reconfirmed|2008-01-13 14:52:00         |2008-02-08 02:01:40
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[ghazi at gcc dot gnu dot org]

------- Comment #5 from ghazi at gcc dot gnu dot org  2008-02-08 02:04 -------
It's not darwin-specific, removing target tag.


-- 

ghazi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 GCC target triplet|powerpc-darwin              |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3/4.4 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[jsm28 at gcc dot gnu dot org]

------- Comment #6 from jsm28 at gcc dot gnu dot org  2008-03-15 00:40 -------
Update milestone after 4.3.0 release.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.0                       |4.3.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3/4.4 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[rguenth at gcc dot gnu dot org]

------- Comment #7 from rguenth at gcc dot gnu dot org  2008-06-06 14:57 -------
4.3.1 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.1                       |4.3.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3/4.4 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[jsm28 at gcc dot gnu dot org]

------- Comment #8 from jsm28 at gcc dot gnu dot org  2008-08-27 22:02 -------
4.3.2 is released, changing milestones to 4.3.3.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.2                       |4.3.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3/4.4 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[rguenth at gcc dot gnu dot org]

------- Comment #9 from rguenth at gcc dot gnu dot org  2009-01-24 10:19 -------
GCC 4.3.3 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.3                       |4.3.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3/4.4/4.5 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[rguenth at gcc dot gnu dot org]

------- Comment #10 from rguenth at gcc dot gnu dot org  2009-08-04 12:28 -------
GCC 4.3.4 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.4                       |4.3.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3/4.4/4.5/4.6 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[iains at gcc dot gnu dot org]

------- Comment #11 from iains at gcc dot gnu dot org  2010-04-09 10:48 -------
Created an attachment (id=20345)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20345&action=view)
Provide template args to structure tags for ObjC++ encode.

Re Comment #1

It seems to me that, whilst there might be issues elsewhere in objc-act.c, the
tests in question are clearly intended to confirm that
encode_aggregate_within() is doing what is intended.

To that end I've made a patch for objc-act.c that uses the approach recommended
at comment 1 to attach the template args to the structure tag.  This is what
the current NeXT-compliant complier does.

I've extended the tests in encode-2/3 to check that:
 (a) the anonymous type is correctly encoded and 
(b) that recursion through encode_aggregate_within()  is operating as well.

I'm adding two similar tests to objc.dg/ that perform the same duties for ObjC.
(encode-10/11)

tested on {powerpc,i686}-apple-darwin and ia32-pc-linux
OK for trunk?  and eventually branch(es)?

objc/

2010-04-09  Iain Sandoe  <iains@gcc.gnu.org>

        PR objc++/32052
        * objc-act.c (encode_aggregate_within): Encode structure tags
        with template args for ObjC++.

testsuite/
2010-04-09  Iain Sandoe <iains@gcc.gnu.org>

        PR objc++/32052
        * obj-c++.dg/encode-2.mm: Remove XFAIL. Add test for anonymous 
        structure and nested declarations.
        * obj-c++.dg/encode-3.mm:  Remove XFAIL. Add test for anonymous 
        structure and nested declarations.  Reduce header clutter and 
        use _exit() rather than abort().
        * objc.dg/encode-10.m: New. 
        * objc.dg/encode-11.m: New.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3/4.4/4.5/4.6 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[steven at gcc dot gnu dot org]

------- Comment #12 from steven at gcc dot gnu dot org  2010-04-30 13:22 -------
Iain, perhaps you should request to be confirmed as ObjC maintainer.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3/4.4/4.5/4.6 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[mrs at gcc dot gnu dot org]

------- Comment #13 from mrs at gcc dot gnu dot org  2010-05-01 00:32 -------
Subject: Bug 32052

Author: mrs
Date: Sat May  1 00:32:13 2010
New Revision: 158958

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=158958
Log:
2010-04-30  Iain Sandoe  <iains@gcc.gnu.org>

        PR objc++/32052
        * objc-act.c (encode_aggregate_within): Encode structure tags
        with template args for ObjC++.

2010-04-30  Iain Sandoe <iains@gcc.gnu.org>

        PR objc++/32052
        * obj-c++.dg/encode-2.mm: Remove XFAIL. Add test for anonymous
        structure and nested declarations.
        * obj-c++.dg/encode-3.mm:  Remove XFAIL. Add test for anonymous
        structure and nested declarations.  Reduce header clutter and
        use _exit() rather than abort().
        * objc.dg/encode-10.m: New.
        * objc.dg/encode-11.m: New.

Added:
    trunk/gcc/testsuite/objc.dg/encode-10.m
    trunk/gcc/testsuite/objc.dg/encode-11.m
Modified:
    trunk/gcc/objc/ChangeLog
    trunk/gcc/objc/objc-act.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/obj-c++.dg/encode-2.mm
    trunk/gcc/testsuite/obj-c++.dg/encode-3.mm


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3/4.4/4.5/4.6 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[mrs at gcc dot gnu dot org]

------- Comment #14 from mrs at gcc dot gnu dot org  2010-05-01 00:33 -------
Thanks.


-- 

mrs at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|mikestump at comcast dot net|
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052

[Bug objc++/32052] [4.3/4.4/4.5/4.6 Regression] encode-2.mm, encode-3.mm fail on at least powerpc-darwin

[iains at gcc dot gnu dot org]

------- Comment #15 from iains at gcc dot gnu dot org  2010-06-10 12:33 -------
back-ported to 4.5 release branch as r160541.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32052