[Bug c/36827] New: newlib:libm/math/k_rem_pio2.c fails in reload

[Bug c/36827] New: newlib:libm/math/k_rem_pio2.c fails in reload

[dj at redhat dot com]

as of rev 137639:

cc1 -fpreprocessed k_rem_pio2.i -quiet -dumpbase k_rem_pio2.c -auxbase-strip
lib_a-k_rem_pio2.o -Os -fno-builtin -o k_rem_pio2.s

src/newlib/libm/math/k_rem_pio2.c: In function '__kernel_rem_pio2':
newlib/libm/math/k_rem_pio2.c:318: error: unable to find a register to spill in
class 'A_REGS'
newlib/libm/math/k_rem_pio2.c:318: error: this is the insn:
(jump_insn 1098 1096 2868 9 newlib/libm/math/k_rem_pio2.c:186 (set (pc)
        (if_then_else (gt (subreg:HI (reg/v:SI 1108 [ i ]) 2)
                (subreg:HI (reg/v:SI 1105 [ m ]) 2))
            (label_ref:HI 3007)
            (pc))) 48 {cbranchhi4} (expr_list:REG_BR_PROB (const_int 5000
[0x1388])
        (nil)))
newlib/libm/math/k_rem_pio2.c:318: internal compiler error: in spill_failure,
at reload1.c:1995


-- 
           Summary: newlib:libm/math/k_rem_pio2.c fails in reload
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dj at redhat dot com
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: m32c-elf


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug c/36827] newlib:libm/math/k_rem_pio2.c fails in reload

[dj at redhat dot com]

------- Comment #1 from dj at redhat dot com  2008-07-14 22:31 -------
Created an attachment (id=15908)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15908&action=view)
preprocessed file for description


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
          Component|c                           |target
            Summary|newlib:libm/math/k_rem_pio2.|[4.4 Regression]
                   |c fails in reload           |newlib:libm/math/k_rem_pio2.
                   |                            |c fails in reload
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[ebotcazou at gcc dot gnu dot org]

------- Comment #2 from ebotcazou at gcc dot gnu dot org  2008-07-14 22:44 -------
Note that the problematic patch has been installed on the 4.3 branch as well.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |blocker
           Keywords|                            |build
   Target Milestone|4.4.0                       |4.3.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[jakub at gcc dot gnu dot org]

------- Comment #3 from jakub at gcc dot gnu dot org  2008-07-15 15:19 -------
You mean http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=137640 or something
else?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[dj at redhat dot com]

------- Comment #4 from dj at redhat dot com  2008-07-15 15:38 -------
Yes, 137639 and 137640 are the same patch, to trunk and 4.3, respectively.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[joseph at codesourcery dot com]

------- Comment #5 from joseph at codesourcery dot com  2008-07-15 15:41 -------
Subject: Re:   New: newlib:libm/math/k_rem_pio2.c fails in reload

Please try this patch.  The m32c target seems to be generating its own 
invalid addresses and reloads for them, for reasons I don't quite 
understand, so something like this looks like it's needed to avoid reload 
generating further reloads in those cases.

Index: config/m32c/m32c.c
===================================================================
--- config/m32c/m32c.c  (revision 137836)
+++ config/m32c/m32c.c  (working copy)
@@ -1778,6 +1778,8 @@

 /* Addressing Modes */

+#define BIG_FB_ADJ 0
+
 /* Used by GO_IF_LEGITIMATE_ADDRESS.  The r8c/m32c family supports a
    wide range of non-orthogonal addressing modes, including the
    ability to double-indirect on *some* of them.  Not all insns
@@ -1895,6 +1897,17 @@
          return 0;
        }
     }
+  if (RTX_IS ("++rii"))
+    {
+      rtx reg = patternr[2];
+      HOST_WIDE_INT offs = INTVAL (patternr[3]);
+
+      /* Avoid reloads for addresses generated by
+        m32c_legitimize_reload_address being generated by
+        find_reloads_subreg_address.  */
+      if (REGNO (reg) == FB_REGNO && offs == -BIG_FB_ADJ)
+       return 1;
+    }
   return 0;
 }

@@ -1942,8 +1955,6 @@
    frame, so the third case seems best.  Note that we subtract the
    zero, but detect that in the addhi3 pattern.  */

-#define BIG_FB_ADJ 0
-
 /* Implements LEGITIMIZE_ADDRESS.  The only address we really have to
    worry about is frame base offsets, as $fb has a limited
    displacement range.  We deal with this by attempting to reload $fb


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[jakub at gcc dot gnu dot org]

------- Comment #6 from jakub at gcc dot gnu dot org  2008-07-15 16:01 -------
m32c-elf is neither primary nor secondary target.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[dj at redhat dot com]

------- Comment #7 from dj at redhat dot com  2008-07-16 02:07 -------
Subject: Re:  [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in
reload


It fixes the newlib compile failure, but there are regressions since
it last built.  I'll have to check each of them to see if they're
caused by this patch or something else that's happened since then.

Meanwhile, please apply your m32c patch. "newlib doesn't build" is
certainly a bigger problem than "some regressions" :-)

Thanks!


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[dj at redhat dot com]

------- Comment #8 from dj at redhat dot com  2008-07-16 03:04 -------
Subject: Re:  [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in
reload


The regressions all show up in v850 and iq2000 too, except one that I
can't reproduce, so I'm not going to worry about them.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[jsm28 at gcc dot gnu dot org]

------- Comment #9 from jsm28 at gcc dot gnu dot org  2008-07-16 10:46 -------
Subject: Bug 36827

Author: jsm28
Date: Wed Jul 16 10:45:57 2008
New Revision: 137875

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=137875
Log:
        PR target/36827
        * config/m32c/m32c.c (BIG_FB_ADJ): Move definition earlier.
        (m32c_legitimate_address_p): Handle "++rii" addresses created by
        m32c_legitimize_reload_address.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/m32c/m32c.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[jsm28 at gcc dot gnu dot org]

------- Comment #10 from jsm28 at gcc dot gnu dot org  2008-07-16 10:47 -------
Subject: Bug 36827

Author: jsm28
Date: Wed Jul 16 10:46:32 2008
New Revision: 137876

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=137876
Log:
        PR target/36827
        * config/m32c/m32c.c (BIG_FB_ADJ): Move definition earlier.
        (m32c_legitimate_address_p): Handle "++rii" addresses created by
        m32c_legitimize_reload_address.

Modified:
    branches/gcc-4_3-branch/gcc/ChangeLog
    branches/gcc-4_3-branch/gcc/config/m32c/m32c.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[dj at redhat dot com]

------- Comment #11 from dj at redhat dot com  2008-07-16 19:08 -------
Subject: Re:  [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in
reload


Last night's builds showed a flaw in the patch.  The "++rii" address
created by m32c_legitimize_reload_address is *not* legitimate, it's
used as a marker for addresses that need to be reloaded into an
address register.  If I fix m32c_print_operand() to print those, it
ends up printing an address that exceeds the displacement range of the
FB register:

regex.s:11903: Error: unrecognized keyword/register name `mov.w mem0,-198[fb]'

The original idea was to reload $fb of $sp itself into an address
register, and use a displacement off that, so that only one address
register is needed for all frame address reloads.  I never quite got
gcc to do it right.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[joseph at codesourcery dot com]

------- Comment #12 from joseph at codesourcery dot com  2008-07-16 20:25 -------
Subject: Re:  [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c
 fails in reload

On Wed, 16 Jul 2008, dj at redhat dot com wrote:

> Last night's builds showed a flaw in the patch.  The "++rii" address
> created by m32c_legitimize_reload_address is *not* legitimate, it's
> used as a marker for addresses that need to be reloaded into an
> address register.  If I fix m32c_print_operand() to print those, it
> ends up printing an address that exceeds the displacement range of the
> FB register:

Try changing the "reloaded != 1" condition in find_reloads_subreg_address 
to "reloaded == 0" (as a replacement for my m32c patch, and probably for 
the SH patch as well).  I hope that should avoid these problems in the 
cases where LEGITIMIZE_RELOAD_ADDRESS does something like this, and I've 
verified the original ARM testcase that motivated my reload change still 
works with that change.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[kkojima at gcc dot gnu dot org]

------- Comment #13 from kkojima at gcc dot gnu dot org  2008-07-17 02:08 -------
> Try changing the "reloaded != 1" condition in find_reloads_subreg_address 
> to "reloaded == 0" (as a replacement for my m32c patch, and probably for 
> the SH patch as well).  I hope that should avoid these problems in the 
> cases where LEGITIMIZE_RELOAD_ADDRESS does something like this, and I've 
> verified the original ARM testcase that motivated my reload change still 
> works with that change.

This works fine on SH.  With this and backing out the workaround
in GO_IF_LEGITIMATE_ADDRESS, sh4-unknown-linux-gnu cross x86 is
built successfully and the result of regtest looks very clean.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[dj at redhat dot com]

------- Comment #14 from dj at redhat dot com  2008-07-18 00:22 -------
Subject: Re:  [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in
reload


Seems to work for m32c too.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[jsm28 at gcc dot gnu dot org]

------- Comment #15 from jsm28 at gcc dot gnu dot org  2008-07-19 11:15 -------
Subject: Bug 36827

Author: jsm28
Date: Sat Jul 19 11:14:13 2008
New Revision: 137976

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=137976
Log:
        PR target/36780
        PR target/36827
        * reload.c (find_reloads_subreg_address): Only reload address if
        reloaded == 0, not for reloaded != 1.

        Revert:
        2008-07-16  Joseph Myers  <joseph@codesourcery.com>
        * config/m32c/m32c.c (BIG_FB_ADJ): Move definition earlier.
        (m32c_legitimate_address_p): Handle "++rii" addresses created by
        m32c_legitimize_reload_address.

        2008-07-15  Kaz Kojima  <kkojima@gcc.gnu.org>
        * config/sh/sh.h (GO_IF_LEGITIMATE_ADDRESS): Allow
        (plus (plus (reg) (const_int)) (const_int)) when reload_in_progress.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/m32c/m32c.c
    trunk/gcc/config/sh/sh.h
    trunk/gcc/reload.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[jsm28 at gcc dot gnu dot org]

------- Comment #16 from jsm28 at gcc dot gnu dot org  2008-07-19 11:16 -------
Subject: Bug 36827

Author: jsm28
Date: Sat Jul 19 11:15:29 2008
New Revision: 137977

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=137977
Log:
        PR target/36780
        PR target/36827
        * reload.c (find_reloads_subreg_address): Only reload address if
        reloaded == 0, not for reloaded != 1.

        Revert:
        2008-07-16  Joseph Myers  <joseph@codesourcery.com>
        * config/m32c/m32c.c (BIG_FB_ADJ): Move definition earlier.
        (m32c_legitimate_address_p): Handle "++rii" addresses created by
        m32c_legitimize_reload_address.

        2008-07-15  Kaz Kojima  <kkojima@gcc.gnu.org>
        * config/sh/sh.h (GO_IF_LEGITIMATE_ADDRESS): Allow
        (plus (plus (reg) (const_int)) (const_int)) when reload_in_progress.

Modified:
    branches/gcc-4_3-branch/gcc/ChangeLog
    branches/gcc-4_3-branch/gcc/config/m32c/m32c.c
    branches/gcc-4_3-branch/gcc/config/sh/sh.h
    branches/gcc-4_3-branch/gcc/reload.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[pinskia at gcc dot gnu dot org]

------- Comment #17 from pinskia at gcc dot gnu dot org  2008-08-11 00:54 -------
Isn't this fixed now?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[jsm28 at gcc dot gnu dot org]

------- Comment #18 from jsm28 at gcc dot gnu dot org  2008-08-27 22:05 -------
4.3.2 is released, changing milestones to 4.3.3.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.2                       |4.3.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[rguenth at gcc dot gnu dot org]

------- Comment #19 from rguenth at gcc dot gnu dot org  2009-01-24 10:20 -------
GCC 4.3.3 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.3                       |4.3.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4/4.5 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[rguenth at gcc dot gnu dot org]

------- Comment #20 from rguenth at gcc dot gnu dot org  2009-08-04 12:29 -------
GCC 4.3.4 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.4                       |4.3.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827

[Bug target/36827] [4.3/4.4/4.5 Regression] newlib:libm/math/k_rem_pio2.c fails in reload

[law at redhat dot com]

------- Comment #21 from law at redhat dot com  2010-02-25 00:25 -------
Fixed long ago.  m32c is building newlib without difficulties now.


-- 

law at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36827