[Bug c++/37121] New: g++ create global symbol for inline function, which make link failed with multiple defination

[Bug c++/37121] New: g++ create global symbol for inline function, which make link failed with multiple defination

[drangon dot mail at gmail dot com]

when use g++ to build wxWidgets in x86_64-pc-mingw32, it output following error
:

------------------
E:\work\09_workroom\wxtest\png>mingw32-make -f Makefile.mingw
WX_DIR=e:\code\wx6
4 CXX=e:\code\target\bin\g++.exe
e:\code\target\bin\g++.exe -g -Wall -pipe  -D__WXMSW__ -D__WXDEBUG__ -DWIN32
-D_
WINDOWS -Ie:\code\wx64/include -Ie:\code\wx64/lib/mswd  png.o  stdafx.o -o
png.e
xe -mwindows -Le:\code\wx64/lib -lwxmsw28d_core -lwxbase28d -lwxpngd -lwxzlibd
-
lgdi32 -lole32 -loleaut32 -lwinmm -lcomctl32 -lcomdlg32 -lwinspool -luuid
-lshel
l32 -lrpcrt4
e:/code/target/bin/../lib/gcc/x86_64-pc-mingw32/4.3.2/../../../../x86_64-pc-ming
w32/lib/libmingwex.a(lib64_libmingwex_a-wininterlocked.o):wininterlocked.c:(.tex
t+0x43b): multiple definition of `_InterlockedIncrement'
e:\code\wx64/lib/libwxbase28d.a(baselib_thread.o):thread.cpp:(.text$_Interlocked
Increment[__InterlockedIncrement]+0x0): first defined here
e:/code/target/bin/../lib/gcc/x86_64-pc-mingw32/4.3.2/../../../../x86_64-pc-ming
w32/lib/libmingwex.a(lib64_libmingwex_a-wininterlocked.o):wininterlocked.c:(.tex
t+0x487): multiple definition of `_InterlockedDecrement'
e:\code\wx64/lib/libwxbase28d.a(baselib_thread.o):thread.cpp:(.text$_Interlocked
Decrement[__InterlockedDecrement]+0x0): first defined here
collect2: ld returned 1 exit status
mingw32-make: *** [png.exe] Error 1     
-----------------

_InterlockedDecrement is an inline function, it should not in baselib_thread.o,
when built with "-O1", its ok. when built with "-O2", g++ crashed.
see attachment for more infomation.


-- 
           Summary: g++ create global symbol for inline function, which make
                    link failed with multiple defination
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: drangon dot mail at gmail dot com
 GCC build triplet: x86_64-redhat-linux-gnu
  GCC host triplet: x86_64-pc-mingw32
GCC target triplet: x86_64-pc-mingw32


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple defination

[drangon dot mail at gmail dot com]

------- Comment #1 from drangon dot mail at gmail dot com  2008-09-25 04:45 -------
Created an attachment (id=16405)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16405&action=view)
output of gcc -E


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple defination

[drangon dot mail at gmail dot com]

------- Comment #2 from drangon dot mail at gmail dot com  2008-09-25 04:47 -------
Created an attachment (id=16406)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16406&action=view)
output of nm, the object is build by gcc -O0


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple defination

[drangon dot mail at gmail dot com]

------- Comment #3 from drangon dot mail at gmail dot com  2008-09-25 04:48 -------
Created an attachment (id=16407)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16407&action=view)
output of nm, the object is build by gcc -O1


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple defination

[drangon dot mail at gmail dot com]

------- Comment #5 from drangon dot mail at gmail dot com  2008-09-25 04:49 -------
Created an attachment (id=16409)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16409&action=view)
output of objdump, the object is build by gcc -O1


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple defination

[drangon dot mail at gmail dot com]

------- Comment #4 from drangon dot mail at gmail dot com  2008-09-25 04:48 -------
Created an attachment (id=16408)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16408&action=view)
output of objdump, the object is build by gcc -O0


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple defination

[nightstrike at gmail dot com]

------- Comment #6 from nightstrike at gmail dot com  2008-09-25 05:00 -------
What is the output of g++ -v?

Are you using the win32 cross compiler, or the win64 native compiler?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple defination

[drangon dot mail at gmail dot com]

------- Comment #7 from drangon dot mail at gmail dot com  2008-09-26 00:33 -------
I'm using the win64 native compiler:

E:\code>g++ -v
Using built-in specs.
Target: x86_64-pc-mingw32
Configured with: ../gcc/configure --host=x86_64-pc-mingw32
--target=x86_64-pc-mi
ngw32 --disable-nls --enable-languages=c,c++
--with-gmp=/home/drangon/mingw/for_
target --enable-twoprocess --prefix=/home/drangon/mingw/target
--with-sysroot=/h
ome/drangon/mingw/target
Thread model: win32
gcc version 4.4.0 20080814 (experimental) (GCC)


-- 

drangon dot mail at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drangon dot mail at gmail
                   |                            |dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple defination

[ktietz at gcc dot gnu dot org]

------- Comment #8 from ktietz at gcc dot gnu dot org  2009-02-28 17:48 -------
I can't test your precompiled code, because c++ has changed in an incompatible
way. Could you attach a current precompiled version using gcc4.4 of it?
Is the problem still present on 4.4.0 ?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple defination

[drangon dot mail at gmail dot com]

------- Comment #9 from drangon dot mail at gmail dot com  2009-03-07 14:52 -------
(In reply to comment #8)
> I can't test your precompiled code, because c++ has changed in an incompatible
> way. Could you attach a current precompiled version using gcc4.4 of it?
> Is the problem still present on 4.4.0 ?
> 

I built the native toolchain using the newest source code, the problem still
present.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple defination

[drangon dot mail at gmail dot com]

------- Comment #10 from drangon dot mail at gmail dot com  2009-03-07 15:02 -------
Created an attachment (id=17413)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17413&action=view)
gcc -E output ( gcc 4.4.0 svn 20090307 )


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple defination

[drangon dot mail at gmail dot com]

------- Comment #11 from drangon dot mail at gmail dot com  2009-03-07 15:10 -------
Created an attachment (id=17414)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17414&action=view)
the output object of thread.o


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple defination

[nightstrike at gmail dot com]

------- Comment #12 from nightstrike at gmail dot com  2009-03-09 02:10 -------
Was this broken in 4.3 compilers?  Is it a 4.4 regression?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple defination

[dannysmith at users dot sourceforge dot net]

------- Comment #13 from dannysmith at users dot sourceforge dot net  2009-03-09 07:46 -------
(In reply to comment #12)
> Was this broken in 4.3 compilers?  Is it a 4.4 regression?
> 
This is not a new bug in the compiler (the same multiple definition will occur
with 3.4.5)  , but an old 'feature' of the the PE-COFF linker

_InterlockedIncrement is defined as an ordinary  C library function  in
lib64_libmingwex_a-wininterlocked.o

In thread.cpp, it is defined and emitted using linkonce semantics (it is put
into its own .text$_InterlockedIncrement link_once sections, which is how
PE-COFF implements vague linkage.

The linker grabs the one and only .text$_InterlockedIncrement section in
thread.o and then while resolving another symbol it needs from
lib64_libmingwex_a-wininterlocked.o finds an ordinary (not .linkonce)
definition InterlockedIncrement

Hence the multiple definition.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple definitions

[drangon dot mail at gmail dot com]

------- Comment #14 from drangon dot mail at gmail dot com  2009-04-21 05:35 -------
how to fix this multiple definition issue ?

adjust the linker to allow this ?

or remove the ordinary  C library function in
lib64_libmingwex_a-wininterlocked.o and just keep the inline function ?

or remove the inline function, replace by a function declaration which use the
implementation from lib64_libmingwex_a-wininterlocked.o ?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple definitions

[dannysmith at users dot sourceforge dot net]

------- Comment #15 from dannysmith at users dot sourceforge dot net  2009-04-21 07:01 -------
(In reply to comment #14)

> or remove the ordinary  C library function in
> lib64_libmingwex_a-wininterlocked.o and just keep the inline function ?
> 

That would be my first experiment.  What depends on 
lib64_libmingwex_a-wininterlocked.o 
Danny


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple definitions

[ktietz at gcc dot gnu dot org]

------- Comment #16 from ktietz at gcc dot gnu dot org  2009-04-21 08:27 -------
(In reply to comment #15)
> (In reply to comment #14)
> > or remove the ordinary  C library function in
> > lib64_libmingwex_a-wininterlocked.o and just keep the inline function ?
> > 
> That would be my first experiment.  What depends on 
> lib64_libmingwex_a-wininterlocked.o 
> Danny

we implemented int wininterlocked.c file the common interlocked symbols,
because some of them should be inlined for performance reasons. To remove the
inline version seems to be the best solution for me here. Because otherwise we
would disallow a function pointer reference to it.
Possibly we could make als define those symbols in wininterlocked.c as weak,
does this help?

Kai


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple definitions

[ktietz at gcc dot gnu dot org]

------- Comment #17 from ktietz at gcc dot gnu dot org  2009-04-21 08:49 -------
Ah, C++ makes here the trouble. We found the same issue about math.h. Here I
fixed it by avoiding to define the inline functions for C++.
I assumed it was fixed already, but this doesn't seem so. It seems that in C++
the meaning of inline functions in extern "C" blocks has altered by intention,
or this regression still exists.

Kai


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121

[Bug target/37121] g++ create global symbol for inline function, which make link failed with multiple definitions

[ktietz at gcc dot gnu dot org]

------- Comment #18 from ktietz at gcc dot gnu dot org  2009-08-18 11:03 -------
This bug is fixed by a recent change to our runtime headers. We support now the
NO_INLINE feature for platform headers, too. So, even intrinsic functions
aren't emitted anymore, when __NO_INLINE__ is defined.


-- 

ktietz at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37121