[Bug testsuite/39655] New: autogen "fixinclude test FAILURES" - trunk revision 145337

[Bug testsuite/39655] New: autogen "fixinclude test FAILURES" - trunk revision 145337

[rob1weld at aol dot com]

There are a few failures in autogen's fixinclude tests for 
gcc version 4.5.0 20090331, trunk revision 145337. One file
says "fixinc check FAILS ON BSD" the others are silent:


# gmake -i -k check 
gmake[1]: Entering directory `/usr/gcc_build'
gmake[2]: Entering directory `/usr/gcc_build/fixincludes'
autogen -T /home/user/gcc_trunk/fixincludes/check.tpl
/home/user/gcc_trunk/fixincludes/inclhack.def
/bin/sh ./check.sh /home/user/gcc_trunk/fixincludes/tests/base
Fixed:  testing.h
Fixed:  testing.h
Fixed:  AvailabilityMacros.h
Fixed:  X11/ShellP.h
...
Fixed:  unistd.h
Fixed:  wchar.h
Xm/Traversal.h /home/user/gcc_trunk/fixincludes/tests/base/Xm/Traversal.h
differ: char 296, line 15
*** Xm/Traversal.h      Sun Apr  5 12:20:08 2009
--- /home/user/gcc_trunk/fixincludes/tests/base/Xm/Traversal.h  Thu Apr  2
10:08:06 2009
***************
*** 12,18 ****
  #if defined( X11_NEW_CHECK )
  struct wedge {
  #ifdef __cplusplus
! Widget        old, c_new;
  #else
     Widget     old, new; /* fixinc check FAILS ON BSD */
  #endif
--- 12,18 ----
  #if defined( X11_NEW_CHECK )
  struct wedge {
  #ifdef __cplusplus
!       Widget  old, c_new;
  #else
     Widget     old, new; /* fixinc check FAILS ON BSD */
  #endif
pthread.h /home/user/gcc_trunk/fixincludes/tests/base/pthread.h differ: char
2234, line 60
*** pthread.h   Sun Apr  5 12:20:09 2009
--- /home/user/gcc_trunk/fixincludes/tests/base/pthread.h       Sat Apr  4
21:03:36 2009
***************
*** 57,82 ****

  #if defined( GLIBC_MUTEX_INIT_CHECK )
  #define PTHREAD_MUTEX_INITIALIZER \
!   { { 0, } }
  #ifdef __USE_GNU
  # if __WORDSIZE == 64
  #  define PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP \
!   { { 0, 0, 0, 0, PTHREAD_MUTEX_RECURSIVE_NP } }
  #  define PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP \
!   { { 0, 0, 0, 0, PTHREAD_MUTEX_ERRORCHECK_NP } }
  #  define PTHREAD_ADAPTIVE_MUTEX_INITIALIZER_NP \
!   { { 0, 0, 0, 0, PTHREAD_MUTEX_ADAPTIVE_NP } }
  # else
  #  define PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP \
!   { { 0, 0, 0, PTHREAD_MUTEX_RECURSIVE_NP } }
  #  define PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP \
!   { { 0, 0, 0, PTHREAD_MUTEX_ERRORCHECK_NP } }
  #  define PTHREAD_ADAPTIVE_MUTEX_INITIALIZER_NP \
!   { { 0, 0, 0, PTHREAD_MUTEX_ADAPTIVE_NP } }
  # endif
  #endif
! # define PTHREAD_RWLOCK_INITIALIZER \
!   { { 0, } }
  # ifdef __USE_GNU
  #  if __WORDSIZE == 64
  #   define PTHREAD_RWLOCK_WRITER_NONRECURSIVE_INITIALIZER_NP \
--- 57,87 ----

  #if defined( GLIBC_MUTEX_INIT_CHECK )
  #define PTHREAD_MUTEX_INITIALIZER \
!   { { 0, 0, 0, 0, 0, 0 } }
  #ifdef __USE_GNU
  # if __WORDSIZE == 64
  #  define PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP \
!   { { 0, 0, 0, 0, PTHREAD_MUTEX_RECURSIVE_NP, 0 } }
  #  define PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP \
!   { { 0, 0, 0, 0, PTHREAD_MUTEX_ERRORCHECK_NP, 0 } }
  #  define PTHREAD_ADAPTIVE_MUTEX_INITIALIZER_NP \
!   { { 0, 0, 0, 0, PTHREAD_MUTEX_ADAPTIVE_NP, 0 } }
  # else
  #  define PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP \
!   { { 0, 0, 0, PTHREAD_MUTEX_RECURSIVE_NP, 0, 0 } }
  #  define PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP \
!   { { 0, 0, 0, PTHREAD_MUTEX_ERRORCHECK_NP, 0, 0 } }
  #  define PTHREAD_ADAPTIVE_MUTEX_INITIALIZER_NP \
!   { { 0, 0, 0, PTHREAD_MUTEX_ADAPTIVE_NP, 0, 0 } }
  # endif
  #endif
! # if __WORDSIZE == 64
! #  define PTHREAD_RWLOCK_INITIALIZER \
!   { { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 } }
! # else
! #  define PTHREAD_RWLOCK_INITIALIZER \
!   { { 0, 0, 0, 0, 0, 0, 0, 0 } }
! # endif
  # ifdef __USE_GNU
  #  if __WORDSIZE == 64
  #   define PTHREAD_RWLOCK_WRITER_NONRECURSIVE_INITIALIZER_NP \
***************
*** 87,93 ****
    { { 0, 0, 0, 0, 0, 0, PTHREAD_RWLOCK_PREFER_WRITER_NONRECURSIVE_NP, 0 } }
  #  endif
  # endif
! #define PTHREAD_COND_INITIALIZER { { 0, } }
  #endif  /* GLIBC_MUTEX_INIT_CHECK */


--- 92,98 ----
    { { 0, 0, 0, 0, 0, 0, PTHREAD_RWLOCK_PREFER_WRITER_NONRECURSIVE_NP, 0 } }
  #  endif
  # endif
! #define PTHREAD_COND_INITIALIZER { { 0, 0, 0, 0, 0, (void *) 0, 0, 0 } }
  #endif  /* GLIBC_MUTEX_INIT_CHECK */


sys/stat.h /home/user/gcc_trunk/fixincludes/tests/base/sys/stat.h differ: char
432, line 18
*** sys/stat.h  Sun Apr  5 12:20:10 2009
--- /home/user/gcc_trunk/fixincludes/tests/base/sys/stat.h      Thu Apr  2
10:08:11 2009
***************
*** 15,21 ****


  #if defined( GLIBC_C99_INLINE_2_CHECK )
! extern int fstat64 (int __fd, struct stat64 *__buf) __THROW __nonnull ((2));
  #ifdef __GNUC_GNU_INLINE__
  extern
  #endif
--- 15,24 ----


  #if defined( GLIBC_C99_INLINE_2_CHECK )
! #ifdef __GNUC_GNU_INLINE__
! extern
! #endif
! __inline__ int fstat64 (int __fd, struct stat64 *__buf) __THROW __nonnull
((2));
  #ifdef __GNUC_GNU_INLINE__
  extern
  #endif

There were fixinclude test FAILURES
gmake[2]: [check] Error 1 (ignored)
gmake[2]: Leaving directory `/usr/gcc_build/fixincludes'
gmake[2]: Entering directory `/usr/gcc_build/gcc'
Making a new config file...
echo "set tmpdir /usr/gcc_build/gcc/testsuite" >> ./tmp0
...

Thanks,
Rob


-- 
           Summary: autogen "fixinclude test FAILURES" - trunk revision
                    145337
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rob1weld at aol dot com
 GCC build triplet: i386-unknown-openbsd4.5
  GCC host triplet: i386-unknown-openbsd4.5
GCC target triplet: i386-unknown-openbsd4.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39655

[Bug testsuite/39655] autogen "fixinclude test FAILURES" - trunk revision 145337

[oliver dot kellogg at eads dot com]

------- Comment #1 from oliver dot kellogg at eads dot com  2009-08-19 05:45 -------
Using trunk r150901 on openSuSE-11.1 i686-pc-linux-gnu, I get:

[...]
Fixed:  Xm/Traversal.h
complex.h /usr/src/packages/SOURCES/gcc/fixincludes/tests/base/complex.h
differ: byte 262, line 13
*** complex.h   2009-08-19 07:19:12.000000000 +0200
--- /usr/src/packages/SOURCES/gcc/fixincludes/tests/base/complex.h     
2009-08-18 22:01:38.000000000 +0200
***************
*** 10,16 ****


  #if defined( AIX_COMPLEX_CHECK )
! #  define _Complex_I (__extension__ 1.0iF)

  #endif  /* AIX_COMPLEX_CHECK */

--- 10,16 ----


  #if defined( AIX_COMPLEX_CHECK )
! #define _Complex_I (__extension__ 1.0iF)

  #endif  /* AIX_COMPLEX_CHECK */

stdint.h /usr/src/packages/SOURCES/gcc/fixincludes/tests/base/stdint.h differ:
byte 283, line 13
*** stdint.h    2009-08-19 07:19:12.000000000 +0200
--- /usr/src/packages/SOURCES/gcc/fixincludes/tests/base/stdint.h      
2009-08-18 22:01:38.000000000 +0200
*** 10,50 ****


  #if defined( AIX_STDINT_1_CHECK )
! #define UINT8_MAX     (255)
! #define UINT16_MAX    (65535)
  #endif  /* AIX_STDINT_1_CHECK */


  #if defined( AIX_STDINT_2_CHECK )
! #define INTPTR_MIN    (-INTPTR_MAX-1)
! #define INTPTR_MAX    9223372036854775807L
! #define UINTPTR_MAX   18446744073709551615UL
  #else
! #define INTPTR_MIN    (-INTPTR_MAX-1)
! #define INTPTR_MAX    2147483647L
! #define UINTPTR_MAX   4294967295UL
  #endif  /* AIX_STDINT_2_CHECK */


  #if defined( AIX_STDINT_3_CHECK )
! #define PTRDIFF_MIN (-PTRDIFF_MAX - 1)
! #define PTRDIFF_MAX __PTRDIFF_MAX__
  #else
! #define PTRDIFF_MIN (-PTRDIFF_MAX - 1)
! #define PTRDIFF_MAX __PTRDIFF_MAX__
  #endif  /* AIX_STDINT_3_CHECK */


  #if defined( AIX_STDINT_4_CHECK )
! #define SIZE_MAX __SIZE_MAX__
  #else
! #define SIZE_MAX __SIZE_MAX__
  #endif  /* AIX_STDINT_4_CHECK */
    #if defined( AIX_STDINT_5_CHECK )
! #define UINT8_C(c) __UINT8_C(c)
! #define UINT16_C(c) __UINT16_C(c)
  #endif  /* AIX_STDINT_5_CHECK */


--- 10,50 ----


  #if defined( AIX_STDINT_1_CHECK )
! #define UINT8_MAX     (255U)
! #define UINT16_MAX    (65535U)
  #endif  /* AIX_STDINT_1_CHECK */


  #if defined( AIX_STDINT_2_CHECK )
! #define INTPTR_MIN    INT64_MIN
! #define INTPTR_MAX    INT64_MAX
! #define UINTPTR_MAX   UINT64_MAX
  #else
! #define INTPTR_MIN    INT32_MIN
! #define INTPTR_MAX    INT32_MAX
! #define UINTPTR_MAX   UINT32_MAX
  #endif  /* AIX_STDINT_2_CHECK */


  #if defined( AIX_STDINT_3_CHECK )
! #define PTRDIFF_MIN   INT64_MIN
! #define PTRDIFF_MAX   INT64_MAX
  #else
! #define PTRDIFF_MIN     INT32_MIN
! #define PTRDIFF_MAX   INT32_MAX
  #endif  /* AIX_STDINT_3_CHECK */


  #if defined( AIX_STDINT_4_CHECK )
! #define SIZE_MAX      UINT64_MAX
  #else
! #define SIZE_MAX        UINT32_MAX
  #endif  /* AIX_STDINT_4_CHECK */


  #if defined( AIX_STDINT_5_CHECK )
! #define UINT8_C(c)    __CONCAT__(c,U)
! #define UINT16_C(c)   __CONCAT__(c,U)
  #endif  /* AIX_STDINT_5_CHECK */



There were fixinclude test FAILURES
make[2]: *** [check] Error 1
make[2]: Leaving directory `/usr/src/packages/BUILD/build-gcc-orig/fixincludes'

Should I file a separate bug?


-- 

oliver dot kellogg at eads dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oliver dot kellogg at eads
                   |                            |dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39655

[Bug testsuite/39655] autogen "fixinclude test FAILURES" - trunk revision 145337

[rwild at gcc dot gnu dot org]

------- Comment #2 from rwild at gcc dot gnu dot org  2009-09-08 17:31 -------
Subject: Bug 39655

Author: rwild
Date: Tue Sep  8 17:30:31 2009
New Revision: 151518

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=151518
Log:
sed portability fixes in fixincludes

fixincludes/:
        PR testsuite/29737
        PR bootstrap/35938
        PR testsuite/39655
        * check.tpl: Fix typos.
        * README: Likewise.  Also, document that 'select' uses ERE.
        * mkheaders.in: Update copyright years in --version output.
        * inclhack.def (sco_math): Add missing final newline in sed
        script 'a', 'c', or 'i' commands, for BSD sed.
        (sco_math): In the text of 'a', 'c', or 'i' sed
        commands, prepend leading white space with a backslash to avoid
        the whitespace to be removed by BSD sed.
        (sco_math): Match plain 'C++' instead of 'C\+\+' in sed regex.
        (x11_new): Fix sed expression, for BSD sed.
        (glibc_mutex_init): Fix newlines in sed 's' command replacement
        part, for GNU sed 3.02 and Solaris sed.
        (glibc_mutex_init): Replace unportable \+ sed regex operator
        with \{1,\}.
        (glibc_c99_inline_2, glibc_mutex_init): Avoid unportable sed
        alternation \| regex operator.
        (solaris_complex): Remove superfluous backslashes from
        replacement string.  Replace \+ operator with \{1,\}.
        * tests/base/Xm/Traversal.h: This is fixed for BSD sed now.
        * fixincl.x: Regenerate.

Modified:
    trunk/fixincludes/ChangeLog
    trunk/fixincludes/README
    trunk/fixincludes/check.tpl
    trunk/fixincludes/fixincl.x
    trunk/fixincludes/inclhack.def
    trunk/fixincludes/mkheaders.in
    trunk/fixincludes/tests/base/Xm/Traversal.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39655

[Bug testsuite/39655] autogen "fixinclude test FAILURES" - trunk revision 145337

[rob1weld at aol dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39655

Rob <rob1weld at aol dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Rob <rob1weld at aol dot com> 2010-12-22 04:09:22 UTC ---
Thanks Ralf, this being fixed I shall close it.

Rob