[Bug fortran/41154] New: [4.5 Regression] Comma required after P descriptor

[Bug fortran/41154] New: [4.5 Regression] Comma required after P descriptor

[janus at gcc dot gnu dot org]

With r151053 I get an error when I compile the following line:

2000 format (1X,1P,E14.6,3E12.4,0P)
                                   1
Error: Comma required after P descriptor in format string at (1)

While I haven't checked in the standard if this is really valid, it was
swallowed by gfortran until recently. It is also accepted by ifort and g95.

This was certainly introduced by Jerry's r151045.


-- 
           Summary: [4.5 Regression] Comma required after P descriptor
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Keywords: rejects-valid
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: janus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41154

[Bug fortran/41154] [4.5 Regression] Comma required after P descriptor

[burnus at gcc dot gnu dot org]

------- Comment #1 from burnus at gcc dot gnu dot org  2009-08-24 13:45 -------
> With r151053 I get an error when I compile the following line:
> 2000 format (1X,1P,E14.6,3E12.4,0P)
>                                    1
> Error: Comma required after P descriptor in format string at (1)

That looks like a bug: There is surely no comma required at the end of the
format/before a ')'. Seemingly, we missed that special case. The check is
correct for fmt strings such as  '(1P2E12.4)'.

However, I cannot reproduce the problem with a program consisting only of:

2000 format (1X,1P,E14.6,3E12.4,0P)
end

In PR 41152, it was also depending on other lines. Can you re-check?


> This was certainly introduced by Jerry's r151045.

See also PR 35754.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41154

[Bug fortran/41154] [4.5 Regression] Comma required after P descriptor

[janus at gcc dot gnu dot org]

------- Comment #2 from janus at gcc dot gnu dot org  2009-08-24 13:55 -------

> However, I cannot reproduce the problem with a program consisting only of:
> 
> 2000 format (1X,1P,E14.6,3E12.4,0P)
> end

Hm, funny. For me the error *does* appear already for this two-liner (at
r151053).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41154

[Bug fortran/41154] [4.5 Regression] Comma required after P descriptor

[jvdelisle at verizon dot net]

------- Comment #3 from jvdelisle at verizon dot net  2009-08-24 23:45 -------
Subject: Re:   New: [4.5 Regression] Comma required after P
 descriptor

On 08/24/2009 05:26 AM, janus at gcc dot gnu dot org wrote:
> With r151053 I get an error when I compile the following line:
>
> 2000 format (1X,1P,E14.6,3E12.4,0P)
>                                     1
> Error: Comma required after P descriptor in format string at (1)
>
> While I haven't checked in the standard if this is really valid, it was
> swallowed by gfortran until recently. It is also accepted by ifort and g95.
>
> This was certainly introduced by Jerry's r151045.
>
>
Thats my fault, will fix shortly.

Jerry


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41154

Re: [Bug fortran/41154] New: [4.5 Regression] Comma required after P descriptor

[Jerry DeLisle]

On 08/24/2009 05:26 AM, janus at gcc dot gnu dot org wrote:
> With r151053 I get an error when I compile the following line:
>
> 2000 format (1X,1P,E14.6,3E12.4,0P)
>                                     1
> Error: Comma required after P descriptor in format string at (1)
>
> While I haven't checked in the standard if this is really valid, it was
> swallowed by gfortran until recently. It is also accepted by ifort and g95.
>
> This was certainly introduced by Jerry's r151045.
>
>
Thats my fault, will fix shortly.

Jerry

[Bug fortran/41154] [4.5 Regression] Comma required after P descriptor

[jvdelisle at gcc dot gnu dot org]

------- Comment #4 from jvdelisle at gcc dot gnu dot org  2009-08-25 01:03 -------
Patch is simple and obvious.  I will commit shortly.

Index: io.c
===================================================================
--- io.c        (revision 151045)
+++ io.c        (working copy)
@@ -694,7 +694,7 @@
        goto fail;
       if (gfc_option.allow_std < GFC_STD_F2003 && t != FMT_COMMA
          && t != FMT_F && t != FMT_E && t != FMT_EN && t != FMT_ES
-         && t != FMT_D && t != FMT_G)
+         && t != FMT_D && t != FMT_G && t != FMT_RPAREN)
        {
          error = _("Comma required after P descriptor");
          goto syntax;
@@ -708,7 +708,7 @@
                goto fail;
            }
           if (t != FMT_F && t != FMT_E && t != FMT_EN && t != FMT_ES && t !=
FMT_D
-             && t != FMT_G)
+             && t != FMT_G && t != FMT_RPAREN)
            {
              error = _("Comma required after P descriptor");
              goto syntax;


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jvdelisle at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-08-25 01:03:20
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41154

[Bug fortran/41154] [4.5 Regression] Comma required after P descriptor

[jvdelisle at gcc dot gnu dot org]

------- Comment #5 from jvdelisle at gcc dot gnu dot org  2009-08-25 01:05 -------
Subject: Bug 41154

Author: jvdelisle
Date: Tue Aug 25 01:05:11 2009
New Revision: 151070

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=151070
Log:
2009-08-24  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/41154
        * io.c (check_format): Fix to not error on right paren after P.

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/io.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41154

[Bug fortran/41154] [4.5 Regression] Comma required after P descriptor

[jvdelisle at gcc dot gnu dot org]

------- Comment #6 from jvdelisle at gcc dot gnu dot org  2009-08-25 01:14 -------
Subject: Bug 41154

Author: jvdelisle
Date: Tue Aug 25 01:14:13 2009
New Revision: 151071

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=151071
Log:
2009-08-24  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/41154
        * gfortran.dg/fmt_error_8.f: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/fmt_error_8.f
Modified:
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41154

[Bug fortran/41154] [4.5 Regression] Comma required after P descriptor

[jvdelisle at gcc dot gnu dot org]

------- Comment #7 from jvdelisle at gcc dot gnu dot org  2009-08-25 01:21 -------
Closing.  By all means let me know if anything else crops up.  Thanks for
catching this.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41154