[Bug c++/41313] New: g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[Bug c++/41313] New: g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

Current on all *-apple-darwin* targets were seeing the following
g++.dg/tree-prof/partition1.C tests fail...

FAIL: g++.dg/tree-prof/partition1.C compilation,  -g  -fprofile-use
UNRESOLVED: g++.dg/tree-prof/partition1.C execution,    -g  -fprofile-use
FAIL: g++.dg/tree-prof/partition1.C compilation,  -O0  -fprofile-use
UNRESOLVED: g++.dg/tree-prof/partition1.C execution,    -O0  -fprofile-use
FAIL: g++.dg/tree-prof/partition1.C compilation,  -O1  -fprofile-use
UNRESOLVED: g++.dg/tree-prof/partition1.C execution,    -O1  -fprofile-use
FAIL: g++.dg/tree-prof/partition1.C compilation,  -O2  -fprofile-use
UNRESOLVED: g++.dg/tree-prof/partition1.C execution,    -O2  -fprofile-use
FAIL: g++.dg/tree-prof/partition1.C compilation,  -O3  -fprofile-use
UNRESOLVED: g++.dg/tree-prof/partition1.C execution,    -O3  -fprofile-use
FAIL: g++.dg/tree-prof/partition1.C compilation,  -O3 -g  -fprofile-use
UNRESOLVED: g++.dg/tree-prof/partition1.C execution,    -O3 -g  -fprofile-use
FAIL: g++.dg/tree-prof/partition1.C compilation,  -Os  -fprofile-use
UNRESOLVED: g++.dg/tree-prof/partition1.C execution,    -Os  -fprofile-use

On x86_64-apple-darwin10, these appear in the form...

Executing on host:
/sw/src/fink.build/gcc45-4.4.999-20090908/darwin_objdir/gcc/testsuite/g++/../../g++
-B/sw/src/fink.build/gcc45-4.4.999-20090908/darwin_objdir/gcc/testsuite/g++/../../
/sw/src/fink.build/gcc45-4.4.999-20090908/gcc-4.5-20090908/gcc/testsuite/g++.dg/tree-prof/partition1.C
 -nostdinc++
-I/sw/src/fink.build/gcc45-4.4.999-20090908/darwin_objdir/x86_64-apple-darwin10/libstdc++-v3/include/x86_64-apple-darwin10
-I/sw/src/fink.build/gcc45-4.4.999-20090908/darwin_objdir/x86_64-apple-darwin10/libstdc++-v3/include
-I/sw/src/fink.build/gcc45-4.4.999-20090908/gcc-4.5-20090908/libstdc++-v3/libsupc++
-I/sw/src/fink.build/gcc45-4.4.999-20090908/gcc-4.5-20090908/libstdc++-v3/include/backward
-I/sw/src/fink.build/gcc45-4.4.999-20090908/gcc-4.5-20090908/libstdc++-v3/testsuite/util
-fmessage-length=0  -g  -O2 -freorder-blocks-and-partition -fprofile-use   
-L/sw/src/fink.build/gcc45-4.4.999-20090908/darwin_objdir/x86_64-apple-darwin10/./libstdc++-v3/src/.libs

-L/sw/src/fink.build/gcc45-4.4.999-20090908/darwin_objdir/x86_64-apple-darwin10/./libstdc++-v3/src/.libs
-L/sw/src/fink.build/gcc45-4.4.999-20090908/darwin_objdir/x86_64-apple-darwin10/./libiberty
 -multiply_defined suppress -lm   -o
/sw/src/fink.build/gcc45-4.4.999-20090908/darwin_objdir/gcc/testsuite/g++/partition1.x02
   (timeout = 300)
/var/tmp//ccXmTU1f.s:1132:FATAL:Symbol __Z3bari.eh already defined.
compiler exited with status 1
output is:
/var/tmp//ccXmTU1f.s:1132:FATAL:Symbol __Z3bari.eh already defined.

FAIL: g++.dg/tree-prof/partition1.C compilation,  -g  -fprofile-use
UNRESOLVED: g++.dg/tree-prof/partition1.C execution,    -g  -fprofile-use


-- 
           Summary: g++.dg/tree-prof/partition1.C compilation and execution
                    test failures on *-apple-darwin*
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: howarth at nitro dot med dot uc dot edu
 GCC build triplet: *-apple-darwin*
  GCC host triplet: *-apple-darwin*
GCC target triplet: *-apple-darwin*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #1 from howarth at nitro dot med dot uc dot edu  2009-09-10 03:49 -------
Created an attachment (id=18558)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18558&action=view)
preprocessed source for g++.dg/tree-prof/partition1.C compilation -g
-fprofile-use


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #2 from howarth at nitro dot med dot uc dot edu  2009-09-10 03:50 -------
Created an attachment (id=18559)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18559&action=view)
assembly file for g++.dg/tree-prof/partition1.C compilation -g -fprofile-use


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #3 from howarth at nitro dot med dot uc dot edu  2009-09-10 03:51 -------
Created an attachment (id=18560)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18560&action=view)
gcda file for g++.dg/tree-prof/partition1.C compilation -g -fprofile-use


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #4 from howarth at nitro dot med dot uc dot edu  2009-09-10 03:52 -------
Attached files were generated under r151584 with the command...

/sw/src/fink.build/gcc45-4.4.999-20090909/darwin_objdir/gcc/testsuite/g++/../../g++
-B/sw/src/fink.build/gcc45-4.4.999-20090909/darwin_objdir/gcc/testsuite/g++/../../
/sw/src/fink.build/gcc45-4.4.999-20090909/gcc-4.5-20090909/gcc/testsuite/g++.dg/tree-prof/partition1.C
-nostdinc++
-I/sw/src/fink.build/gcc45-4.4.999-20090909/darwin_objdir/x86_64-apple-darwin10/libstdc++-v3/include/x86_64-apple-darwin10
-I/sw/src/fink.build/gcc45-4.4.999-20090909/darwin_objdir/x86_64-apple-darwin10/libstdc++-v3/include
-I/sw/src/fink.build/gcc45-4.4.999-20090909/gcc-4.5-20090909/libstdc++-v3/libsupc++
-I/sw/src/fink.build/gcc45-4.4.999-20090909/gcc-4.5-20090909/libstdc++-v3/include/backward
-I/sw/src/fink.build/gcc45-4.4.999-20090909/gcc-4.5-20090909/libstdc++-v3/testsuite/util
-fmessage-length=0 --save-temps -g -O2 -freorder-blocks-and-partition
-fprofile-use
-L/sw/src/fink.build/gcc45-4.4.999-20090909/darwin_objdir/x86_64-apple-darwin10/./libstdc++-v3/src/.libs
-L/sw/src/fink.build/gcc45-4.4.999-20090909/darwin_objdir/x86_64-apple-darwin10/./libstdc++-v3/src/.libs
-L/sw/src/fink.build/gcc45-4.4.999-20090909/darwin_objdir/x86_64-apple-darwin10/./libiberty
-multiply_defined suppress -lm -o
/sw/src/fink.build/gcc45-4.4.999-20090909/darwin_objdir/gcc/testsuite/g++/partition1.x02

which produced the error...

partition1.s:1132:FATAL:Symbol __Z3bari.eh already defined.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #5 from howarth at nitro dot med dot uc dot edu  2009-09-26 18:14 -------
Jakub,
    Can you check what --save-temps produces for g++.dg/tree-prof/partition1.C
in partition1.s on linux? Does it produce two sets of global statements as
well?

grep __Z3bari.eh partition1.S
.globl __Z3bari.eh
__Z3bari.eh:
.globl __Z3bari.eh
__Z3bari.eh:

If so, is this by design or is it a gcc bug which binutils tolerates.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[dominiq at lps dot ens dot fr]

------- Comment #6 from dominiq at lps dot ens dot fr  2009-09-26 19:10 -------
I also see similar failures on i686-apple-darwin9 in 32-bit mode (but not with
-m64) for
gcc.dg/tree-prof/bb-reorg.c and gcc.dg/tree-prof/pr34999.c:

output is:
/var/tmp//cc3DMvjA.s:230:FATAL:Symbol _foo.eh already defined.

FAIL: gcc.dg/tree-prof/bb-reorg.c compilation,  -fprofile-use -D_PROFILE_USE
...
output is:
/var/tmp//ccHG6m6S.s:219:FATAL:Symbol _main.eh already defined.

FAIL: gcc.dg/tree-prof/pr34999.c compilation,  -fprofile-use -D_PROFILE_USE


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[hjl dot tools at gmail dot com]

------- Comment #7 from hjl dot tools at gmail dot com  2009-09-26 20:20 -------
(In reply to comment #5)
> Jakub,
>     Can you check what --save-temps produces for g++.dg/tree-prof/partition1.C
> in partition1.s on linux? Does it produce two sets of global statements as
> well?
> 
> grep __Z3bari.eh partition1.S
> .globl __Z3bari.eh
> __Z3bari.eh:
> .globl __Z3bari.eh
> __Z3bari.eh:
> 

Linux doesn't have __Z3bari.eh at all.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[rguenth at gcc dot gnu dot org]

------- Comment #8 from rguenth at gcc dot gnu dot org  2009-09-26 20:43 -------
darwin has -fpic by default.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #9 from howarth at nitro dot med dot uc dot edu  2009-09-30 20:26 -------
(In reply to comment #8)
> darwin has -fpic by default.
> 

Oddly, if I build gcc trunk on x86_64 Fedora 10 with CPPFLAGS set to -fPIC and
run the testsuite with -fPIC, I don't see the .eh symbols...

grep globl partition1.s
.globl _ZN1AC2Ev
.globl _ZN1AC1Ev
.globl _ZN1AD2Ev
.globl _ZN1AD1Ev
.globl _Z3bari
.globl _Z3foov
.globl __gxx_personality_v0
.globl main
.globl k
.globl l

compared to x86_64-apple-darwin10...

.globl __ZN1AC2Ev
.globl __ZN1AC1Ev
.globl __ZN1AD2Ev
.globl __ZN1AD1Ev
.globl __Z3bari
.globl __Z3foov
.globl _main
.globl _k
.globl _l
.globl __ZN1AC2Ev.eh
.globl __ZN1AC1Ev.eh
.globl __ZN1AD2Ev.eh
.globl __ZN1AD1Ev.eh
.globl __Z3bari.eh
.globl __Z3bari.eh
.globl __Z3foov.eh
.globl __Z3foov.eh
.globl _main.eh


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[mrs at apple dot com]

------- Comment #10 from mrs at apple dot com  2009-09-30 20:54 -------
When targeting darwin10, the .eh symbols don't have to be generated anymore. 
They are from darwin.c, darwin_emit_unwind_label.

 if (darwin_macosx_version_min
      && strverscmp (darwin_macosx_version_min, "10.6") >= 0)

can be used, and the entirety of the routine can be avoided.  That said, this
is a bug somewhere, it can be found by binary searching the testcase on the
compiler sources until the change that dupped these is found.  I don't believe
it has always been broken.  Or, you can just put a breakpoint on this routine,
and when the second one is hit, find a variable that is different that the
first time it is hit, and pass that as a parameter and the bail out, just like
! for_eh.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #11 from howarth at nitro dot med dot uc dot edu  2009-09-30 22:36 -------
Mike,
     I am a fuzzy on the best way to avoid darwin_emit_unwind_label since it is
assigned to a define in darwin.h. The only thing that makes sense to me is...

Index: gcc/config/darwin.c
===================================================================
--- gcc/config/darwin.c (revision 152347)
+++ gcc/config/darwin.c (working copy)
@@ -1454,7 +1454,7 @@
 {
   char *lab;

-  if (! for_eh)
+  if ((! for_eh) || (darwin_macosx_version_min && strverscmp
(darwin_macosx_version_min, "10.6") >= 0))
     return;

   lab = concat (IDENTIFIER_POINTER (DECL_ASSEMBLER_NAME (decl)), ".eh", NULL);

Does that seem reasonable?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[jakub at gcc dot gnu dot org]

------- Comment #12 from jakub at gcc dot gnu dot org  2009-09-30 22:46 -------
It is unclear what those labels are good for, but if darwin is to support
hot/cold partitioning and FDEs covering it, the emit unwind_label hook (which
is apparently darwin specific only) should be passed also the SECOND variable
and create different label name for the second FDE for the same function (if
function starts in hot section, then the second one is covering the cold
section, and vice versa).
The patch in #c11 would just mean you'd keep older versions broken.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #13 from howarth at nitro dot med dot uc dot edu  2009-10-01 00:18 -------
Actually, the patch in Comment 11 leaves two of the original failures...

FAIL: g++.dg/tree-prof/partition1.C compilation,  -g  -fprofile-use
FAIL: g++.dg/tree-prof/partition1.C compilation,  -O3 -g  -fprofile-use

These remaining failing test cases are both accompanied by the numerous
warnings of the form...

ld: warning: can't add line info to anonymous symbol anon-func-0xF40 from
/var/tmp//ccwuqn0i.o

and

output is:
ld: warning: can't add line info to anonymous symbol anon-func-0xF40 from
/var/tmp//ccwuqn0i.o


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #14 from howarth at nitro dot med dot uc dot edu  2009-10-01 00:29 -------
Jakub,
   If you could propose a patch to the darwin_emit_unwind_label subroutine in
gcc/config/darwin.c to implement the changes you propose in Comment 12, I would
be happy to test it on darwin9/darwin10. I'm out of my depth to try to
implement that cleanly myself.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[mrs at apple dot com]

------- Comment #15 from mrs at apple dot com  2009-10-01 00:54 -------
Yeah, the patch in #11 is about the right for half the problem (darwin10), if
it weren't for ld's warning message.  I don't know quite why it is doing that,
so guess we'll just have to nix that idea.  So, the next best thing would be to
just turn off hot/cold partitioning for darwin.  In override_option in
darwin.c, just do hot_cold = 0.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #16 from howarth at nitro dot med dot uc dot edu  2009-10-01 15:41 -------
   It looks like this problem isn't strictly target specific (although we are
the only target currently impacted). If TARGET_ASM_EMIT_UNWIND_LABEL as defined
needs to support passing SECOND, both the default_emit_unwind_label() and
darwin_emit_unwind_label() prototypes would have to be revised to support this
additional variable as well as any place they are called from to properly
support hot/cold partitioning.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #17 from howarth at nitro dot med dot uc dot edu  2009-10-01 15:55 -------
(In reply to comment #15)
> Yeah, the patch in #11 is about the right for half the problem (darwin10), if
> it weren't for ld's warning message.  I don't know quite why it is doing that,
> so guess we'll just have to nix that idea.  So, the next best thing would be to
> just turn off hot/cold partitioning for darwin.  In override_option in
> darwin.c, just do hot_cold = 0.
> 

Won't disabling hot/cold partitioning for darwin potentially degrade the code
generation at -O3 or is this issue limited to -freorder-blocks-and-partition
only?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[mrs at apple dot com]

------- Comment #18 from mrs at apple dot com  2009-10-01 19:14 -------
Yes.  If someone wants to propose a better solution, they will...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #19 from howarth at nitro dot med dot uc dot edu  2009-10-01 23:54 -------
I'm not sure that hot_cold=0 would work as a grep of gcc trunk doesn't show any
thing matching hot_cold. I did find the original commit of the problematic
code...

http://gcc.gnu.org/ml/gcc/2004-02/msg00825.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[mrs at apple dot com]

------- Comment #20 from mrs at apple dot com  2009-10-02 02:03 -------
flag_reorder_blocks_and_partition was the complete name of the variable last I
looked.  If flag_unwind_tables is true and this variable is true, that's the
bug.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #21 from howarth at nitro dot med dot uc dot edu  2009-10-02 02:36 -------
We seemed to have changed the original code from gcc 4.2.1...

  /* If user requested unwind info, then turn off the partitioning
     optimization.  */

  if (flag_unwind_tables && ! targetm.unwind_tables_default
      && flag_reorder_blocks_and_partition)
    {
      inform ("-freorder-blocks-and-partition does not support unwind info");
      flag_reorder_blocks_and_partition = 0;
      flag_reorder_blocks = 1;
    }


in gcc/opts.c to...

  /* If the target requested unwind info, then turn off the partitioning
     optimization with a different message.  Likewise, if the target does not
     support named sections.  */

  if (flag_reorder_blocks_and_partition
      && (!targetm.have_named_sections
          || (flag_unwind_tables && targetm.unwind_tables_default
              && (USING_SJLJ_EXCEPTIONS
#ifdef TARGET_UNWIND_INFO
                  || 1
#endif
                 ))))
    {
      inform (input_location,
              "-freorder-blocks-and-partition does not work on this
architecture");
      flag_reorder_blocks_and_partition = 0;
      flag_reorder_blocks = 1;
    }


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #22 from howarth at nitro dot med dot uc dot edu  2009-10-02 02:44 -------
This change came from...

Author: jakub
Date: Fri Aug  7 06:23:42 2009
New Revision: 150553

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=150553
Log:
        * dwarf2out.c (output_fde): When doing hot/cold partitioning, use
        fde->dw_fde_begin as begin label instead of hot/cold label.
        Use LLSDAC label instead of LLSDA for second section lsda.
        (dwarf2out_do_cfi_startproc): Add SECOND argument.  Use LLSDAC
        label instead of LLSDA if it is true.
        (dwarf2out_begin_prologue, dwarf2out_switch_text_section): Adjust
        callers.
        * except.c (add_call_site, dw2_size_of_call_site_table): Add
        SECTION argument.  Use it as index into crtl->eh.call_site_record
        array.
        (dw2_output_call_site_table): Likewise.  Add CS_FORMAT argument,
        use it to determine how to print table entries instead of using
        #ifdef HAVE_AS_LEB128.  For SECTION > 0 use hot resp. cold
        label instead of normal begin label as base.
        (sjlj_assign_call_site_values): Adjust add_call_site caller.
        (convert_to_eh_region_ranges): When doing hot/cold partitioning,
        ensure no EH range spans between sections and that landing pads
        are always in the corresponding section.
        (sjlj_size_of_call_site_table, sjlj_output_call_site_table): Adjust
        for crtl->eh.call_site_record being an array rather than scalar.
        (output_one_function_exception_table): New function, copied
        from output_function_exception_table.  Adjust
        dw2_size_of_call_site_table, dw2_output_call_site_table
        callers.  For SECOND section use *C suffixed labels.
        (output_function_exception_table): Call
        output_one_function_exception_table and, when doing hot/cold
        partitioning, also another time for the second section.
        * opts.c: Include except.h.
        (decode_options): Allow -freorder-blocks-and-partition with
        exceptions, unless SJLJ or TARGET_UNWIND_INFO.
        * Makefile.in (opts.o): Depend on $(EXCEPT_H).
        * function.h (struct rtl_eh): Change call_site_record from
        scalar into array of 2 elements.

        * g++.dg/tree-prof/partition1.C: New test.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #23 from howarth at nitro dot med dot uc dot edu  2009-10-02 05:00 -------
Oddly...

Index: config/darwin.c
===================================================================
--- config/darwin.c     (revision 152389)
+++ config/darwin.c     (working copy)
@@ -1697,6 +1697,9 @@
   if (dwarf_strict < 0) 
     dwarf_strict = 1;

+  if (flag_unwind_tables)
+    flag_reorder_blocks_and_partition = 0;
+
   if (flag_mkernel || flag_apple_kext)
     {
       /* -mkernel implies -fapple-kext for C++ */

doesn't solve the problem. However if I manually revert...

--- /Users/howarth/gcc/gcc/opts.c       2009-09-28 19:33:18.000000000 -0400
+++ opts.c      2009-10-02 00:51:55.000000000 -0400
@@ -1054,12 +1054,7 @@
      optimization.  */

   if (flag_unwind_tables && ! targetm.unwind_tables_default
-      && flag_reorder_blocks_and_partition
-      && (USING_SJLJ_EXCEPTIONS
-#ifdef TARGET_UNWIND_INFO
-         || 1
-#endif
-        ))
+      && flag_reorder_blocks_and_partition)
     {
       inform (input_location,
              "-freorder-blocks-and-partition does not support unwind info on
this architecture");

The failures are reduced down to just...

FAIL: g++.dg/tree-prof/partition1.C compilation,  -fprofile-use

with the same error as before...

/var/tmp//ccMjlW9T.s:620:FATAL:Symbol __Z3bari.eh already defined.compiler
exited with status 1output is:/var/tmp//ccMjlW9T.s:620:FATAL:Symbol __Z3bari.eh
already defined.

Perhaps there is another instance of flag_reorder_blocks_and_partition being
reset to 1 in the -fprofile-use case?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #24 from howarth at nitro dot med dot uc dot edu  2009-10-02 05:11 -------
Oh, I didn't regress out all of the changes from...

http://gcc.gnu.org/viewcvs/trunk/gcc/opts.c?r1=150553&r2=150552&view=patch&pathrev=150553

when I do that, the tree-prof tests pass fine...

Native configuration is x86_64-apple-darwin10.0.0

                === g++ tests ===


Running target unix/-m32

                === g++ Summary for unix/-m32 ===

# of expected passes            12
# of unsupported tests          1

Running target unix/-m64

                === g++ Summary for unix/-m64 ===

# of expected passes            12
# of unsupported tests          1

                === g++ Summary ===

# of expected passes            24
# of unsupported tests          2
/sw/src/fink.build/gcc45-4.4.999-20090930/darwin_objdir/gcc/testsuite/g++/../../g++
 version 4.5.0 20090930 (experimental) (GCC) 


Compiler version: 4.5.0 20090930 (experimental) (GCC) g++ 
Platform: x86_64-apple-darwin10.0.0
configure flags: --prefix=/sw --prefix=/sw/lib/gcc4.5 --mandir=/sw/share/man
--infodir=/sw/share/info --enable-languages=c,c++,fortran,objc,java
--with-gmp=/sw --with-libiconv-prefix=/sw --with-ppl=/sw --with-cloog=/sw
--with-system-zlib --x-includes=/usr/X11R6/include --x-libraries=/usr/X11R6/lib
--disable-libjava-multilib


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #25 from howarth at nitro dot med dot uc dot edu  2009-10-02 05:34 -------
The following change achieves the same test results as in Comment 24...

--- /Users/howarth/gcc/gcc/opts.c       2009-09-28 19:33:18.000000000 -0400
+++ opts.c      2009-10-02 01:30:48.000000000 -0400
@@ -1038,11 +1038,14 @@
      turn off the partitioning optimization.  */

   if (flag_exceptions && flag_reorder_blocks_and_partition
+#if !defined(__MACH__)
       && (USING_SJLJ_EXCEPTIONS
-#ifdef TARGET_UNWIND_INFO
+#if defined(TARGET_UNWIND_INFO)
          || 1
 #endif
-        ))
+        )
+#endif
+        )
     {
       inform (input_location, 
              "-freorder-blocks-and-partition does not work with exceptions on
this architecture");
@@ -1055,11 +1058,14 @@

   if (flag_unwind_tables && ! targetm.unwind_tables_default
       && flag_reorder_blocks_and_partition
+#if !defined(__MACH__)
       && (USING_SJLJ_EXCEPTIONS
-#ifdef TARGET_UNWIND_INFO
+#if defined(TARGET_UNWIND_INFO)
          || 1
 #endif
-        ))
+        )
+#endif
+         )
     {
       inform (input_location,
              "-freorder-blocks-and-partition does not support unwind info on
this architecture");
@@ -1074,11 +1080,14 @@
   if (flag_reorder_blocks_and_partition
       && (!targetm.have_named_sections
          || (flag_unwind_tables && targetm.unwind_tables_default
+#if !defined(__MACH__)
              && (USING_SJLJ_EXCEPTIONS
-#ifdef TARGET_UNWIND_INFO
+#if defined(TARGET_UNWIND_INFO)
                  || 1
 #endif
-                ))))
+               )
+#endif
+                 ))) 
     {
       inform (input_location,
              "-freorder-blocks-and-partition does not work on this
architecture");


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #26 from howarth at nitro dot med dot uc dot edu  2009-10-02 05:40 -------
I should note that if I don't wrapper the line ...

              && (USING_SJLJ_EXCEPTIONS

with the #if !defined(__MACH__), I get the following results...

                === g++ tests ===

Schedule of variations:
    unix/-m32
    unix/-m64

Running target unix/-m32
Using /sw/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /sw/share/dejagnu/config/unix.exp as generic interface file for target.
Using
/sw/src/fink.build/gcc45-4.4.999-20090930/gcc-4.5-20090930/gcc/testsuite/config/default.exp
as tool-and-target-specific interface file.
Running
/sw/src/fink.build/gcc45-4.4.999-20090930/gcc-4.5-20090930/gcc/testsuite/g++.dg/tree-prof/tree-prof.exp
...
FAIL: g++.dg/tree-prof/partition1.C compilation,  -fprofile-use

                === g++ Summary for unix/-m32 ===

# of expected passes            14
# of unexpected failures        1
# of unresolved testcases       1
Running target unix/-m64
Using /sw/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /sw/share/dejagnu/config/unix.exp as generic interface file for target.
Using
/sw/src/fink.build/gcc45-4.4.999-20090930/gcc-4.5-20090930/gcc/testsuite/config/default.exp
as tool-and-target-specific interface file.
Running
/sw/src/fink.build/gcc45-4.4.999-20090930/gcc-4.5-20090930/gcc/testsuite/g++.dg/tree-prof/tree-prof.exp
...
FAIL: g++.dg/tree-prof/partition1.C compilation,  -fprofile-use

                === g++ Summary for unix/-m64 ===

# of expected passes            14
# of unexpected failures        1
# of unresolved testcases       1

                === g++ Summary ===

# of expected passes            28
# of unexpected failures        2
# of unresolved testcases       2
/sw/src/fink.build/gcc45-4.4.999-20090930/darwin_objdir/prev-gcc/testsuite/g++/../../g++
 version 4.5.0 20090930 (experimental) (GCC) 

so the entirety of the additional conditional added in r150553 needs to be
wrappered on darwin.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #27 from howarth at nitro dot med dot uc dot edu  2009-10-02 05:44 -------
I should note that with the proposed change in Comment 25, the 2 unsupported
tests properly show up in g++.log as...

cc1plus: note: -freorder-blocks-and-partition does not work with exceptions on
this architecture
output is:
cc1plus: note: -freorder-blocks-and-partition does not work with exceptions on
this architecture

UNSUPPORTED:
/sw/src/fink.build/gcc45-4.4.999-20090930/gcc-4.5-20090930/gcc/testsuite/g++.dg/tree-prof/partition1.C


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #28 from howarth at nitro dot med dot uc dot edu  2009-10-02 14:08 -------
On reflection, I think the change Mike proposed for darwin.c in Comment 13
fails because it flag_reorder_blocks never gets set to 1 by that patch. I don't
know how I could implement the three variations of setting that which occur in
opts.c from within the overrides of darwin.c. Those cases in opts.c are listed
as...

  /* The optimization to partition hot and cold basic blocks into separate
     sections of the .o and executable files does not work (currently)
     with exception handling.  This is because there is no support for
     generating unwind info.  If flag_exceptions is turned on we need to
     turn off the partitioning optimization.  */

  /* If user requested unwind info, then turn off the partitioning
     optimization.  */

  /* If the target requested unwind info, then turn off the partitioning
     optimization with a different message.  Likewise, if the target does not
     support named sections.  */

Would it be as simple as duplicating those three variations of the conditional
within the overrides of darwin.c to duplicate their behavior? It seem much
better to fix the breakage in opts.c caused by r150553.


-- 

howarth at nitro dot med dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|g++.dg/tree-                |r150553 causes g++.dg/tree-
                   |prof/partition1.C           |prof/partition1.C
                   |compilation and execution   |compilation and execution
                   |test failures on *-apple-   |test failures on *-apple-
                   |darwin*                     |darwin*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #29 from howarth at nitro dot med dot uc dot edu  2009-10-02 22:09 -------
Jakub,
    Is there any reason why we can't have...

Index: opts.c
===================================================================
--- opts.c      (revision 152346)
+++ opts.c      (working copy)
@@ -1039,7 +1039,7 @@

   if (flag_exceptions && flag_reorder_blocks_and_partition
       && (USING_SJLJ_EXCEPTIONS
-#ifdef TARGET_UNWIND_INFO
+#if defined (TARGET_UNWIND_INFO) || defined (DWARF2_UNWIND_INFO)
          || 1
 #endif
         ))
@@ -1056,7 +1056,7 @@
   if (flag_unwind_tables && ! targetm.unwind_tables_default
       && flag_reorder_blocks_and_partition
       && (USING_SJLJ_EXCEPTIONS
-#ifdef TARGET_UNWIND_INFO
+#if defined (TARGET_UNWIND_INFO) || defined (DWARF2_UNWIND_INFO)
          || 1
 #endif
         ))
@@ -1075,7 +1075,7 @@
       && (!targetm.have_named_sections
          || (flag_unwind_tables && targetm.unwind_tables_default
              && (USING_SJLJ_EXCEPTIONS
-#ifdef TARGET_UNWIND_INFO
+#if defined (TARGET_UNWIND_INFO)  || defined (DWARF2_UNWIND_INFO)
                  || 1
 #endif
                 ))))

I suspect this should unbreak darwin.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #30 from howarth at nitro dot med dot uc dot edu  2009-10-04 16:38 -------
Created an attachment (id=18703)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18703&action=view)
Patch to revert to pre-r150553 behavior on darwin


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #31 from howarth at nitro dot med dot uc dot edu  2009-10-05 18:05 -------
(In reply to comment #12)
> It is unclear what those labels are good for, but if darwin is to support
> hot/cold partitioning and FDEs covering it, the emit unwind_label hook (which
> is apparently darwin specific only) should be passed also the SECOND variable
> and create different label name for the second FDE for the same function (if
> function starts in hot section, then the second one is covering the cold
> section, and vice versa).
> The patch in #c11 would just mean you'd keep older versions broken.
> 

Jakub,
   Do you mean that we need to pass 'second' from gcc/ira-int.h?

  /* Allocnos connected by the copy.  The first allocno should have
     smaller order number than the second one.  */
  ira_allocno_t first, second;

to darwin_emit_unwind_label()? Also, what would we use to detect whether the
first and second FDE's came from hot or cold sections?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[mrs at apple dot com]

------- Comment #32 from mrs at apple dot com  2009-10-05 20:55 -------
I suspect the other case is simply:

if (flag_exceptions)
  flag_reorder_blocks_and_partition = 0;

be added, just like the code for flag_unwind_tables.  I suspect this, as the
testcase is *.C.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[mrs at apple dot com]

------- Comment #33 from mrs at apple dot com  2009-10-05 21:16 -------
I'm fine with the latest patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #34 from howarth at nitro dot med dot uc dot edu  2009-10-05 23:25 -------
Actually, I just noticed that with the latest patch we still fail...

gcc.dg/tree-prof/pr34999.c

Executing on host:
/sw/src/fink.build/gcc45-4.4.999-20091003/darwin_objdir/gcc/xgcc
-B/sw/src/fink.build/gcc45-4.4.999-20091003/darwin_objdir/gcc/
/sw/src/fink.build/gcc45-4.4.999-20091003/gcc-4.5-20091003/gcc/testsuite/gcc.dg/tree-prof/pr34999.c
  -O2 -freorder-blocks-and-partition -fprofile-use -D_PROFILE_USE  -lm   -o
/sw/src/fink.build/gcc45-4.4.999-20091003/darwin_objdir/gcc/testsuite/gcc/pr34999.x02
   (timeout = 300)
/var/tmp//ccTlWKzV.s:219:FATAL:Symbol _main.eh already defined.
compiler exited with status 1
output is:
/var/tmp//ccTlWKzV.s:219:FATAL:Symbol _main.eh already defined.

FAIL: gcc.dg/tree-prof/pr34999.c compilation,  -fprofile-use -D_PROFILE_USE
UNRESOLVED: gcc.dg/tree-prof/pr34999.c execution,    -fprofile-use
-D_PROFILE_USE

I'll take a look at perhaps just setting...

flag_reorder_blocks_and_partition = 0;
flag_reorder_blocks = 1;

 in darwin.c's overrides when targeting <10.6 and adjusting
darwin_emit_unwind() to not emit labels when targeting >=10.6.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #35 from howarth at nitro dot med dot uc dot edu  2009-10-06 00:51 -------
Testing...

Index: gcc/config/darwin.c
===================================================================
--- gcc/config/darwin.c (revision 152480)
+++ gcc/config/darwin.c (working copy)
@@ -1454,7 +1454,7 @@
 {
   char *lab;

-  if (! for_eh)
+  if ((! for_eh) || (darwin_macosx_version_min &&
strverscmp(darwin_macosx_version_min, "10.6") >= 0))
     return;

   lab = concat (IDENTIFIER_POINTER (DECL_ASSEMBLER_NAME (decl)), ".eh", NULL);
@@ -1697,6 +1697,19 @@
   if (dwarf_strict < 0) 
     dwarf_strict = 1;

+  if (!(darwin_macosx_version_min && strverscmp(darwin_macosx_version_min,
"10.6") >= 0) && flag_reorder_blocks_and_partition)
+    {
+      if (flag_exceptions ||
+         (flag_unwind_tables && !targetm.unwind_tables_default) ||
+         (!targetm.have_named_sections || (flag_unwind_tables &&
targetm.unwind_tables_default)))
+           {
+             inform (input_location,
+                      "-freorder-blocks-and-partition does not work with
exceptions on this architecture");
+             flag_reorder_blocks_and_partition = 0;
+             flag_reorder_blocks = 1;
+           }
+    }
+
   if (flag_mkernel || flag_apple_kext)
     {
       /* -mkernel implies -fapple-kext for C++ */


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #36 from howarth at nitro dot med dot uc dot edu  2009-10-06 02:02 -------
This can be factored down to...

Index: gcc/config/darwin.c
===================================================================
--- gcc/config/darwin.c (revision 152481)
+++ gcc/config/darwin.c (working copy)
@@ -1454,7 +1454,7 @@
 {
   char *lab;

-  if (! for_eh)
+  if ((! for_eh) || (darwin_macosx_version_min &&
strverscmp(darwin_macosx_version_min, "10.6") >= 0))
     return;

   lab = concat (IDENTIFIER_POINTER (DECL_ASSEMBLER_NAME (decl)), ".eh", NULL);
@@ -1697,6 +1697,19 @@
   if (dwarf_strict < 0) 
     dwarf_strict = 1;

+  if ((darwin_macosx_version_min && strverscmp(darwin_macosx_version_min,
"10.6") >= 0) || flag_reorder_blocks_and_partition)
+    {
+      if (flag_exceptions ||
+         flag_unwind_tables ||
+         !targetm.have_named_sections)
+           {
+             inform (input_location,
+                      "-freorder-blocks-and-partition does not work with
exceptions on this architecture");
+             flag_reorder_blocks_and_partition = 0;
+             flag_reorder_blocks = 1;
+           }
+    }
+
   if (flag_mkernel || flag_apple_kext)
     {
       /* -mkernel implies -fapple-kext for C++ */


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #37 from howarth at nitro dot med dot uc dot edu  2009-10-06 02:05 -------
Opps. In both of the last patch...

+  if ((darwin_macosx_version_min && strverscmp(darwin_macosx_version_min,
"10.6") >= 0) || flag_reorder_blocks_and_partition)

should be

+  if (!(darwin_macosx_version_min && strverscmp(darwin_macosx_version_min,
"10.6") >= 0) && flag_reorder_blocks_and_partition)

of course.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #38 from howarth at nitro dot med dot uc dot edu  2009-10-06 02:18 -------
Created an attachment (id=18718)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18718&action=view)
patch to handle unwind label and -freorder-blocks-and-partition control in
darwin.c


-- 

howarth at nitro dot med dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18703|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #39 from howarth at nitro dot med dot uc dot edu  2009-10-06 02:19 -------
Mike,
    Does darwin have named sections? If so, we can drop the check on
!targetm.have_named_sections.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #41 from howarth at nitro dot med dot uc dot edu  2009-10-08 15:17 -------
Posted revised patch from Comment 40 to gcc-patches...

http://gcc.gnu.org/ml/gcc-patches/2009-10/msg00519.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #40 from howarth at nitro dot med dot uc dot edu  2009-10-08 15:16 -------
Created an attachment (id=18752)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18752&action=view)
Fix PR41313 with dual approach


-- 

howarth at nitro dot med dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18718|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #42 from howarth at nitro dot med dot uc dot edu  2009-10-11 01:11 -------
Created an attachment (id=18782)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18782&action=view)
Revised fix for PR41313 with dual approach


-- 

howarth at nitro dot med dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18752|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #43 from howarth at nitro dot med dot uc dot edu  2009-10-11 01:13 -------
Posted new revised patch to gcc-patches...

http://gcc.gnu.org/ml/gcc-patches/2009-10/msg00670.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[pogma at gcc dot gnu dot org]

------- Comment #44 from pogma at gcc dot gnu dot org  2009-10-21 15:08 -------
Subject: Bug 41313

Author: pogma
Date: Wed Oct 21 15:07:59 2009
New Revision: 153057

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=153057
Log:
2009-10-21  Jack Howarth  <howarth@bromo.med.uc.edu>

        PR c++/41313
        * gcc/config/darwin10.h: Use default_emit_unwind_label.
        * gcc/config/darwin.c: Disable -freorder-blocks-and-partition
        when darwin_emit_unwind_label is used.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/darwin.c
    trunk/gcc/config/darwin10.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313

[Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin*

[howarth at nitro dot med dot uc dot edu]

------- Comment #45 from howarth at nitro dot med dot uc dot edu  2009-10-22 12:57 -------
Fixed with r153057.


-- 

howarth at nitro dot med dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313