From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7944 invoked by alias); 2 Oct 2009 14:08:51 -0000 Received: (qmail 7886 invoked by uid 48); 2 Oct 2009 14:08:36 -0000 Date: Fri, 02 Oct 2009 14:08:00 -0000 Message-ID: <20091002140836.7885.qmail@sourceware.org> X-Bugzilla-Reason: CC References: Subject: [Bug c++/41313] r150553 causes g++.dg/tree-prof/partition1.C compilation and execution test failures on *-apple-darwin* In-Reply-To: Reply-To: gcc-bugzilla@gcc.gnu.org To: gcc-bugs@gcc.gnu.org From: "howarth at nitro dot med dot uc dot edu" Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2009-10/txt/msg00112.txt.bz2 ------- Comment #28 from howarth at nitro dot med dot uc dot edu 2009-10-02 14:08 ------- On reflection, I think the change Mike proposed for darwin.c in Comment 13 fails because it flag_reorder_blocks never gets set to 1 by that patch. I don't know how I could implement the three variations of setting that which occur in opts.c from within the overrides of darwin.c. Those cases in opts.c are listed as... /* The optimization to partition hot and cold basic blocks into separate sections of the .o and executable files does not work (currently) with exception handling. This is because there is no support for generating unwind info. If flag_exceptions is turned on we need to turn off the partitioning optimization. */ /* If user requested unwind info, then turn off the partitioning optimization. */ /* If the target requested unwind info, then turn off the partitioning optimization with a different message. Likewise, if the target does not support named sections. */ Would it be as simple as duplicating those three variations of the conditional within the overrides of darwin.c to duplicate their behavior? It seem much better to fix the breakage in opts.c caused by r150553. -- howarth at nitro dot med dot uc dot edu changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|g++.dg/tree- |r150553 causes g++.dg/tree- |prof/partition1.C |prof/partition1.C |compilation and execution |compilation and execution |test failures on *-apple- |test failures on *-apple- |darwin* |darwin* http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41313