[Bug fortran/41579] New: [OOP/Polymorphism] Nesting of SELECT TYPE

[Bug fortran/41579] New: [OOP/Polymorphism] Nesting of SELECT TYPE

[burnus at gcc dot gnu dot org]

See review comment http://gcc.gnu.org/ml/fortran/2009-09/msg00298.html

For two longer test cases, see 
http://gcc.gnu.org/ml/fortran/2009-09/msg00295.html


Currently, SELECT TYPE(type) uses:

+  /* Special case: If we're in a SELECT TYPE block,
+     replace the selector variable by a temporary.  */
+  if (gfc_current_state () == COMP_SELECT_TYPE
+      && st && st->n.sym == type_selector)
+    st = select_type_tmp;
+

That fails
(a) If the current state is not COMP_SELECT_TYPE
(b) If one nests SELECT TYPE

Example:

select type (mt2)
  type is(t2)
    mt2%i = 5
    select type(mt3)
      type is(t3)
        mt3%j = mt2%i
      class default
        stop 'error'
    end select
  class default
    stop 'error'
end select

        mt3%j = mt2%i
                     1
Error: 'i' at (1) is not a member of the 't1' structure


-- 
           Summary: [OOP/Polymorphism] Nesting of SELECT TYPE
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Keywords: rejects-valid
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41579

[Bug fortran/41579] [OOP/Polymorphism] Nesting of SELECT TYPE

[janus at gcc dot gnu dot org]

------- Comment #1 from janus at gcc dot gnu dot org  2009-10-08 20:27 -------
Mine (have a patch).


-- 

janus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |janus at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-10-08 20:27:58
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41579

[Bug fortran/41579] [OOP/Polymorphism] Nesting of SELECT TYPE

[janus at gcc dot gnu dot org]

------- Comment #2 from janus at gcc dot gnu dot org  2009-10-09 20:25 -------
Subject: Bug 41579

Author: janus
Date: Fri Oct  9 20:25:19 2009
New Revision: 152600

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=152600
Log:
2009-10-09  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/41579
        * gfortran.h (gfc_select_type_stack): New struct, to be used as a stack
        for SELECT TYPE statements.
        (select_type_stack): New global variable.
        (type_selector,select_type_tmp): Removed.
        * match.c (type_selector,type_selector): Removed.
        (select_type_stack): New variable, serving as a stack for
        SELECT TYPE statements.
        (select_type_push,select_type_set_tmp): New functions.
        (gfc_match_select_type): Call select_type_push.
        (gfc_match_type_is): Call select_type_set_tmp.
        * parse.c (select_type_pop): New function.
        (parse_select_type_block): Call select_type_pop.
        * symbol.c (select_type_insert_tmp): New function.
        (gfc_find_sym_tree): Call select_type_insert_tmp.


2009-10-09  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/41579
        * gfortran.dg/select_type_6.f03: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/select_type_6.f03
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/match.c
    trunk/gcc/fortran/parse.c
    trunk/gcc/fortran/symbol.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41579

[Bug fortran/41579] [OOP] Nesting of SELECT TYPE

[janus at gcc dot gnu dot org]

------- Comment #3 from janus at gcc dot gnu dot org  2009-10-09 20:31 -------
Fixed with r152600. Closing.


-- 

janus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Summary|[OOP/Polymorphism] Nesting  |[OOP] Nesting of SELECT TYPE
                   |of SELECT TYPE              |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41579