[Bug lto/41658] New: Execution testsuite fails with -O2 -fwhopr

[Bug lto/41658] New: Execution testsuite fails with -O2 -fwhopr

[danglin at gcc dot gnu dot org]

FAIL: gcc.c-torture/execute/builtins/sprintf-chk.c execution,  -O2 -fwhopr
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution,  -O2 -fwhopr
FAIL: gcc.c-torture/execute/builtins/strcpy-chk.c execution,  -O2 -fwhopr


-- 
           Summary: Execution testsuite fails with -O2 -fwhopr
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
 GCC build triplet: hppa-unknown-linux-gnu
  GCC host triplet: hppa-unknown-linux-gnu
GCC target triplet: hppa-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41658

[Bug lto/41658] Execution testsuite fails with -O2 -fwhopr

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2009-10-10 17:08 -------
Confirmed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-10-10 17:08:53
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41658

[Bug lto/41658] Execution testsuite fails with -O2 -fwhopr

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2009-12-11 14:25 -------
The issue with strcpy-chk.c is that with WHOPR we end up streaming

const char s1[] = "123";

as DECL_WEAK which causes string_constant () to not look at DECL_INITIAL
and thus the test fails.  Likely the other two are similar.

We do that here:

make_decl_one_only (decl=0xb77d0000, comdat_group=0xb77c8a64)
    at /home/richard/src/trunk/gcc/varasm.c:5765
5762    #ifdef MAKE_DECL_ONE_ONLY
5763          MAKE_DECL_ONE_ONLY (decl);
5764    #endif

which sets DECL_WEAK on elfos.  Called from

#0  make_decl_one_only (decl=0xb77d0000, comdat_group=0xb77c8a64)
    at /home/richard/src/trunk/gcc/varasm.c:5765
#1  0x083cbd8e in write_global_stream (ob=0x8dd8478, encoder=0x8d9a18c)
    at /home/richard/src/trunk/gcc/lto-streamer-out.c:2174

                  if (pointer_set_insert (decls_already_emitted, t))
                    make_decl_one_only (t, DECL_ASSEMBLER_NAME (t));

rather than making the decl one-only we should emit true external references
here (or for this particular case localize the variable if we know its
address is not refered to).  We could maybe also resort to TREE_ASM_WRITTEN
(that's the only thing that "fixes" this testcase).

This bug isn't particularly bad but the testsuite FAILs are annoying at least.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dnovillo at gcc dot gnu dot
                   |                            |org
  GCC build triplet|hppa-unknown-linux-gnu      |
   GCC host triplet|hppa-unknown-linux-gnu      |
 GCC target triplet|hppa-unknown-linux-gnu      |
           Keywords|                            |lto, missed-optimization


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41658

[Bug lto/41658] Execution testsuite fails with -O2 -fwhopr

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2009-12-11 14:33 -------
I'm going to test the TREE_ASM_WRITTEN variant.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2009-10-10 17:08:53         |2009-12-11 14:33:43
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41658

[Bug lto/41658] Execution testsuite fails with -O2 -fwhopr

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2009-12-11 18:00 -------
Subject: Bug 41658

Author: rguenth
Date: Fri Dec 11 18:00:24 2009
New Revision: 155174

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155174
Log:
2009-12-11  Richard Guenther  <rguenther@suse.de>

        PR lto/41658
        PR lto/41657
        * lto-streamer-out.c (write_global_stream): Do not make decls
        weak but resort to TREE_ASM_WRITTEN to avoid multiple definitions.
        Make sure to mark all decls that we have written.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/lto-streamer-out.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41658

[Bug lto/41658] Execution testsuite fails with -O2 -fwhopr

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2009-12-11 18:00 -------
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41658