From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20872 invoked by alias); 20 Oct 2009 20:54:53 -0000 Received: (qmail 20841 invoked by uid 48); 20 Oct 2009 20:54:43 -0000 Date: Tue, 20 Oct 2009 20:54:00 -0000 Message-ID: <20091020205443.20840.qmail@sourceware.org> X-Bugzilla-Reason: CC References: Subject: [Bug fortran/41478] Corrupted memory using PACK for derived-types with allocated components In-Reply-To: Reply-To: gcc-bugzilla@gcc.gnu.org To: gcc-bugs@gcc.gnu.org From: "janus at gcc dot gnu dot org" Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2009-10/txt/msg01767.txt.bz2 ------- Comment #12 from janus at gcc dot gnu dot org 2009-10-20 20:54 ------- Here is a simple patch which cures the segfault in comment #9. However it does not tackle the double-free issue. Index: libgfortran/intrinsics/pack_generic.c =================================================================== --- libgfortran/intrinsics/pack_generic.c (Revision 153009) +++ libgfortran/intrinsics/pack_generic.c (Arbeitskopie) @@ -350,7 +350,7 @@ pack (gfc_array_char *ret, const gfc_array_char *a case GFC_DTYPE_DERIVED_2: if (GFC_UNALIGNED_2(ret->data) || GFC_UNALIGNED_2(array->data) - || GFC_UNALIGNED_2(vector->data)) + || (vector && GFC_UNALIGNED_2(vector->data))) break; else { @@ -361,7 +361,7 @@ pack (gfc_array_char *ret, const gfc_array_char *a case GFC_DTYPE_DERIVED_4: if (GFC_UNALIGNED_4(ret->data) || GFC_UNALIGNED_4(array->data) - || GFC_UNALIGNED_4(vector->data)) + || (vector && GFC_UNALIGNED_4(vector->data))) break; else { @@ -372,7 +372,7 @@ pack (gfc_array_char *ret, const gfc_array_char *a case GFC_DTYPE_DERIVED_8: if (GFC_UNALIGNED_8(ret->data) || GFC_UNALIGNED_8(array->data) - || GFC_UNALIGNED_8(vector->data)) + || (vector && GFC_UNALIGNED_8(vector->data))) break; else { @@ -383,7 +383,7 @@ pack (gfc_array_char *ret, const gfc_array_char *a #ifdef HAVE_GFC_INTEGER_16 case GFC_DTYPE_DERIVED_16: if (GFC_UNALIGNED_16(ret->data) || GFC_UNALIGNED_16(array->data) - || GFC_UNALIGNED_16(vector->data)) + || (vector && GFC_UNALIGNED_16(vector->data))) break; else { -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41478