[Bug middle-end/41907] New: [4.5 Regression] 465.tonto in SPEC CPU 2006 runtime failure

[Bug middle-end/41907] New: [4.5 Regression] 465.tonto in SPEC CPU 2006 runtime failure

[hjl dot tools at gmail dot com]

On Linux/ia32 and Linux/intel64, 465.tonto in SPEC CPU 2006 failed
to run at -O3:

  Running 465.tonto ref base o3 default

65.tonto: copy #0 non-zero return code (rc=0, signal=11)

Revision 153787 is OK and revision 153795 is bad.


-- 
           Summary: [4.5 Regression] 465.tonto in SPEC CPU 2006 runtime
                    failure
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl dot tools at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41907

[Bug middle-end/41907] [4.5 Regression] 465.tonto in SPEC CPU 2006 runtime failure

[hjl dot tools at gmail dot com]

------- Comment #1 from hjl dot tools at gmail dot com  2009-11-02 15:49 -------
It may be caused by revision 153793:

http://gcc.gnu.org/ml/gcc-cvs/2009-11/msg00009.html

or revision 153795:

http://gcc.gnu.org/ml/gcc-cvs/2009-11/msg00011.html


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at net-b dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41907

[Bug middle-end/41907] [4.5 Regression] 465.tonto in SPEC CPU 2006 runtime failure

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41907

[Bug middle-end/41907] [4.5 Regression] 465.tonto in SPEC CPU 2006 runtime failure

[burnus at gcc dot gnu dot org]

------- Comment #2 from burnus at gcc dot gnu dot org  2009-11-02 17:30 -------
> It may be caused by revision 153793:
> http://gcc.gnu.org/ml/gcc-cvs/2009-11/msg00009.html

Could be. If so, it is likely that the program crashes in this case. Can you
print a backtrace? I can access Tonto at
http://sourceforge.net/projects/tonto-chem/ but I do not have SPEC CPU 2006.

> or revision 153795:
> http://gcc.gnu.org/ml/gcc-cvs/2009-11/msg00011.html
This is highly unlikely.


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41907

[Bug middle-end/41907] [4.5 Regression] 465.tonto in SPEC CPU 2006 runtime failure

[hjl dot tools at gmail dot com]

------- Comment #3 from hjl dot tools at gmail dot com  2009-11-02 17:44 -------
It is caused by revision 153793:

Program received signal SIGSEGV, Segmentation fault.
0x00000000006a05d1 in __shell2_module_MOD_make_kei ()
(gdb) bt
#0  0x00000000006a05d1 in __shell2_module_MOD_make_kei ()
#1  0x00000000006a1298 in __shell2_module_MOD_get_kei ()
#2  0x0000000000933404 in __mol_module_MOD_make_kinetic_matrix ()
#3  0x0000000000936219 in __mol_module_MOD_make_core_matrix ()
#4  0x000000000093670e in __mol_module_MOD_get_core_matrix ()
#5  0x00000000009369f3 in __mol_module_MOD_make_r_core_guess ()
#6  0x00000000009c52df in __mol_module_MOD_make_core_guess ()
#7  0x00000000009d6630 in __mol_module_MOD_get_initial_density ()
#8  0x00000000009d6a4e in __mol_module_MOD_usual_scf ()
#9  0x00000000009d7a93 in __mol_module_MOD_make_atom_density ()
#10 0x00000000009d8155 in __mol_module_MOD_get_atom_density ()
#11 0x00000000009d64fe in __mol_module_MOD_get_initial_density ()
#12 0x00000000009d6ff8 in __mol_module_MOD_constrained_scf ()
#13 0x00000000009d75cf in __mol_module_MOD_scf ()
#14 0x00000000009f1523 in __mol_main_module_MOD_process_keyword ()
#15 0x00000000009f17d8 in __mol_main_module_MOD_main ()
#16 0x00000000009f1b42 in main ()
(gdb) disass
...
0x00000000006a05ce <__shell2_module_MOD_make_kei+878>:  and    $0x7,%esi
0x00000000006a05d1 <__shell2_module_MOD_make_kei+881>:  movq   $0x0,(%rax)
(gdb) p/x $rax
$1 = 0x3
(gdb) 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41907

[Bug middle-end/41907] [4.5 Regression] 465.tonto in SPEC CPU 2006 runtime failure

[burnus at gcc dot gnu dot org]

------- Comment #4 from burnus at gcc dot gnu dot org  2009-11-02 18:02 -------
Test case:

program test
  implicit none
  call one()
contains
  subroutine one(a)
    real, dimension(:,:), intent(inout), optional :: a
    call two(a)
  end subroutine one
  subroutine two(a)
    real, dimension(:,:), intent(inout), optional :: a
    if (present(a)) A(1,1) = 7
  end subroutine two
end program test


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-11-02 18:02:02
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41907

[Bug middle-end/41907] [4.5 Regression] 465.tonto in SPEC CPU 2006 runtime failure

[burnus at gcc dot gnu dot org]

------- Comment #5 from burnus at gcc dot gnu dot org  2009-11-02 18:07 -------
The problem is that gfortran copies for some reason the array descriptor in
"one()" before calling "two()". The question is only why? One should be able to
simply pass the array on, shouldn't one? The dump shows:

    parm.12.data = (void *) &(*a.0)[0];
    two (&parm.12);

Thus the check whether the argument is there succeeds in "two". I will have a
look later how to solve it.

 * * *

Note: The problematic part of the patch is the second block in the diff at
http://gcc.gnu.org/ml/fortran/2009-10/msg00246.html (Thus 4.4 is not affected.)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41907

[Bug fortran/41907] [4.5 Regression] 465.tonto in SPEC CPU 2006 runtime failure

[burnus at gcc dot gnu dot org]

-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |burnus at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2009-11-02 18:02:02         |2009-11-02 19:29:43
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41907

[Bug fortran/41907] [4.5 Regression] 465.tonto in SPEC CPU 2006 runtime failure

[burnus at gcc dot gnu dot org]

------- Comment #6 from burnus at gcc dot gnu dot org  2009-11-03 16:52 -------
Subject: Bug 41907

Author: burnus
Date: Tue Nov  3 16:51:52 2009
New Revision: 153854

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=153854
Log:
2009-11-03  Tobias Burnus  <burnus@net-b.de>

        PR fortran/41907
        * trans-expr.c (gfc_conv_procedure_call): Fix presence check
        for optional arguments.

2009-11-03  Tobias Burnus  <burnus@net-b.de>

        PR fortran/41907
        * gfortran.dg/missing_optional_dummy_6.f90: New test.


Added:
    trunk/gcc/testsuite/gfortran.dg/missing_optional_dummy_6.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-expr.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41907

[Bug fortran/41907] [4.5 Regression] 465.tonto in SPEC CPU 2006 runtime failure

[burnus at gcc dot gnu dot org]

------- Comment #7 from burnus at gcc dot gnu dot org  2009-11-03 16:55 -------
FIXED. Thanks for the report!

 * * *

> The problem is that gfortran copies for some reason the array descriptor in
> "one()" before calling "two()". The question is only why?

I understand now the "why"; it is a missed optimization - tracked in PR 41911.


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41907

[Bug fortran/41907] [4.5 Regression] 465.tonto in SPEC CPU 2006 runtime failure

[jv244 at cam dot ac dot uk]

------- Comment #8 from jv244 at cam dot ac dot uk  2009-11-03 16:57 -------
thanks for fixing.. this also affected CP2K.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41907

[Bug fortran/41907] [4.5 Regression] 465.tonto in SPEC CPU 2006 runtime failure

[burnus at gcc dot gnu dot org]

------- Comment #9 from burnus at gcc dot gnu dot org  2009-11-06 11:19 -------
*** Bug 41948 has been marked as a duplicate of this bug. ***


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |reuter at physik dot uni-
                   |                            |freiburg dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41907

[Bug fortran/41907] [4.5 Regression] 465.tonto in SPEC CPU 2006 runtime failure

[hjl at gcc dot gnu dot org]

------- Comment #10 from hjl at gcc dot gnu dot org  2009-11-20 14:50 -------
Subject: Bug 41907

Author: hjl
Date: Fri Nov 20 14:49:22 2009
New Revision: 154366

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=154366
Log:
2009-11-20  H.J. Lu  <hongjiu.lu@intel.com>

        Backport from mainline:
        2009-11-18  Alexandre Oliva  <aoliva@redhat.com>

        PR debug/41926
        * gcc.dg/vect/vect-debug-pr41926.c: New.

        2009-11-16  Paolo Carlini  <paolo.carlini@oracle.com>

        PR c++/42055
        * g++.dg/template/crash92.C: New.

        2009-11-08  Richard Guenther  <rguenther@suse.de>

        PR rtl-optimization/41928
        * gfortran.dg/pr41928.f90: New testcase.

        2009-11-06  Jakub Jelinek  <jakub@redhat.com>

        PR middle-end/41935
        * gcc.dg/pr41935.c: New test.
        * c-c++-common/pr41935.c: New test.
        * gcc.c-torture/execute/pr41935.c: New test.

        2009-11-04  Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/41919
        * gcc.c-torture/execute/pr41919.c: New testcase.

        2009-11-03  Tobias Burnus  <burnus@net-b.de>

        PR fortran/41907
        * gfortran.dg/missing_optional_dummy_6.f90: New test.

        2009-11-02  Martin Jambor  <mjambor@suse.cz>

        PR tree-optimization/41750
        * gcc.c-torture/execute/pr41750.c: New test.

        2009-11-02  Jakub Jelinek  <jakub@redhat.com>

        PR tree-optimization/41841
        * gcc.dg/pr41841.c: New test.

Added:
    branches/gcc-4_4-branch/gcc/testsuite/c-c++-common/pr41935.c
      - copied unchanged from r154365,
trunk/gcc/testsuite/c-c++-common/pr41935.c
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/template/crash92.C
      - copied unchanged from r154365,
trunk/gcc/testsuite/g++.dg/template/crash92.C
    branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/execute/pr41750.c
      - copied unchanged from r154365,
trunk/gcc/testsuite/gcc.c-torture/execute/pr41750.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/execute/pr41919.c
      - copied unchanged from r154365,
trunk/gcc/testsuite/gcc.c-torture/execute/pr41919.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/execute/pr41935.c
      - copied unchanged from r154365,
trunk/gcc/testsuite/gcc.c-torture/execute/pr41935.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/pr41841.c
      - copied unchanged from r154365, trunk/gcc/testsuite/gcc.dg/pr41841.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/pr41935.c
      - copied unchanged from r154365, trunk/gcc/testsuite/gcc.dg/pr41935.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/vect/vect-debug-pr41926.c
      - copied unchanged from r154365,
trunk/gcc/testsuite/gcc.dg/vect/vect-debug-pr41926.c
   
branches/gcc-4_4-branch/gcc/testsuite/gfortran.dg/missing_optional_dummy_6.f90
      - copied unchanged from r154365,
trunk/gcc/testsuite/gfortran.dg/missing_optional_dummy_6.f90
    branches/gcc-4_4-branch/gcc/testsuite/gfortran.dg/pr41928.f90
      - copied unchanged from r154365,
trunk/gcc/testsuite/gfortran.dg/pr41928.f90
Modified:
    branches/gcc-4_4-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41907