public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/42041] New: Missing defs in omp_lib.h
@ 2009-11-14 7:00 longb at cray dot com
2009-11-14 10:59 ` [Bug fortran/42041] " jakub at gcc dot gnu dot org
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: longb at cray dot com @ 2009-11-14 7:00 UTC (permalink / raw)
To: gcc-bugs
This code shows that the definitions for omp_integer_kind and omp_logical_kind
are missing from the omp_lib.h include file. If the module is used instead,
there is no error.
! derived from OpenMP test omp3f/F03_3_2_11_1a.f90
program F03_3_2_11_1a
! use omp_lib
implicit none
include 'omp_lib.h'
! check that some kind variables are around
print *, 'omp_integer_kind = ', omp_integer_kind
print *, 'omp_logical_kind = ', omp_logical_kind
print *, 'omp_sched_kind = ', omp_sched_kind
end program F03_3_2_11_1a
> ftn -fopenmp test.f90
test.f90:8.53:
print *, 'omp_integer_kind = ', omp_integer_kind
1
Error: Symbol 'omp_integer_kind' at (1) has no IMPLICIT type
test.f90:9.53:
print *, 'omp_logical_kind = ', omp_logical_kind
1
Error: Symbol 'omp_logical_kind' at (1) has no IMPLICIT type
>
Note from the OpenMP tester:
Output for the modified program using the module omp_lib:
> ./x
omp_integer_kind = 4
omp_logical_kind = 4
omp_sched_kind = 4
NOTE:
Section D.2 is missing the following statements found in
Section D.3 p.306 lines 7 & 8:
integer, parameter :: omp_integer_kind = 4
integer, parameter :: omp_logical_kind = 4
--
Summary: Missing defs in omp_lib.h
Product: gcc
Version: 4.4.2
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: longb at cray dot com
GCC build triplet: x86_64-suse-linux
GCC host triplet: x86_64-suse-linux
GCC target triplet: x86_64-suse-linux
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42041
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/42041] Missing defs in omp_lib.h
2009-11-14 7:00 [Bug fortran/42041] New: Missing defs in omp_lib.h longb at cray dot com
@ 2009-11-14 10:59 ` jakub at gcc dot gnu dot org
2009-11-16 16:59 ` longb at cray dot com
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu dot org @ 2009-11-14 10:59 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from jakub at gcc dot gnu dot org 2009-11-14 10:59 -------
When only D.3 lists them and D.2 doesn't is IMHO a clear sign that they belong
into omp_lib.f90 only and not into omp_lib.h.
These two parameters are never mentioned in the standard except for D.3/D.4
AFAIK, and D.3 just covers omp_lib module and D.4 only talks about that module
too.
--
jakub at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution| |INVALID
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42041
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/42041] Missing defs in omp_lib.h
2009-11-14 7:00 [Bug fortran/42041] New: Missing defs in omp_lib.h longb at cray dot com
2009-11-14 10:59 ` [Bug fortran/42041] " jakub at gcc dot gnu dot org
@ 2009-11-16 16:59 ` longb at cray dot com
2009-11-17 7:56 ` burnus at gcc dot gnu dot org
2010-06-10 20:36 ` fxcoudert at gcc dot gnu dot org
3 siblings, 0 replies; 9+ messages in thread
From: longb at cray dot com @ 2009-11-16 16:59 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from longb at cray dot com 2009-11-16 16:58 -------
I posed this question to the Cray OpenMP committee member:
Jim @ ISU submitted a bug against gfortran noting that some parameters
defined in the omp_lib Fortran module are missing from the corresponding
omp_lib.h include file. The GNU guys are claiming that the difference
is intentional, and are right that in the 3.0 standard the 'missing'
declarations are only in the Example module in D3, and not in the
Example include file in D2. They are not mentioned in the normative
text in Chapter 3. Is this difference intentional? Or is it an
oversight in the standard? Could you add a Comment to Bug 753421?
Thanks.
And got this reply:
The differences between the omp_lib.h and omp_lib module are actually a bug in
the specification. I have an open issue in my name with the OpenMP Language
committee to submit a proposed fix for this. The solution will be to make the
types default to the size of a default integer. This change will be in the 3.1
specification due for release by SC10.
------
>From which I would conclude that this bug will come back again when the OpenMP
spec is corrected. Might be easier to just fix it now.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42041
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/42041] Missing defs in omp_lib.h
2009-11-14 7:00 [Bug fortran/42041] New: Missing defs in omp_lib.h longb at cray dot com
2009-11-14 10:59 ` [Bug fortran/42041] " jakub at gcc dot gnu dot org
2009-11-16 16:59 ` longb at cray dot com
@ 2009-11-17 7:56 ` burnus at gcc dot gnu dot org
2010-06-10 20:36 ` fxcoudert at gcc dot gnu dot org
3 siblings, 0 replies; 9+ messages in thread
From: burnus at gcc dot gnu dot org @ 2009-11-17 7:56 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from burnus at gcc dot gnu dot org 2009-11-17 07:56 -------
Reopened based on comment 2 to make sure this is/remains on the radar
--
burnus at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |UNCONFIRMED
Resolution|INVALID |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42041
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/42041] Missing defs in omp_lib.h
2009-11-14 7:00 [Bug fortran/42041] New: Missing defs in omp_lib.h longb at cray dot com
` (2 preceding siblings ...)
2009-11-17 7:56 ` burnus at gcc dot gnu dot org
@ 2010-06-10 20:36 ` fxcoudert at gcc dot gnu dot org
3 siblings, 0 replies; 9+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2010-06-10 20:36 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from fxcoudert at gcc dot gnu dot org 2010-06-10 20:36 -------
Patch proposed at: http://gcc.gnu.org/ml/gcc-patches/2010-06/msg01143.html
--
fxcoudert at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |fxcoudert at gcc dot gnu dot
|dot org |org
URL| |http://gcc.gnu.org/ml/gcc-
| |patches/2010-
| |06/msg01143.html
Status|UNCONFIRMED |ASSIGNED
Ever Confirmed|0 |1
Keywords| |patch
Last reconfirmed|0000-00-00 00:00:00 |2010-06-10 20:36:38
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42041
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/42041] Missing defs in omp_lib.h
[not found] <bug-42041-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2011-08-02 16:16 ` jakub at gcc dot gnu.org
@ 2011-08-02 17:16 ` jakub at gcc dot gnu.org
3 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-08-02 17:16 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42041
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-08-02 17:15:28 UTC ---
In 4.7+.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/42041] Missing defs in omp_lib.h
[not found] <bug-42041-4@http.gcc.gnu.org/bugzilla/>
2011-02-24 14:18 ` jakub at gcc dot gnu.org
2011-02-24 17:11 ` jakub at gcc dot gnu.org
@ 2011-08-02 16:16 ` jakub at gcc dot gnu.org
2011-08-02 17:16 ` jakub at gcc dot gnu.org
3 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-08-02 16:16 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42041
--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-08-02 16:13:35 UTC ---
Author: jakub
Date: Tue Aug 2 16:13:29 2011
New Revision: 177194
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=177194
Log:
Merge from gomp-3_1-branch branch:
2011-08-02 Jakub Jelinek <jakub@redhat.com>
gcc/
* c-parser.c (enum c_parser_prec): New enum, moved from within
c_parser_binary_expression.
(c_parser_binary_expression): Add PREC argument. Stop parsing
if operator has lower or equal precedence than PREC.
(c_parser_conditional_expression, c_parser_omp_for_loop): Adjust
callers.
(c_parser_omp_atomic): Handle parsing OpenMP 3.1 atomics.
Adjust c_finish_omp_atomic caller.
(c_parser_omp_taskyield): New function.
(c_parser_pragma): Handle PRAGMA_OMP_TASKYIELD.
(c_parser_omp_clause_name): Handle final and mergeable clauses.
(c_parser_omp_clause_final, c_parser_omp_clause_mergeable): New
functions.
(c_parser_omp_all_clauses): Handle PRAGMA_OMP_CLAUSE_FINAL
and PRAGMA_OMP_CLAUSE_MERGEABLE.
(OMP_TASK_CLAUSE_MASK): Allow final and mergeable clauses.
(c_parser_omp_clause_reduction): Handle min and max.
* c-typeck.c (c_finish_omp_clauses): Don't complain about
const qualified predetermined vars in firstprivate clause.
andle OMP_CLAUSE_FINAL and OMP_CLAUSE_MERGEABLE.
Handle MIN_EXPR and MAX_EXPR.
* tree-pretty-print.c (dump_omp_clause): Handle OMP_CLAUSE_FINAL
and OMP_CLAUSE_MERGEABLE.
(dump_generic_node): Handle OMP_ATOMIC_READ, OMP_ATOMIC_CAPTURE_OLD
and OMP_ATOMIC_CAPTURE_NEW.
* tree.c (omp_clause_num_ops): Add OMP_CLAUSE_FINAL and
OMP_CLAUSE_MERGEABLE.
(omp_clause_code_name): Likewise.
(walk_tree_1): Handle OMP_CLAUSE_FINAL and OMP_CLAUSE_MERGEABLE.
* tree.h (enum omp_clause_code): Add OMP_CLAUSE_FINAL
and OMP_CLAUSE_MERGEABLE.
(OMP_CLAUSE_FINAL_EXPR): Define.
* omp-low.c (scan_sharing_clauses): Handle OMP_CLAUSE_FINAL and
OMP_CLAUSE_MERGEABLE.
(expand_task_call): Likewise.
(expand_omp_atomic_load, expand_omp_atomic_store): New functions.
(expand_omp_atomic_fetch_op): Handle cases where old or new
value is needed afterwards.
(expand_omp_atomic): Call expand_omp_atomic_load resp.
expand_omp_atomic_store.
* gimplify.c (gimplify_omp_atomic, gimplify_expr): Handle
OMP_ATOMIC_READ, OMP_ATOMIC_CAPTURE_OLD and OMP_ATOMIC_CAPTURE_NEW.
(gimplify_scan_omp_clauses, gimplify_adjust_omp_clauses): Handle
OMP_CLAUSE_FINAL and OMP_CLAUSE_MERGEABLE.
* tree-nested.c (convert_nonlocal_omp_clauses,
convert_local_omp_clauses): Likewise.
* tree.def (OMP_ATOMIC_READ, OMP_ATOMIC_CAPTURE_OLD,
OMP_ATOMIC_CAPTURE_NEW): New.
* gimple.h (GF_OMP_ATOMIC_NEED_VALUE): New.
(gimple_omp_atomic_need_value_p, gimple_omp_atomic_set_need_value):
New inlines.
* omp-builtins.def (BUILT_IN_GOMP_TASKYIELD): New builtin.
* doc/generic.texi: Mention OMP_CLAUSE_COLLAPSE,
OMP_CLAUSE_UNTIED, OMP_CLAUSE_FINAL and OMP_CLAUSE_MERGEABLE.
gcc/c-family/
* c-common.h (c_finish_omp_atomic): Adjust prototype.
(c_finish_omp_taskyield): New prototype.
* c-omp.c (c_finish_omp_atomic): Add OPCODE, V, LHS1 and RHS1
arguments. Handle OMP_ATOMIC_READ, OMP_ATOMIC_CAPTURE_OLD and
OMP_ATOMIC_CAPTURE_NEW in addition to OMP_ATOMIC. If LHS1
or RHS1 have side-effects, evaluate those too in the right spot,
if it is a decl and LHS is also a decl, error out if they
aren't the same.
(c_finish_omp_taskyield): New function.
* c-cppbuiltin.c (c_cpp_builtins): Change _OPENMP to 201107.
* c-pragma.c (omp_pragmas): Add taskyield.
* c-pragma.h (enum pragma_kind): Add PRAGMA_OMP_TASKYIELD.
(enum pragma_omp_clause): Add PRAGMA_OMP_CLAUSE_FINAL and
PRAGMA_OMP_CLAUSE_MERGEABLE.
gcc/cp/
* cp-tree.h (finish_omp_atomic): Adjust prototype.
(cxx_omp_const_qual_no_mutable): New prototype.
(finish_omp_taskyield): New prototype.
* parser.c (cp_parser_omp_atomic): (cp_parser_omp_atomic): Handle
parsing OpenMP 3.1 atomics. Adjust finish_omp_atomic caller.
(cp_parser_omp_clause_name): Handle final and mergeable clauses.
(cp_parser_omp_clause_final, cp_parser_omp_clause_mergeable): New
functions.
(cp_parser_omp_all_clauses): Handle PRAGMA_OMP_CLAUSE_FINAL
and PRAGMA_OMP_CLAUSE_MERGEABLE.
(OMP_TASK_CLAUSE_MASK): Allow final and mergeable clauses.
(cp_parser_omp_taskyield): New function.
(cp_parser_pragma): Handle PRAGMA_OMP_TASKYIELD.
(cp_parser_omp_clause_reduction): Handle min and max.
* pt.c (tsubst_expr) <case OMP_ATOMIC>: Handle OpenMP 3.1 atomics.
(tsubst_omp_clauses): Handle OMP_CLAUSE_FINAL and
OMP_CLAUSE_MERGEABLE.
* semantics.c (finish_omp_atomic): Add OPCODE, V, LHS1 and RHS1
arguments. Handle OpenMP 3.1 atomics. Adjust c_finish_omp_atomic
caller.
(finish_omp_clauses): Don't complain about const qualified
predetermined vars and static data members in firstprivate clause.
Handle OMP_CLAUSE_FINAL and OMP_CLAUSE_MERGEABLE. Handle MIN_EXPR
and MAX_EXPR.
(finish_omp_taskyield): New function.
* cp-gimplify.c (cxx_omp_const_qual_no_mutable): New function.
(cxx_omp_predetermined_sharing): Use it.
gcc/fortran/
PR fortran/46752
* cpp.c (cpp_define_builtins): Change _OPENMP to 201107.
* openmp.c (gfc_free_omp_clauses): Free also final_expr.
(OMP_CLAUSE_FINAL, OMP_CLAUSE_MERGEABLE): Define.
(gfc_match_omp_clauses): Handle parsing final and mergeable
clauses.
(OMP_TASK_CLAUSES): Allow final and mergeable clauses.
(gfc_match_omp_taskyield): New function.
(resolve_omp_clauses): Resolve final clause. Allow POINTERs and
Cray pointers in clauses other than REDUCTION.
(gfc_match_omp_atomic): Match optional
read/write/update/capture keywords after !$omp atomic.
(resolve_omp_atomic): Handle all OpenMP 3.1 atomic forms.
* dump-parse-tree.c (show_omp_node): Handle EXEC_OMP_TASKYIELD,
print final and mergeable clauses.
(show_code_node): Handle EXEC_OMP_TASKYIELD.
* trans-openmp.c (gfc_trans_omp_clauses): Handle final and
mergeable clauses.
(gfc_trans_omp_taskyield): New function.
(gfc_trans_omp_directive): Handle EXEC_OMP_TASKYIELD.
(gfc_trans_omp_atomic): Handle all OpenMP 3.1 atomic forms.
(gfc_omp_clause_copy_ctor): Handle non-allocated allocatable.
(gfc_omp_predetermined_sharing): Adjust comment.
* gfortran.h (gfc_statement): Add ST_OMP_TASKYIELD and
ST_OMP_END_ATOMIC.
(gfc_omp_clauses): Add final_expr and mergeable fields.
(gfc_exec_op): Add EXEC_OMP_TASKYIELD.
(gfc_omp_atomic_op): New enum typedef.
(struct gfc_code): Add ext.omp_atomic.
* trans.c (trans_code): Handle EXEC_OMP_TASKYIELD.
* frontend-passes.c (gfc_code_walker): Also walk final_expr.
* resolve.c (gfc_resolve_blocks, resolve_code): Handle
EXEC_OMP_TASKYIELD.
* st.c (gfc_free_statement): Likewise.
* match.h (gfc_match_omp_taskyield): New prototype.
* parse.c (decode_omp_directive): Handle taskyield directive.
Handle !$omp end atomic.
(case_executable): Add ST_OMP_TASKYIELD case.
(gfc_ascii_statement): Handle ST_OMP_TASKYIELD.
(parse_omp_atomic): Return gfc_statement instead of void.
For !$omp atomic capture parse two assignments instead of
just one and require !$omp end atomic afterwards, for
other !$omp atomic forms just allow !$omp end atomic at the
end.
(parse_omp_structured_block, parse_executable): Adjust
parse_omp_atomic callers.
2011-08-02 Tobias Burnus <burnus@net-b.de>
* intrinsic.c (OMP_LIB): Updated openmp_version's
value to 201107.
* gfortran.texi (OpenMP): Update ref to OpenMP 3.1.
* intrinsic.texi (OpenMP Modules): Update ref to OpenMP 3.1;
remove deleted omp_integer_kind and omp_logical_kind constants.
gcc/testsuite/
PR fortran/46752
* gcc.dg/gomp/atomic-5.c: Adjust expected diagnostics.
* gcc.dg/gomp/atomic-15.c: New test.
* g++.dg/gomp/atomic-5.C: Adjust expected diagnostics.
* g++.dg/gomp/atomic-15.C: New test.
* g++.dg/gomp/private-1.C: New test.
* g++.dg/gomp/sharing-2.C: New test.
* gfortran.dg/gomp/crayptr1.f90: Don't expect error
about Cray pointer in FIRSTPRIVATE/LASTPRIVATE.
* gfortran.dg/gomp/omp_atomic2.f90: New test.
libgomp/
PR fortran/42041
PR fortran/46752
* omp.h.in (omp_in_final): New prototype.
* omp_lib.f90.in (omp_in_final): New interface.
(omp_integer_kind, omp_logical_kind): Remove
and replace all its uses in the module with 4.
(openmp_version): Change to 201107.
* omp_lib.h.in (omp_sched_static, omp_sched_dynamic,
omp_sched_guided, omp_sched_auto): Use omp_sched_kind
kind for the parameters.
(omp_in_final): New external.
(openmp_version): Change to 201107.
* task.c (omp_in_final): New function.
(gomp_init_task): Initialize final_task.
(GOMP_task): Remove unused attribute from flags. Handle final
tasks.
(GOMP_taskyield): New function.
(omp_in_final): Return true if if (false) or final (true) task
or descendant of final (true).
* fortran.c (omp_in_final_): New function.
* libgomp.map (OMP_3.1): Export omp_in_final and omp_in_final_.
(GOMP_3.0): Export GOMP_taskyield.
* env.c (gomp_nthreads_var_list, gomp_nthreads_var_list_len): New
variables.
(parse_unsigned_long_list): New function.
(initialize_env): Use it for OMP_NUM_THREADS. Call parse_boolean
with "OMP_PROC_BIND". If OMP_PROC_BIND=true, call gomp_init_affinity
even if parse_affinity returned false.
* config/linux/affinity.c (gomp_init_affinity): Handle
gomp_cpu_affinity_len == 0.
* libgomp_g.h (GOMP_taskyield): New prototype.
* libgomp.h (struct gomp_task): Add final_task field.
(gomp_nthreads_var_list, gomp_nthreads_var_list_len): New externs.
* team.c (gomp_team_start): Override new task's nthreads_var icv
if list form OMP_NUM_THREADS has been used and it has value for
the new nesting level.
* testsuite/libgomp.c/atomic-11.c: New test.
* testsuite/libgomp.c/atomic-12.c: New test.
* testsuite/libgomp.c/atomic-13.c: New test.
* testsuite/libgomp.c/atomic-14.c: New test.
* testsuite/libgomp.c/reduction-6.c: New test.
* testsuite/libgomp.c/task-5.c: New test.
* testsuite/libgomp.c++/atomic-2.C: New test.
* testsuite/libgomp.c++/atomic-3.C: New test.
* testsuite/libgomp.c++/atomic-4.C: New test.
* testsuite/libgomp.c++/atomic-5.C: New test.
* testsuite/libgomp.c++/atomic-6.C: New test.
* testsuite/libgomp.c++/atomic-7.C: New test.
* testsuite/libgomp.c++/atomic-8.C: New test.
* testsuite/libgomp.c++/atomic-9.C: New test.
* testsuite/libgomp.c++/task-8.C: New test.
* testsuite/libgomp.c++/reduction-4.C: New test.
* testsuite/libgomp.fortran/allocatable7.f90: New test.
* testsuite/libgomp.fortran/allocatable8.f90: New test.
* testsuite/libgomp.fortran/crayptr3.f90: New test.
* testsuite/libgomp.fortran/omp_atomic3.f90: New test.
* testsuite/libgomp.fortran/omp_atomic4.f90: New test.
* testsuite/libgomp.fortran/pointer1.f90: New test.
* testsuite/libgomp.fortran/pointer2.f90: New test.
* testsuite/libgomp.fortran/task4.f90: New test.
2011-08-02 Tobias Burnus <burnus@net-b.de>
* libgomp.texi: Update OpenMP spec references to 3.1.
(omp_in_final,OMP_PROC_BIND): New sections.
(OMP_NUM_THREADS): Document that the value can be now a list.
(GOMP_STACKSIZE,GOMP_CPU_AFFINITY): Update @ref.
Added:
trunk/gcc/testsuite/g++.dg/gomp/atomic-15.C
trunk/gcc/testsuite/g++.dg/gomp/private-1.C
trunk/gcc/testsuite/g++.dg/gomp/sharing-2.C
trunk/gcc/testsuite/gcc.dg/gomp/atomic-15.c
trunk/gcc/testsuite/gfortran.dg/gomp/omp_atomic2.f90
trunk/libgomp/testsuite/libgomp.c++/atomic-2.C
trunk/libgomp/testsuite/libgomp.c++/atomic-3.C
trunk/libgomp/testsuite/libgomp.c++/atomic-4.C
trunk/libgomp/testsuite/libgomp.c++/atomic-5.C
trunk/libgomp/testsuite/libgomp.c++/atomic-6.C
trunk/libgomp/testsuite/libgomp.c++/atomic-7.C
trunk/libgomp/testsuite/libgomp.c++/atomic-8.C
trunk/libgomp/testsuite/libgomp.c++/atomic-9.C
trunk/libgomp/testsuite/libgomp.c++/reduction-4.C
trunk/libgomp/testsuite/libgomp.c++/task-8.C
trunk/libgomp/testsuite/libgomp.c/atomic-11.c
trunk/libgomp/testsuite/libgomp.c/atomic-12.c
trunk/libgomp/testsuite/libgomp.c/atomic-13.c
trunk/libgomp/testsuite/libgomp.c/atomic-14.c
trunk/libgomp/testsuite/libgomp.c/reduction-6.c
trunk/libgomp/testsuite/libgomp.c/task-5.c
trunk/libgomp/testsuite/libgomp.fortran/allocatable7.f90
trunk/libgomp/testsuite/libgomp.fortran/allocatable8.f90
trunk/libgomp/testsuite/libgomp.fortran/crayptr3.f90
trunk/libgomp/testsuite/libgomp.fortran/omp_atomic3.f90
trunk/libgomp/testsuite/libgomp.fortran/omp_atomic4.f90
trunk/libgomp/testsuite/libgomp.fortran/pointer1.f90
trunk/libgomp/testsuite/libgomp.fortran/pointer2.f90
trunk/libgomp/testsuite/libgomp.fortran/task4.f90
Modified:
trunk/gcc/ChangeLog
trunk/gcc/c-family/ChangeLog
trunk/gcc/c-family/c-common.h
trunk/gcc/c-family/c-cppbuiltin.c
trunk/gcc/c-family/c-omp.c
trunk/gcc/c-family/c-pragma.c
trunk/gcc/c-family/c-pragma.h
trunk/gcc/c-parser.c
trunk/gcc/c-typeck.c
trunk/gcc/cp/ChangeLog
trunk/gcc/cp/cp-gimplify.c
trunk/gcc/cp/cp-tree.h
trunk/gcc/cp/parser.c
trunk/gcc/cp/pt.c
trunk/gcc/cp/semantics.c
trunk/gcc/doc/generic.texi
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/cpp.c
trunk/gcc/fortran/dump-parse-tree.c
trunk/gcc/fortran/frontend-passes.c
trunk/gcc/fortran/gfortran.h
trunk/gcc/fortran/gfortran.texi
trunk/gcc/fortran/intrinsic.texi
trunk/gcc/fortran/match.h
trunk/gcc/fortran/openmp.c
trunk/gcc/fortran/parse.c
trunk/gcc/fortran/resolve.c
trunk/gcc/fortran/st.c
trunk/gcc/fortran/trans-openmp.c
trunk/gcc/fortran/trans.c
trunk/gcc/gimple.h
trunk/gcc/gimplify.c
trunk/gcc/omp-builtins.def
trunk/gcc/omp-low.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/g++.dg/gomp/atomic-5.C
trunk/gcc/testsuite/g++.dg/gomp/clause-3.C
trunk/gcc/testsuite/gcc.dg/gomp/atomic-5.c
trunk/gcc/testsuite/gcc.dg/gomp/clause-1.c
trunk/gcc/testsuite/gfortran.dg/gomp/crayptr1.f90
trunk/gcc/tree-nested.c
trunk/gcc/tree-pretty-print.c
trunk/gcc/tree.c
trunk/gcc/tree.def
trunk/gcc/tree.h
trunk/libgomp/ChangeLog
trunk/libgomp/config/linux/affinity.c
trunk/libgomp/env.c
trunk/libgomp/fortran.c
trunk/libgomp/libgomp.h
trunk/libgomp/libgomp.map
trunk/libgomp/libgomp.texi
trunk/libgomp/libgomp_g.h
trunk/libgomp/omp.h.in
trunk/libgomp/omp_lib.f90.in
trunk/libgomp/omp_lib.h.in
trunk/libgomp/task.c
trunk/libgomp/team.c
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/42041] Missing defs in omp_lib.h
[not found] <bug-42041-4@http.gcc.gnu.org/bugzilla/>
2011-02-24 14:18 ` jakub at gcc dot gnu.org
@ 2011-02-24 17:11 ` jakub at gcc dot gnu.org
2011-08-02 16:16 ` jakub at gcc dot gnu.org
2011-08-02 17:16 ` jakub at gcc dot gnu.org
3 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-02-24 17:11 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42041
--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-24 16:22:28 UTC ---
Author: jakub
Date: Thu Feb 24 16:22:24 2011
New Revision: 170475
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170475
Log:
* omp.h.in (omp_in_final): New prototype.
* omp_lib.f90.in (omp_in_final): New interface.
* omp_lib.h.in (omp_sched_static, omp_sched_dynamic,
omp_sched_guided, omp_sched_auto): Use omp_sched_kind
kind for the parameters.
(omp_in_final): New external.
* task.c (omp_in_final): New function.
* fortran.c (omp_in_final_): Likewise.
* libgomp.map (OMP_3.1): Export omp_in_final and omp_in_final_.
PR fortran/42041
* omp_lib.f90.in (omp_integer_kind, omp_logical_kind): Remove
and replace all its uses in the module with 4.
Modified:
branches/gomp-3_1-branch/libgomp/ChangeLog
branches/gomp-3_1-branch/libgomp/fortran.c
branches/gomp-3_1-branch/libgomp/libgomp.map
branches/gomp-3_1-branch/libgomp/omp.h.in
branches/gomp-3_1-branch/libgomp/omp_lib.f90.in
branches/gomp-3_1-branch/libgomp/omp_lib.h.in
branches/gomp-3_1-branch/libgomp/task.c
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/42041] Missing defs in omp_lib.h
[not found] <bug-42041-4@http.gcc.gnu.org/bugzilla/>
@ 2011-02-24 14:18 ` jakub at gcc dot gnu.org
2011-02-24 17:11 ` jakub at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-02-24 14:18 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42041
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-24 14:15:52 UTC ---
Ugh, the OpenMP 3.1 draft change is exactly the opposite of FX's patch.
If all those functions are supposed to return default integer instead of
integer of some implementation chosen kind, I wonder how it can be portably
implemented, unless the FE would be playing some ugly tricks and sign extending
from kind 4 to kind 8 integer if requested.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-08-02 17:16 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-14 7:00 [Bug fortran/42041] New: Missing defs in omp_lib.h longb at cray dot com
2009-11-14 10:59 ` [Bug fortran/42041] " jakub at gcc dot gnu dot org
2009-11-16 16:59 ` longb at cray dot com
2009-11-17 7:56 ` burnus at gcc dot gnu dot org
2010-06-10 20:36 ` fxcoudert at gcc dot gnu dot org
[not found] <bug-42041-4@http.gcc.gnu.org/bugzilla/>
2011-02-24 14:18 ` jakub at gcc dot gnu.org
2011-02-24 17:11 ` jakub at gcc dot gnu.org
2011-08-02 16:16 ` jakub at gcc dot gnu.org
2011-08-02 17:16 ` jakub at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).