[Bug debug/42244] New: var-tracking ICE for 300.twolf

[Bug debug/42244] New: var-tracking ICE for 300.twolf

[janis at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]

GCC trunk gets an internal compiler error when building SPEC CPU2000 test
300.twolf with "-O2 -g -ffloat-store -fmodulo-sched" on powerpc-linux, as
demonstrated by this minimized testcase:

  extern int numerator, denom;

  double
  compute_and_combination (double states)
  {
    for (; numerator > denom; numerator--)
      states *= (double) numerator;
    return states;
   }

  elm3b149% /home/janis/tools/gcc-trunk-anonsvn/bin/gcc -O2 -g -ffloat-store
-fmodulo-sched -c bug.c
  bug.c: In function ‘compute_and_combination’:
  bug.c:9:1: internal compiler error: in create_ddg_dep_no_link, at ddg.c:215
  Please submit a full bug report,
  with preprocessed source if appropriate.
  See <http://gcc.gnu.org/bugs.html> for instructions.

The failure started when var-tracking-assignments was enabled by default if
var-tracking was enabled; the test case passes with the additional option
-fno-var-tracking.


-- 
           Summary: var-tracking ICE for 300.twolf
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: debug
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: janis at gcc dot gnu dot org
GCC target triplet: powerpc-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42244

[Bug debug/42244] [4.5 Regression] var-tracking ICE for 300.twolf

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|var-tracking ICE for        |[4.5 Regression] var-
                   |300.twolf                   |tracking ICE for 300.twolf
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42244

[Bug debug/42244] [4.5 Regression] var-tracking ICE for 300.twolf

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42244

[Bug debug/42244] [4.5 Regression] var-tracking ICE for 300.twolf

[jakub at gcc dot gnu dot org]

------- Comment #1 from jakub at gcc dot gnu dot org  2009-12-03 15:00 -------
Created an attachment (id=19216)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19216&action=view)
gcc45-pr42444.patch

Patch that fixes the ICE (and that testcase works even with -fcompare-debug).
It shouldn't regress anything, as the only cases it changes is where there
would be assertion failures previously.

I'm not 100% sure it is the right thing to do though, and perhaps it would be
better to just drop the asserts and instead silently override d_t to ANTI_DEP
if from->insn or to->insn is DEBUG_INSN.  Then one wouldn't need to adjust all
the callers...  Alex?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42244

[Bug debug/42244] [4.5 Regression] var-tracking ICE for 300.twolf

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2009-12-03 15:03 -------
Isn't adding any dependency based on DEBUG_INSNs going to cause problems with
same code -g vs. -g0?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42244

[Bug debug/42244] [4.5 Regression] var-tracking ICE for 300.twolf

[aoliva at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 904 bytes --]



------- Comment #3 from aoliva at gcc dot gnu dot org  2009-12-03 15:34 -------
@richi it would, if we didn't have code to deal with that in sched-deps.  now,
depl_on_debug_p() are accepted, ignored for purposes of scheduling decisions,
and used only to reset debug stmts that were rendered invalid when insns that
anti-dependent on them were scheduled ahead of them

@jakub thanks, the patch is good.  making the change at the assert rather than
at the caller would work, but then it wouldn't help catch situations that don't
deal with debug insns but that might have to.  explicitly dealing with them is
kind of a way of saying “yeah, I thought this through”, even if that's all it
takes.  Now, this used to be far more important, before we dealt with
dep-on-debug the way we do now.  Maybe we could make this simplification in 4.6
or so?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42244

[Bug debug/42244] [4.5 Regression] var-tracking ICE for 300.twolf

[jakub at gcc dot gnu dot org]

------- Comment #4 from jakub at gcc dot gnu dot org  2009-12-07 17:16 -------
http://gcc.gnu.org/ml/gcc-patches/2009-12/msg00222.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42244

[Bug debug/42244] [4.5 Regression] var-tracking ICE for 300.twolf

[rth at gcc dot gnu dot org]

-- 

rth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-12-07 22:20:23
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42244

[Bug debug/42244] [4.5 Regression] var-tracking ICE for 300.twolf

[jakub at gcc dot gnu dot org]

------- Comment #5 from jakub at gcc dot gnu dot org  2009-12-07 22:37 -------
Subject: Bug 42244

Author: jakub
Date: Mon Dec  7 22:37:21 2009
New Revision: 155062

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155062
Log:
        PR debug/42244
        * ddg.c (add_inter_loop_mem_dep): Use ANTI_DEP if from or to
        is a DEBUG_INSN.

        * gcc.dg/debug/pr42244.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/debug/pr42244.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ddg.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42244

[Bug debug/42244] [4.5 Regression] var-tracking ICE for 300.twolf

[jakub at gcc dot gnu dot org]

------- Comment #6 from jakub at gcc dot gnu dot org  2009-12-07 22:39 -------
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42244

[Bug debug/42244] [4.5 Regression] var-tracking ICE for 300.twolf

[hjl at gcc dot gnu dot org]

------- Comment #7 from hjl at gcc dot gnu dot org  2009-12-11 23:38 -------
Subject: Bug 42244

Author: hjl
Date: Fri Dec 11 23:36:24 2009
New Revision: 155184

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155184
Log:
Backport testcases from trunk.

2009-12-11  H.J. Lu  <hongjiu.lu@intel.com>

        Backport from mainline:
        2009-12-11  Dodji Seketeli  <dodji@redhat.com>

        PR c++/42225
        * g++.dg/template/typedef24.C: New test.
        * g++.dg/template/typedef25.C: New test.

        2009-12-11  Dodji Seketeli  <dodji@redhat.com>

        PR c++/42251
        * g++.dg/template/const3.C: New test.

        2009-12-10  Jakub Jelinek  <jakub@redhat.com>

        PR c++/42317
        * g++.dg/opt/dtor2.C: New test.
        * g++.dg/opt/dtor2.h: New file.
        * g++.dg/opt/dtor2-aux.cc: New file.

        2009-12-10  Jan Hubicka  <jh@suse.cz>

        PR middle-end/42110
        * g++.dg/torture/pr42110.C: new file.

        2009-12-07  Jakub Jelinek  <jakub@redhat.com>

        PR debug/42244
        * gcc.dg/debug/pr42244.c: New test.

        2009-12-04  David Daney  <ddaney@caviumnetworks.com>

        PR rtl-optimization/42164
        * gcc.c-torture/compile/pr42164.c: New test.

        2009-12-03  Jason Merrill  <jason@redhat.com>

        PR c++/41611
        * g++.dg/abi/guard2.C: New.

        2009-12-03  Dodji Seketeli  <dodji@redhat.com>

        PR c++/42217
        * g++.dg/other/bitfield4.C: New test.

        2009-12-03  Jakub Jelinek  <jakub@redhat.com>

        PR c++/42256
        * g++.dg/inherit/thunk11.C: New test.
        * g++.dg/inherit/thunk11.h: New file.
        * g++.dg/inherit/thunk11-aux.cc: New file.

        2009-12-01  Martin Jambor  <mjambor@suse.cz>

        PR tree-optimization/42237
        * gcc.c-torture/compile/pr42237.c: New test.

        2009-12-01  Paolo Carlini  <paolo.carlini@oracle.com>

        PR c++/42057
        * g++.dg/parse/crash54.C: New.

        2009-11-30  Martin Jambor  <mjambor@suse.cz>

        PR middle-end/42196
        * gcc.c-torture/compile/pr42196-1.c: New test.
        * gcc.c-torture/compile/pr42196-2.c: New test.
        * gcc.c-torture/compile/pr42196-3.c: New test.

        2009-11-30  Dodji Seketeli  <dodji@redhat.com>

        PR c++/42069
        * g++.dg/template/typedef23.C: New test.

        2009-11-29  H.J. Lu  <hongjiu.lu@intel.com>

        PR tree-optimization/41961
        * g++.dg/tree-ssa/pr41961.C: New.

        2009-11-29  Ira Rosen  <irar@il.ibm.com>

        PR tree-optimization/42193
        * gcc.dg/vect/pr42193.c: New test.

        2009-11-28  Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/42183
        * g++.dg/torture/pr42183.C: New testcase.

        2009-11-27  Martin Jambor  <mjambor@suse.cz>

        PR middle-end/42006
        * gcc.c-torture/execute/pr42006.c: New test.

        2009-11-27  Michael Matz  <matz@suse.de>

        PR rtl-optimization/42084
        * gcc.dg/pr42084.c: New test.

        2009-11-27  Michael Matz  <matz@suse.de>

        PR c++/41906
        * g++.dg/tree-ssa/pr41906.C: New testcase.

        2009-11-26  Michael Matz  <matz@suse.de>

        PR tree-optimization/41905
        * g++.dg/tree-ssa/pr41905.C: New testcase.

        2009-11-24  Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/42142
        * gcc.c-torture/execute/pr42142.c: New testcase.

        2009-11-24  Martin Jambor  <mjambor@suse.cz>

        PR tree-optimization/42154
        * gcc.c-torture/execute/pr42154.c: New test.

        2009-11-21  Martin Jambor  <mjambor@suse.cz>

        PR middle-end/42025
        * gcc.c-torture/compile/pr42025-1.c: New test.
        * gcc.c-torture/compile/pr42025-2.c: New test.

        2009-11-21  Jakub Jelinek  <jakub@redhat.com>

        PR tree-optimization/42078
        * gcc.dg/pr42078.c: New test.

Added:
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/abi/guard2.C
      - copied unchanged from r155170, trunk/gcc/testsuite/g++.dg/abi/guard2.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/inherit/thunk11-aux.cc
      - copied unchanged from r155170,
trunk/gcc/testsuite/g++.dg/inherit/thunk11-aux.cc
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/inherit/thunk11.C
      - copied unchanged from r155170,
trunk/gcc/testsuite/g++.dg/inherit/thunk11.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/inherit/thunk11.h
      - copied unchanged from r155170,
trunk/gcc/testsuite/g++.dg/inherit/thunk11.h
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/opt/dtor2-aux.cc
      - copied unchanged from r155170,
trunk/gcc/testsuite/g++.dg/opt/dtor2-aux.cc
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/opt/dtor2.C
      - copied unchanged from r155170, trunk/gcc/testsuite/g++.dg/opt/dtor2.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/opt/dtor2.h
      - copied unchanged from r155170, trunk/gcc/testsuite/g++.dg/opt/dtor2.h
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/other/bitfield4.C
      - copied unchanged from r155170,
trunk/gcc/testsuite/g++.dg/other/bitfield4.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/parse/crash54.C
      - copied unchanged from r155172,
trunk/gcc/testsuite/g++.dg/parse/crash54.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/template/const3.C
      - copied unchanged from r155170,
trunk/gcc/testsuite/g++.dg/template/const3.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/template/typedef23.C
      - copied unchanged from r155181,
trunk/gcc/testsuite/g++.dg/template/typedef23.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/template/typedef24.C
      - copied unchanged from r155170,
trunk/gcc/testsuite/g++.dg/template/typedef24.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/template/typedef25.C
      - copied unchanged from r155170,
trunk/gcc/testsuite/g++.dg/template/typedef25.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/torture/pr42110.C
      - copied unchanged from r155170,
trunk/gcc/testsuite/g++.dg/torture/pr42110.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/torture/pr42183.C
      - copied unchanged from r155181,
trunk/gcc/testsuite/g++.dg/torture/pr42183.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/tree-ssa/pr41905.C
      - copied unchanged from r155182,
trunk/gcc/testsuite/g++.dg/tree-ssa/pr41905.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/tree-ssa/pr41906.C
      - copied unchanged from r155182,
trunk/gcc/testsuite/g++.dg/tree-ssa/pr41906.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/tree-ssa/pr41961.C
      - copied unchanged from r155181,
trunk/gcc/testsuite/g++.dg/tree-ssa/pr41961.C
    branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/compile/pr42025-1.c
      - copied unchanged from r155182,
trunk/gcc/testsuite/gcc.c-torture/compile/pr42025-1.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/compile/pr42025-2.c
      - copied unchanged from r155182,
trunk/gcc/testsuite/gcc.c-torture/compile/pr42025-2.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/compile/pr42164.c
      - copied unchanged from r155170,
trunk/gcc/testsuite/gcc.c-torture/compile/pr42164.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/compile/pr42196-1.c
      - copied unchanged from r155181,
trunk/gcc/testsuite/gcc.c-torture/compile/pr42196-1.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/compile/pr42196-2.c
      - copied unchanged from r155181,
trunk/gcc/testsuite/gcc.c-torture/compile/pr42196-2.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/compile/pr42196-3.c
      - copied unchanged from r155181,
trunk/gcc/testsuite/gcc.c-torture/compile/pr42196-3.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/compile/pr42237.c
      - copied unchanged from r155171,
trunk/gcc/testsuite/gcc.c-torture/compile/pr42237.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/execute/pr42006.c
      - copied unchanged from r155181,
trunk/gcc/testsuite/gcc.c-torture/execute/pr42006.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/execute/pr42142.c
      - copied unchanged from r155182,
trunk/gcc/testsuite/gcc.c-torture/execute/pr42142.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/execute/pr42154.c
      - copied unchanged from r155182,
trunk/gcc/testsuite/gcc.c-torture/execute/pr42154.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/debug/pr42244.c
      - copied unchanged from r155170,
trunk/gcc/testsuite/gcc.dg/debug/pr42244.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/pr42078.c
      - copied unchanged from r155182, trunk/gcc/testsuite/gcc.dg/pr42078.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/pr42084.c
      - copied unchanged from r155182, trunk/gcc/testsuite/gcc.dg/pr42084.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/vect/pr42193.c
      - copied unchanged from r155181,
trunk/gcc/testsuite/gcc.dg/vect/pr42193.c
Modified:
    branches/gcc-4_4-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42244