[Bug bootstrap/42271] New: os_defines.h:60:1: error: expected '{' before '_GLIBCXX_PSEUDO_VISIBILITY'

[Bug bootstrap/42271] New: os_defines.h:60:1: error: expected '{' before '_GLIBCXX_PSEUDO_VISIBILITY'

[danglin at gcc dot gnu dot org]

/test/gnu/gcc/objdir/./gcc/xgcc -shared-libgcc -B/test/gnu/gcc/objdir/./gcc
-nos
tdinc++ -L/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++-v3/src
-L/test/gn
u/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++-v3/src/.libs
-B/opt/gnu/gcc/gcc-4.5
.0/hppa2.0w-hp-hpux11.11/bin/
-B/opt/gnu/gcc/gcc-4.5.0/hppa2.0w-hp-hpux11.11/lib
/ -isystem /opt/gnu/gcc/gcc-4.5.0/hppa2.0w-hp-hpux11.11/include -isystem
/opt/gn
u/gcc/gcc-4.5.0/hppa2.0w-hp-hpux11.11/sys-include    -x c++-header -g -O2
-I/tes
t/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++-v3/include/hppa2.0w-hp-hpux11.1
1 -I/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++-v3/include
-I/test/gnu/
gcc/gcc/libstdc++-v3/libsupc++ -O2 -g -std=gnu++0x
/test/gnu/gcc/gcc/libstdc++-v
3/include/precompiled/stdc++.h \
        -o hppa2.0w-hp-hpux11.11/bits/stdc++.h.gch/O2ggnu++0x.gch
In file included from
/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++-v3/in
clude/hppa2.0w-hp-hpux11.11/bits/c++config.h:275:0,
                 from
/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++-v3/in
clude/cctype:43,
                 from
/test/gnu/gcc/gcc/libstdc++-v3/include/precompiled/stdc++.
h:36:
/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++-v3/include/hppa2.0w-hp-hpux
11.11/bits/os_defines.h:60:1: error: expected '{' before
'_GLIBCXX_PSEUDO_VISIBI
LITY'
/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++-v3/include/hppa2.0w-hp-hpux
11.11/bits/os_defines.h:60:1: error: expected constructor, destructor, or type
c
onversion before '(' token
...

-bash-3.2$ ./xgcc -B./ -v
Reading specs from ./specs
COLLECT_GCC=./xgcc
COLLECT_LTO_WRAPPER=./lto-wrapper
Target: hppa2.0w-hp-hpux11.11
Configured with: ../gcc/configure --with-gnu-as --with-as=/opt/gnu/bin/as
--enable-shared --with-local-prefix=/opt/gnu --prefix=/opt/gnu/gcc/gcc-4.5.0
--with-gmp=/opt/gnu/gcc/gcc-4.5.0 --enable-threads=posix --enable-debug=no
--disable-nls --without-cloog --without-ppl
--enable-languages=c,c++,objc,fortran,java,ada,obj-c++
Thread model: posix
gcc version 4.5.0 20091203 (experimental) [trunk revision 154954] (GCC)


-- 
           Summary: os_defines.h:60:1: error: expected '{' before
                    '_GLIBCXX_PSEUDO_VISIBILITY'
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
 GCC build triplet: hppa2.0w-hp-hpux11.11
  GCC host triplet: hppa2.0w-hp-hpux11.11
GCC target triplet: hppa2.0w-hp-hpux11.11


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42271

[Bug bootstrap/42271] os_defines.h:60:1: error: expected '{' before '_GLIBCXX_PSEUDO_VISIBILITY'

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #1 from dave at hiauly1 dot hia dot nrc dot ca  2009-12-04 03:50 -------
Subject: Re:   New: os_defines.h:60:1: error: expected
        '{' before '_GLIBCXX_PSEUDO_VISIBILITY'

Attached os_defines.h.


------- Comment #2 from dave at hiauly1 dot hia dot nrc dot ca  2009-12-04 03:50 -------
Created an attachment (id=19221)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19221&action=view)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42271

[Bug bootstrap/42271] os_defines.h:60:1: error: expected '{' before '_GLIBCXX_PSEUDO_VISIBILITY'

[paolo dot carlini at oracle dot com]

------- Comment #3 from paolo dot carlini at oracle dot com  2009-12-04 10:49 -------
Let's add DaveK in CC


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dave dot korn dot cygwin at
                   |                            |gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42271

[Bug bootstrap/42271] os_defines.h:60:1: error: expected '{' before '_GLIBCXX_PSEUDO_VISIBILITY'

[davek at gcc dot gnu dot org]

------- Comment #4 from davek at gcc dot gnu dot org  2009-12-04 17:30 -------
Just got awake in my $TZ, will look at this straight away and fix or revert in
the next couple of hours.   Sorry for the inconvenience.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42271

[Bug bootstrap/42271] os_defines.h:60:1: error: expected '{' before '_GLIBCXX_PSEUDO_VISIBILITY'

[davek at gcc dot gnu dot org]

------- Comment #5 from davek at gcc dot gnu dot org  2009-12-04 17:58 -------
Created an attachment (id=19225)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19225&action=view)
Simple fix

The comment in the patch should explain.  Namespace macros are defined at the
top of c++config.h before target-specific headers are included, but need to
allow a target-specific override, so we have the pseudo-vis macro in there and
if it still isn't defined after the target-specific os_defines.h is included,
it gets defaulted empty.  That means the namespace macros can't be used until
after either the os-specific override if any or the empty default has actually
been defined for it of course.

This works fine, except when an os_defines.h header needs to use the namespace
macros itself.  The trivial fix is for it to provide its own empty definition
of the os-specific override, as here.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42271

[Bug bootstrap/42271] os_defines.h:60:1: error: expected '{' before '_GLIBCXX_PSEUDO_VISIBILITY'

[davek at gcc dot gnu dot org]

------- Comment #6 from davek at gcc dot gnu dot org  2009-12-04 18:00 -------
I didn't anticipate any of the os-specific config headers trying to use the
namespace macros, since all the necessary defines and stuff are only half-way
through being set up, but I didn't imagine the possibility of wanting to import
some libc functions.  I probably could have anticipated this if I'd done a bit
more grepping around, sorry.

JDA, I don't have headers and libs to test a hpux cross-compiler, could you
test the patch?


-- 

davek at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-12-04 18:00:47
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42271

[Bug bootstrap/42271] os_defines.h:60:1: error: expected '{' before '_GLIBCXX_PSEUDO_VISIBILITY'

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #7 from dave at hiauly1 dot hia dot nrc dot ca  2009-12-04 18:22 -------
Subject: Re:  os_defines.h:60:1: error: expected '{' before
'_GLIBCXX_PSEUDO_VISIBILITY'

> JDA, I don't have headers and libs to test a hpux cross-compiler, could you
> test the patch?

I'll test tonight.

Thanks,
Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42271

[Bug bootstrap/42271] os_defines.h:60:1: error: expected '{' before '_GLIBCXX_PSEUDO_VISIBILITY'

[davek at gcc dot gnu dot org]

------- Comment #8 from davek at gcc dot gnu dot org  2009-12-04 18:23 -------
(In reply to comment #7)

> I'll test tonight.

  Thanks.  So sorry for the aggro :(


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42271

[Bug bootstrap/42271] os_defines.h:60:1: error: expected '{' before '_GLIBCXX_PSEUDO_VISIBILITY'

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #9 from dave at hiauly1 dot hia dot nrc dot ca  2009-12-04 23:39 -------
Subject: Re:  os_defines.h:60:1: error: expected '{'
        before '_GLIBCXX_PSEUDO_VISIBILITY'

On Fri, 04 Dec 2009, davek at gcc dot gnu dot org wrote:

> 
> 
> ------- Comment #8 from davek at gcc dot gnu dot org  2009-12-04 18:23 -------
> (In reply to comment #7)
> 
> > I'll test tonight.
> 
>   Thanks.  So sorry for the aggro :(

No problem.  I'm used to hppa being broken by this and that...

The patch fixes the build error.  It's ok to install with a ChangeLog
entry.

Thanks,
Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42271

[Bug bootstrap/42271] os_defines.h:60:1: error: expected '{' before '_GLIBCXX_PSEUDO_VISIBILITY'

[davek at gcc dot gnu dot org]

------- Comment #10 from davek at gcc dot gnu dot org  2009-12-05 02:27 -------
(In reply to comment #9)

> The patch fixes the build error.  It's ok to install with a ChangeLog
> entry.

  Great, thanks for checking and sorry for the inconvience.  I'll get it
committed in the next hour or two, modulo getting coffee and a bite to eat.


-- 

davek at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |davek at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2009-12-04 18:00:47         |2009-12-05 02:27:50
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42271

[Bug bootstrap/42271] os_defines.h:60:1: error: expected '{' before '_GLIBCXX_PSEUDO_VISIBILITY'

[davek at gcc dot gnu dot org]

------- Comment #11 from davek at gcc dot gnu dot org  2009-12-05 06:14 -------
Committed revision 155008.


-- 

davek at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42271

[Bug bootstrap/42271] os_defines.h:60:1: error: expected '{' before '_GLIBCXX_PSEUDO_VISIBILITY'

[davek at gcc dot gnu dot org]

------- Comment #12 from davek at gcc dot gnu dot org  2009-12-05 06:16 -------
boh!  Forgot to reference the pr in the changelog.  I'll fix it if anyone asks
me to but not otherwise, I don't think it's likely to be critical for such a
transient bug.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42271

[Bug bootstrap/42271] os_defines.h:60:1: error: expected '{' before '_GLIBCXX_PSEUDO_VISIBILITY'

[davek at gcc dot gnu dot org]

-- 

davek at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42271