[Bug middle-end/42130] New: [graphite-branch] dealII fails

[Bug middle-end/42130] New: [graphite-branch] dealII fails

[grosser at gcc dot gnu dot org]

Compilation with only graphite-identity fails:
"-O3 -fno-loop-interchange -fno-loop-block -fno-loop-strip-mine"

------------------------------------------------------------------------------
 Running 447.dealII train base amd64-m64-gcc43-nn default
/home/grosser/spec/bin/specinvoke -d
/home/grosser/spec/benchspec/CPU2006/447.dealII/run/run_base_train_amd64-m64-gcc43-nn.0007
-e speccmds.err -o speccmds.stdout -f speccmds.cmd -C

447.dealII: copy 0 non-zero return code (exit code=0, signal=11)
------------------------------------------------------------------------------

without graphite identity it works:
-O3 -fno-graphite-identity -fno-loop-interchange -fno-loop-block
-fno-loop-strip-mine -fno-graphite


-- 
           Summary: [graphite-branch] dealII fails
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: grosser at gcc dot gnu dot org
        ReportedBy: grosser at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42130

[Bug middle-end/42130] [graphite-branch] dealII fails

[grosser at gcc dot gnu dot org]

------- Comment #1 from grosser at gcc dot gnu dot org  2009-11-21 08:50 -------
Created an attachment (id=19071)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19071&action=view)
Small C++ testcase showing the same behavior

-O2 -fno-tree-ch are required options

Fails on execution

Submitted by: Alexander Monakov


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42130

[Bug middle-end/42130] [graphite-branch] dealII fails

[grosser at gcc dot gnu dot org]

------- Comment #2 from grosser at gcc dot gnu dot org  2009-11-22 18:06 -------
Created an attachment (id=19086)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19086&action=view)
First try - Needs cleanup

I got a patch that fixes both the small C++ testcase and the dealII. It needs
just some cleanup, a nice description and all this stuff.
The problem was that we check the loop conditions only after the loop body, so
loops with zero iterations are executed once. And this is one time too much.

I will do the cleanup and committing of this patch next week


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42130

[Bug middle-end/42130] [graphite-branch] dealII fails

[grosser at gcc dot gnu dot org]

------- Comment #3 from grosser at gcc dot gnu dot org  2009-11-23 13:02 -------
Subject: Bug 42130

Author: grosser
Date: Mon Nov 23 13:02:08 2009
New Revision: 154440

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=154440
Log:
Protect loops that might be executed zero times.

2009-11-23  Tobias Grosser  <grosser@fim.uni-passau.de>

        PR middle-end/42130
        * graphite-clast-to-gimple.c (graphite_create_new_loop_guard,
        translate_clast_for_loop): New.
        (translate_clast_for): Add a condition around the loop, to do not
        execute loops with zero iterations.
        * testsuite/g++.dg/graphite/pr42130.C: New.
        * testsuite/gcc.dg/graphite/pr35356-2.c: Adapt.

Added:
    branches/graphite/gcc/testsuite/g++.dg/graphite/pr42130.C
Modified:
    branches/graphite/gcc/ChangeLog.graphite
    branches/graphite/gcc/graphite-clast-to-gimple.c
    branches/graphite/gcc/testsuite/gcc.dg/graphite/pr35356-2.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42130

[Bug middle-end/42130] [graphite-branch] dealII fails

[amonakov at gcc dot gnu dot org]

------- Comment #4 from amonakov at gcc dot gnu dot org  2009-11-25 11:48 -------
Tobias,

Please fix the testcase before committing to trunk, like this ('return 0' is
needed to ensure the test does not fail when compiled correctly; 'noclone' to
ensure that foo is not specialized for n=0):

/* { dg-options "-O2 -fno-tree-ch" } */ 
#include <vector>

using std::vector;

vector<unsigned> & __attribute__((noinline,noclone)) foo(unsigned n)
{
  vector<unsigned> *vv = new vector<unsigned>(n, 0u);
  return *vv;
}


int main()
{
  foo(0);
  return 0;
}

(In reply to comment #3)


-- 

amonakov at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amonakov at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42130

[Bug middle-end/42130] [graphite-branch] dealII fails

[spop at gcc dot gnu dot org]

------- Comment #5 from spop at gcc dot gnu dot org  2009-11-30 16:59 -------
Fixed.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42130

[Bug middle-end/42130] [graphite-branch] dealII fails

[grosser at gcc dot gnu dot org]

------- Comment #6 from grosser at gcc dot gnu dot org  2009-11-30 22:08 -------
Subject: Bug 42130

Author: grosser
Date: Mon Nov 30 22:07:59 2009
New Revision: 154849

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=154849
Log:
Protect loops that might be executed zero times.

2009-11-23  Tobias Grosser  <grosser@fim.uni-passau.de>

        PR middle-end/42130
        * graphite-clast-to-gimple.c (graphite_create_new_loop_guard,
        translate_clast_for_loop): New.
        (translate_clast_for): Add a condition around the loop, to do not
        execute loops with zero iterations.
        * testsuite/g++.dg/graphite/pr42130.C: New.
        * testsuite/gcc.dg/graphite/pr35356-2.c: Adapt.

Added:
    trunk/gcc/testsuite/g++.dg/graphite/pr42130.C
Modified:
    trunk/gcc/ChangeLog.graphite
    trunk/gcc/graphite-clast-to-gimple.c
    trunk/gcc/testsuite/gcc.dg/graphite/pr35356-2.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42130

[Bug middle-end/42130] [graphite-branch] dealII fails

[spop at gcc dot gnu dot org]

------- Comment #7 from spop at gcc dot gnu dot org  2009-12-15 08:21 -------
I will add -fgraphite-identity to the testcase as otherwise we're not going to
test graphite on trunk...

diff --git a/gcc/testsuite/g++.dg/graphite/pr42130.C
b/gcc/testsuite/g++.dg/graphite/pr42130.C
index ca00227..5652139 100644
--- a/gcc/testsuite/g++.dg/graphite/pr42130.C
+++ b/gcc/testsuite/g++.dg/graphite/pr42130.C
@@ -1,4 +1,4 @@
-/* { dg-options "-O2 -fno-tree-ch" } */
+/* { dg-options "-O2 -fgraphite-identity -fno-tree-ch" } */
 #include <vector>

 using std::vector;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42130

[Bug middle-end/42130] [graphite-branch] dealII fails

[spop at gcc dot gnu dot org]

------- Comment #8 from spop at gcc dot gnu dot org  2009-12-15 08:27 -------
Also, I don't know why the test fails at runtime like this:

FAIL: g++.dg/graphite/pr42130.C execution test


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42130

[Bug middle-end/42130] [graphite-branch] dealII fails

[spop at gcc dot gnu dot org]

------- Comment #9 from spop at gcc dot gnu dot org  2009-12-23 17:37 -------
The testcase still fails with -fgraphite-identity.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42130

[Bug middle-end/42130] [graphite-branch] dealII fails

[spop at gcc dot gnu dot org]

------- Comment #10 from spop at gcc dot gnu dot org  2010-01-13 06:33 -------
This seems to still be wrong code, so P1.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42130

[Bug middle-end/42130] [graphite-branch] dealII fails

[spop at gcc dot gnu dot org]

------- Comment #11 from spop at gcc dot gnu dot org  2010-03-08 17:54 -------
Fixed by http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=157287


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42130

[Bug middle-end/42130] [graphite-branch] dealII fails

[spop at gcc dot gnu dot org]

------- Comment #12 from spop at gcc dot gnu dot org  2010-03-25 15:15 -------
The patch for the fix is:
http://gcc.gnu.org/viewcvs?view=revision&revision=157286


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42130