public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "pault at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/40158] Misleading error message for passing a scalar to an array Date: Fri, 18 Dec 2009 06:47:00 -0000 [thread overview] Message-ID: <20091218064714.30112.qmail@sourceware.org> (raw) In-Reply-To: <bug-40158-13404@http.gcc.gnu.org/bugzilla/> ------- Comment #1 from pault at gcc dot gnu dot org 2009-12-18 06:47 ------- This fixes it and even bootstraps and regtests: Index: gcc/fortran/interface.c =================================================================== --- gcc/fortran/interface.c (revision 155192) +++ gcc/fortran/interface.c (working copy) @@ -1375,6 +1375,29 @@ } + +static void +argument_rank_mismatch (const char *name, locus *where, + int rank1, int rank2) +{ + if (rank1 == 0) + { + gfc_error ("Rank mismatch in argument '%s' at %L " + "(scalar and rank-%d)", name, where, rank2); + } + if (rank2 == 0) + { + gfc_error ("Rank mismatch in argument '%s' at %L " + "(rank-%d and scalar)", name, where, rank1); + } + else + { + gfc_error ("Rank mismatch in argument '%s' at %L " + "(rank-%d and rank-%d)", name, where, rank1, rank2); + } +} + + /* Given a symbol of a formal argument list and an expression, see if the two are compatible as arguments. Returns nonzero if compatible, zero if not compatible. */ @@ -1456,9 +1479,8 @@ || (actual->rank == 0 && formal->as->type == AS_ASSUMED_SHAPE)) { if (where) - gfc_error ("Rank mismatch in argument '%s' at %L (%d and %d)", - formal->name, &actual->where, symbol_rank (formal), - actual->rank); + argument_rank_mismatch (formal->name, &actual->where, + symbol_rank (formal), actual->rank); return 0; } else if (actual->rank != 0 && (is_elemental || formal->attr.dimension)) @@ -1496,9 +1518,8 @@ else if (ref == NULL) { if (where) - gfc_error ("Rank mismatch in argument '%s' at %L (%d and %d)", - formal->name, &actual->where, symbol_rank (formal), - actual->rank); + argument_rank_mismatch (formal->name, &actual->where, + symbol_rank (formal), actual->rank); return 0; } Cheers Paul -- pault at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|unassigned at gcc dot gnu |pault at gcc dot gnu dot org |dot org | Status|UNCONFIRMED |ASSIGNED Ever Confirmed|0 |1 Last reconfirmed|0000-00-00 00:00:00 |2009-12-18 06:47:14 date| | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40158
next prev parent reply other threads:[~2009-12-18 6:47 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-05-15 12:45 [Bug fortran/40158] New: " burnus at gcc dot gnu dot org 2009-12-18 6:47 ` pault at gcc dot gnu dot org [this message] 2010-05-07 19:57 ` [Bug fortran/40158] " dfranke at gcc dot gnu dot org 2010-06-24 15:31 ` pault at gcc dot gnu dot org 2010-06-28 17:17 ` pault at gcc dot gnu dot org 2010-07-16 4:39 ` pault at gcc dot gnu dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20091218064714.30112.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).