[Bug testsuite/42135] New: FAIL: libgomp.graphite/force-parallel-2.c execution test

[Bug testsuite/42135] New: FAIL: libgomp.graphite/force-parallel-2.c execution test

[dominiq at lps dot ens dot fr]

Since revision 150792, the test libgomp.graphite/force-parallel-2.c (introduced
in revision 150755) fails on *-apple-darwin9. AFAICT the array x[10000][10000]
is allocated in stack and is too big for the 64Mb hard limit on darwin. One
solution could be to replace 10000 with 4000. Also the following patch works.

--- /opt/gcc/_gcc_clean/libgomp/testsuite/libgomp.graphite/graphite.exp
2009-08-14 19:16:39.000000000 +0200
+++ /opt/gcc/gcc-4.5-work/libgomp/testsuite/libgomp.graphite/graphite.exp      
2009-11-20 16:32:46.000000000 +0100
@@ -33,10 +33,24 @@ if ![check_effective_target_fgraphite] {
 }

 # Flags for force-parallel-*.c testcases.
-set PARALLEL_CFLAGS "-ansi -pedantic-errors -O2 \
--ftree-parallelize-loops=4 -floop-parallelize-all \
--fdump-tree-parloops-details -fdump-tree-optimized \
--fno-loop-strip-mine -fdump-tree-graphite-all"
+if { ![istarget *-*-darwin*] } {
+    set PARALLEL_CFLAGS "-ansi -pedantic-errors -O2 \
+    -ftree-parallelize-loops=4 -floop-parallelize-all \
+    -fdump-tree-parloops-details -fdump-tree-optimized \
+    -fno-loop-strip-mine -fdump-tree-graphite-all"
+  } elseif { ![is-effective-target lp64] } {
+    set PARALLEL_CFLAGS "-ansi -pedantic-errors -O2 \
+    -ftree-parallelize-loops=4 -floop-parallelize-all \
+    -fdump-tree-parloops-details -fdump-tree-optimized \
+    -fno-loop-strip-mine -fdump-tree-graphite-all \
+    -Wl,-stack_size,0x20000000,-stack_addr,0xa0000000"
+  } else {
+    set PARALLEL_CFLAGS "-ansi -pedantic-errors -O2 \
+    -ftree-parallelize-loops=4 -floop-parallelize-all \
+    -fdump-tree-parloops-details -fdump-tree-optimized \
+    -fno-loop-strip-mine -fdump-tree-graphite-all \
+    -Wl,-stack_size,0x20000000"
+  }

 # Initialize `dg'.
 dg-init

What is the best solution? or is there a better one?


-- 
           Summary: FAIL: libgomp.graphite/force-parallel-2.c execution test
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dominiq at lps dot ens dot fr
 GCC build triplet: *-apple-darwin9
  GCC host triplet: *-apple-darwin9
GCC target triplet: *-apple-darwin9


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42135

Re: [Bug testsuite/42135] New: FAIL: libgomp.graphite/force-parallel-2.c execution test

[Sebastian Pop]

On Sat, Nov 21, 2009 at 14:57, dominiq at lps dot ens dot fr
<gcc-bugzilla@gcc.gnu.org> wrote:
> Since revision 150792, the test libgomp.graphite/force-parallel-2.c (introduced
> in revision 150755) fails on *-apple-darwin9. AFAICT the array x[10000][10000]
> is allocated in stack and is too big for the 64Mb hard limit on darwin. One
> solution could be to replace 10000 with 4000. Also the following patch works.

Please update the size of arrays.

Thanks,
Sebastian

[Bug testsuite/42135] FAIL: libgomp.graphite/force-parallel-2.c execution test

[sebpop at gmail dot com]

------- Comment #1 from sebpop at gmail dot com  2009-11-24 06:51 -------
Subject: Re:  New: FAIL: libgomp.graphite/force-parallel-2.c 
        execution test

On Sat, Nov 21, 2009 at 14:57, dominiq at lps dot ens dot fr
<gcc-bugzilla@gcc.gnu.org> wrote:
> Since revision 150792, the test libgomp.graphite/force-parallel-2.c (introduced
> in revision 150755) fails on *-apple-darwin9. AFAICT the array x[10000][10000]
> is allocated in stack and is too big for the 64Mb hard limit on darwin. One
> solution could be to replace 10000 with 4000. Also the following patch works.

Please update the size of arrays.

Thanks,
Sebastian


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42135

[Bug testsuite/42135] FAIL: libgomp.graphite/force-parallel-2.c execution test

[jakub at gcc dot gnu dot org]

------- Comment #2 from jakub at gcc dot gnu dot org  2009-11-24 07:17 -------
4000 is still too much.  The usual stack size limit on Linux is 8MB, on cygwin
it is I think even just 2MB.  So it would need to be 500 instead of 10000.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42135

[Bug testsuite/42135] FAIL: libgomp.graphite/force-parallel-2.c execution test

[spop at gcc dot gnu dot org]

------- Comment #3 from spop at gcc dot gnu dot org  2009-12-18 07:38 -------
Subject: Bug 42135

Author: spop
Date: Fri Dec 18 07:38:06 2009
New Revision: 155337

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155337
Log:
Fix PR42135.

2009-12-18  Jack Howarth <howarth@bromo.med.uc.edu>

        PR testsuite/42135
        * libgomp.graphite/force-parallel-2.c: Reduce array size.

Modified:
    trunk/libgomp/ChangeLog
    trunk/libgomp/testsuite/libgomp.graphite/force-parallel-2.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42135

[Bug testsuite/42135] FAIL: libgomp.graphite/force-parallel-2.c execution test

[spop at gcc dot gnu dot org]

------- Comment #4 from spop at gcc dot gnu dot org  2009-12-18 07:38 -------
Fixed.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42135