[Bug tree-optimization/42334] New: segfault in graphite-poly.h for 200.sixtrack

[Bug tree-optimization/42334] New: segfault in graphite-poly.h for 200.sixtrack

[janis at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1773 bytes --]

GCC trunk gets a segmentation fault when building SPEC CPU2000 test
200.sixtrack with "-floop-interchange -ftree-loop-distribution" on
powerpc-linux, as demonstrated by this minimized testcase:

      subroutine blockdis(bl1eg,bl2eg)
      implicit real*8 (a-h,o-z)
      parameter(nblo=300)
      common/str /mblo
      common/str2 /mel(nblo)
      dimension h(nblo,2,6),g(nblo,2,6)
      dimension bl1eg(nblo,2,6),bl2eg(nblo,2,6)
      do k=1,mblo
        jm=mel(k)
        do l=1,2
          do m=1,6
            bl1eg(k,l,m)=h(jm,l,m)
            bl2eg(k,l,m)=g(jm,l,m)
          enddo
        enddo
      enddo
      return
      end

n function ‘blockdis’:
bug.f:1:0: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.See
<http://gcc.gnu.org/bugs.html> for instructions.

The segfault is in VEC_lst_p_base_iterate at graphite-poly.h:623.

sixtrack passed with the now-failing options until r150248.  With the merge
from the Graphite branch at r150301 that test started failing at runtime.  (In
between those two revisions trunk didn't build with Graphite for
powerpc-linux).  sixtrack failed at runtime with r154631, and GCC started
getting the segmentation fault at r154632.


-- 
           Summary: segfault in graphite-poly.h for 200.sixtrack
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: janis at gcc dot gnu dot org
GCC target triplet: powerpc-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42334

[Bug tree-optimization/42334] segfault in graphite-poly.h for 200.sixtrack

[spop at gcc dot gnu dot org]

------- Comment #1 from spop at gcc dot gnu dot org  2009-12-14 19:17 -------
Mine.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |spop at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-12-14 19:17:15
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42334

[Bug tree-optimization/42334] segfault in graphite-poly.h for 200.sixtrack

[spop at gcc dot gnu dot org]

------- Comment #2 from spop at gcc dot gnu dot org  2009-12-15 08:39 -------
Subject: Bug 42334

Author: spop
Date: Tue Dec 15 08:39:25 2009
New Revision: 155248

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155248
Log:
Fix PR42334: correct the update of the LST on loop interchange and
distribution.

2009-12-15  Sebastian Pop  <sebastian.pop@amd.com>

        PR middle-end/42178
        PR middle-end/42334
        * graphite-interchange.c (lst_perfect_nestify): Reset to NULL the LSTs
        that are empty.
        (lst_do_interchange_1): Renamed lst_interchange_select_inner.
        (lst_try_interchange): Reimplemented.
        (lst_interchange_select_inner): Same.
        (lst_do_interchange): Renamed lst_interchange_select_outer.
        Reimplemented.
        (scop_do_interchange): Update use of lst_interchange_select_outer.

        * testsuite/g++.dg/graphite/pr42130.C: Add -fgraphite-identity.
        * testsuite/gcc.dg/graphite/block-0.c: Un-XFAILed.
        * testsuite/gcc.dg/graphite/pr42211.c: New.
        * testsuite/gfortran.dg/graphite/pr42334.f90: New.

Added:
    branches/graphite/gcc/testsuite/gcc.dg/graphite/pr42211.c
    branches/graphite/gcc/testsuite/gfortran.dg/graphite/pr42334.f90
Modified:
    branches/graphite/gcc/ChangeLog.graphite
    branches/graphite/gcc/graphite-interchange.c
    branches/graphite/gcc/testsuite/g++.dg/graphite/pr42130.C
    branches/graphite/gcc/testsuite/gcc.dg/graphite/block-0.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42334

[Bug tree-optimization/42334] segfault in graphite-poly.h for 200.sixtrack

[spop at gcc dot gnu dot org]

------- Comment #3 from spop at gcc dot gnu dot org  2009-12-15 08:41 -------
Fixed in the graphite branch.  I will commit this to trunk after further test.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42334

[Bug tree-optimization/42334] segfault in graphite-poly.h for 200.sixtrack

[spop at gcc dot gnu dot org]

------- Comment #4 from spop at gcc dot gnu dot org  2009-12-15 21:12 -------
Subject: Bug 42334

Author: spop
Date: Tue Dec 15 21:11:48 2009
New Revision: 155273

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155273
Log:
Fix fall outs from Fix-PR42334.

2009-12-15  Sebastian Pop  <sebastian.pop@amd.com>

        PR middle-end/42178
        PR middle-end/42334
        * graphite-interchange.c (lst_try_interchange): Do not increment the
        the OUTER index when there is no AFTER kernel.  Do not increment the
        OUTER index for after processing the AFTER kernel.
        (lst_interchange_select_inner): Call lst_try_interchange only on loops.
        (lst_interchange_select_outer): Do not pass in a pointer to the OUTER
        index.  Do not pass to lst_interchange_select_inner the OUTER index.
        (scop_do_interchange): Update use of lst_interchange_select_outer.

        * testsuite/gfortran.dg/graphite/graphite.exp
        (DEFAULT_FLAGS_GRAPHITE_IDENTITY): Remove -fdump-tree-graphite-all.
        * testsuite/gfortran.dg/graphite/interchange-1.f: Add comment.  Clean
        the graphite dump file.
        * testsuite/gfortran.dg/graphite/interchange-2.f: Same.
        * testsuite/gfortran.dg/graphite/pr42334-1.f: New.

Added:
    branches/graphite/gcc/testsuite/gfortran.dg/graphite/pr42334-1.f
Modified:
    branches/graphite/gcc/ChangeLog.graphite
    branches/graphite/gcc/graphite-interchange.c
    branches/graphite/gcc/testsuite/gfortran.dg/graphite/graphite.exp
    branches/graphite/gcc/testsuite/gfortran.dg/graphite/interchange-1.f
    branches/graphite/gcc/testsuite/gfortran.dg/graphite/interchange-2.f


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42334

[Bug tree-optimization/42334] segfault in graphite-poly.h for 200.sixtrack

[spop at gcc dot gnu dot org]

------- Comment #5 from spop at gcc dot gnu dot org  2009-12-17 21:57 -------
Subject: Bug 42334

Author: spop
Date: Thu Dec 17 21:57:29 2009
New Revision: 155326

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155326
Log:
Fix fall outs from Fix-PR42334.

2009-12-17  Sebastian Pop  <sebastian.pop@amd.com>

        PR middle-end/42178
        PR middle-end/42334
        * graphite-interchange.c (lst_try_interchange): Do not modify OUTER
        index.  Call lst_interchange_select_inner only once.
        (lst_interchange_select_inner): Update use of lst_try_interchange.
        (lst_interchange_select_outer): Update.

Modified:
    branches/graphite/gcc/ChangeLog.graphite
    branches/graphite/gcc/graphite-interchange.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42334

[Bug tree-optimization/42334] segfault in graphite-poly.h for 200.sixtrack

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2009-12-19 19:06 -------
Re-open. Not fixed on the trunk.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42334

[Bug tree-optimization/42334] segfault in graphite-poly.h for 200.sixtrack

[spop at gcc dot gnu dot org]

------- Comment #7 from spop at gcc dot gnu dot org  2009-12-23 07:50 -------
Subject: Bug 42334

Author: spop
Date: Wed Dec 23 07:50:12 2009
New Revision: 155418

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155418
Log:
Fix PR42334: correct the update of the LST on loop interchange and
distribution.

2009-12-15  Sebastian Pop  <sebastian.pop@amd.com>

        PR middle-end/42178
        PR middle-end/42334
        * graphite-interchange.c (lst_perfect_nestify): Reset to NULL the LSTs
        that are empty.
        (lst_do_interchange_1): Renamed lst_interchange_select_inner.
        (lst_try_interchange): Reimplemented.
        (lst_interchange_select_inner): Same.
        (lst_do_interchange): Renamed lst_interchange_select_outer.
        Reimplemented.
        (scop_do_interchange): Update use of lst_interchange_select_outer.

        * graphite-interchange.c (lst_try_interchange): Do not increment the
        the OUTER index when there is no AFTER kernel.  Do not increment the
        OUTER index for after processing the AFTER kernel.
        (lst_interchange_select_inner): Call lst_try_interchange only on loops.
        (lst_interchange_select_outer): Do not pass in a pointer to the OUTER
        index.  Do not pass to lst_interchange_select_inner the OUTER index.
        (scop_do_interchange): Update use of lst_interchange_select_outer.

        * graphite-interchange.c (lst_try_interchange): Do not modify OUTER
        index.  Call lst_interchange_select_inner only once.
        (lst_interchange_select_inner): Update use of lst_try_interchange.
        (lst_interchange_select_outer): Update.

        * testsuite/g++.dg/graphite/pr42130.C: Add -fgraphite-identity.
        * testsuite/gcc.dg/graphite/block-0.c: Un-XFAILed.
        * testsuite/gcc.dg/graphite/pr42211.c: New.
        * testsuite/gfortran.dg/graphite/pr42334.f90: New.

        * testsuite/gfortran.dg/graphite/graphite.exp
        (DEFAULT_FLAGS_GRAPHITE_IDENTITY): Remove -fdump-tree-graphite-all.
        * testsuite/gfortran.dg/graphite/interchange-1.f: Add comment.  Clean
        the graphite dump file.
        * testsuite/gfortran.dg/graphite/interchange-2.f: Same.
        * testsuite/gfortran.dg/graphite/pr42334-1.f: New.

Added:
    trunk/gcc/testsuite/gcc.dg/graphite/pr42211.c
    trunk/gcc/testsuite/gfortran.dg/graphite/pr42334-1.f
    trunk/gcc/testsuite/gfortran.dg/graphite/pr42334.f90
Modified:
    trunk/gcc/ChangeLog.graphite
    trunk/gcc/graphite-interchange.c
    trunk/gcc/testsuite/g++.dg/graphite/pr42130.C
    trunk/gcc/testsuite/gcc.dg/graphite/block-0.c
    trunk/gcc/testsuite/gfortran.dg/graphite/graphite.exp
    trunk/gcc/testsuite/gfortran.dg/graphite/interchange-1.f
    trunk/gcc/testsuite/gfortran.dg/graphite/interchange-2.f


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42334

[Bug tree-optimization/42334] segfault in graphite-poly.h for 200.sixtrack

[spop at gcc dot gnu dot org]

------- Comment #8 from spop at gcc dot gnu dot org  2009-12-23 07:52 -------
Fixed.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42334

[Bug tree-optimization/42334] segfault in graphite-poly.h for 200.sixtrack

[howarth at nitro dot med dot uc dot edu]

------- Comment #9 from howarth at nitro dot med dot uc dot edu  2009-12-24 02:29 -------
On x86_64-apple-darwin10, the two new test cases are cause ICEs...

FAIL: gfortran.dg/graphite/pr42334-1.f  -O  (internal compiler error)
FAIL: gfortran.dg/graphite/pr42334-1.f  -O  (test for excess errors)
FAIL: gfortran.dg/graphite/pr42393.f90  -O  (internal compiler error)
FAIL: gfortran.dg/graphite/pr42393.f90  -O  (test for excess errors)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42334

[Bug tree-optimization/42334] segfault in graphite-poly.h for 200.sixtrack

[howarth at nitro dot med dot uc dot edu]

------- Comment #10 from howarth at nitro dot med dot uc dot edu  2009-12-24 02:34 -------
The pr42334-1.f test case fails as...

Executing on host:
/sw/src/fink.build/gcc45-4.4.999-20091223/darwin_objdir/gcc/testsuite/gfortran/../../gfortran
-B/sw/src/fink.build/gcc45-4.4.999-20091223/darwin_objdir/gcc/testsuite/gfortran/../../
/sw/src/fink.build/gcc45-4.4.999-20091223/gcc-4.5-20091223/gcc/testsuite/gfortran.dg/graphite/pr42334-1.f
  -O  -O2 -floop-interchange -S  -o pr42334-1.s    (timeout = 300)
/sw/src/fink.build/gcc45-4.4.999-20091223/gcc-4.5-20091223/gcc/testsuite/gfortran.dg/graphite/pr42334-1.f:
In function 'linel':
/sw/src/fink.build/gcc45-4.4.999-20091223/gcc-4.5-20091223/gcc/testsuite/gfortran.dg/graphite/pr42334-1.f:3:0:
internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
compiler exited with status 1
output is:
/sw/src/fink.build/gcc45-4.4.999-20091223/gcc-4.5-20091223/gcc/testsuite/gfortran.dg/graphite/pr42334-1.f:
In function 'linel':
/sw/src/fink.build/gcc45-4.4.999-20091223/gcc-4.5-20091223/gcc/testsuite/gfortran.dg/graphite/pr42334-1.f:3:0:
internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

FAIL: gfortran.dg/graphite/pr42334-1.f  -O  (internal compiler error)
FAIL: gfortran.dg/graphite/pr42334-1.f  -O  (test for excess errors)
Excess errors:
/sw/src/fink.build/gcc45-4.4.999-20091223/gcc-4.5-20091223/gcc/testsuite/gfortran.dg/graphite/pr42334-1.f:3:0:
internal compiler error: Segmentation fault

and backtraces as....

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0000000000000002
0x00000001005355c8 in lst_interchange_select_inner (scop=<value temporarily
unavailable, due to optimizations>, outer_father=<value temporarily
unavailable, due to optimizations>, outer=<value temporarily unavailable, due
to optimizations>, inner_father=<value temporarily unavailable, due to
optimizations>) at ../../gcc-4.5-20091223/gcc/graphite-interchange.c:706
706       for (inner = 0; VEC_iterate (lst_p, LST_SEQ (inner_father), inner,
l); inner++)
(gdb) bt
#0  0x00000001005355c8 in lst_interchange_select_inner (scop=<value temporarily
unavailable, due to optimizations>, outer_father=<value temporarily
unavailable, due to optimizations>, outer=<value temporarily unavailable, due
to optimizations>, inner_father=<value temporarily unavailable, due to
optimizations>) at ../../gcc-4.5-20091223/gcc/graphite-interchange.c:706
#1  0x00000001005356de in lst_interchange_select_inner (scop=<value temporarily
unavailable, due to optimizations>, outer_father=<value temporarily
unavailable, due to optimizations>, outer=<value temporarily unavailable, due
to optimizations>, inner_father=<value temporarily unavailable, due to
optimizations>) at ../../gcc-4.5-20091223/gcc/graphite-interchange.c:684
#2  0x0000000100536996 in lst_interchange_select_outer (scop=0x14182d360,
loop=0x14185d390, outer=1) at
../../gcc-4.5-20091223/gcc/graphite-interchange.c:732
#3  0x0000000100536a01 in lst_interchange_select_outer (scop=0x14182d360,
loop=0x141831f80, outer=<value temporarily unavailable, due to optimizations>)
at ../../gcc-4.5-20091223/gcc/graphite-interchange.c:743
#4  0x0000000100536a01 in lst_interchange_select_outer (scop=0x14182d360,
loop=0x141831fa0, outer=<value temporarily unavailable, due to optimizations>)
at ../../gcc-4.5-20091223/gcc/graphite-interchange.c:743
#5  0x0000000100536a3e in scop_do_interchange (scop=0x14182d360) at
../../gcc-4.5-20091223/gcc/graphite-interchange.c:754
#6  0x0000000100537f98 in apply_poly_transforms (scop=0x14182d360) at
../../gcc-4.5-20091223/gcc/graphite-poly.c:260
#7  0x0000000100523873 in graphite_transform_loops () at
../../gcc-4.5-20091223/gcc/graphite.c:276
#8  0x00000001007c734a in graphite_transforms () at
../../gcc-4.5-20091223/gcc/tree-ssa-loop.c:300
#9  0x00000001006095ee in execute_one_pass (pass=0x100c7fda0) at
../../gcc-4.5-20091223/gcc/passes.c:1561
#10 0x00000001006098bd in execute_pass_list (pass=0x100c7fda0) at
../../gcc-4.5-20091223/gcc/passes.c:1616
#11 0x00000001006098cf in execute_pass_list (pass=0x100c7fb00) at
../../gcc-4.5-20091223/gcc/passes.c:1617
#12 0x00000001006098cf in execute_pass_list (pass=0x100c7f140) at
../../gcc-4.5-20091223/gcc/passes.c:1617
#13 0x0000000100738d58 in tree_rest_of_compilation (fndecl=0x141df1e00) at
../../gcc-4.5-20091223/gcc/tree-optimize.c:413
#14 0x00000001008f37f3 in cgraph_expand_function (node=<value temporarily
unavailable, due to optimizations>) at
../../gcc-4.5-20091223/gcc/cgraphunit.c:1544
#15 0x00000001008f66ea in cgraph_optimize () at
../../gcc-4.5-20091223/gcc/cgraphunit.c:1623
#16 0x00000001008f6ccd in cgraph_finalize_compilation_unit () at
../../gcc-4.5-20091223/gcc/cgraphunit.c:1093
#17 0x000000010059b8b6 in write_global_declarations () at
../../gcc-4.5-20091223/gcc/langhooks.c:309
#18 0x00000001006ce9c2 in toplev_main (argc=19, argv=0x7fff5fbfee70) at
../../gcc-4.5-20091223/gcc/toplev.c:1061
#19 0x0000000100001534 in start ()
(gdb) 

at r155434.

Using built-in specs.
COLLECT_GCC=gfortran
COLLECT_LTO_WRAPPER=/sw/lib/gcc4.5/libexec/gcc/x86_64-apple-darwin10.2.0/4.5.0/lto-wrapper
Target: x86_64-apple-darwin10.2.0
Configured with: ../gcc-4.5-20091223/configure --prefix=/sw
--prefix=/sw/lib/gcc4.5 --mandir=/sw/share/man --infodir=/sw/share/info
--enable-languages=c,c++,fortran,objc,obj-c++,java --with-gmp=/sw
--with-libiconv-prefix=/sw --with-ppl=/sw --with-cloog=/sw --with-mpc=/sw
--with-system-zlib --x-includes=/usr/X11R6/include --x-libraries=/usr/X11R6/lib
--disable-libjava-multilib
Thread model: posix
gcc version 4.5.0 20091223 (experimental) (GCC) 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42334

[Bug tree-optimization/42334] segfault in graphite-poly.h for 200.sixtrack

[burnus at gcc dot gnu dot org]

------- Comment #11 from burnus at gcc dot gnu dot org  2010-01-04 13:12 -------
(In reply to comment #9)
> On x86_64-apple-darwin10, the two new test cases are cause ICEs...
> FAIL: gfortran.dg/graphite/pr42334-1.f  -O  (internal compiler error)
> FAIL: gfortran.dg/graphite/pr42334-1.f  -O  (test for excess errors)
> FAIL: gfortran.dg/graphite/pr42393.f90  -O  (internal compiler error)
> FAIL: gfortran.dg/graphite/pr42393.f90  -O  (test for excess errors)

Same on my x86-64-linux system, except that I have also a failure for
  pr42334.f90 besides pr42334-1.f and pr42393.f90

 * * *

$ gfortran -c -O1 -floop-interchange -ftree-loop-distribution
gfortran.dg/graphite/pr42334.f90

gfortran.dg/graphite/pr42334.f90: In function 'blockdis':
gfortran.dg/graphite/pr42334.f90:3:0: internal compiler error: Segmentation
fault

#0  0x0000000000ce764f in VEC_lst_p_base_iterate (ptr=<value optimized out>,
ix_=<value optimized out>,
    vec_=<value optimized out>) at
/home/tob/projects/gcc-trunk-checkout/gcc/graphite-interchange.c:706


$ gfortran -c -O2 -floop-interchange gfortran.dg/graphite/pr42334-1.f

gfortran.dg/graphite/pr42334-1.f: In function 'linel':
gfortran.dg/graphite/pr42334-1.f:3:0: internal compiler error: Segmentation
fault

#0  0x0000000000ce76e7 in lst_try_interchange_loops (lst=<value optimized out>)
#1  lst_try_interchange (lst=<value optimized out>)
    at /home/tob/projects/gcc-trunk-checkout/gcc/graphite-interchange.c:677


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu dot
                   |                            |org
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42334

[Bug tree-optimization/42334] segfault in graphite-poly.h for 200.sixtrack

[dominiq at lps dot ens dot fr]

------- Comment #12 from dominiq at lps dot ens dot fr  2010-01-07 21:03 -------
On x86_64-apple-darwin10 at revision 155703 this PR seems fixed (most likely
revision 155701 for pr42178).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42334

[Bug tree-optimization/42334] segfault in graphite-poly.h for 200.sixtrack

[spop at gcc dot gnu dot org]

------- Comment #13 from spop at gcc dot gnu dot org  2010-01-07 21:32 -------
Yes, this is fixed by the patch for pr42178.

pr42393.f90 is still failing on amd64-linux, but we have a PR open for that
one, so I am closing this PR.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42334