[Bug fortran/42517] New: Bogus runtime error with -fopemp -fcheck=recursion

[Bug fortran/42517] New: Bogus runtime error with -fopemp -fcheck=recursion

[janus at gcc dot gnu dot org]

Consider this simple test case:

use omp_lib
implicit none
integer :: i

!$omp parallel do
do i=1,10
  call sub(i)
end do
!$omp end parallel do

contains

  subroutine sub (n)
    integer :: n
    print '(A,i3,A,i3)',"loop =",n," | thread =",omp_get_thread_num()
    call sleep(1)
  end subroutine

end


Compiling this with -fopenmp gives the expected results. But when adding
-fcheck=recursion, one gets a runtime error:

Fortran runtime error: Recursive call to nonrecursive procedure 'sub'

-fcheck=recursion is new in 4.5, therefore I'm not sure if one can call this a
regression. In any case this bug makes -fcheck=all unusable for OpenMP code.


-- 
           Summary: Bogus runtime error with -fopemp -fcheck=recursion
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Keywords: wrong-code, openmp
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: janus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42517

[Bug fortran/42517] Bogus runtime error with -fopenmp -fcheck=recursion

[janus at gcc dot gnu dot org]

------- Comment #1 from janus at gcc dot gnu dot org  2009-12-27 18:39 -------
An easy way to fix this is to simply disable the recursion check if -fopenmp is
given:

Index: gcc/fortran/trans-decl.c
===================================================================
--- gcc/fortran/trans-decl.c    (revision 155479)
+++ gcc/fortran/trans-decl.c    (working copy)
@@ -4318,7 +4318,8 @@ gfc_generate_function_code (gfc_namespace * ns)
    is_recursive = sym->attr.recursive
                  || (sym->attr.entry_master
                      && sym->ns->entries->sym->attr.recursive);
-   if ((gfc_option.rtcheck & GFC_RTCHECK_RECURSION) && !is_recursive)
+   if ((gfc_option.rtcheck & GFC_RTCHECK_RECURSION) && !is_recursive
+       && !gfc_option.flag_openmp)
      {
        char * msg;

@@ -4395,7 +4396,8 @@ gfc_generate_function_code (gfc_namespace * ns)
       gfc_add_expr_to_block (&block, tmp);

       /* Reset recursion-check variable.  */
-      if ((gfc_option.rtcheck & GFC_RTCHECK_RECURSION) && !is_recursive)
+      if ((gfc_option.rtcheck & GFC_RTCHECK_RECURSION) && !is_recursive
+         && !gfc_option.flag_openmp)
        {
          gfc_add_modify (&block, recurcheckvar, boolean_false_node);
          recurcheckvar = NULL;
@@ -4426,7 +4428,8 @@ gfc_generate_function_code (gfc_namespace * ns)
     {
       gfc_add_expr_to_block (&block, tmp);
       /* Reset recursion-check variable.  */
-      if ((gfc_option.rtcheck & GFC_RTCHECK_RECURSION) && !is_recursive)
+      if ((gfc_option.rtcheck & GFC_RTCHECK_RECURSION) && !is_recursive
+         && !gfc_option.flag_openmp)
       {
        gfc_add_modify (&block, recurcheckvar, boolean_false_node);
        recurcheckvar = NULL;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42517

[Bug fortran/42517] Bogus runtime error with -fopenmp -fcheck=recursion

[janus at gcc dot gnu dot org]

------- Comment #2 from janus at gcc dot gnu dot org  2009-12-29 19:30 -------
Subject: Bug 42517

Author: janus
Date: Tue Dec 29 19:29:54 2009
New Revision: 155506

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155506
Log:
gcc/fortran/
2009-12-29  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/42517
        * invoke.texi: Document the interference of
        -fcheck=recursion and -fopenmp.
        * trans-decl.c (gfc_generate_function_code): Disable -fcheck=recursion
        when used with -fopenmp.

gcc/testsuite/
2009-12-29  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/42517
        * gfortran.dg/gomp/recursion1.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/gomp/recursion1.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/invoke.texi
    trunk/gcc/fortran/trans-decl.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42517

[Bug fortran/42517] -fcheck=recursion does not work with -fopenmp

[janus at gcc dot gnu dot org]

------- Comment #3 from janus at gcc dot gnu dot org  2009-12-29 20:19 -------
The commit in comment #2 contains the patch in comment #1 and disables
recursion checking if -fopenmp is given.

In the long run, the checking should be modified so that it can work with
multiple threads. It has been suggested in
http://gcc.gnu.org/ml/fortran/2009-12/msg00201.html to do this via TLS.


-- 

janus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Bogus runtime error with -  |-fcheck=recursion does not
                   |fopenmp -fcheck=recursion   |work with -fopenmp


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42517

[Bug fortran/42517] -fcheck=recursion does not work with -fopenmp

[burnus at gcc dot gnu dot org]

------- Comment #4 from burnus at gcc dot gnu dot org  2010-01-04 07:31 -------
Subject: Bug 42517

Author: burnus
Date: Mon Jan  4 07:30:49 2010
New Revision: 155606

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155606
Log:
2009-01-04  Tobias Burnus  <burnus@net-b.de>

        PR fortran/41872
        * trans-expr.c (gfc_conv_procedure_call): Add indirect ref
        for functions returning allocatable scalars.
        * trans-stmt.c (gfc_trans_allocate): Emmit error when
        reallocating an allocatable scalar.
        * trans.c (gfc_allocate_with_status): Fix pseudocode syntax
        in comment.
        * trans-decl.c (gfc_trans_deferred_vars): Nullify local
        allocatable scalars.
        (gfc_generate_function_code): Nullify result variable for
        allocatable scalars.

        PR fortran/40849
        * module.c (gfc_use_module): Fix warning string to allow
        for translation.

        PR fortran/42517
        * invoke.texi (-fcheck=recursion): Mention that the checking
        is also disabled for -frecursive.
        * trans-decl.c (gfc_generate_function_code): Disable
        -fcheck=recursion when -frecursive is used.

        * intrinsic.texi (iso_c_binding): Improve wording.

2009-01-04  Tobias Burnus  <burnus@net-b.de>

        PR fortran/41872
        * gfortran.dg/allocatable_scalar_5.f90: New test.
        * gfortran.dg/allocatable_scalar_6.f90: New test.


Added:
    trunk/gcc/testsuite/gfortran.dg/allocatable_scalar_5.f90
    trunk/gcc/testsuite/gfortran.dg/allocatable_scalar_6.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/intrinsic.texi
    trunk/gcc/fortran/invoke.texi
    trunk/gcc/fortran/module.c
    trunk/gcc/fortran/trans-decl.c
    trunk/gcc/fortran/trans-expr.c
    trunk/gcc/fortran/trans-stmt.c
    trunk/gcc/fortran/trans.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42517

[Bug fortran/42517] -fcheck=recursion does not work with -fopenmp

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2010-01-04 14:22 -------
The testcase gfortran.dg/gomp/recursion1.f90 which was moved to
libgomp/testsuite/libgomp.fortran/recursion1.f90 now fails randomly,
see PR42602.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42517

[Bug fortran/42517] -fcheck=recursion does not work with -fopenmp

[burnus at gcc dot gnu dot org]

------- Comment #6 from burnus at gcc dot gnu dot org  2010-01-04 16:16 -------
Mark as fixed as:
- The issue of comment 0 is fixed
- PR42602 is fixed
- As -frecursion is already triggering it (cf. comment 4)
and as I do not see a need for a __THREAD version, cf. comment 3. If you see a
real need for the latter, please reopen.


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42517

[Bug fortran/42517] -fcheck=recursion does not work with -fopenmp

[bdavis at gcc dot gnu dot org]

------- Comment #7 from bdavis at gcc dot gnu dot org  2010-01-04 17:54 -------
Index: gcc/gcc/fortran/trans-decl.c
===================================================================
--- gcc/gcc/fortran/trans-decl.c        (revision 155625)
+++ gcc/gcc/fortran/trans-decl.c        (working copy)
@@ -4330,6 +4330,7 @@
                 sym->name);
        recurcheckvar = gfc_create_var (boolean_type_node, "is_recursive");
        TREE_STATIC (recurcheckvar) = 1;
+       DECL_TLS_MODEL (recurcheckvar) = decl_default_tls_model
(recurcheckvar);
        DECL_INITIAL (recurcheckvar) = boolean_false_node;
        gfc_add_expr_to_block (&block, recurcheckvar);
        gfc_trans_runtime_check (true, false, recurcheckvar, &block,


-- 

bdavis at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bdavis at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42517

[Bug fortran/42517] -fcheck=recursion does not work with -fopenmp

[hjl dot tools at gmail dot com]

------- Comment #8 from hjl dot tools at gmail dot com  2010-01-04 18:41 -------
The testcase failed at run-time. See PR 42602


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |42602
              nThis|                            |
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42517

[Bug fortran/42517] -fcheck=recursion does not work with -fopenmp

[hjl dot tools at gmail dot com]

------- Comment #9 from hjl dot tools at gmail dot com  2010-01-04 22:36 -------
(In reply to comment #8)
> The testcase failed at run-time. See PR 42602
> 

A patch is posted at

http://gcc.gnu.org/ml/gcc-patches/2010-01/msg00187.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42517

[Bug fortran/42517] -fcheck=recursion does not work with -fopenmp

[burnus at gcc dot gnu dot org]

------- Comment #10 from burnus at gcc dot gnu dot org  2010-01-05 14:15 -------
Subject: Bug 42517

Author: burnus
Date: Tue Jan  5 14:15:37 2010
New Revision: 155649

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155649
Log:
2010-01-05  Tobias Burnus  <burnus@net-b.de>

        PR fortran/42517
        * options.c (gfc_post_options): Set -frecursion
        when -fopenmp is used.


Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/options.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42517

[Bug fortran/42517] -fcheck=recursion does not work with -fopenmp

[dominiq at lps dot ens dot fr]

------- Comment #11 from dominiq at lps dot ens dot fr  2010-04-19 11:25 -------
Should not this PR closed as fixed?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42517

[Bug fortran/42517] -fcheck=recursion does not work with -fopenmp

[burnus at gcc dot gnu dot org]

------- Comment #12 from burnus at gcc dot gnu dot org  2010-04-21 12:25 -------
Close as FIXED. If someone feels strong about allowing -fcheck=recursion with
-fopenmp, please reopen. (I think as fopenmp implies -frecursive, it does not
make much sense.)


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42517