From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21442 invoked by alias); 6 Jan 2010 11:57:53 -0000 Received: (qmail 21391 invoked by uid 48); 6 Jan 2010 11:57:42 -0000 Date: Wed, 06 Jan 2010 11:57:00 -0000 Message-ID: <20100106115742.21390.qmail@sourceware.org> X-Bugzilla-Reason: CC References: Subject: [Bug libstdc++/17038] ABI impacting issue in time_put In-Reply-To: Reply-To: gcc-bugzilla@gcc.gnu.org To: gcc-bugs@gcc.gnu.org From: "paolo dot carlini at oracle dot com" Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2010-01/txt/msg00626.txt.bz2 ------- Comment #6 from paolo dot carlini at oracle dot com 2010-01-06 11:57 ------- Now the buffer is 128 chars. On second thought, I don't think checking the return value of strftime and all the added complexity are worth the trouble: given the semantics of the function and the actual data in existing named locales the maximum size is bounded and certainly <~ 200. Also note that there are no risks of memory corruption. If somebody reports a truncated output for some exotic locale, we'll increase the buffer a bit and everything will be fine. -- paolo dot carlini at oracle dot com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |WORKSFORME http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17038