[Bug target/38697] New: gcc.target/arm/neon/neon.exp tests for vmov fail on arm-linux-eabi

[Bug target/38697] New: gcc.target/arm/neon/neon.exp tests for vmov fail on arm-linux-eabi

[laurent at guerby dot net]

As shown on http://gcc.gnu.org/ml/gcc-testresults/2009-01/msg00092.html
neon tests scanning for vmov are failing on trunk:

FAIL: gcc.target/arm/neon/polytypes.c (test for excess errors)
FAIL: gcc.target/arm/neon/vget_lowf32.c scan-assembler vmov[ \\t]+[dD][0-9]+,
[dD][0-9]+!?([ \\t]+@[a-zA-Z0-9 ]+)?\\n
FAIL: gcc.target/arm/neon/vget_lowp16.c scan-assembler vmov[ \\t]+[dD][0-9]+,
[dD][0-9]+!?([ \\t]+@[a-zA-Z0-9 ]+)?\\n
FAIL: gcc.target/arm/neon/vget_lowp8.c scan-assembler vmov[ \\t]+[dD][0-9]+,
[dD][0-9]+!?([ \\t]+@[a-zA-Z0-9 ]+)?\\n
FAIL: gcc.target/arm/neon/vget_lows16.c scan-assembler vmov[ \\t]+[dD][0-9]+,
[dD][0-9]+!?([ \\t]+@[a-zA-Z0-9 ]+)?\\n
FAIL: gcc.target/arm/neon/vget_lows32.c scan-assembler vmov[ \\t]+[dD][0-9]+,
[dD][0-9]+!?([ \\t]+@[a-zA-Z0-9 ]+)?\\n
FAIL: gcc.target/arm/neon/vget_lows64.c scan-assembler vmov[ \\t]+[dD][0-9]+,
[dD][0-9]+!?([ \\t]+@[a-zA-Z0-9 ]+)?\\n
FAIL: gcc.target/arm/neon/vget_lows8.c scan-assembler vmov[ \\t]+[dD][0-9]+,
[dD][0-9]+!?([ \\t]+@[a-zA-Z0-9 ]+)?\\n
FAIL: gcc.target/arm/neon/vget_lowu16.c scan-assembler vmov[ \\t]+[dD][0-9]+,
[dD][0-9]+!?([ \\t]+@[a-zA-Z0-9 ]+)?\\n
FAIL: gcc.target/arm/neon/vget_lowu32.c scan-assembler vmov[ \\t]+[dD][0-9]+,
[dD][0-9]+!?([ \\t]+@[a-zA-Z0-9 ]+)?\\n
FAIL: gcc.target/arm/neon/vget_lowu64.c scan-assembler vmov[ \\t]+[dD][0-9]+,
[dD][0-9]+!?([ \\t]+@[a-zA-Z0-9 ]+)?\\n
FAIL: gcc.target/arm/neon/vget_lowu8.c scan-assembler vmov[ \\t]+[dD][0-9]+,
[dD][0-9]+!?([ \\t]+@[a-zA-Z0-9 ]+)?\\n

Looking at one of the assembly generated vmov is indeed not there:

guerby@gcc50:~$ cat  vget_lowf32.s
        .cpu arm10tdmi
        .eabi_attribute 27, 3
        .fpu neon
        .eabi_attribute 20, 1
        .eabi_attribute 21, 1
        .eabi_attribute 23, 3
        .eabi_attribute 24, 1
        .eabi_attribute 25, 1
        .eabi_attribute 26, 2
        .eabi_attribute 30, 6
        .eabi_attribute 18, 4
        .file   "vget_lowf32.c"
        .text
        .align  2
        .global test_vget_lowf32
        .type   test_vget_lowf32, %function
test_vget_lowf32:
        @ args = 0, pretend = 0, frame = 24
        @ frame_needed = 1, uses_anonymous_args = 0
        @ link register save eliminated.
        str     fp, [sp, #-4]!
        add     fp, sp, #0
        sub     sp, sp, #28
        vldr    d16, [fp, #-20]
        vldr    d17, [fp, #-12]
        fstd    d16, [fp, #-28]
        add     sp, fp, #0
        ldmfd   sp!, {fp}
        bx      lr
        .size   test_vget_lowf32, .-test_vget_lowf32
        .ident  "GCC: (GNU) 4.4.0 20081231 (experimental) [trunk revision
142984]"
        .section        .note.GNU-stack,"",%progbits

My configure:

../trunk/configure --prefix=/n/50/guerby/install-trunk-142984
--enable-languages=c --enable-__cxa_atexit --disable-nls --enable-threads=posix
--with-mpfr=/opt/cfarm/mpfr-2.3.2 --build=arm-linux-gnueabi
--host=arm-linux-gnueabi --target=arm-linux-gnueabi
--enable-stage1-checking=release

My host/build/target:

guerby@gcc50:~$ cat /proc/cpuinfo 
Processor       : XScale-80219 rev 0 (v5l)
BogoMIPS        : 593.10
Features        : swp half thumb fastmult edsp 
CPU implementer : 0x69
CPU architecture: 5TE
CPU variant     : 0x0
CPU part        : 0x2e3
CPU revision    : 0
Cache type      : undefined 5
Cache clean     : undefined 5
Cache lockdown  : undefined 5
Cache format    : Harvard
I size          : 32768
I assoc         : 32
I line length   : 32
I sets          : 32
D size          : 32768
D assoc         : 32
D line length   : 32
D sets          : 32

Hardware        : Thecus N2100
Revision        : 0000
Serial          : 0000000000000000


-- 
           Summary: gcc.target/arm/neon/neon.exp tests for vmov fail on arm-
                    linux-eabi
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: laurent at guerby dot net
 GCC build triplet: arm-linux-gnueabi
  GCC host triplet: arm-linux-gnueabi
GCC target triplet: arm-linux-gnueabi


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38697

[Bug target/38697] gcc.target/arm/neon/neon.exp tests for vmov fail on arm-linux-eabi

[laurent at guerby dot net]

------- Comment #1 from laurent at guerby dot net  2009-01-02 13:43 -------
Forgot the compile line used:

/home/guerby/build-142984/gcc/xgcc -B/home/guerby/build-142984/gcc/  
-save-temps -O0 -mfpu=neon -mfloat-abi=softfp -c  -o vget_lowf32.o
/home/guerby/trunk/gcc/testsuite/gcc.target/arm/neon/vget_lowf32.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38697

[Bug target/38697] gcc.target/arm/neon/neon.exp tests for vmov fail on arm-linux-eabi

[danglin at gcc dot gnu dot org]

------- Comment #2 from danglin at gcc dot gnu dot org  2009-02-03 20:53 -------
I also see this.  Also seen with 4.3.3.


-- 

danglin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-02-03 20:53:06
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38697

[Bug target/38697] gcc.target/arm/neon/neon.exp tests for vmov fail on arm-linux-eabi

[jules at gcc dot gnu dot org]

------- Comment #3 from jules at gcc dot gnu dot org  2009-03-11 20:47 -------
These failures show up because the tests are kind of weak. There's no
particular reason that vget_low* intrinsics should generate vmov instructions
as the tests are expecting: the assembly output shown with vldr/fstd works just
as well, and no instructions at all (i.e. just a hint to the register
allocator) would work even better.

Without converting all the Neon intrinsic tests to be execution rather than
compilation tests, I'm not sure if there's any way they can be made robust.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38697

[Bug target/38697] gcc.target/arm/neon/neon.exp tests for vmov fail on arm-linux-eabi

[joseph at codesourcery dot com]

------- Comment #4 from joseph at codesourcery dot com  2009-03-11 22:43 -------
Subject: Re:  gcc.target/arm/neon/neon.exp tests for vmov
 fail on arm-linux-eabi

On Wed, 11 Mar 2009, jules at gcc dot gnu dot org wrote:

> These failures show up because the tests are kind of weak. There's no
> particular reason that vget_low* intrinsics should generate vmov instructions
> as the tests are expecting: the assembly output shown with vldr/fstd works just
> as well, and no instructions at all (i.e. just a hint to the register
> allocator) would work even better.

That's the move intrinsic tests.  I think polytypes.c is because of 
additional diagnostics added at some point for which target-independent 
tests were updated but not all target-specific tests (i.e., the testcase 
needs updating for the current front-end diagnostics).  Unlike the move 
instrinsics tests polytypes.c is not an automatically generated file, so 
should be straightforward for anyone to fix.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38697

[Bug target/38697] gcc.target/arm/neon/neon.exp tests for vmov fail on arm-linux-eabi

[laurent at guerby dot net]

------- Comment #5 from laurent at guerby dot net  2009-03-11 22:58 -------
If it's too hard to make the test work reliably, may be just XFAIL them or
deactivate them until someone comes up with a more reliable way?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38697

[Bug target/38697] gcc.target/arm/neon/neon.exp tests for vmov fail on arm-linux-eabi

[laurent at guerby dot net]

------- Comment #6 from laurent at guerby dot net  2009-12-08 22:41 -------
Note: armv7l 4.4.2 also fails:

http://gcc.gnu.org/ml/gcc-testresults/2009-12/msg00749.html

Discussions on the topic.

http://gcc.gnu.org/ml/gcc-patches/2009-08/msg01495.html

Doug?


-- 

laurent at guerby dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laurent at guerby dot net,
                   |                            |dougkwan at google dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38697

[Bug target/38697] gcc.target/arm/neon/neon.exp tests for vmov fail on arm-linux-eabi

[ramana at gcc dot gnu dot org]

------- Comment #7 from ramana at gcc dot gnu dot org  2010-01-09 16:48 -------
Patch submitted here. 

http://gcc.gnu.org/ml/gcc-patches/2010-01/msg00438.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38697

[Bug target/38697] gcc.target/arm/neon/neon.exp tests for vmov fail on arm-linux-eabi

[ramana at gcc dot gnu dot org]

------- Comment #8 from ramana at gcc dot gnu dot org  2010-01-19 14:21 -------
Subject: Bug 38697

Author: ramana
Date: Tue Jan 19 14:21:14 2010
New Revision: 156042

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=156042
Log:
Fix target/38697

2010-01-19  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>

       PR target/38697
       * config/arm/neon-testgen.m (emit_automatics): New parameter
        features. Adjust for Fixed_return_reg feature.
        (test_intrinsic): Call emit_automatics with new feature.
       * config/arm/neon.ml: Update copyright years.
        (features): New Fixed_return_reg feature.
        (ops): Update feature for Vget_low.

2010-01-19  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>

        PR target/38697.
        * gcc.target/arm/neon/vget_lowf32.c: Regenerate.
        * gcc.target/arm/neon/vget_lowp16.c: Likewise.
        * gcc.target/arm/neon/vget_lowp8.c:  Likewise.
        * gcc.target/arm/neon/vget_lows16.c: Likewise.
        * gcc.target/arm/neon/vget_lows32.c: Likewise.
        * gcc.target/arm/neon/vget_lows64.c: Likewise.
        * gcc.target/arm/neon/vget_lows8.c: Likewise.
        * gcc.target/arm/neon/vget_lowu16.c: Likewise.
        * gcc.target/arm/neon/vget_lowu32.c: Likewise.
        * gcc.target/arm/neon/vget_lowu64.c: Likewise.
        * gcc.target/arm/neon/vget_lowu8.c: Likewise.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/neon-testgen.ml
    trunk/gcc/config/arm/neon.ml
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.target/arm/neon/vget_lowf32.c
    trunk/gcc/testsuite/gcc.target/arm/neon/vget_lowp16.c
    trunk/gcc/testsuite/gcc.target/arm/neon/vget_lowp8.c
    trunk/gcc/testsuite/gcc.target/arm/neon/vget_lows16.c
    trunk/gcc/testsuite/gcc.target/arm/neon/vget_lows32.c
    trunk/gcc/testsuite/gcc.target/arm/neon/vget_lows64.c
    trunk/gcc/testsuite/gcc.target/arm/neon/vget_lows8.c
    trunk/gcc/testsuite/gcc.target/arm/neon/vget_lowu16.c
    trunk/gcc/testsuite/gcc.target/arm/neon/vget_lowu32.c
    trunk/gcc/testsuite/gcc.target/arm/neon/vget_lowu64.c
    trunk/gcc/testsuite/gcc.target/arm/neon/vget_lowu8.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38697

[Bug target/38697] gcc.target/arm/neon/neon.exp tests for vmov fail on arm-linux-eabi

[ramana at gcc dot gnu dot org]

------- Comment #9 from ramana at gcc dot gnu dot org  2010-01-25 12:29 -------
Subject: Bug 38697

Author: ramana
Date: Mon Jan 25 12:29:25 2010
New Revision: 156206

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=156206
Log:
Backport target/38697

       Backport from trunk.

       2010-01-19  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
       PR target/38697
       * config/arm/neon-testgen.m (emit_automatics): New parameter
        features. Adjust for Fixed_return_reg feature.
        (test_intrinsic): Call emit_automatics with new feature.
       * config/arm/neon.ml: Update copyright years.
        (features): New Fixed_return_reg feature.
        (ops): Update feature for Vget_low.

        Backport from mainline.
        2010-01-19  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>

        PR target/38697.
        * gcc.target/arm/neon/vget_lowf32.c: Regenerate.
        * gcc.target/arm/neon/vget_lowp16.c: Likewise.
        * gcc.target/arm/neon/vget_lowp8.c:  Likewise.
        * gcc.target/arm/neon/vget_lows16.c: Likewise.
        * gcc.target/arm/neon/vget_lows32.c: Likewise.
        * gcc.target/arm/neon/vget_lows64.c: Likewise.
        * gcc.target/arm/neon/vget_lows8.c: Likewise.
        * gcc.target/arm/neon/vget_lowu16.c: Likewise.
        * gcc.target/arm/neon/vget_lowu32.c: Likewise.
        * gcc.target/arm/neon/vget_lowu64.c: Likewise.
        * gcc.target/arm/neon/vget_lowu8.c: Likewise.


Modified:
    branches/gcc-4_4-branch/   (props changed)
    branches/gcc-4_4-branch/gcc/ChangeLog
    branches/gcc-4_4-branch/gcc/config/arm/neon-testgen.ml
    branches/gcc-4_4-branch/gcc/config/arm/neon.ml
    branches/gcc-4_4-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_4-branch/gcc/testsuite/gcc.target/arm/neon/vget_lowf32.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.target/arm/neon/vget_lowp16.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.target/arm/neon/vget_lowp8.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.target/arm/neon/vget_lows16.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.target/arm/neon/vget_lows32.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.target/arm/neon/vget_lows64.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.target/arm/neon/vget_lows8.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.target/arm/neon/vget_lowu16.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.target/arm/neon/vget_lowu32.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.target/arm/neon/vget_lowu64.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.target/arm/neon/vget_lowu8.c

Propchange: branches/gcc-4_4-branch/
            ('svn:mergeinfo' added)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38697

[Bug target/38697] gcc.target/arm/neon/neon.exp tests for vmov fail on arm-linux-eabi

[ramana at gcc dot gnu dot org]

------- Comment #10 from ramana at gcc dot gnu dot org  2010-01-25 12:30 -------
Fixed on branch .


-- 

ramana at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.4.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38697