[Bug c/42667] New: internal compiler error: in insert_into_preds_of_block, at tree-ssa-pre.c:3146

[Bug c/42667] New: internal compiler error: in insert_into_preds_of_block, at tree-ssa-pre.c:3146

[jerstlouis at gmail dot com]

Compile this with -O2 -m32:

extern int strlen(const char *);
void WriteTextDots(int len);

void OnDisplay(char * string)
{
   if(!string) string = "(none)";
   WriteTextDots(strlen(string));
}


-- 
           Summary: internal compiler error: in insert_into_preds_of_block,
                    at tree-ssa-pre.c:3146
           Product: gcc
           Version: 4.4.1
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jerstlouis at gmail dot com
  GCC host triplet: x86_64-linux-gnu
GCC target triplet: i686-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42667

[Bug c/42667] internal compiler error: in insert_into_preds_of_block, at tree-ssa-pre.c:3146

[jerstlouis at gmail dot com]

------- Comment #1 from jerstlouis at gmail dot com  2010-01-09 06:08 -------
Created an attachment (id=19516)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19516&action=view)
test case


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42667

[Bug c/42667] [4.4/4.5 Regression] internal compiler error: in insert_into_preds_of_block, at tree-ssa-pre.c:3146

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2010-01-09 11:25 -------
Confirmed.

We arrive at PRE with

OnDisplay (char * string)
{
  int D.1959;

<bb 2>:
  if (string_2(D) == 0B)
    goto <bb 5>;
  else
    goto <bb 3>;

<bb 5>:
  goto <bb 4>;

<bb 3>:

<bb 4>:
  # string_1 = PHI <string_2(D)(3), &"(none)"[0](5)>
  D.1959_4 = strlen (string_1);
  WriteTextDots (D.1959_4);
  return;


note the missing conversion on the strlen return value assignment which
misses already from the original frontend trees.  This is because the
builtin strlen has a proper prototype which is overridden by the
invalid prototype

  extern int strlen(const char *);

The PRE assert might look overeager here, but really only the missing
gimple type verification saves us (I guess I didn't add that just because
of similar issues).


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |ice-on-invalid-code
      Known to fail|                            |4.4.2 4.5.0
      Known to work|                            |4.3.4
   Last reconfirmed|0000-00-00 00:00:00         |2010-01-09 11:25:00
               date|                            |
            Summary|internal compiler error: in |[4.4/4.5 Regression]
                   |insert_into_preds_of_block, |internal compiler error: in
                   |at tree-ssa-pre.c:3146      |insert_into_preds_of_block,
                   |                            |at tree-ssa-pre.c:3146
   Target Milestone|---                         |4.4.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42667

[Bug middle-end/42667] [4.4/4.5 Regression] internal compiler error: in insert_into_preds_of_block, at tree-ssa-pre.c:3146

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2010-01-09 12:07 -------
Actually it might be subtly different.  Yep, it's a bug in folding.

Mine.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
          Component|c                           |middle-end
   Last reconfirmed|2010-01-09 11:25:00         |2010-01-09 12:07:24
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42667

[Bug middle-end/42667] [4.4/4.5 Regression] internal compiler error: in insert_into_preds_of_block, at tree-ssa-pre.c:3146

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2010-01-10 19:37 -------
Subject: Bug 42667

Author: rguenth
Date: Sun Jan 10 19:37:45 2010
New Revision: 155791

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155791
Log:
2010-01-10  Richard Guenther  <rguenther@suse.de>

        PR middle-end/42667
        * builtins.c (fold_builtin_strlen): Add type argument and
        convert the resulting length to it.
        (fold_builtin_1): Adjust.

        * gcc.dg/torture/pr42667.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.dg/torture/pr42667.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/builtins.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42667

[Bug middle-end/42667] [4.4 Regression] internal compiler error: in insert_into_preds_of_block, at tree-ssa-pre.c:3146

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2010-01-10 19:39 -------
Fixed for 4.5 sofar.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|rguenth at gcc dot gnu dot  |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|ASSIGNED                    |NEW
      Known to fail|4.4.2 4.5.0                 |4.4.2
      Known to work|4.3.4                       |4.3.4 4.5.0
            Summary|[4.4/4.5 Regression]        |[4.4 Regression] internal
                   |internal compiler error: in |compiler error: in
                   |insert_into_preds_of_block, |insert_into_preds_of_block,
                   |at tree-ssa-pre.c:3146      |at tree-ssa-pre.c:3146


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42667

[Bug middle-end/42667] [4.4 Regression] internal compiler error: in insert_into_preds_of_block, at tree-ssa-pre.c:3146

[jakub at gcc dot gnu dot org]

------- Comment #6 from jakub at gcc dot gnu dot org  2010-01-13 18:25 -------
Created an attachment (id=19579)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19579&action=view)
gcc44-pr42667.patch

This backport works for me on 4.4 branch, going to bootstrap/regtest it now.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42667

[Bug middle-end/42667] [4.4 Regression] internal compiler error: in insert_into_preds_of_block, at tree-ssa-pre.c:3146

[jakub at gcc dot gnu dot org]

------- Comment #7 from jakub at gcc dot gnu dot org  2010-01-14 09:46 -------
Subject: Bug 42667

Author: jakub
Date: Thu Jan 14 09:46:04 2010
New Revision: 155886

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155886
Log:
        Backport from mainline
        2010-01-10  Richard Guenther  <rguenther@suse.de>

        PR middle-end/42667
        * builtins.c (fold_builtin_strlen): Add type argument and
        convert the resulting length to it.
        (fold_builtin_1): Adjust.

        * gcc.dg/torture/pr42667.c: New testcase.

Added:
    branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/torture/pr42667.c
Modified:
    branches/gcc-4_4-branch/gcc/ChangeLog
    branches/gcc-4_4-branch/gcc/builtins.c
    branches/gcc-4_4-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42667

[Bug middle-end/42667] [4.4 Regression] internal compiler error: in insert_into_preds_of_block, at tree-ssa-pre.c:3146

[jakub at gcc dot gnu dot org]

------- Comment #8 from jakub at gcc dot gnu dot org  2010-01-14 12:09 -------
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42667