public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jvdelisle at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/42684] [4.5 Regression] ICE when interface operator(xx) available through host and use assoc in module procedure
Date: Wed, 13 Jan 2010 04:23:00 -0000	[thread overview]
Message-ID: <20100113042333.18688.qmail@sourceware.org> (raw)
In-Reply-To: <bug-42684-17837@http.gcc.gnu.org/bugzilla/>



------- Comment #6 from jvdelisle at gcc dot gnu dot org  2010-01-13 04:23 -------
Regression testing with the following patch passes.  I used p->sym->name
instead of q->sym->name in place of NULL, but I do not think it matters.

Index: interface.c
===================================================================
--- interface.c (revision 155799)
+++ interface.c (working copy)
@@ -1126,7 +1126,7 @@
        if (p->sym->name == q->sym->name && p->sym->module == q->sym->module)
          continue;

-       if (gfc_compare_interfaces (p->sym, q->sym, NULL, generic_flag, 0,
+       if (gfc_compare_interfaces (p->sym, q->sym, p->sym->name, generic_flag,
0,
                                    NULL, 0))
          {
            if (referenced)

and allows operator.f90 to compile as well as the test case in PR42680.

I think this does it.  I will submit to list for approval.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42684


  parent reply	other threads:[~2010-01-13  4:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-10 23:19 [Bug fortran/42684] New: " ian_harvey at bigpond dot com
2010-01-10 23:21 ` [Bug fortran/42684] " ian_harvey at bigpond dot com
2010-01-11  1:56 ` ian_harvey at bigpond dot com
2010-01-11  2:54 ` jvdelisle at gcc dot gnu dot org
2010-01-11  8:32 ` [Bug fortran/42684] [4.5 Regression] " burnus at gcc dot gnu dot org
2010-01-11  8:50 ` dominiq at lps dot ens dot fr
2010-01-13  3:14 ` jvdelisle at gcc dot gnu dot org
2010-01-13  4:23 ` jvdelisle at gcc dot gnu dot org [this message]
2010-01-13  4:24 ` jvdelisle at gcc dot gnu dot org
2010-01-14  3:07 ` jvdelisle at gcc dot gnu dot org
2010-01-14 16:39 ` rguenth at gcc dot gnu dot org
2010-01-15  1:48 ` jvdelisle at gcc dot gnu dot org
2010-01-15  2:06 ` jvdelisle at gcc dot gnu dot org
2010-01-15  2:07 ` jvdelisle at gcc dot gnu dot org
2010-02-07  4:47 ` hjl at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100113042333.18688.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).