[Bug tree-optimization/42732] New: ICE: verify_ssa failed

[Bug tree-optimization/42732] New: ICE: verify_ssa failed

[rguenth at gcc dot gnu dot org]

The fix for PR42521 produces an ICE in 434.zeusmp:

+ /home/seb/gcc/graphite/usr/bin/gfortran -c -g -O2 -DSPEC_CPU_LP64 -o pdv_d.o
pdv_d.f
pdv_d.f: In function pdv_d:
pdv_d.f:89:0: error: definition in block 40 does not dominate use in block 212
for SSA_NAME: prephitmp.28_439 in statement:
D.2771_606 = D.2770_605 <= prephitmp.28_439;
pdv_d.f:89:0: internal compiler error: verify_ssa failed
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

This is the reduced testcase:

      parameter(in =           128+5
     &        , jn =           128+5
     &        , kn =           128+5)
      real*8   d (in,jn,kn)
       real*8 dcopy(in,jn,kn)
       call pdv (is, dcopy)
       do k=ks,ke
         do j=je+1,je+2
           do i=is-2,ie+2
             dcopy(i,j,k) = d(i,j,k)
           enddo
         enddo
       enddo
       do k=ks,ke
         do j=js,je
           do i=is-2,is-1
             dcopy(i,j,k) = d(i,j,k)
           enddo
         enddo
       enddo
       end


-- 
           Summary: ICE: verify_ssa failed
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rguenth at gcc dot gnu dot org
OtherBugsDependingO 42521
             nThis:


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42732

[Bug tree-optimization/42732] ICE: verify_ssa failed

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2010-01-13 17:36 -------
Confirmed with -fgraphite-identity added.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-01-13 17:36:09
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42732

[Bug tree-optimization/42732] [graphite] ICE: verify_ssa failed

[spop at gcc dot gnu dot org]

------- Comment #2 from spop at gcc dot gnu dot org  2010-01-13 19:01 -------
> pdv_d.f:89:0: error: definition in block 40 does not dominate use in block 212
> for SSA_NAME: prephitmp.28_439 in statement:
> D.2771_606 = D.2770_605 <= prephitmp.28_439;

The error comes from the fact that we are not clearing the scev
information anymore in between the code generation of two scops.

In this particular case, we have two scops, the second scop contains a
loop for which the number of iterations is a variable computed in the
first scop, and because we do not update the niter/scev info we keep
referring to the old SSA_NAME, prephitmp.28_439.

A solution would be to rename all the scev info based on the
rename_map that is computed by the translation of the first scop.

I am working on a patch to do that.

Sebastian


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |spop at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2010-01-13 17:36:09         |2010-01-13 19:01:20
               date|                            |
            Summary|ICE: verify_ssa failed      |[graphite] ICE: verify_ssa
                   |                            |failed


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42732

[Bug tree-optimization/42732] [4.5 Regression] [graphite] ICE: verify_ssa failed

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
            Summary|[graphite] ICE: verify_ssa  |[4.5 Regression] [graphite]
                   |failed                      |ICE: verify_ssa failed
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42732

[Bug tree-optimization/42732] [4.5 Regression] [graphite] ICE: verify_ssa failed

[spop at gcc dot gnu dot org]

------- Comment #3 from spop at gcc dot gnu dot org  2010-01-14 06:40 -------
Subject: Bug 42732

Author: spop
Date: Thu Jan 14 06:40:33 2010
New Revision: 155879

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155879
Log:
Fix PR42732.

2010-01-14  Sebastian Pop  <sebastian.pop@amd.com>

        PR middle-end/42732
        * graphite-clast-to-gimple.c (gloog): Call scev_reset_htab and
        rename_nb_iterations.
        * sese.c (rename_variables_in_operand): New.
        (rename_variables_in_expr): New.
        (rename_nb_iterations): New.
        (sese_adjust_liveout_phis): Update the rename_map.
        * sese.h (rename_nb_iterations): Declared.
        * tree-scalar-evolution.c (scev_reset_htab): New.
        (scev_reset): Call scev_reset_htab.
        * tree-scalar-evolution.h (scev_reset_htab): Declared.

        * testsuite/gfortran.dg/graphite/pr42732.f: New.

Added:
    branches/graphite/gcc/testsuite/gfortran.dg/graphite/pr42732.f
Modified:
    branches/graphite/gcc/ChangeLog.graphite
    branches/graphite/gcc/graphite-clast-to-gimple.c
    branches/graphite/gcc/sese.c
    branches/graphite/gcc/sese.h
    branches/graphite/gcc/tree-scalar-evolution.c
    branches/graphite/gcc/tree-scalar-evolution.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42732

[Bug tree-optimization/42732] [4.5 Regression] [graphite] ICE: verify_ssa failed

[spop at gcc dot gnu dot org]

------- Comment #4 from spop at gcc dot gnu dot org  2010-01-14 07:38 -------
Subject: Bug 42732

Author: spop
Date: Thu Jan 14 07:38:15 2010
New Revision: 155881

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155881
Log:
Fix PR42732.

2010-01-14  Sebastian Pop  <sebastian.pop@amd.com>

        PR middle-end/42732
        * graphite-clast-to-gimple.c (gloog): Call scev_reset_htab and
        rename_nb_iterations.
        * sese.c (rename_variables_in_operand): New.
        (rename_variables_in_expr): New.
        (rename_nb_iterations): New.
        (sese_adjust_liveout_phis): Update the rename_map.
        * sese.h (rename_nb_iterations): Declared.
        * tree-scalar-evolution.c (scev_reset_htab): New.
        (scev_reset): Call scev_reset_htab.
        * tree-scalar-evolution.h (scev_reset_htab): Declared.

        * testsuite/gfortran.dg/graphite/pr42732.f: New.

Added:
    trunk/gcc/testsuite/gfortran.dg/graphite/pr42732.f
Modified:
    trunk/gcc/ChangeLog.graphite
    trunk/gcc/graphite-clast-to-gimple.c
    trunk/gcc/sese.c
    trunk/gcc/sese.h
    trunk/gcc/tree-scalar-evolution.c
    trunk/gcc/tree-scalar-evolution.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42732

[Bug tree-optimization/42732] [4.5 Regression] [graphite] ICE: verify_ssa failed

[spop at gcc dot gnu dot org]

------- Comment #5 from spop at gcc dot gnu dot org  2010-01-14 07:39 -------
Fixed.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42732