public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "burnus at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/42858] [4.5 Regression] ICE in gfc_array_dimen_size at ../../trunk/gcc/fortran/array.c:2063
Date: Mon, 25 Jan 2010 09:37:00 -0000	[thread overview]
Message-ID: <20100125093746.26766.qmail@sourceware.org> (raw)
In-Reply-To: <bug-42858-6318@http.gcc.gnu.org/bugzilla/>



------- Comment #4 from burnus at gcc dot gnu dot org  2010-01-25 09:37 -------
(In reply to comment #3)
> This appears to fix this: regression tested on x86-64

I think the following patch is better. My intrinsic check was bogus.

Index: array.c
===================================================================
--- array.c     (revision 156196)
+++ array.c     (working copy)
@@ -2054,7 +2054,7 @@ gfc_array_dimen_size (gfc_expr *array, i
        }

       if (array->symtree->n.sym->attr.generic
-         && !array->symtree->n.sym->attr.intrinsic)
+         && array->value.function.esym != NULL)
        {
          if (spec_dimen_size (array->value.function.esym->as, dimen, result)
              == FAILURE)


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |burnus at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2010-01-25 01:18:04         |2010-01-25 09:37:46
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42858


  parent reply	other threads:[~2010-01-25  9:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-24 22:35 [Bug fortran/42858] New: " anlauf at gmx dot de
2010-01-24 22:36 ` [Bug fortran/42858] " anlauf at gmx dot de
2010-01-24 23:15 ` dominiq at lps dot ens dot fr
2010-01-25  1:18 ` jvdelisle at gcc dot gnu dot org
2010-01-25  9:37 ` burnus at gcc dot gnu dot org [this message]
2010-01-25 16:22 ` burnus at gcc dot gnu dot org
2010-01-25 16:25 ` burnus at gcc dot gnu dot org
2010-02-07  4:48 ` hjl at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100125093746.26766.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).