[Bug tree-optimization/42771] New: [4.5 Regression] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[Bug tree-optimization/42771] New: [4.5 Regression] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[zsojka at seznam dot cz]

The original, unreduced, testcase from pr42521 started crashing again, with the
same error message. Only little modification to the reduced testcase is needed
to reproduce it.

Command line:
gcc -O3 -fgraphite-identity -c testcase.c

Tested revisions (x86_64):
r155945 - crash (x86)
r155938 - crash
r155902 - crash
- r155881 - pr42732 fix (can be related)
r155844 - OK (x86)
r155833 - OK
- r155728 - pr42521 fix
r155363 - crash

Output:
$ /mnt/svn/gcc-trunk/binary-155945-x86-lto/bin/gcc -O3 -fgraphite-identity -c
testcase.c
testcase.c: In function 'foo':
testcase.c:5:6: internal compiler error: in graphite_loop_normal_form, at
graphite-sese-to-poly.c:2844
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

Valgrind:
no errors reported


-- 
           Summary: [4.5 Regression] ICE: in graphite_loop_normal_form, at
                    graphite-sese-to-poly.c (2)
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: zsojka at seznam dot cz
  GCC host triplet: x86(_64)-pc-linux-gnu
GCC target triplet: x86(_64)-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771

[Bug tree-optimization/42771] [4.5 Regression] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[zsojka at seznam dot cz]

------- Comment #1 from zsojka at seznam dot cz  2010-01-16 22:03 -------
Created an attachment (id=19628)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19628&action=view)
original, unreduced testcase (from ffmpeg sources)

Command line:
gcc -O3 -fgraphite-identity -c aes.i


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771

[Bug tree-optimization/42771] [4.5 Regression] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[zsojka at seznam dot cz]

------- Comment #2 from zsojka at seznam dot cz  2010-01-16 22:05 -------
Created an attachment (id=19629)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19629&action=view)
reduced testcase

The only difference to the pr42521 testcase is added declaration of and call to
bar()

Command line:
gcc -O3 -fgraphite-identity -c pr42771.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771

[Bug tree-optimization/42771] [4.5 Regression] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771

[Bug tree-optimization/42771] [4.5 Regression] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[hjl dot tools at gmail dot com]

------- Comment #3 from hjl dot tools at gmail dot com  2010-01-16 22:36 -------
It is caused by the new implementation of Graphite:

http://gcc.gnu.org/ml/gcc-cvs/2009-07/msg01187.html


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-01-16 22:36:03
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771

[Bug tree-optimization/42771] [4.5 Regression] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771

[Bug tree-optimization/42771] [4.5 Regression] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[uramakrishna at gmail dot com]

------- Comment #4 from uramakrishna at gmail dot com  2010-01-25 16:30 -------
Created an attachment (id=19704)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19704&action=view)
A further reduced case to show the ICE

Unable to find non-zero value for 'known_niter'.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771

[Bug tree-optimization/42771] [4.5 Regression] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[amonakov at gcc dot gnu dot org]

------- Comment #5 from amonakov at gcc dot gnu dot org  2010-01-25 17:06 -------
We fail to find number of iterations after rewriting reductions out of SSA. 
Before graphite pass, IR looks like (for the previous testcase, "pr42771.c"):

<bb 9>:
  # j_26 = PHI <j_20(10)>

<bb 10>:
  # j_33 = PHI <j_26(9), 1(16)>
  D.2747_16 = B[j_33][0];
  D.2748_17 = j_33 + -1;
  D.2749_18 = B[D.2748_17][0];
  D.2750_19 = D.2749_18 ^ D.2747_16;
  B[j_33][0] = D.2750_19;
  j_20 = j_33 + 1;
  if (jm_14(D) > j_20)
    goto <bb 9>;
  else
    goto <bb 11>;

At the time of the ICE, IR is transformed to
(gdb) call debug_loop(use_loop, 3)
loop_3 (header = 10, latch = 9, niter = (unsigned int) jm_14(D) + 4294967294,
upper_bound = 2147483646)
{
  bb_9 (preds = {bb_10 }, succs = {bb_10 })
  {
  <bb 9>:
    # .MEM_24 = PHI <.MEM_78(10)>
    # VUSE <.MEM_24>
    j_26 = Close_Phi.13[0];
    # .MEM_79 = VDEF <.MEM_24>
    General_Reduction.14[0] = j_26;

  }
  bb_10 (preds = {bb_9 bb_16 }, succs = {bb_9 bb_11 })
  {
  <bb 10>:
    # .MEM_15 = PHI <.MEM_79(9), .MEM_77(16)>
    # VUSE <.MEM_15>
    D.2766_76 = General_Reduction.14[0];
    j_33 = D.2766_76;
    # VUSE <.MEM_15>
    D.2747_16 = B[j_33][0];
    D.2748_17 = j_33 + -1;
    # VUSE <.MEM_15>
    D.2749_18 = B[D.2748_17][0];
    D.2750_19 = D.2749_18 ^ D.2747_16;
    # .MEM_30 = VDEF <.MEM_15>
    B[j_33][0] = D.2750_19;
    j_20 = j_33 + 1;
    # .MEM_78 = VDEF <.MEM_30>
    Close_Phi.13[0] = j_20;
    if (jm_14(D) > j_20)
      goto <bb 9>;
    else
      goto <bb 11>;
  }
}

We would fail to discover scalar evolution of j_33.


-- 

amonakov at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amonakov at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771

[Bug tree-optimization/42771] [4.5 Regression] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[uramakrishna at gmail dot com]

------- Comment #6 from uramakrishna at gmail dot com  2010-01-26 10:08 -------
This PR is perhaps related to <a
href="http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42644">PR42644</a> (equake
problem) and <a
href="http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42130">PR42130</a> (DealII
problem), as it has the 2^32-1 values as well as unsigned int in the cloog
output.


-- 

uramakrishna at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |uramakrishna at gmail dot
                   |                            |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771

[Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[spop at gcc dot gnu dot org]

------- Comment #7 from spop at gcc dot gnu dot org  2010-02-07 07:52 -------
Mine.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |spop at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2010-01-16 22:36:03         |2010-02-07 07:52:02
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771

[Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[spop at gcc dot gnu dot org]

------- Comment #8 from spop at gcc dot gnu dot org  2010-02-10 16:47 -------
Subject: Bug 42771

Author: spop
Date: Wed Feb 10 16:47:04 2010
New Revision: 156664

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=156664
Log:
Fix PR42771.

2010-02-10  Sebastian Pop  <seb@napoca>

        PR middle-end/42771
        * graphite-clast-to-gimple.c (gloog): Call rename_sese_parameters.
        * graphite-clast-to-gimple.h (gloog): Update declaration.
        * graphite-poly.c (new_scop): Clear POLY_SCOP_P.
        * graphite-poly.h (struct poly_bb): Add missing comments.
        (struct scop): Add poly_scop_p field.
        (POLY_SCOP_P): New.
        * graphite-sese-to-poly.c (build_poly_scop): Set POLY_SCOP_P.
        * graphite.c (graphite_transform_loops): Build the polyhedral
        representation for each scop before code generation.
        * sese.c (rename_variables_in_operand): Removed.
        (rename_variables_in_expr): Return the renamed expression.
        (rename_sese_parameters): New.
        * sese.h (rename_sese_parameters): Declared.

        * gcc.dg/graphite/pr42771.c: New.

Added:
    branches/graphite/gcc/testsuite/gcc.dg/graphite/pr42771.c
Modified:
    branches/graphite/gcc/ChangeLog.graphite
    branches/graphite/gcc/graphite-clast-to-gimple.c
    branches/graphite/gcc/graphite-clast-to-gimple.h
    branches/graphite/gcc/graphite-poly.c
    branches/graphite/gcc/graphite-poly.h
    branches/graphite/gcc/graphite-sese-to-poly.c
    branches/graphite/gcc/graphite.c
    branches/graphite/gcc/sese.c
    branches/graphite/gcc/sese.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771

[Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[spop at gcc dot gnu dot org]

------- Comment #9 from spop at gcc dot gnu dot org  2010-02-10 17:03 -------
Fixed as described in 
http://gcc.gnu.org/ml/gcc-patches/2010-02/msg00436.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771

[Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[amonakov at gcc dot gnu dot org]

------- Comment #10 from amonakov at gcc dot gnu dot org  2010-02-10 18:26 -------
(In reply to comment #9)
> Fixed as described in 
> http://gcc.gnu.org/ml/gcc-patches/2010-02/msg00436.html
> 

I don't see how this patch makes simple_iv call from number_of_iterations_exit
return true for j_20.  Could you please kindly explain?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771

[Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[sebpop at gmail dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]



------- Comment #11 from sebpop at gmail dot com  2010-02-11 00:29 -------
Subject: Re:  [4.5 Regression][graphite] ICE: in 
        graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

On Wed, Feb 10, 2010 at 12:26, amonakov at gcc dot gnu dot org
<gcc-bugzilla@gcc.gnu.org> wrote:
> I don't see how this patch makes simple_iv call from number_of_iterations_exit
> return true for j_20.  Could you please kindly explain?

We used to analyze the second scop after the code generation of the
first one.  In that context, the scalar evolution analysis failed to
analyze the code containing scalar computations stored and read from
arrays with 1 element (introduced by the code generation and analysis
part).  We now analyze all the scops before code generating them:
thus, we don't have to invalidate the scalar evolution hash tables
between the analysis of two scops.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771

Re: [Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[Sebastian Pop]

On Wed, Feb 10, 2010 at 12:26, amonakov at gcc dot gnu dot org
<gcc-bugzilla@gcc.gnu.org> wrote:
> I don't see how this patch makes simple_iv call from number_of_iterations_exit
> return true for j_20.  Could you please kindly explain?

We used to analyze the second scop after the code generation of the
first one.  In that context, the scalar evolution analysis failed to
analyze the code containing scalar computations stored and read from
arrays with 1 element (introduced by the code generation and analysis
part).  We now analyze all the scops before code generating them:
thus, we don't have to invalidate the scalar evolution hash tables
between the analysis of two scops.

[Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[spop at gcc dot gnu dot org]

------- Comment #12 from spop at gcc dot gnu dot org  2010-02-11 19:42 -------
Subject: Bug 42771

Author: spop
Date: Thu Feb 11 19:42:38 2010
New Revision: 156711

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=156711
Log:
Fix PR42771.

2010-02-10  Sebastian Pop  <seb@napoca>

        PR middle-end/42771
        * graphite-clast-to-gimple.c (gloog): Call rename_sese_parameters.
        * graphite-clast-to-gimple.h (gloog): Update declaration.
        * graphite-poly.c (new_scop): Clear POLY_SCOP_P.
        * graphite-poly.h (struct poly_bb): Add missing comments.
        (struct scop): Add poly_scop_p field.
        (POLY_SCOP_P): New.
        * graphite-sese-to-poly.c (build_poly_scop): Set POLY_SCOP_P.
        * graphite.c (graphite_transform_loops): Build the polyhedral
        representation for each scop before code generation.
        * sese.c (rename_variables_in_operand): Removed.
        (rename_variables_in_expr): Return the renamed expression.
        (rename_sese_parameters): New.
        * sese.h (rename_sese_parameters): Declared.

        * gcc.dg/graphite/pr42771.c: New.

Added:
    trunk/gcc/testsuite/gcc.dg/graphite/pr42771.c
Modified:
    trunk/gcc/ChangeLog.graphite
    trunk/gcc/graphite-clast-to-gimple.c
    trunk/gcc/graphite-clast-to-gimple.h
    trunk/gcc/graphite-poly.c
    trunk/gcc/graphite-poly.h
    trunk/gcc/graphite-sese-to-poly.c
    trunk/gcc/graphite.c
    trunk/gcc/sese.c
    trunk/gcc/sese.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771

[Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)

[spop at gcc dot gnu dot org]

------- Comment #13 from spop at gcc dot gnu dot org  2010-02-11 19:46 -------
Fixed.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771