[Bug tree-optimization/42890] New: Crash in type_like_member_ptr_p (IPA)

[Bug tree-optimization/42890] New: Crash in type_like_member_ptr_p (IPA)

[d dot g dot gorbachev at gmail dot com]

GCC 4.4.4 20100126 (appeared between r154520 and 155845).


-- 
           Summary: Crash in type_like_member_ptr_p (IPA)
           Product: gcc
           Version: 4.4.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: d dot g dot gorbachev at gmail dot com
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42890

[Bug tree-optimization/42890] Crash in type_like_member_ptr_p (IPA)

[d dot g dot gorbachev at gmail dot com]

------- Comment #1 from d dot g dot gorbachev at gmail dot com  2010-01-28 01:18 -------
Created an attachment (id=19734)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19734&action=view)
Backtrace


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42890

[Bug tree-optimization/42890] Crash in type_like_member_ptr_p (IPA)

[d dot g dot gorbachev at gmail dot com]

------- Comment #2 from d dot g dot gorbachev at gmail dot com  2010-01-28 01:23 -------
Created an attachment (id=19735)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19735&action=view)
Testcase

g++ -O -findirect-inlining -fipa-cp -fipa-cp-clone pr42890.cc


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42890

[Bug tree-optimization/42890] [4.4 Regression] Crash in type_like_member_ptr_p in ipa-prop.c:382

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2010-01-28 10:08 -------
Confirmed.  Also fails with -O3.

424           if (type_like_member_ptr_p (TREE_TYPE (arg), NULL, NULL))
(gdb) p arg
$1 = (tree) 0x7ffff6197e70
(gdb) call debug_tree (arg)
 <ssa_name 0x7ffff6197e70 nothrow var <var_decl 0x7ffff619c6e0 D.2152>def_stmt 

    version 3 in-free-list>


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu dot
                   |                            |org, jamborm at gcc dot gnu
                   |                            |dot org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
  GCC build triplet|i686-pc-linux-gnu           |
   GCC host triplet|i686-pc-linux-gnu           |
 GCC target triplet|i686-pc-linux-gnu           |i?86-*-* x86_64-*-*
      Known to fail|                            |4.4.3
      Known to work|                            |4.4.2 4.5.0
   Last reconfirmed|0000-00-00 00:00:00         |2010-01-28 10:08:57
               date|                            |
            Summary|Crash in                    |[4.4 Regression] Crash in
                   |type_like_member_ptr_p (IPA)|type_like_member_ptr_p in
                   |                            |ipa-prop.c:382
   Target Milestone|---                         |4.4.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42890

[Bug tree-optimization/42890] [4.4 Regression] Crash in type_like_member_ptr_p in ipa-prop.c:382

[jakub at gcc dot gnu dot org]

------- Comment #4 from jakub at gcc dot gnu dot org  2010-02-08 12:13 -------
I believe the problem is that cgraph edges aren't updated during
tree_function_versioning's call to delete_unreachable_blocks:
  if (gimple_in_ssa_p (cfun))
    {
      free_dominance_info (CDI_DOMINATORS);
      free_dominance_info (CDI_POST_DOMINATORS);
      if (!update_clones)
        delete_unreachable_blocks ();      // <<<< HERE
      update_ssa (TODO_update_ssa);
      if (!update_clones)
        {
          fold_cond_expr_cond ();
          if (need_ssa_update_p ())
            update_ssa (TODO_update_ssa);
        }
    }

The trunk has delete_unreachable_blocks_update_callgraph, perhaps we want
something like that for the branch as well.  As delete_unreachable_blocks is
called here just when !updates_clones, i.e. id.transform_call_graph_edges ==
CB_CGE_MOVE, we can leave handling of that in the function for the branch.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2010-01-28 10:08:57         |2010-02-08 12:13:50
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42890

[Bug tree-optimization/42890] [4.4 Regression] Crash in type_like_member_ptr_p in ipa-prop.c:382

[hubicka at ucw dot cz]

------- Comment #5 from hubicka at ucw dot cz  2010-02-08 14:59 -------
Subject: Re:  [4.4 Regression] Crash in
        type_like_member_ptr_p in ipa-prop.c:382

> The trunk has delete_unreachable_blocks_update_callgraph, perhaps we want
> something like that for the branch as well.  As delete_unreachable_blocks is
> called here just when !updates_clones, i.e. id.transform_call_graph_edges ==
> CB_CGE_MOVE, we can leave handling of that in the function for the branch.

I will have to look into this tomorrow.  But strategy before we introduced all
this delete_unreachable_blocks_update_callgraph code was to simply not cleanup
or to force rebuild of edges (earlier had problems that we was not able to
build dominance tree anymore, the later become impossible with virtual clones
since edges hold important infomration and can not be just thrown away.
So perhaps we can simply rebuild edges here?

Honza


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42890

[Bug tree-optimization/42890] [4.4 Regression] Crash in type_like_member_ptr_p in ipa-prop.c:382

[jakub at gcc dot gnu dot org]

------- Comment #6 from jakub at gcc dot gnu dot org  2010-02-08 15:49 -------
Subject: Bug 42890

Author: jakub
Date: Mon Feb  8 15:49:30 2010
New Revision: 156604

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=156604
Log:
        PR tree-optimization/42890
        * g++.dg/torture/pr42890.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/torture/pr42890.C
Modified:
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42890

[Bug tree-optimization/42890] [4.4 Regression] Crash in type_like_member_ptr_p in ipa-prop.c:382

[jakub at gcc dot gnu dot org]

------- Comment #7 from jakub at gcc dot gnu dot org  2010-02-08 15:51 -------
Subject: Bug 42890

Author: jakub
Date: Mon Feb  8 15:50:59 2010
New Revision: 156605

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=156605
Log:
        PR tree-optimization/42890
        * tree-inline.c (delete_unreachable_blocks_update_callgraph): New
        function backported from the trunk.
        (tree_function_versioning): Call it instead of
        delete_unreachable_blocks.

        * g++.dg/torture/pr42890.C: New test.

Added:
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/torture/pr42890.C
Modified:
    branches/gcc-4_4-branch/gcc/ChangeLog
    branches/gcc-4_4-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_4-branch/gcc/tree-inline.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42890

[Bug tree-optimization/42890] [4.4 Regression] Crash in type_like_member_ptr_p in ipa-prop.c:382

[jakub at gcc dot gnu dot org]

------- Comment #8 from jakub at gcc dot gnu dot org  2010-02-08 15:54 -------
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42890