public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/37448] [4.3/4.4/4.5 Regression] gcc 4.3.1 cannot compile big function
Date: Thu, 28 Jan 2010 16:50:00 -0000	[thread overview]
Message-ID: <20100128165025.8999.qmail@sourceware.org> (raw)
In-Reply-To: <bug-37448-16683@http.gcc.gnu.org/bugzilla/>



------- Comment #37 from rguenth at gcc dot gnu dot org  2010-01-28 16:50 -------
But it miscompares.  Honza?!

Index: gcc/ipa-inline.c
===================================================================
*** gcc/ipa-inline.c    (revision 156321)
--- gcc/ipa-inline.c    (working copy)
*************** cgraph_decide_inlining_incrementally (st
*** 1510,1515 ****
--- 1510,1517 ----
        /* Never inline regular functions into always-inline functions
         during incremental inlining.  */
        && !node->local.disregard_inline_limits)
+     {
+       bitmap visited = BITMAP_ALLOC (NULL);
      for (e = node->callees; e; e = e->next_callee)
        {
          int allowed_growth = 0;
*************** cgraph_decide_inlining_incrementally (st
*** 1517,1522 ****
--- 1519,1528 ----
            || !e->inline_failed
            || e->callee->local.disregard_inline_limits)
          continue;
+       /* We are inlining a function to all call-sites in node
+          or to none.  So visit each candidate only once.  */
+       if (!bitmap_set_bit (visited, e->callee->uid))
+         continue;
        if (dump_file)
          fprintf (dump_file, "Considering inline candidate %s.\n",
                   cgraph_node_name (e->callee));
*************** cgraph_decide_inlining_incrementally (st
*** 1601,1606 ****
--- 1607,1614 ----
        if (cgraph_default_inline_p (e->callee, &failed_reason))
          inlined |= try_inline (e, mode, depth);
        }
+     BITMAP_FREE (visited);
+     }
    node->aux = (void *)(size_t) old_mode;
    return inlined;
  }


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37448


  parent reply	other threads:[~2010-01-28 16:50 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-09 18:35 [Bug c/37448] New: " grue at diku dot dk
2008-09-10  8:02 ` [Bug middle-end/37448] " grue at diku dot dk
2008-09-10  8:03 ` grue at diku dot dk
2008-09-10  8:04 ` rguenth at gcc dot gnu dot org
2008-09-10  8:12 ` [Bug middle-end/37448] [4.3 Regression] " rguenth at gcc dot gnu dot org
2008-09-10  9:58 ` hubicka at gcc dot gnu dot org
2008-09-10 10:04 ` hubicka at gcc dot gnu dot org
2008-09-10 11:33 ` hubicka at gcc dot gnu dot org
2008-09-10 11:40 ` hubicka at gcc dot gnu dot org
2008-09-10 21:17 ` vmakarov at redhat dot com
2008-09-11 12:37 ` hubicka at gcc dot gnu dot org
2008-09-11 12:41 ` hubicka at gcc dot gnu dot org
2008-09-13 16:00 ` hjl at gcc dot gnu dot org
2008-09-17 17:50 ` lucier at math dot purdue dot edu
2008-09-18  1:31 ` lucier at math dot purdue dot edu
2008-09-18 16:50 ` hubicka at gcc dot gnu dot org
2008-09-18 17:31 ` hubicka at gcc dot gnu dot org
2008-09-18 18:19 ` hubicka at gcc dot gnu dot org
2008-09-18 21:13 ` hubicka at gcc dot gnu dot org
2008-09-20 14:44 ` rguenth at gcc dot gnu dot org
2008-09-26  0:17 ` vmakarov at gcc dot gnu dot org
2008-09-26 21:14 ` hubicka at gcc dot gnu dot org
2008-09-26 22:16 ` hubicka at gcc dot gnu dot org
2008-09-26 23:36 ` hubicka at gcc dot gnu dot org
2008-09-27 12:45 ` zadeck at naturalbridge dot com
2008-10-08  2:55 ` zadeck at gcc dot gnu dot org
2008-10-08  3:39 ` lucier at math dot purdue dot edu
2008-10-11 23:42 ` zadeck at gcc dot gnu dot org
2009-01-24 10:26 ` rguenth at gcc dot gnu dot org
2009-03-29 18:26 ` [Bug middle-end/37448] [4.3 4.5 " hubicka at gcc dot gnu dot org
2009-03-29 18:31 ` hubicka at gcc dot gnu dot org
2009-08-04 12:43 ` [Bug middle-end/37448] [4.3/4.5 " rguenth at gcc dot gnu dot org
2010-01-26 11:35 ` [Bug middle-end/37448] [4.3/4.4/4.5 " rguenth at gcc dot gnu dot org
2010-01-26 11:45 ` rguenth at gcc dot gnu dot org
2010-01-26 12:34 ` rguenth at gcc dot gnu dot org
2010-01-26 16:05 ` hubicka at ucw dot cz
2010-01-28 16:21 ` rguenth at gcc dot gnu dot org
2010-01-28 16:42 ` rguenth at gcc dot gnu dot org
2010-01-28 16:50 ` rguenth at gcc dot gnu dot org [this message]
2010-01-28 16:58 ` rguenth at gcc dot gnu dot org
2010-01-29 11:26 ` rguenth at gcc dot gnu dot org
2010-01-29 20:54 ` hubicka at ucw dot cz
2010-05-22 18:26 ` [Bug middle-end/37448] [4.3/4.4/4.5/4.6 " rguenth at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100128165025.8999.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).