public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug other/42966]  New: add some indication that a warning has been converted to an error
@ 2010-02-05  1:16 manu at gcc dot gnu dot org
  2010-02-05  1:20 ` [Bug other/42966] " manu at gcc dot gnu dot org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: manu at gcc dot gnu dot org @ 2010-02-05  1:16 UTC (permalink / raw)
  To: gcc-bugs

See http://gcc.gnu.org/ml/gcc-patches/2009-11/msg01197.html

Currently, warnings enabled by flags are indicated by the flag when using
-fdiagnostics-show-option. However, warnings enabled by default do not show
anything. Two possible fixes:

1) Give the flag that enables the warning (like now). For default warnings, say
"[default warning]". 

2) Give the flag that disables the warning. For default warnings, say "[-w]".

Also, it would be good to move this info after "warning:" (or "error:" if
-Werror=) to make it easier to see/parse.

Of course, anything that does not have a [something] is a hard error that
cannot be disabled.


-- 
           Summary: add some indication that a warning has been converted to
                    an error
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: enhancement
          Priority: P3
         Component: other
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: manu at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42966


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug other/42966] add some indication that a warning has been converted to an error
  2010-02-05  1:16 [Bug other/42966] New: add some indication that a warning has been converted to an error manu at gcc dot gnu dot org
@ 2010-02-05  1:20 ` manu at gcc dot gnu dot org
  2010-02-07 20:58 ` pinskia at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: manu at gcc dot gnu dot org @ 2010-02-05  1:20 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #1 from manu at gcc dot gnu dot org  2010-02-05 01:20 -------
@Simon,

I think this solution would be accepted more readily by everybody, since anyway
we already have the [-W*] markers for most warnings except default ones. What
do you think?

I specially like showing the flag for disabling but that would be perhaps more
transgressive.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42966


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug other/42966] add some indication that a warning has been converted to an error
  2010-02-05  1:16 [Bug other/42966] New: add some indication that a warning has been converted to an error manu at gcc dot gnu dot org
  2010-02-05  1:20 ` [Bug other/42966] " manu at gcc dot gnu dot org
@ 2010-02-07 20:58 ` pinskia at gcc dot gnu dot org
  2010-02-27 18:49 ` manu at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2010-02-07 20:58 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #2 from pinskia at gcc dot gnu dot org  2010-02-07 20:58 -------
Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-02-07 20:58:38
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42966


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug other/42966] add some indication that a warning has been converted to an error
  2010-02-05  1:16 [Bug other/42966] New: add some indication that a warning has been converted to an error manu at gcc dot gnu dot org
  2010-02-05  1:20 ` [Bug other/42966] " manu at gcc dot gnu dot org
  2010-02-07 20:58 ` pinskia at gcc dot gnu dot org
@ 2010-02-27 18:49 ` manu at gcc dot gnu dot org
  2010-04-14 16:08 ` manu at gcc dot gnu dot org
  2010-04-14 16:10 ` manu at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: manu at gcc dot gnu dot org @ 2010-02-27 18:49 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from manu at gcc dot gnu dot org  2010-02-27 18:49 -------
Patch approved http://gcc.gnu.org/ml/gcc-patches/2010-02/msg01138.html


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |41998
              nThis|                            |
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42966


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug other/42966] add some indication that a warning has been converted to an error
  2010-02-05  1:16 [Bug other/42966] New: add some indication that a warning has been converted to an error manu at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2010-02-27 18:49 ` manu at gcc dot gnu dot org
@ 2010-04-14 16:08 ` manu at gcc dot gnu dot org
  2010-04-14 16:10 ` manu at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: manu at gcc dot gnu dot org @ 2010-04-14 16:08 UTC (permalink / raw)
  To: gcc-bugs

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2174 bytes --]



------- Comment #4 from manu at gcc dot gnu dot org  2010-04-14 16:08 -------
Subject: Bug 42966

Author: manu
Date: Wed Apr 14 16:08:23 2010
New Revision: 158349

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=158349
Log:
2010-04-14  Manuel López-Ibáñez  <manu@gcc.gnu.org>

        PR 42966
        * diagnostics.c (diagnostic_report_diagnostic): Mark specially
        warnings converted to errors.

testsuite/      
        * gcc.dg/cpp/warn-undef-2.c: Update.
        * gcc.dg/cpp/warn-traditional-2.c: Update.
        * gcc.dg/cpp/warn-comments-2.c: Update.
        * gcc.dg/cpp/warn-variadic-2.c: Update.
        * gcc.dg/cpp/warn-long-long-2.c: Update.
        * gcc.dg/cpp/warn-deprecated-2.c: Update.
        * gcc.dg/cpp/warn-multichar-2.c: Update.
        * gcc.dg/cpp/warn-normalized-3.c: Update.
        * gcc.dg/cpp/warn-cxx-compat-2.c: Update.
        * gcc.dg/cpp/warn-trigraphs-3.c: Update.
        * gcc.dg/cpp/warn-unused-macros-2.c: Update.
        * gcc.dg/cpp/warn-trigraphs-4.c: Update.
        * gcc.dg/cpp/warn-redefined-2.c: Update.
        * gfortran.dg/warning-directive-2.F90: Update.
        * c-c++-common/cpp/warning-directive-2.c: Update.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/diagnostic.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/c-c++-common/cpp/warning-directive-2.c
    trunk/gcc/testsuite/gcc.dg/cpp/warn-comments-2.c
    trunk/gcc/testsuite/gcc.dg/cpp/warn-cxx-compat-2.c
    trunk/gcc/testsuite/gcc.dg/cpp/warn-deprecated-2.c
    trunk/gcc/testsuite/gcc.dg/cpp/warn-long-long-2.c
    trunk/gcc/testsuite/gcc.dg/cpp/warn-multichar-2.c
    trunk/gcc/testsuite/gcc.dg/cpp/warn-normalized-3.c
    trunk/gcc/testsuite/gcc.dg/cpp/warn-redefined-2.c
    trunk/gcc/testsuite/gcc.dg/cpp/warn-traditional-2.c
    trunk/gcc/testsuite/gcc.dg/cpp/warn-trigraphs-3.c
    trunk/gcc/testsuite/gcc.dg/cpp/warn-trigraphs-4.c
    trunk/gcc/testsuite/gcc.dg/cpp/warn-undef-2.c
    trunk/gcc/testsuite/gcc.dg/cpp/warn-unused-macros-2.c
    trunk/gcc/testsuite/gcc.dg/cpp/warn-variadic-2.c
    trunk/gcc/testsuite/gfortran.dg/warning-directive-2.F90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42966


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug other/42966] add some indication that a warning has been converted to an error
  2010-02-05  1:16 [Bug other/42966] New: add some indication that a warning has been converted to an error manu at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2010-04-14 16:08 ` manu at gcc dot gnu dot org
@ 2010-04-14 16:10 ` manu at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: manu at gcc dot gnu dot org @ 2010-04-14 16:10 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #5 from manu at gcc dot gnu dot org  2010-04-14 16:10 -------
FIXED in gcc 4.6.

Thanks Simon for the original idea.


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42966


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-04-14 16:10 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-05  1:16 [Bug other/42966] New: add some indication that a warning has been converted to an error manu at gcc dot gnu dot org
2010-02-05  1:20 ` [Bug other/42966] " manu at gcc dot gnu dot org
2010-02-07 20:58 ` pinskia at gcc dot gnu dot org
2010-02-27 18:49 ` manu at gcc dot gnu dot org
2010-04-14 16:08 ` manu at gcc dot gnu dot org
2010-04-14 16:10 ` manu at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).