From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14823 invoked by alias); 8 Feb 2010 13:19:35 -0000 Received: (qmail 14800 invoked by uid 48); 8 Feb 2010 13:19:24 -0000 Date: Mon, 08 Feb 2010 13:19:00 -0000 Message-ID: <20100208131924.14799.qmail@sourceware.org> X-Bugzilla-Reason: CC References: Subject: [Bug libfortran/42996] Incorrect length returned from get_command_argument intrinsic In-Reply-To: Reply-To: gcc-bugzilla@gcc.gnu.org To: gcc-bugs@gcc.gnu.org From: "burnus at gcc dot gnu dot org" Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2010-02/txt/msg00702.txt.bz2 ------- Comment #2 from burnus at gcc dot gnu dot org 2010-02-08 13:19 ------- Confirm - I get for "./a.out test" the following result. Current (gfortran): With no value, length was:4 and status:0 With LEN=1 value, length was:1 and status:-1 <<<<< Bad: len = 1 With LEN=10 value, length was:4 and status:0 Expected (NAG f95, ifort): With no value, length was:4 and status:0 With LEN=1 value, length was:4 and status:-1 <<<<< OK: len = 4 With LEN=10 value, length was:4 and status:0 By the way, the manual is correct: http://gcc.gnu.org/onlinedocs/gfortran/GET_005fCOMMAND_005fARGUMENT.html Draft patch: diff --git a/libgfortran/intrinsics/args.c b/libgfortran/intrinsics/args.c index 7187bec..83a0502 100644 --- a/libgfortran/intrinsics/args.c +++ b/libgfortran/intrinsics/args.c @@ -147,11 +147,9 @@ get_command_argument_i4 (GFC_INTEGER_4 *number, char *value, if (value != NULL && stat_flag != GFC_GC_FAILURE) { if (arglen > value_len) - { - arglen = value_len; stat_flag = GFC_GC_VALUE_TOO_SHORT; - } - memcpy (value, argv[*number], arglen); + + memcpy (value, argv[*number], arglen > value_len ? value_len : arglen); } if (length != NULL) -- burnus at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Last reconfirmed|0000-00-00 00:00:00 |2010-02-08 13:19:24 date| | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42996