public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "steven at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/43056] __builtin_prefetch causes ICE: in rtl_verify_flow_info, at cfgrtl.c:2205 with -fsched2-use-superblocks Date: Sun, 14 Feb 2010 00:08:00 -0000 [thread overview] Message-ID: <20100214000748.12366.qmail@sourceware.org> (raw) In-Reply-To: <bug-43056-14164@http.gcc.gnu.org/bugzilla/> ------- Comment #3 from steven at gcc dot gnu dot org 2010-02-14 00:07 ------- User prefetches should never be scheduled. Andreas Krebbel posted a patch towards that (http://gcc.gnu.org/ml/gcc-patches/2009-09/msg00130.html) but he hasn't followed up on it, so far. Of course, in very rare corner cases, it is possible to have a non-user prefetch and then all other code removed as dead. To handle this situation, sched-ebb.c should not move the barrier after the jump into a new basic block. But I don't know if this is the responsibility of the CFGRTL modification interface, or of the user of this interface. If the latter, the following patch would be necessary: Index: sched-ebb.c =================================================================== --- sched-ebb.c (revision 156750) +++ sched-ebb.c (working copy) @@ -174,8 +174,13 @@ gcc_assert (NOTE_INSN_BASIC_BLOCK_P (BB_END (bb))); } else - /* Create an empty unreachable block after the INSN. */ - bb = create_basic_block (NEXT_INSN (insn), NULL_RTX, last_bb); + { + /* Create an empty unreachable block after the INSN. */ + rtx head = NEXT_INSN (insn); + while (head && BARRIER_P (head)) + head = NEXT_INSN (head); + bb = create_basic_block (head, NULL_RTX, last_bb); + } /* split_edge () creates BB before E->DEST. Keep in mind, that this operation extends scheduling region till the end of BB. -- steven at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |krebbel at gcc dot gnu dot | |org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43056
next prev parent reply other threads:[~2010-02-14 0:08 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-02-13 13:00 [Bug rtl-optimization/43056] New: " zsojka at seznam dot cz 2010-02-13 23:09 ` [Bug rtl-optimization/43056] " steven at gcc dot gnu dot org 2010-02-13 23:18 ` steven at gcc dot gnu dot org 2010-02-13 23:29 ` steven at gcc dot gnu dot org 2010-02-14 0:08 ` steven at gcc dot gnu dot org [this message] [not found] <bug-43056-4@http.gcc.gnu.org/bugzilla/> 2012-11-11 20:46 ` steven at gcc dot gnu.org 2013-04-04 5:09 ` mpolacek at gcc dot gnu.org 2021-08-27 6:33 ` pinskia at gcc dot gnu.org 2021-08-27 6:46 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100214000748.12366.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).