[Bug tree-optimization/43083] New: [4.5 Regression] ICE: SIGSEGV with -fgraphite-identity

[Bug tree-optimization/43083] New: [4.5 Regression] ICE: SIGSEGV with -fgraphite-identity

[zsojka at seznam dot cz]

Command line:
gcc -O1 -fgraphite-identity testcase.c
(fails at all -O1, -O2, -O3 levels)

Tested revisions:
r156745 - crash
r153685 - crash
4.4 r156256 - OK

Output:
$ /mnt/svn/gcc-trunk/binary-156745-lto/bin/gcc -O3 -fgraphite-identity
testcase.c
testcase.c: In function 'foo':
testcase.c:9:5: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

Valgrind:
==14930== Invalid write of size 8
==14930==    at 0x563054: link_block (cfg.c:153)
==14930==    by 0x7CD121: create_bb (tree-cfg.c:444)
==14930==    by 0x572672: create_basic_block (cfghooks.c:621)
==14930==    by 0x7CDF84: gimple_split_block (tree-cfg.c:4812)
==14930==    by 0x5720BE: split_block (cfghooks.c:433)
==14930==    by 0x572970: make_forwarder_block (cfghooks.c:737)              
==14930==    by 0xBFB572: create_sese_edges (graphite-scop-detection.c:965)
==14930==    by 0xBFD4BA: build_scops (graphite-scop-detection.c:1327)
==14930==    by 0xBF036F: graphite_transform_loops (graphite.c:260)
==14930==    by 0x8968C6: graphite_transforms (tree-ssa-loop.c:300)
==14930==    by 0x7233EA: execute_one_pass (passes.c:1561)
==14930==    by 0x723674: execute_pass_list (passes.c:1616)
==14930==  Address 0x30 is not stack'd, malloc'd or (recently) free'd


-- 
           Summary: [4.5 Regression] ICE: SIGSEGV with -fgraphite-identity
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: zsojka at seznam dot cz
  GCC host triplet: x86_64-pc-linux-gnu
GCC target triplet: x86_64-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43083

[Bug tree-optimization/43083] [4.5 Regression] ICE: SIGSEGV with -fgraphite-identity

[zsojka at seznam dot cz]

------- Comment #1 from zsojka at seznam dot cz  2010-02-15 18:45 -------
Created an attachment (id=19880)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19880&action=view)
reduced testcase


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43083

[Bug tree-optimization/43083] [4.5 Regression] ICE: SIGSEGV with -fgraphite-identity

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43083

[Bug tree-optimization/43083] [4.5 Regression] ICE: SIGSEGV with -fgraphite-identity

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43083

[Bug tree-optimization/43083] [4.5 Regression] ICE: SIGSEGV with -fgraphite-identity

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2010-02-18 18:38 -------
Confirmed backtrace:
#0  0x0000000000801625 in link_block (b=0x7f9f943dcaf8, after=0x7f9f943dc138)
at /home/apinski/src/gcc-fsf/local//gcc/gcc/cfg.c:153
#1  0x00000000012b8fb6 in create_bb (h=0x0, e=0x0, after=0x7f9f943dc138) at
/home/apinski/src/gcc-fsf/local//gcc/gcc/tree-cfg.c:444
#2  0x0000000000863a60 in create_basic_block (head=0x0, end=0x0,
after=0x7f9f943dc138) at
/home/apinski/src/gcc-fsf/local//gcc/gcc/cfghooks.c:621
#3  0x0000000000863ac1 in create_empty_bb (after=0x7f9f943dc138) at
/home/apinski/src/gcc-fsf/local//gcc/gcc/cfghooks.c:636
#4  0x00000000012c7d00 in gimple_split_block (bb=0x7f9f943dc138, stmt=0x0) at
/home/apinski/src/gcc-fsf/local//gcc/gcc/tree-cfg.c:4812
#5  0x00000000008633d7 in split_block (bb=0x7f9f943dc138, i=0x0) at
/home/apinski/src/gcc-fsf/local//gcc/gcc/cfghooks.c:433
#6  0x0000000000863510 in split_block_after_labels (bb=0x7f9f943dc138) at
/home/apinski/src/gcc-fsf/local//gcc/gcc/cfghooks.c:471
#7  0x0000000000863e00 in make_forwarder_block (bb=0x7f9f943dc138,
redirect_edge_p=0x2532697 <sd_region_without_exit>, new_bb_cbk=0)
    at /home/apinski/src/gcc-fsf/local//gcc/gcc/cfghooks.c:737
#8  0x000000000253271e in create_single_exit_edge (region=0x47afff8) at
/home/apinski/src/gcc-fsf/local//gcc/gcc/graphite-scop-detection.c:965
#9  0x00000000025329f1 in create_sese_edges (regions=0x47affd0) at
/home/apinski/src/gcc-fsf/local//gcc/gcc/graphite-scop-detection.c:1034
#10 0x000000000253338c in build_scops (scops=0x7fff14b44e20) at
/home/apinski/src/gcc-fsf/local//gcc/gcc/graphite-scop-detection.c:1327
#11 0x000000000245f015 in graphite_transform_loops () at
/home/apinski/src/gcc-fsf/local//gcc/gcc/graphite.c:260
#12 0x0000000001906459 in graphite_transforms () at
/home/apinski/src/gcc-fsf/local//gcc/gcc/tree-ssa-loop.c:300


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-02-18 18:38:22
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43083

[Bug tree-optimization/43083] [4.5 Regression] ICE: SIGSEGV with -fgraphite-identity

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2010-02-18 18:39 -------
#8  0x000000000253271e in create_single_exit_edge (region=0x47afff8) at
/home/apinski/src/gcc-fsf/local//gcc/gcc/graphite-scop-detection.c:965
965       forwarder = make_forwarder_block (exit, &sd_region_without_exit,
NULL);
(gdb) p debug_bb(exit)
;; basic block 1, loop depth 0, count 0
;; prev block 7, next block 9
;; pred:       7 [100.0%]  6 [100.0%] 
;; succ:      
<bb 1>:


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43083

[Bug tree-optimization/43083] [4.5 Regression] ICE: SIGSEGV with -fgraphite-identity

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2010-02-18 18:42 -------
(In reply to comment #3)
> #8  0x000000000253271e in create_single_exit_edge (region=0x47afff8) at
> /home/apinski/src/gcc-fsf/local//gcc/gcc/graphite-scop-detection.c:965
> 965       forwarder = make_forwarder_block (exit, &sd_region_without_exit,
> NULL);
> (gdb) p debug_bb(exit)
> ;; basic block 1, loop depth 0, count 0
> ;; prev block 7, next block 9
> ;; pred:       7 [100.0%]  6 [100.0%] 
> ;; succ:      
> <bb 1>:
> 

Well BB 1 is not supposed to have any succ anyways as it is the exit block. 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43083

[Bug tree-optimization/43083] [4.5 Regression] ICE: SIGSEGV with -fgraphite-identity

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2010-02-18 18:46 -------
Hmm, this code is undefined first but that does not matter.  The issue comes
down to return statements not being combined into just one return statement.  I
don't know if this is supposed to happen this way or not.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43083

[Bug middle-end/43083] [4.5 Regression] ICE with -fgraphite-identity with fall through return value

[spop at gcc dot gnu dot org]

------- Comment #6 from spop at gcc dot gnu dot org  2010-02-22 17:40 -------
Subject: Bug 43083

Author: spop
Date: Mon Feb 22 17:40:23 2010
New Revision: 156970

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=156970
Log:
Fix PR43083: Do not handle regions ending with multiple edges on the exit BB.

2010-02-22  Sebastian Pop  <sebastian.pop@amd.com>

        PR middle-end/43083
        * graphite-scop-detection.c (create_single_exit_edge): Move
        the call to find_single_exit_edge to....
        (create_sese_edges): ...here.  Don't handle multiple edges
        exiting the function.
        (build_graphite_scops): Don't handle multiple edges
        exiting the function.

        * gcc.dg/graphite/pr43083.c: New.

Added:
    branches/graphite/gcc/testsuite/gcc.dg/graphite/pr43083.c
Modified:
    branches/graphite/gcc/ChangeLog.graphite
    branches/graphite/gcc/graphite-scop-detection.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43083

[Bug middle-end/43083] [4.5 Regression] ICE with -fgraphite-identity with fall through return value

[spop at gcc dot gnu dot org]

-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |spop at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2010-02-18 18:38:22         |2010-02-22 21:02:03
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43083

[Bug middle-end/43083] [4.5 Regression] ICE with -fgraphite-identity with fall through return value

[spop at gcc dot gnu dot org]

------- Comment #7 from spop at gcc dot gnu dot org  2010-02-23 13:00 -------
Subject: Bug 43083

Author: spop
Date: Tue Feb 23 12:59:48 2010
New Revision: 156997

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=156997
Log:
Fix PR43083: Do not handle regions ending with multiple edges on the exit BB.

2010-02-22  Sebastian Pop  <sebastian.pop@amd.com>

        PR middle-end/43083
        * graphite-scop-detection.c (create_single_exit_edge): Move
        the call to find_single_exit_edge to....
        (create_sese_edges): ...here.  Don't handle multiple edges
        exiting the function.
        (build_graphite_scops): Don't handle multiple edges
        exiting the function.

        * gcc.dg/graphite/pr43083.c: New.

Added:
    trunk/gcc/testsuite/gcc.dg/graphite/pr43083.c
Modified:
    trunk/gcc/ChangeLog.graphite
    trunk/gcc/graphite-scop-detection.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43083

[Bug middle-end/43083] [4.5 Regression] ICE with -fgraphite-identity with fall through return value

[spop at gcc dot gnu dot org]

------- Comment #8 from spop at gcc dot gnu dot org  2010-02-23 13:05 -------
Fixed.


-- 

spop at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43083