public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/32063]  New: "contrib/test_summary" script could output results more neatly
@ 2007-05-24  3:22 rob1weld at aol dot com
  2007-05-25  6:35 ` [Bug testsuite/32063] " pinskia at gcc dot gnu dot org
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: rob1weld at aol dot com @ 2007-05-24  3:22 UTC (permalink / raw)
  To: gcc-bugs

This affects any HTB triplet if the person runs the "contrib/test_summary"
script. 

The script creates results that are not "pretty-printed" and mails them to
gcc-testresults@gcc.gnu.org which automatically generates ugly web pages.


We might improved the line spacing in the mailer script, here is an example:

---START---
/opt/gcc-4_3-build/gcc/testsuite/gfortran/../../gfortran  version 4.3.0
20070523 (experimental)

                === gnat tests ===


Running target unix
FAIL: gnat.dg/address_conversion.adb execution test

                === gnat Summary ===

# of expected passes            168
# of unexpected failures        1
                === obj-c++ tests ===


Running target unix
--- END ---


I suggest it would look better if it were like this:


---START---
/opt/gcc-4_3-build/gcc/testsuite/gfortran/../../gfortran  version 4.3.0
20070523 (experimental)

(Add a blank line here)
                === gnat tests ===
(Subtract a blank line here)
Running target unix
FAIL: gnat.dg/address_conversion.adb execution test

                === gnat Summary ===

# of expected passes            168
# of unexpected failures        1
(Add a blank line here)
(Add a blank line here)
                === obj-c++ tests ===
(Subtract a blank line here)
Running target unix
--- END ---


That is only a dozen line example. The _whole_ output is like that; with extra
"C/R"'s where they are not needed and too few "C/R"'s in some spots.

I realize that the output is supposed to be "machine readable", so is our ource
code. We have _standards_ for the appearance of the source, why not the output.

While this is "trivial" we should have pride in our great compiler and the
usually great results. Even if there are failures we should still present them
neatly.

See here for many examples: http://gcc.gnu.org/ml/gcc-testresults/2007-05/


-- 
           Summary: "contrib/test_summary" script could output results more
                    neatly
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rob1weld at aol dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32063


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug testsuite/32063] "contrib/test_summary" script could output results more neatly
  2007-05-24  3:22 [Bug testsuite/32063] New: "contrib/test_summary" script could output results more neatly rob1weld at aol dot com
@ 2007-05-25  6:35 ` pinskia at gcc dot gnu dot org
  2007-05-25 13:05 ` manu at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-05-25  6:35 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #1 from pinskia at gcc dot gnu dot org  2007-05-25 07:35 -------
You know the testresults are not looked at by almost nobody (I am one of the
few person who looks at them).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32063


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug testsuite/32063] "contrib/test_summary" script could output results more neatly
  2007-05-24  3:22 [Bug testsuite/32063] New: "contrib/test_summary" script could output results more neatly rob1weld at aol dot com
  2007-05-25  6:35 ` [Bug testsuite/32063] " pinskia at gcc dot gnu dot org
@ 2007-05-25 13:05 ` manu at gcc dot gnu dot org
  2007-05-26 18:45 ` rob1weld at aol dot com
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: manu at gcc dot gnu dot org @ 2007-05-25 13:05 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #2 from manu at gcc dot gnu dot org  2007-05-25 14:05 -------
(In reply to comment #0)
> While this is "trivial" we should have pride in our great compiler and the
> usually great results. Even if there are failures we should still present them
> neatly.

If it is trivial, then just prepare a patch for it, test it and send it to
gcc-patches. Opening a PR for this was a waste of electricity.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32063


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug testsuite/32063] "contrib/test_summary" script could output results more neatly
  2007-05-24  3:22 [Bug testsuite/32063] New: "contrib/test_summary" script could output results more neatly rob1weld at aol dot com
  2007-05-25  6:35 ` [Bug testsuite/32063] " pinskia at gcc dot gnu dot org
  2007-05-25 13:05 ` manu at gcc dot gnu dot org
@ 2007-05-26 18:45 ` rob1weld at aol dot com
  2007-06-09  3:27 ` rob1weld at aol dot com
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: rob1weld at aol dot com @ 2007-05-26 18:45 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from rob1weld at aol dot com  2007-05-26 18:45 -------
> If it is trivial, then just prepare a patch for it, test it and send it to
> gcc-patches. Opening a PR for this was a waste of electricity.

"Minor" and "Trivial" are choices on the "Severity" setting.

I'll be glad to make the patch, just send me the scripts that are used to read
the reports and perform "breakage e-mailing" and I'll ensure that my patch is
compatable. 

Failing that someone who has access to such information _may_ decide to make
such changes after other things are out of the way ...

We are all (some of us anyways) kinda working on the "Blocker" problem at the
moment. Those sorts of things come first. The report _might_ be dealt with in
the next 2-6 months -- depending on how people feel about the appearance of
those web pages.

Your electricity company thanks you for your support. (Mine is non-profit).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32063


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug testsuite/32063] "contrib/test_summary" script could output results more neatly
  2007-05-24  3:22 [Bug testsuite/32063] New: "contrib/test_summary" script could output results more neatly rob1weld at aol dot com
                   ` (2 preceding siblings ...)
  2007-05-26 18:45 ` rob1weld at aol dot com
@ 2007-06-09  3:27 ` rob1weld at aol dot com
  2007-06-12 11:12 ` rob1weld at aol dot com
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: rob1weld at aol dot com @ 2007-06-09  3:27 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #4 from rob1weld at aol dot com  2007-06-09 03:27 -------
One enhancement I did try was adding this to the end of contrib/test_summary. 

It does nothing for _me_ since I have the new assembler but for others it would
catch the failures and report them.

  print "";
  print "---";
  print "Check gcc/testsuite/gcc/gcc.log for Spurious Errors:"
  print "grep -e Assembler\\ messages -e Warning -e Error
gcc/testsuite/gcc/gcc.log | sort -k 2 -i -u"
  print "";
  system("grep -e Assembler\\ messages -e Warning -e Error
gcc/testsuite/gcc/gcc.log | sort -k 2 -i -u");
  print "---";
  print "";


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32063


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug testsuite/32063] "contrib/test_summary" script could output results more neatly
  2007-05-24  3:22 [Bug testsuite/32063] New: "contrib/test_summary" script could output results more neatly rob1weld at aol dot com
                   ` (3 preceding siblings ...)
  2007-06-09  3:27 ` rob1weld at aol dot com
@ 2007-06-12 11:12 ` rob1weld at aol dot com
  2010-02-20 23:17 ` manu at gcc dot gnu dot org
  2010-02-20 23:19 ` manu at gcc dot gnu dot org
  6 siblings, 0 replies; 8+ messages in thread
From: rob1weld at aol dot com @ 2007-06-12 11:12 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #5 from rob1weld at aol dot com  2007-06-12 11:11 -------
Here is another, this caught some errors! See end of:
http://gcc.gnu.org/ml/gcc-testresults/2007-06/msg00573.html


  print "grep -e undefined\\ reference\\ to
/opt/gcc-4_3-build/gcc/testsuite/gcc/gcc.log | sort -u -k 2 | head -n 10"
  print "";
  system("grep -e undefined\\ reference\\ to
/opt/gcc-4_3-build/gcc/testsuite/gcc/gcc.log | sort -u -k 2 | head -n 10");
  print "---";
  print "";


Note: These additions go directly before these lines:

  print "Compiler version: " prefix version lang;
  print "Platform: " host;
  print configflags;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32063


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug testsuite/32063] "contrib/test_summary" script could output results more neatly
  2007-05-24  3:22 [Bug testsuite/32063] New: "contrib/test_summary" script could output results more neatly rob1weld at aol dot com
                   ` (4 preceding siblings ...)
  2007-06-12 11:12 ` rob1weld at aol dot com
@ 2010-02-20 23:17 ` manu at gcc dot gnu dot org
  2010-02-20 23:19 ` manu at gcc dot gnu dot org
  6 siblings, 0 replies; 8+ messages in thread
From: manu at gcc dot gnu dot org @ 2010-02-20 23:17 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #6 from manu at gcc dot gnu dot org  2010-02-20 23:17 -------
(In reply to comment #3)
> 
> I'll be glad to make the patch, just send me the scripts that are used to read
> the reports and perform "breakage e-mailing" and I'll ensure that my patch is
> compatable. 

contrib/test_summary

> We are all (some of us anyways) kinda working on the "Blocker" problem at the
> moment. Those sorts of things come first. The report _might_ be dealt with in
> the next 2-6 months -- depending on how people feel about the appearance of
> those web pages.

The problem is that we have too many important bugs and too many trivial ones.
Few of us look at trivial stuff and we are really overwhelmed. And this one is
beyond trivial. If you do not do it yourself, I assure you it will be there in
50 years.

> Your electricity company thanks you for your support. (Mine is non-profit).

Really? Where is that? That is awesome.


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32063


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug testsuite/32063] "contrib/test_summary" script could output results more neatly
  2007-05-24  3:22 [Bug testsuite/32063] New: "contrib/test_summary" script could output results more neatly rob1weld at aol dot com
                   ` (5 preceding siblings ...)
  2010-02-20 23:17 ` manu at gcc dot gnu dot org
@ 2010-02-20 23:19 ` manu at gcc dot gnu dot org
  6 siblings, 0 replies; 8+ messages in thread
From: manu at gcc dot gnu dot org @ 2010-02-20 23:19 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #7 from manu at gcc dot gnu dot org  2010-02-20 23:18 -------
Bah, Rob is not even reading mail anymore, so why bother to have this open.

No patch, no clear problem, no one is interested, so closing.


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32063


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2010-02-20 23:19 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-24  3:22 [Bug testsuite/32063] New: "contrib/test_summary" script could output results more neatly rob1weld at aol dot com
2007-05-25  6:35 ` [Bug testsuite/32063] " pinskia at gcc dot gnu dot org
2007-05-25 13:05 ` manu at gcc dot gnu dot org
2007-05-26 18:45 ` rob1weld at aol dot com
2007-06-09  3:27 ` rob1weld at aol dot com
2007-06-12 11:12 ` rob1weld at aol dot com
2010-02-20 23:17 ` manu at gcc dot gnu dot org
2010-02-20 23:19 ` manu at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).