* [Bug c++/2288] Variable declared in for-loop-header is in wrong scope
[not found] <bug-2288-4@http.gcc.gnu.org/bugzilla/>
@ 2010-10-27 14:35 ` bergner at gcc dot gnu.org
2010-10-27 16:04 ` janis at gcc dot gnu.org
` (7 subsequent siblings)
8 siblings, 0 replies; 16+ messages in thread
From: bergner at gcc dot gnu.org @ 2010-10-27 14:35 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=2288
Peter Bergner <bergner at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |http://gcc.gnu.org/ml/gcc-p
| |atches/2010-03/msg00838.htm
| |l
CC| |bergner at gcc dot gnu.org
Known to fail| |
--- Comment #12 from Peter Bergner <bergner at gcc dot gnu.org> 2010-10-27 14:34:30 UTC ---
Janis, I noticed your patch:
http://gcc.gnu.org/ml/gcc-patches/2010-03/msg00838.html
to fix this PR and PR18770 was approved by Jason here:
http://gcc.gnu.org/ml/gcc-patches/2010-05/msg00264.html
Now that we're in 4.6 stage1, can we commit this patch to mainline?
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug c++/2288] Variable declared in for-loop-header is in wrong scope
[not found] <bug-2288-4@http.gcc.gnu.org/bugzilla/>
2010-10-27 14:35 ` bergner at gcc dot gnu.org
@ 2010-10-27 16:04 ` janis at gcc dot gnu.org
2010-10-27 17:27 ` bergner at gcc dot gnu.org
` (6 subsequent siblings)
8 siblings, 0 replies; 16+ messages in thread
From: janis at gcc dot gnu.org @ 2010-10-27 16:04 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=2288
--- Comment #13 from Janis Johnson <janis at gcc dot gnu.org> 2010-10-27 16:04:10 UTC ---
It's fine with me to commit the patch, but can someone else do it? I wrote the
patch when I worked at IBM. I have a personal copyright assignment now, but
haven't been involved for several months and it would be a lot of work to get
set up to commit it myself.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug c++/2288] Variable declared in for-loop-header is in wrong scope
[not found] <bug-2288-4@http.gcc.gnu.org/bugzilla/>
2010-10-27 14:35 ` bergner at gcc dot gnu.org
2010-10-27 16:04 ` janis at gcc dot gnu.org
@ 2010-10-27 17:27 ` bergner at gcc dot gnu.org
2010-10-27 17:38 ` janis at gcc dot gnu.org
` (5 subsequent siblings)
8 siblings, 0 replies; 16+ messages in thread
From: bergner at gcc dot gnu.org @ 2010-10-27 17:27 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=2288
--- Comment #14 from Peter Bergner <bergner at gcc dot gnu.org> 2010-10-27 17:26:27 UTC ---
I can do it, I just wanted to make sure I could. I'll apply the patch to
current mainline and give it another bootstrap regtesting before committing. I
assume I should use "Janis Johnson <janis187@us.ibm.com>" as your email
address in the ChangeLog since that was what you used to submit the patch?
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug c++/2288] Variable declared in for-loop-header is in wrong scope
[not found] <bug-2288-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2010-10-27 17:27 ` bergner at gcc dot gnu.org
@ 2010-10-27 17:38 ` janis at gcc dot gnu.org
2011-05-20 17:36 ` pinskia at gcc dot gnu.org
` (4 subsequent siblings)
8 siblings, 0 replies; 16+ messages in thread
From: janis at gcc dot gnu.org @ 2010-10-27 17:38 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=2288
--- Comment #15 from Janis Johnson <janis at gcc dot gnu.org> 2010-10-27 17:38:36 UTC ---
Peter, I don't know what address you should use for me; ask on #gcc if you
should use the IBM one, otherwise it's janis.marie.johnson@gmail.com.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug c++/2288] Variable declared in for-loop-header is in wrong scope
[not found] <bug-2288-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2010-10-27 17:38 ` janis at gcc dot gnu.org
@ 2011-05-20 17:36 ` pinskia at gcc dot gnu.org
2011-05-20 18:35 ` fang at csl dot cornell.edu
` (3 subsequent siblings)
8 siblings, 0 replies; 16+ messages in thread
From: pinskia at gcc dot gnu.org @ 2011-05-20 17:36 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=2288
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |howarth at nitro dot
| |med.uc.edu
--- Comment #16 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-05-20 17:09:41 UTC ---
*** Bug 49083 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug c++/2288] Variable declared in for-loop-header is in wrong scope
[not found] <bug-2288-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2011-05-20 17:36 ` pinskia at gcc dot gnu.org
@ 2011-05-20 18:35 ` fang at csl dot cornell.edu
2011-05-20 19:15 ` froydnj at gcc dot gnu.org
` (2 subsequent siblings)
8 siblings, 0 replies; 16+ messages in thread
From: fang at csl dot cornell.edu @ 2011-05-20 18:35 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=2288
--- Comment #17 from David Fang <fang at csl dot cornell.edu> 2011-05-20 17:56:25 UTC ---
I usually catch these with -Wshadow -Werror.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug c++/2288] Variable declared in for-loop-header is in wrong scope
[not found] <bug-2288-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2011-05-20 18:35 ` fang at csl dot cornell.edu
@ 2011-05-20 19:15 ` froydnj at gcc dot gnu.org
2011-05-23 16:11 ` bergner at gcc dot gnu.org
2011-06-05 2:16 ` froydnj at gcc dot gnu.org
8 siblings, 0 replies; 16+ messages in thread
From: froydnj at gcc dot gnu.org @ 2011-05-20 19:15 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=2288
Nathan Froyd <froydnj at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |froydnj at gcc dot gnu.org
--- Comment #18 from Nathan Froyd <froydnj at gcc dot gnu.org> 2011-05-20 18:34:08 UTC ---
Peter, can you apply Janis's patch now that we're in 4.7 stage 1?
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug c++/2288] Variable declared in for-loop-header is in wrong scope
[not found] <bug-2288-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2011-05-20 19:15 ` froydnj at gcc dot gnu.org
@ 2011-05-23 16:11 ` bergner at gcc dot gnu.org
2011-06-05 2:16 ` froydnj at gcc dot gnu.org
8 siblings, 0 replies; 16+ messages in thread
From: bergner at gcc dot gnu.org @ 2011-05-23 16:11 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=2288
--- Comment #19 from Peter Bergner <bergner at gcc dot gnu.org> 2011-05-23 15:38:11 UTC ---
I applied Janis' patch (modulo a small fixup due to upstream changes) to
current mainline and did a bootstrap and regtest. We bootstrap fine,
unfortunately the patch no longer fixes the new added test case
(g++.dg/parse/pr18770.C) and the modified test case
(g++.old-deja/g++.jason/cond.C) also fails. I'm not really a C++ expert, so
I'm not sure what to do here.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug c++/2288] Variable declared in for-loop-header is in wrong scope
[not found] <bug-2288-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2011-05-23 16:11 ` bergner at gcc dot gnu.org
@ 2011-06-05 2:16 ` froydnj at gcc dot gnu.org
8 siblings, 0 replies; 16+ messages in thread
From: froydnj at gcc dot gnu.org @ 2011-06-05 2:16 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=2288
Nathan Froyd <froydnj at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #20 from Nathan Froyd <froydnj at gcc dot gnu.org> 2011-06-05 02:08:38 UTC ---
This bug was fixed on trunk in r174307; the automated update was not done
because something was wonky with my email. Closing.
^ permalink raw reply [flat|nested] 16+ messages in thread