[Bug fortran/43217] New: Output of Hollerith constants which are not a multiple of 4 bytes

[Bug fortran/43217] New: Output of Hollerith constants which are not a multiple of 4 bytes

[burnus at gcc dot gnu dot org]

I do not know whether the following program is valid Fortran 77 (with deleted
parts). The issue is that gfortran creates:

    static character(kind=1) C.1534[1:9] = "HELLO YOU";

which is then passed to an default-kind integer. "HELLO YOU" consists of 9
characters, but a default-kind integer can accommodate for multiples of 4, i.e.
12 characters. Thus, printing with "FORMAT (100A4)" prints more data than
available.

gfortran:
HELLO YOUhfj
:HELLO YOUhfj:
4C4C4548 4F59204F 6A666855
where "od" shows that it prints:
  H   E   L   L   O  sp   Y   O   U   h   f   j  nl

ifort:
HELLO YOU
:HELLO YOU:
4C4C4548 4F59204F       55
   H   E   L   L   O  sp   Y   O   U nul nul nul  nl
i.e. it prints trailing NULs.

NAG f95:
HELLO YOU
:HELLO YOU:
4C4C4548 4F59204F 34280055
   H   E   L   L   O  sp   Y   O   U nul   (   4  nl

sunf95:
HELLO YOU
:HELLO YOU:
4C4C4548 4F59204F       55
  H   E   L   L   O  sp   Y   O   U nul nul nul  nl

open64:
HELLO YOU
:HELLO YOU   :
4C4C4548 4F59204F 20202055
   H   E   L   L   O  sp   Y   O   U  sp  sp  sp  nl

pathscale:
HELLO YOU
:HELLO YOU   :
4C4C4548 4F59204F 20202055
   H   E   L   L   O  sp   Y   O   U  sp  sp  sp  nl

Thus either by zero or by space padding it seems to work in the other
compilers. I wonder what happens with g77.


The program itself:

C     PROGRAM HELLO2
      CALL WRTOUT (9HHELLO YOU, 9)
      STOP
      END
C
      SUBROUTINE WRTOUT (IARRAY, NCHRS)
C
      INTEGER IARRAY(1)
      INTEGER NCHRS
C
      INTEGER ICPW
      DATA ICPW/4/
      INTEGER I, NWRDS
C
      NWRDS = (NCHRS + ICPW - 1) /ICPW
      WRITE (6,100) (IARRAY(I), I=1,NWRDS)
      WRITE (6,101) (IARRAY(I), I=1,NWRDS)
      write(*,'(4(z8," "))') (IARRAY(I), I=1,NWRDS)
      RETURN
  100 FORMAT (100A4)
  101 FORMAT (':',3A4,':')
      END


-- 
           Summary: Output of Hollerith constants which are not a multiple
                    of 4 bytes
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217

[Bug fortran/43217] Output of Hollerith constants which are not a multiple of 4 bytes

[dominiq at lps dot ens dot fr]

------- Comment #1 from dominiq at lps dot ens dot fr  2010-03-01 10:29 -------
> I wonder what happens with g77.

[ibook-dhum] f90/bug% g77 pr43217.f
[ibook-dhum] f90/bug% a.out
HELLO YOU       
:HELLO YOU      :
4C4C4548 4F59204F  9000055 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217

[Bug fortran/43217] Output of Hollerith constants which are not a multiple of 4 bytes

[jvdelisle at gcc dot gnu dot org]

------- Comment #2 from jvdelisle at gcc dot gnu dot org  2010-03-01 14:31 -------
You folks think of the crazy stuff :)  I will check into this.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jvdelisle at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-03-01 14:31:02
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217

[Bug fortran/43217] Output of Hollerith constants which are not a multiple of 4 bytes

[burnus at gcc dot gnu dot org]

------- Comment #3 from burnus at gcc dot gnu dot org  2010-03-01 15:37 -------
I now check the standard.

a) Hollerith constants (not H... in FORMAT) are deleted in Fortran 77, but they
were allowed in Fortran 66. F77 "A.2 Conflicts with ANSI X3.9-1966" has:
"Hollerith constants and Hollerith data are not permitted in this standard.
ANSI X3.9-1966 permitted the use of Hollerith constants in DATA and CALL
statements"

b) They seemingly need to be space padded; F77 "C.4 Hollerith Constant" has:
"For an entity of type integer, real, or logical, the number of characters n in
the corresponding Hollerith constant must be less than or equal to g, where g
is the maximum number of characters that can be stored in a single numeric
storage unit at one time. If n is less than g, the entity is initially defined
with the n Hollerith characters extended on the right with g - n blank
characters.
Note that each Hollerith constant initially defines exactly one variable or
array element. Also note that g is processor dependent"

gfortran seemingly supports the common extension of allowing arrays (and not
just array elements) to be initialized by a single constant.

F66 has Holleriths in 4.2.6, 5.1.1.6 and some other places, though I could not
spot the padding part. (I have not tried very hard.)

c) The Hollerith constants should not be mixed up with the H edit descriptor,
which has only be deleted in Fortran 95 (cf. "B.1.5 H edit descriptor" in F95).

 * * *

> You folks think of the crazy stuff :)  I will check into this.

Well, that's the nice thing. With minimal modifications even Fortran IV
programs will run with today's compiler. Compare this with Python where you
need to modify/audit your code to go from Python 2 (released 2000) to 3
(released 2008).

If you look at the example on page 46 of "Fortran - Programmer's Reference
Manual" from 1956, you have no trouble except for the FREQUENCY statement
(estimate of likelihood that a certain branch is taken) - and also on p. 48 it
does not look to strange, though WRITE TAPE, END FILE and MORE PROGRAM do not
exist anymore. And contrary to the the H edit descriptor, Hollerith constants
wee not available; as there were no DATA nor subroutines that it not
surprising. (There were functions but they could not be written in Fortran.)

 * * *

See: http://gcc.gnu.org/wiki/GFortranStandards for the Fortran 77 and 66
standards - and the Fortran handbook of 1956.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217

[Bug fortran/43217] Output of Hollerith constants which are not a multiple of 4 bytes

[burnus at gcc dot gnu dot org]

------- Comment #4 from burnus at gcc dot gnu dot org  2010-03-02 09:50 -------
For DATA gfortran already pads the Hollerith constant; maybe the simplest would
be to modify primary.c's match_hollerith_constant to simply add tailing spaces
such that the length is multiples of the storage size of, e.g., a default
integer - or of gfc_numeric_storage_size? (They are not the same).

Something like
  chunk_size = gfc_integer_kinds[gfc_default_integer_kind].bit_size
               /gfc_char_kinds[gfc_default_char_kind].bit_size;
  extra_size = num % chunk_size;
  size = num + 1 + (extra_size > 0) ? chunk_size - extra_size : 0;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217

[Bug fortran/43217] Output of Hollerith constants which are not a multiple of 4 bytes

[jvdelisle at gcc dot gnu dot org]

------- Comment #5 from jvdelisle at gcc dot gnu dot org  2010-03-04 03:08 -------
Tobias,

If you have a fix in mind, you are welcome to take this.  I am going to work
the namelist bug first.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217

[Bug fortran/43217] Output of Hollerith constants which are not a multiple of 4 bytes

[kargl at gcc dot gnu dot org]

------- Comment #6 from kargl at gcc dot gnu dot org  2010-03-04 03:15 -------
(In reply to comment #5)
> Tobias,
> 
> If you have a fix in mind, you are welcome to take this.  I am going to work
> the namelist bug first.
> 

Just close the report.  Using Hollerith in 2010 is a less than 
smart idea.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217

[Bug fortran/43217] Output of Hollerith constants which are not a multiple of 4 bytes

[jvdelisle at gcc dot gnu dot org]

------- Comment #7 from jvdelisle at gcc dot gnu dot org  2010-08-21 16:42 -------
Created an attachment (id=21539)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21539&action=view)
Proposed patch

This patch adds the padding requested. Output of test case matches a few of the
other compilers.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217

[Bug fortran/43217] Output of Hollerith constants which are not a multiple of 4 bytes

[jvdelisle at gcc dot gnu dot org]

------- Comment #8 from jvdelisle at gcc dot gnu dot org  2010-08-27 06:50 -------
Subject: Bug 43217

Author: jvdelisle
Date: Fri Aug 27 06:50:03 2010
New Revision: 163581

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=163581
Log:
2010-08-27  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/43217
        * primary.c (match_hollerith_constant): Calculate padding needed to
        fill default integer and allocate string for that size.  Set pad bytes
        to ' '.
        * gfortran.h: Add hollerith pad value to type spec union.
        * data.c (create_character_initializer): Fix spelling of function name.
        Use hollerith pad value to calculate length.
        * arith.c (hollerith2representation); Use hollerith pad value to
        calculate length.

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/arith.c
    trunk/gcc/fortran/data.c
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/primary.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217

[Bug fortran/43217] Output of Hollerith constants which are not a multiple of 4 bytes

[burnus at gcc dot gnu dot org]

------- Comment #9 from burnus at gcc dot gnu dot org  2010-08-27 07:26 -------
Close as FIXED (on the 4.6 trunk).

Thanks for fixing it, Jerry!


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217

[Bug fortran/43217] Output of Hollerith constants which are not a multiple of 4 bytes

[dominiq at lps dot ens dot fr]

------- Comment #10 from dominiq at lps dot ens dot fr  2010-08-27 10:23 -------
I think the test case has not been committed.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217

[Bug fortran/43217] Output of Hollerith constants which are not a multiple of 4 bytes

[jvdelisle at gcc dot gnu dot org]

------- Comment #11 from jvdelisle at gcc dot gnu dot org  2010-08-27 14:02 -------
Dominiq, can you test the output of the test case for me on PPC?

hollerith8.f90 in the gfortran post.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217

[Bug fortran/43217] Output of Hollerith constants which are not a multiple of 4 bytes

[dominiq at lps dot ens dot fr]

------- Comment #12 from dominiq at lps dot ens dot fr  2010-08-27 14:20 -------
On ppc, the original test gives before patch

48454C4C 4F20594F 55000000

So it seems that the test is likely to fail on ppc.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217

[Bug fortran/43217] Output of Hollerith constants which are not a multiple of 4 bytes

[dominiq at lps dot ens dot fr]

------- Comment #13 from dominiq at lps dot ens dot fr  2010-08-27 14:48 -------
The following test

! { dg-do run )
program hello2
  call wrtout (9hHELLO YOU, 9)
  stop
end

subroutine wrtout (iarray, nchrs)
  integer(1), parameter :: zero = 0
  LOGICAL, PARAMETER :: bigend = IACHAR(TRANSFER(1,"a")) == zero

  integer iarray(1)
  integer nchrs

  integer icpw
  data icpw/4/
  integer i, nwrds
  character(len=33) outstr

  nwrds = (nchrs + icpw - 1) /icpw
  write(outstr,'(4(z8," "))') (iarray(i), i=1,nwrds)
  if (.not.bigend.and.outstr.ne."4C4C4548 4F59204F 20202055") call abort
  if (bigend.and.outstr.ne."48454C4C 4F20594F 55202020") call abort
  return
end
! { dg-warning "Hollerith constant" "" { target *-*-* } 3 }
! { dg-warning "Rank mismatch" "" { target *-*-* } 3 }

seems to work on ppc and *86* platforms (please adjust the test according your
taste!-).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217

[Bug fortran/43217] Output of Hollerith constants which are not a multiple of 4 bytes

[jvdelisle at gcc dot gnu dot org]

------- Comment #14 from jvdelisle at gcc dot gnu dot org  2010-08-27 15:00 -------
Subject: Bug 43217

Author: jvdelisle
Date: Fri Aug 27 15:00:11 2010
New Revision: 163588

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=163588
Log:
2010-08-27  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libfortran/43217
        * gfortran.dg/hollerith8.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/hollerith8.f90
Modified:
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217

[Bug fortran/43217] Output of Hollerith constants which are not a multiple of 4 bytes

[jvdelisle at gcc dot gnu dot org]

------- Comment #15 from jvdelisle at gcc dot gnu dot org  2010-08-27 15:01 -------
Dominique, thanks for testing that.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43217