public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/43259] ext/profile/all.cc fails on Solaris 11/x86
Date: Thu, 04 Mar 2010 17:44:00 -0000	[thread overview]
Message-ID: <20100304174425.3962.qmail@sourceware.org> (raw)
In-Reply-To: <bug-43259-279@http.gcc.gnu.org/bugzilla/>



------- Comment #1 from redi at gcc dot gnu dot org  2010-03-04 17:44 -------
The problematic line expands to:

  static pthread_mutex_t __global_lock(PTHREAD_MUTEX_INITIALIZER);

which is clearly wrong when PTHREAD_MUTEX_INITIALIZER is of the form {...}

As you suggest, it should be using gthreads, but a simpler fix for now would be
to avoid using _GLIBCXX_PROFILE_DEFINE_DATA and declare __get___global_lock
directly in profiler_trace.h, something like:

inline __mutex_t& __get___global_lock() {
  static __mutex_t __global_lock = PTHREAD_MUTEX_INITIALIZER;
  return __global_lock;
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43259


  reply	other threads:[~2010-03-04 17:44 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-04 17:27 [Bug libstdc++/43259] New: " ro at gcc dot gnu dot org
2010-03-04 17:44 ` redi at gcc dot gnu dot org [this message]
2010-03-04 17:45 ` [Bug libstdc++/43259] ext/profile/all.cc fails on Solaris ebotcazou at gcc dot gnu dot org
2010-03-05 10:07 ` paolo dot carlini at oracle dot com
2010-03-05 18:41 ` ro at gcc dot gnu dot org
2010-03-05 23:18 ` ebotcazou at gcc dot gnu dot org
2010-03-21  1:44 ` paolo dot carlini at oracle dot com
2010-03-21  1:59 ` paolo dot carlini at oracle dot com
2010-03-21  4:52 ` rus at google dot com
2010-03-21 11:13 ` paolo dot carlini at oracle dot com
2010-03-21 19:15 ` paolo dot carlini at oracle dot com
2010-04-09 10:08 ` paolo dot carlini at oracle dot com
2010-04-28 18:37 ` ro at gcc dot gnu dot org
2010-04-28 19:06 ` rus at google dot com
2010-05-05  3:09 ` rus at google dot com
2010-05-05 10:46 ` kgardas at objectsecurity dot com
2010-05-05 10:47 ` kgardas at objectsecurity dot com
2010-05-06  2:04 ` rus at google dot com
2010-05-06  2:19 ` rus at google dot com
2010-05-06 16:25 ` paolo dot carlini at oracle dot com
2010-05-06 19:44 ` rus at google dot com
2010-05-06 20:25 ` paolo dot carlini at oracle dot com
2010-05-07  6:53 ` kgardas at objectsecurity dot com
2010-05-07 17:50 ` rus at google dot com
2010-05-09 16:57 ` paolo dot carlini at oracle dot com
2010-05-11 10:22 ` paolo at gcc dot gnu dot org
2010-05-11 10:23 ` paolo at gcc dot gnu dot org
2010-05-14 11:40 ` paolo at gcc dot gnu dot org
2010-05-14 11:41 ` paolo dot carlini at oracle dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100304174425.3962.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).