public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "janus at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/43256] [OOP] TBP with missing optional arg
Date: Thu, 04 Mar 2010 21:14:00 -0000	[thread overview]
Message-ID: <20100304211406.1636.qmail@sourceware.org> (raw)
In-Reply-To: <bug-43256-16146@http.gcc.gnu.org/bugzilla/>



------- Comment #3 from janus at gcc dot gnu dot org  2010-03-04 21:14 -------
Ok, think I got it. It's a one-liner:

Index: gcc/fortran/resolve.c
===================================================================
--- gcc/fortran/resolve.c       (revision 157225)
+++ gcc/fortran/resolve.c       (working copy)
@@ -5124,7 +5124,7 @@ resolve_compcall (gfc_expr* e, bool fcn)
     return FAILURE;

   e->value.function.actual = newactual;
-  e->value.function.name = e->value.compcall.name;
+  e->value.function.name = NULL;
   e->value.function.esym = target->n.sym;
   e->value.function.class_esym = NULL;
   e->value.function.isym = NULL;


Hope this produces no regressions.

[Explanation: The problem was that 'compare_actual_formal', which sets up the
null pointer for the missing actual arg, was never called for the TBP call. Due
to e->value.function.name being set already, 'resolve_function' always assumed
the function call had already been resolved, although it was never done.]


-- 

janus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |janus at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-03-04 21:14:06
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43256


  parent reply	other threads:[~2010-03-04 21:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-04 15:44 [Bug fortran/43256] New: [OOP] character-valued " janus at gcc dot gnu dot org
2010-03-04 16:04 ` [Bug fortran/43256] " janus at gcc dot gnu dot org
2010-03-04 16:12 ` [Bug fortran/43256] [OOP] " janus at gcc dot gnu dot org
2010-03-04 21:14 ` janus at gcc dot gnu dot org [this message]
2010-03-04 22:11 ` janus at gcc dot gnu dot org
2010-03-04 22:44 ` janus at gcc dot gnu dot org
2010-03-05  9:36 ` janus at gcc dot gnu dot org
2010-03-05  9:56 ` janus at gcc dot gnu dot org
2010-03-07 14:07 ` janus at gcc dot gnu dot org
2010-03-07 15:59 ` dominiq at lps dot ens dot fr
2010-03-08  9:35 ` janus at gcc dot gnu dot org
2010-03-08  9:37 ` janus at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100304211406.1636.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).