[Bug fortran/43409] New: I/O: INQUIRE for SIZE does not work.

[Bug fortran/43409] New: I/O: INQUIRE for SIZE does not work.

[burnus at gcc dot gnu dot org]

Found at
http://groups.google.com/group/comp.lang.fortran/browse_thread/thread/110fb27c70e1a193
Reported by: Philippe Bourdin

The following program always prints "-42" independent whether the file exists
or not. It at least should initialize the variable by "-1".

!-------------------
integer :: i
i = -42
inquire(file='test.dat', size=i)
print *, i
end
!-------------------


"9.9.1.29 SIZE= specifier in the INQUIRE statement"

"The scalar-int-variable in the SIZE= specifier is assigned the size of the
file in file storage units. If the file size cannot be determined, the variable
is assigned the value -1.

"For a file that may be connected for stream access, the file size is the
number of the highest-numbered file storage unit in the file. For a file that
may be connected for sequential or direct access, the file size may be
different from the number of storage units implied by the data in the records;
the exact relationship is processor-dependent."


-- 
           Summary: I/O: INQUIRE for SIZE does not work.
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[burnus at gcc dot gnu dot org]

------- Comment #1 from burnus at gcc dot gnu dot org  2010-03-17 17:34 -------
If one checks libgfortran/io/*, one sees that (dtp->common.flags &
IOPARM_DT_HAS_SIZE) is only used for read.c and transfer.c and is not touched
at all for inquire.c.

Work-around: gfortran offers the STAT, FSTAT, and LSTAT intrinsics.


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jvdelisle at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[burnus at gcc dot gnu dot org]

------- Comment #2 from burnus at gcc dot gnu dot org  2010-03-17 17:43 -------
I was wondering about connected files. (I think it only applies to
inquire_via_unit.) What does one return here if the file has not been flushed?
The *STAT result or does one calls flush on the unit and uses then *STAT?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[jvdelisle at gcc dot gnu dot org]

------- Comment #3 from jvdelisle at gcc dot gnu dot org  2010-03-18 02:14 -------
I have a few other bugs ahead of this, but I will fix it if no one else does so
before I get to it.  


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[jvdelisle at gcc dot gnu dot org]

------- Comment #4 from jvdelisle at gcc dot gnu dot org  2010-03-19 03:24 -------
The front end work for this is complete.  We simply forgot to implement on the
runtime side.  One thing we have to be careful with is the kind of the integer.
Currently it is limited to kind=4 and all results are cast to that size.  In
other words:

i = (integer(kind=2)) size.1; or

i = (integer(kind=8)) size.1;

size.1 is always kind=4 so we may need some error checks if someone tries to
stuff a large file size into a small space.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-03-19 03:24:02
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[burnus at gcc dot gnu dot org]

------- Comment #5 from burnus at gcc dot gnu dot org  2010-03-19 17:40 -------
(In reply to comment #4)
> size.1 is always kind=4 so we may need some error checks if someone tries to
> stuff a large file size into a small space.

Thus, we should change the ABI at some point (e.g. when doing the array desc.
update).

For too large files, one can meanwhile return -1 ("If the file size cannot be
determined").


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[jvdelisle at gcc dot gnu dot org]

------- Comment #6 from jvdelisle at gcc dot gnu dot org  2010-03-19 20:25 -------
On it.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jvdelisle at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2010-03-19 03:24:02         |2010-03-19 20:25:58
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[jvdelisle at gcc dot gnu dot org]

------- Comment #7 from jvdelisle at gcc dot gnu dot org  2010-03-20 14:39 -------
Subject: Bug 43409

Author: jvdelisle
Date: Sat Mar 20 14:39:00 2010
New Revision: 157593

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=157593
Log:
2010-03-20  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/43409
        * ioparm.def: Change inquire size variable to type pointer to
        GFC_IO_INT type.

2010-03-20  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/43409
        * io/unix.h: Add prototype for new function to return file size.
        * io/unix.c (file_size): New function.
        * io/inquire.c (inquire_via_unit): Use new function.
        (inquire_via_filename): Use new function.

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/ioparm.def
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/inquire.c
    trunk/libgfortran/io/unix.c
    trunk/libgfortran/io/unix.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[jvdelisle at gcc dot gnu dot org]

------- Comment #8 from jvdelisle at gcc dot gnu dot org  2010-03-20 14:42 -------
Subject: Bug 43409

Author: jvdelisle
Date: Sat Mar 20 14:42:04 2010
New Revision: 157594

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=157594
Log:
2010-03-20  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/43409
        * gfortran.dg/inquire_size.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/inquire_size.f90
Modified:
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[dominiq at lps dot ens dot fr]

------- Comment #9 from dominiq at lps dot ens dot fr  2010-03-21 08:58 -------
The test fails gfortran.dg/inquire_size.f90 on powerpc-apple-darwin9 (see
http://gcc.gnu.org/ml/gcc-testresults/2010-03/msg01801.html). The failures are
due to bad values of size, as shown by the following output of the tested
variables (i=0 instead of 3000, and 8324 instead of -1):

 T testfile                                 0
 T testfile                                 0
        8324
Abort


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[jvdelisle at gcc dot gnu dot org]

------- Comment #10 from jvdelisle at gcc dot gnu dot org  2010-03-21 13:31 -------
Dominiq, can you test the FSTAT intrinsic while you are at it? With the same
file I wonder if it gives the same results.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[jvdelisle at gcc dot gnu dot org]

------- Comment #11 from jvdelisle at gcc dot gnu dot org  2010-03-22 02:03 -------
Found it:

Index: io.h
===================================================================
--- io.h        (revision 157617)
+++ io.h        (working copy)
@@ -331,7 +331,7 @@
   CHARACTER2 (round);
   CHARACTER1 (sign);
   GFC_INTEGER_4 *pending;
-  GFC_INTEGER_4 *size;
+  GFC_IO_INT *size;
   GFC_INTEGER_4 *id;
 }
 st_parameter_inquire;

I will commit as obvious after regression testing on ppc and x86-64.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[jvdelisle at gcc dot gnu dot org]

------- Comment #12 from jvdelisle at gcc dot gnu dot org  2010-03-22 02:39 -------
Subject: Bug 43409

Author: jvdelisle
Date: Mon Mar 22 02:39:02 2010
New Revision: 157618

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=157618
Log:
2010-03-21  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/43409
        * io/io.h: Fix type of size in st_parameter_inquire structure.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/io.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[jvdelisle at gcc dot gnu dot org]

------- Comment #13 from jvdelisle at gcc dot gnu dot org  2010-03-22 02:41 -------
I will back port all of this business to 4.4 in a few days.  Dominique, please
confirm this fixes it on your machine and I thank you very much for the report.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[dominiq at lps dot ens dot fr]

------- Comment #14 from dominiq at lps dot ens dot fr  2010-03-22 09:05 -------
> Dominique, please confirm this fixes it on your machine.

It does (for limited testing only). Thanks for the fix. Note that a "quick" (8
hours latency) way to check what's happen on powerpc is to monitor the tester
"regress" on http://gcc.gnu.org/ml/gcc-testresults/ .
It darwin oriented and does not test everything (no -m64, no graphite, ...),
but it gives early warnings about problems on ppc.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[dominiq at lps dot ens dot fr]

------- Comment #15 from dominiq at lps dot ens dot fr  2010-03-22 12:29 -------
Full regtesting passed on powerpc-apple-darwin9.8.0 for -m32 (see
http://gcc.gnu.org/ml/gcc-testresults/2010-03/msg01896.html ).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[jvdelisle at gcc dot gnu dot org]

------- Comment #16 from jvdelisle at gcc dot gnu dot org  2010-03-31 02:00 -------
Subject: Bug 43409

Author: jvdelisle
Date: Wed Mar 31 01:59:52 2010
New Revision: 157846

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=157846
Log:
2010-03-30  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/43409
        Back port from trunk.
        * ioparm.def: Change inquire size variable to type pointer to
        GFC_IO_INT type.

Modified:
    branches/gcc-4_4-branch/gcc/fortran/ChangeLog
    branches/gcc-4_4-branch/gcc/fortran/ioparm.def


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[jvdelisle at gcc dot gnu dot org]

------- Comment #17 from jvdelisle at gcc dot gnu dot org  2010-03-31 02:01 -------
Subject: Bug 43409

Author: jvdelisle
Date: Wed Mar 31 02:00:51 2010
New Revision: 157847

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=157847
Log:
2010-03-30  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/43409
        Back port from trunk.
        * io/io.h: Fix type of size in st_parameter_inquire structure.
        Add prototype for new function to return file size.
        * io/unix.c (file_size): New function.
        * io/inquire.c (inquire_via_unit): Use new function.
        (inquire_via_filename): Use new function.

Modified:
    branches/gcc-4_4-branch/libgfortran/ChangeLog
    branches/gcc-4_4-branch/libgfortran/io/inquire.c
    branches/gcc-4_4-branch/libgfortran/io/io.h
    branches/gcc-4_4-branch/libgfortran/io/unix.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[jvdelisle at gcc dot gnu dot org]

------- Comment #18 from jvdelisle at gcc dot gnu dot org  2010-03-31 02:06 -------
Subject: Bug 43409

Author: jvdelisle
Date: Wed Mar 31 02:05:56 2010
New Revision: 157848

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=157848
Log:
2010-03-30  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libfortran/43409
        * gfortran.dg/inquire_size.f90: New test.

Added:
    branches/gcc-4_4-branch/gcc/testsuite/gfortran.dg/inquire_size.f90
Modified:
    branches/gcc-4_4-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409

[Bug fortran/43409] I/O: INQUIRE for SIZE does not work.

[jvdelisle at gcc dot gnu dot org]

------- Comment #19 from jvdelisle at gcc dot gnu dot org  2010-03-31 02:10 -------
Fixed on 4.4 Closing


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43409