[Bug c++/43487] New: method locations are incorrect

[Bug c++/43487] New: method locations are incorrect

[tglek at mozilla dot com]

Following up on bug https://bugzilla.mozilla.org/show_bug.cgi?id=497972

Function locations do not make sense at the moment
1176 nsresult
1177 RDFServiceImpl::GetBlobLiteral(const PRUint8 *aBytes, PRInt32 aLength,
1178                                nsIRDFBlob **aResult)

Here the location of the FUNCTION_DECL ends up being 1178. Not 1176


-- 
           Summary: method locations are incorrect
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tglek at mozilla dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43487

[Bug c++/43487] method locations are incorrect

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2010-03-22 22:34 -------
is it really 1178 with the column of the ending parenthesis?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43487

[Bug c++/43487] method locations are incorrect

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43487

[Bug c++/43487] method locations are incorrect

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2010-03-22 22:38 -------
I think at one point we had it being the open { but we changed it to the
closing ) recently.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43487

[Bug c++/43487] method locations are incorrect

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2010-03-22 22:41 -------
Wait wrong one.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43487

[Bug c++/43487] method locations are incorrect

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2010-03-22 22:40 -------
In fact this changed with:
2009-12-01  Taras Glek  <taras@mozilla.com>

        * parser.c (cp_parser_class_specifier): Set class location to that
        of IDENTIFIER_NODE instead of '{' when possible.


:).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43487

[Bug c++/43487] method locations are incorrect

[jason at gcc dot gnu dot org]

------- Comment #5 from jason at gcc dot gnu dot org  2010-03-23 01:46 -------
I would think the position of the declarator-id ("GetBlobLiteral") would be a
better choice.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43487

[Bug c++/43487] method locations are incorrect

[dodji at gcc dot gnu dot org]

------- Comment #6 from dodji at gcc dot gnu dot org  2010-03-25 18:21 -------
I guess this would be useful for diagnostic too.


-- 

dodji at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dodji at gcc dot gnu dot org
           Keywords|                            |diagnostic


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43487

[Bug c++/43487] method locations are incorrect

[manu at gcc dot gnu.org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 3663 bytes --]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43487

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #8 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
I cannot reproduce this and no testcase is forthcoming (and Mozilla already
replaced their GCC plugins for Clang, so probably they don't care anymore about
this).
>From gcc-bugs-return-463861-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Oct 12 13:59:36 2014
Return-Path: <gcc-bugs-return-463861-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 3088 invoked by alias); 12 Oct 2014 13:59:36 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 3059 invoked by uid 48); 12 Oct 2014 13:59:32 -0000
From: "Joost.VandeVondele at mat dot ethz.ch" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/63514] New: functions containing volatile are considered pure
Date: Sun, 12 Oct 2014 13:59:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: Joost.VandeVondele at mat dot ethz.ch
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-63514-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg00882.txt.bz2
Content-length: 1238

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc514

            Bug ID: 63514
           Summary: functions containing volatile are considered pure
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: Joost.VandeVondele at mat dot ethz.ch

The following testcase is miscompiled at -O1:

> cat test.f90
MODULE M1
CONTAINS
  INTEGER FUNCTION F1()
    INTEGER, VOLATILE :: i
    F1=i
  END FUNCTION
  INTEGER FUNCTION F2()
    F2ñ()+F1()
  END FUNCTION
END MODULE

> gfortran -O1 -fdump-tree-optimized -fno-inline -c test.f90

;; Function f2 (__m1_MOD_f2, funcdef_no=0, decl_uid#55, cgraph_uid=0,
symbol_order=0)

f2 ()
{
  integer(kind=4) __var_1;
  integer(kind=4) __result_f2.0_3;

  <bb 2>:
  __var_1_2 = f1 ();
  __result_f2.0_3 = __var_1_2 + __var_1_2;
  return __result_f2.0_3;

}

f1 should be called twice in this case, as it returns the value of a volatile.
I believe f1 is being considered as pure here, which seems not correct.
Actually, it doesn't generate an error if I add 'PURE' to the function
definition, which I assume is not correct either.

[Bug c++/43487] method locations are incorrect

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43487

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2013-05-24
                 CC|gcc-bugs at gcc dot gnu.org        |
     Ever confirmed|0                           |1

--- Comment #7 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Can we have a short self contained testcase for this issue? May be easy to fix.