[Bug c/43642] New: FAIL: c-c++-common/raw-string-1.c

[Bug c/43642] New: FAIL: c-c++-common/raw-string-1.c

[dominiq at lps dot ens dot fr]

The test c-c++-common/raw-string-1.c fails on ppc (see
http://gcc.gnu.org/ml/gcc-testresults/2010-04/msg00315.html or
http://gcc.gnu.org/ml/gcc-testresults/2010-04/msg00299.html).

I have reduced the failures to any of the following if:

int
main (void)
{
/*  if (sizeof (s4) != sizeof (s5)
      || __builtin_memcmp (s4, s5, sizeof (s4)) != 0)
    __builtin_abort (); */
/*  if (sizeof (t4) != sizeof (t5)
      || __builtin_memcmp (t4, t5, sizeof (t4)) != 0)
    __builtin_abort (); */
/*  if (sizeof (u4) != sizeof (u5)
      || __builtin_memcmp (u4, u5, sizeof (u4)) != 0)
    __builtin_abort (); */
  if (sizeof (U4) != sizeof (U5)
      || __builtin_memcmp (U4, U5, sizeof (U4)) != 0)
    __builtin_abort (); 
/*  if (sizeof (L4) != sizeof (L5)
      || __builtin_memcmp (L4, L5, sizeof (L4)) != 0)
    __builtin_abort (); */
  return 0;
}

It looks like an endianness issue.


-- 
           Summary: FAIL: c-c++-common/raw-string-1.c
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dominiq at lps dot ens dot fr
 GCC build triplet: powerpc-*-*
  GCC host triplet: powerpc-*-*
GCC target triplet: powerpc-*-*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43642

[Bug c/43642] FAIL: c-c++-common/raw-string-1.c

[jakub at gcc dot gnu dot org]

------- Comment #1 from jakub at gcc dot gnu dot org  2010-04-04 18:41 -------
It fails on s390*-linux too.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43642

[Bug c/43642] FAIL: c-c++-common/raw-string-1.c

[dominiq at lps dot ens dot fr]

------- Comment #2 from dominiq at lps dot ens dot fr  2010-04-04 19:42 -------
Fails on sparc64-unknown-linux-gnu too (see
http://gcc.gnu.org/ml/gcc-testresults/2010-04/msg00295.html ).


-- 

dominiq at lps dot ens dot fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at redhat dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43642

[Bug c/43642] FAIL: c-c++-common/raw-string-1.c

[dominiq at lps dot ens dot fr]

------- Comment #3 from dominiq at lps dot ens dot fr  2010-04-04 21:03 -------
Fails on hppa-unknown-linux-gnu too (see
http://gcc.gnu.org/ml/gcc-testresults/2010-04/msg00313.html ).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43642

[Bug c/43642] FAIL: c-c++-common/raw-string-1.c

[jakub at gcc dot gnu dot org]

------- Comment #4 from jakub at gcc dot gnu dot org  2010-04-05 15:40 -------
Minimal testcase seems to be:
const char s4[] = R"(??()";
On powerpc64-linux native, compiled with -trigraphs -std=gnu99 -S this yields
the correct:
s4:
        .string "??("
but compiled with -std=gnu99 -trigraphs -S it yields:
s4:
        .string "??"
        .string ""
Couldn't reproduce with a cross compiler though.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43642

[Bug c/43642] FAIL: c-c++-common/raw-string-1.c

[jakub at gcc dot gnu dot org]

------- Comment #5 from jakub at gcc dot gnu dot org  2010-04-05 15:44 -------
And it shows on the same testcase even with just preprocessing:
gcc -E -std=gnu99 -trigraphs r.c | tail -n 1 | hexdump
0000000 636f 6e73 7420 6368 6172 2073 345b 5d20
0000010 3d20 5222 283f 3f00 2922 3b0a          
000001c
gcc -E -trigraphs -std=gnu99 r.c | tail -n 1 | hexdump
0000000 636f 6e73 7420 6368 6172 2073 345b 5d20
0000010 3d20 5222 283f 3f28 2922 3b0a          
000001c

Note 0x00 vs. 0x28 (the latter is correct).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43642

[Bug preprocessor/43642] FAIL: c-c++-common/raw-string-1.c

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
          Component|c                           |preprocessor
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-04-05 15:55:46
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43642

[Bug preprocessor/43642] FAIL: c-c++-common/raw-string-1.c

[jakub at gcc dot gnu dot org]

------- Comment #6 from jakub at gcc dot gnu dot org  2010-04-05 15:57 -------
Created an attachment (id=20311)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20311&action=view)
gcc45-pr43642.patch

Untested fix.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43642

[Bug preprocessor/43642] FAIL: c-c++-common/raw-string-1.c

[jakub at gcc dot gnu dot org]

------- Comment #7 from jakub at gcc dot gnu dot org  2010-04-05 16:00 -------
Note that a few lines before that is if (_cpp_trigraph_map[note->type])
and _cpp_trigraph_map is [UCHAR_MAX + 1] sized array, so note->type surely must
be an unsigned char and nothing else (well, it will be only one of the 9
special char values), despite the type of note->type being actually unsigned
int.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43642

[Bug preprocessor/43642] FAIL: c-c++-common/raw-string-1.c

[jason at gcc dot gnu dot org]

------- Comment #8 from jason at gcc dot gnu dot org  2010-04-05 16:14 -------
The patch is OK if it passes testing.  Though you might use "uchar" rather than
"unsigned char".


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43642

[Bug preprocessor/43642] FAIL: c-c++-common/raw-string-1.c

[jakub at gcc dot gnu dot org]

------- Comment #9 from jakub at gcc dot gnu dot org  2010-04-06 07:03 -------
Subject: Bug 43642

Author: jakub
Date: Tue Apr  6 07:02:40 2010
New Revision: 157979

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=157979
Log:
        PR preprocessor/43642
        * lex.c (lex_raw_string): Change type of TYPE variable to
        unsigned char.

Modified:
    trunk/libcpp/ChangeLog
    trunk/libcpp/lex.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43642

[Bug preprocessor/43642] FAIL: c-c++-common/raw-string-1.c

[jakub at gcc dot gnu dot org]

------- Comment #10 from jakub at gcc dot gnu dot org  2010-04-06 07:47 -------
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43642