[Bug target/43635] [4.5 Regression] ICE in s390_emit_call, at config/s390/s390.c:9484

[Bug target/43635] [4.5 Regression] ICE in s390_emit_call, at config/s390/s390.c:9484

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2010-04-03 14:07 -------
Created an attachment (id=20300)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20300&action=view)
preprocessed source


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43635

[Bug target/43635] [4.5 Regression] ICE in s390_emit_call, at config/s390/s390.c:9484

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |krebbel at gcc dot gnu dot
                   |                            |org
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43635

[Bug target/43635] New: [4.5 Regression] ICE in s390_emit_call, at config/s390/s390.c:9484

[rguenth at gcc dot gnu dot org]

/usr/lib/gcc/s390-suse-linux/4.5/cc1 -fpreprocessed sqlite3.i -quiet -dumpbase
sqlite3.c -march=z900 -mtune=z9-109 -m31 -mesa -auxbase-strip .libs/sqlite3.o
-g -O2 -Wall -version -fmessage-length=0 -fstack-protector -funwind-tables
-fasynchronous-unwind-tables -fPIC -o sqlite3.s
sqlite3.c: In function 'porter_stemmer':
sqlite3.c:104020:41: warning: value computed is not used
sqlite3.c:104024:39: warning: value computed is not used
sqlite3.c:104037:35: warning: value computed is not used
sqlite3.c:104042:39: warning: value computed is not used
sqlite3.c:104048:41: warning: value computed is not used
sqlite3.c:104053:39: warning: value computed is not used
sqlite3.c:104062:36: warning: value computed is not used
sqlite3.c:104069:37: warning: value computed is not used
sqlite3.c:104112:39: warning: value computed is not used
sqlite3.c:104132:34: warning: value computed is not used
sqlite3.c: At top level:
sqlite3.c:99963:12: warning: 'sqlite3Fts3DeleteVtab' declared 'static' but
never defined
sqlite3.c:99964:12: warning: 'sqlite3Fts3InitVtab' declared 'static' but never
defined
sqlite3.c:102221:13: warning: 'sqlite3Fts3IcuTokenizerModule' declared 'static'
but never defined
sqlite3.c: In function 'unixDlSym':
sqlite3.c:26055:3: internal compiler error: in s390_emit_call, at
config/s390/s390.c:9484
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://bugs.opensuse.org/> for instructions.


-- 
           Summary: [4.5 Regression] ICE in s390_emit_call, at
                    config/s390/s390.c:9484
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rguenth at gcc dot gnu dot org
GCC target triplet: s390-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43635

[Bug target/43635] [4.5 Regression] ICE in s390_emit_call, at config/s390/s390.c:9484

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2010-04-06 11:21 -------
GCC 4.5.0 is being released.  Deferring to 4.5.1.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.0                       |4.5.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43635

[Bug target/43635] [4.5/4.6 Regression] ICE in s390_emit_call, at config/s390/s390.c:9484

[krebbel at gcc dot gnu dot org]

------- Comment #3 from krebbel at gcc dot gnu dot org  2010-04-07 15:56 -------
Created an attachment (id=20328)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20328&action=view)
Reduced testcase

The check for valid sibcalls in the S/390 back-end relies on the decl to be
available in the DECL parameter:

  /* The 31 bit PLT code uses register 12 (GOT pointer - caller saved)
     which would have to be restored before the sibcall.  */
  if (!TARGET_64BIT && flag_pic && decl && !targetm.binds_local_p (decl))
    return false;

The type cast of the function pointer in the testcase introduces a temporary
variable on 4.5 which is not linked with the function decl anymore:

  x_1 = (void (*<T244>) (float) (*<T248>) (void *)) d;
  D.1966_3 = x_1 (p_2(D)); [tail call]
  return D.1966_3;

With 4.4:

  D.1224 = (void (*<T242>) (float) (*<T246>) (void *)) d (p); [tail call]
  return D.1224;

So we probably have to always reject sibcalls if the fndecl is not reachable.


-- 

krebbel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20300|0                           |1
        is obsolete|                            |
         AssignedTo|unassigned at gcc dot gnu   |krebbel at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43635

[Bug target/43635] [4.5/4.6 Regression] ICE in s390_emit_call, at config/s390/s390.c:9484

[rguenther at suse dot de]

------- Comment #4 from rguenther at suse dot de  2010-04-08 08:11 -------
Subject: Re:  [4.5/4.6 Regression] ICE in s390_emit_call,
 at config/s390/s390.c:9484

On Wed, 7 Apr 2010, krebbel at gcc dot gnu dot org wrote:

> ------- Comment #3 from krebbel at gcc dot gnu dot org  2010-04-07 15:56 -------
> Created an attachment (id=20328)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20328&action=view)
>  --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20328&action=view)
> Reduced testcase
> 
> The check for valid sibcalls in the S/390 back-end relies on the decl to be
> available in the DECL parameter:
> 
>   /* The 31 bit PLT code uses register 12 (GOT pointer - caller saved)
>      which would have to be restored before the sibcall.  */
>   if (!TARGET_64BIT && flag_pic && decl && !targetm.binds_local_p (decl))
>     return false;
> 
> The type cast of the function pointer in the testcase introduces a temporary
> variable on 4.5 which is not linked with the function decl anymore:
> 
>   x_1 = (void (*<T244>) (float) (*<T248>) (void *)) d;
>   D.1966_3 = x_1 (p_2(D)); [tail call]
>   return D.1966_3;
> 
> With 4.4:
> 
>   D.1224 = (void (*<T242>) (float) (*<T246>) (void *)) d (p); [tail call]
>   return D.1224;
> 
> So we probably have to always reject sibcalls if the fndecl is not reachable.

The extra cast happens if the function signatures are not compatible
(by means of useless_type_conversion_p).  I can't deciper the
function type from (void (*<T244>) (float) (*<T248>) (void *))
right now, but it's early in the morning ;)

Richard.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43635

[Bug target/43635] [4.5/4.6 Regression] ICE in s390_emit_call, at config/s390/s390.c:9484

[krebbel at gcc dot gnu dot org]

------- Comment #5 from krebbel at gcc dot gnu dot org  2010-04-08 09:23 -------
(In reply to comment #4)
> The extra cast happens if the function signatures are not compatible
> (by means of useless_type_conversion_p).

Ok. Do you know why that behavior changed between gcc 4.4 and 4.5?

Is there a way to obtain the function decl from D.1966_3 in the 4.5 example or
do we really need to reject sibcall optimizations in that case?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43635

[Bug target/43635] [4.5/4.6 Regression] ICE in s390_emit_call, at config/s390/s390.c:9484

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2010-04-08 10:00 -------
(In reply to comment #5)
> (In reply to comment #4)
> > The extra cast happens if the function signatures are not compatible
> > (by means of useless_type_conversion_p).
> 
> Ok. Do you know why that behavior changed between gcc 4.4 and 4.5?

It changed because of the gimple type system got a verifier.

> Is there a way to obtain the function decl from D.1966_3 in the 4.5 example or
> do we really need to reject sibcall optimizations in that case?

You can do a lookup in the SSA web (well, but it'll be expanded as an
indirect call probably - you have to check).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43635

[Bug target/43635] [4.5/4.6 Regression] ICE in s390_emit_call, at config/s390/s390.c:9484

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43635

[Bug target/43635] [4.5/4.6 Regression] ICE in s390_emit_call, at config/s390/s390.c:9484

[krebbel at gcc dot gnu dot org]

------- Comment #7 from krebbel at gcc dot gnu dot org  2010-04-20 07:51 -------
Subject: Bug 43635

Author: krebbel
Date: Tue Apr 20 07:51:14 2010
New Revision: 158540

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=158540
Log:
2010-04-20  Andreas Krebbel  <Andreas.Krebbel@de.ibm.com>

        PR target/43635
        * config/s390/s390.c (s390_emit_call): Turn direct into indirect
        calls for -fpic -m31 if they have been sibcall optimized.

2010-04-20  Andreas Krebbel  <Andreas.Krebbel@de.ibm.com>

        PR target/43635
        * gcc.c-torture/compile/pr43635.c: New testcase.



Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/pr43635.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/s390/s390.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43635

[Bug target/43635] [4.5/4.6 Regression] ICE in s390_emit_call, at config/s390/s390.c:9484

[krebbel at gcc dot gnu dot org]

------- Comment #8 from krebbel at gcc dot gnu dot org  2010-04-20 08:18 -------
Subject: Bug 43635

Author: krebbel
Date: Tue Apr 20 08:18:18 2010
New Revision: 158541

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=158541
Log:
2010-04-20  Andreas Krebbel  <Andreas.Krebbel@de.ibm.com>

        PR target/43635
        * config/s390/s390.c (s390_emit_call): Turn direct into indirect
        calls for -fpic -m31 if they have been sibcall optimized.

2010-04-20  Andreas Krebbel  <Andreas.Krebbel@de.ibm.com>

        PR target/43635
        * gcc.c-torture/compile/pr43635.c: New testcase.


Added:
    branches/gcc-4_5-branch/gcc/testsuite/gcc.c-torture/compile/pr43635.c
Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/config/s390/s390.c
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43635

[Bug target/43635] [4.5/4.6 Regression] ICE in s390_emit_call, at config/s390/s390.c:9484

[krebbel at gcc dot gnu dot org]

------- Comment #9 from krebbel at gcc dot gnu dot org  2010-04-20 08:21 -------
Fixed with the patch above.


-- 

krebbel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43635