public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/40518] data races when calling std::string::erase() on empty string
Date: Thu, 08 Apr 2010 13:51:00 -0000	[thread overview]
Message-ID: <20100408135117.3849.qmail@sourceware.org> (raw)
In-Reply-To: <bug-40518-5876@http.gcc.gnu.org/bugzilla/>



------- Comment #20 from redi at gcc dot gnu dot org  2010-04-08 13:51 -------
You can still reduce the helgrind output with just one suppression

{
  libstdcxx_std_string_race_pr40518
  Helgrind:Race
  fun:_ZNSs9_M_mutateEmmm
}

I'm not convinced the impact is "severe", COW strings already have problems in
multiprocessor systems, I don't think erase() on empty strings is the
bottleneck!   It's not been a problem in my own experience, and I'm not aware
of any distros having felt the need to backport the patch to their 4.4
packages.

I'll look into backporting it tonight on condition you cease the hyperbole


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40518


  parent reply	other threads:[~2010-04-08 13:51 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-22 10:27 [Bug libstdc++/40518] New: " jwakely dot gcc at gmail dot com
2009-06-22 11:03 ` [Bug libstdc++/40518] " paolo dot carlini at oracle dot com
2009-06-22 11:06 ` paolo dot carlini at oracle dot com
2009-06-22 11:06 ` paolo dot carlini at oracle dot com
2009-06-22 11:58 ` jwakely dot gcc at gmail dot com
2009-06-22 12:02 ` paolo dot carlini at oracle dot com
2009-06-22 17:56 ` paolo dot carlini at oracle dot com
2009-06-22 17:56 ` paolo dot carlini at oracle dot com
2009-06-22 17:57 ` paolo dot carlini at oracle dot com
2009-06-22 20:30 ` jwakely dot gcc at gmail dot com
2009-06-23 12:37 ` paolo at gcc dot gnu dot org
2009-06-23 12:39 ` paolo dot carlini at oracle dot com
2010-04-07 17:55 ` bart dot vanassche at gmail dot com
2010-04-07 18:11 ` paolo dot carlini at oracle dot com
2010-04-07 19:06 ` redi at gcc dot gnu dot org
2010-04-08  6:04 ` bart dot vanassche at gmail dot com
2010-04-08  9:33 ` paolo dot carlini at oracle dot com
2010-04-08  9:34 ` paolo dot carlini at oracle dot com
2010-04-08  9:34 ` paolo dot carlini at oracle dot com
2010-04-08 10:28 ` bart dot vanassche at gmail dot com
2010-04-08 10:33 ` paolo dot carlini at oracle dot com
2010-04-08 13:51 ` redi at gcc dot gnu dot org [this message]
2010-04-08 14:04 ` paolo dot carlini at oracle dot com
2010-04-09  8:03 ` redi at gcc dot gnu dot org
2010-04-10 13:46 ` redi at gcc dot gnu dot org
2010-04-10 13:48 ` redi at gcc dot gnu dot org
     [not found] <bug-40518-4@http.gcc.gnu.org/bugzilla/>
2014-02-16 13:12 ` jackie.rosen at hushmail dot com
2021-11-05 23:18 ` timturnerc at yahoo dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100408135117.3849.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).