public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ramana at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/43698] Invalid code when building gentoo pax-utils-0.1.19 with -Os optimizations
Date: Fri, 09 Apr 2010 07:49:00 -0000	[thread overview]
Message-ID: <20100409074857.26540.qmail@sourceware.org> (raw)
In-Reply-To: <bug-43698-14457@http.gcc.gnu.org/bugzilla/>



------- Comment #5 from ramana at gcc dot gnu dot org  2010-04-09 07:48 -------
Actually strike out the last patch - that's just wrong for Thumb1. This is what
I am testing currently.


Index: arm.md
===================================================================
--- arm.md      (revision 158138)
+++ arm.md      (working copy)
@@ -11200,12 +11200,18 @@
 (define_insn "arm_rev"
   [(set (match_operand:SI 0 "s_register_operand" "=r")
        (bswap:SI (match_operand:SI 1 "s_register_operand" "r")))]
-  "TARGET_EITHER && arm_arch6"
+  "TARGET_32BIT && arm_arch6"
+  "rev%?\t%0, %1"
+  [(set_attr "predicable" "yes")
+   (set_attr "length" "4")]
+)
+
+(define_insn "thumb1_rev"
+  [(set (match_operand:SI 0 "s_register_operand" "=l")
+       (bswap:SI (match_operand:SI 1 "s_register_operand" "l")))]
+  "TARGET_THUMB1 && arm_arch6"
   "rev\t%0, %1"
-  [(set (attr "length")
-        (if_then_else (eq_attr "is_thumb" "yes")
-                     (const_int 2)
-                     (const_int 4)))]
+  [(set_attr "length" "2")]
 )

 (define_expand "arm_legacy_rev"


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43698


  parent reply	other threads:[~2010-04-09  7:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-09  0:05 [Bug c/43698] New: " siarhei dot siamashka at gmail dot com
2010-04-09  5:49 ` [Bug target/43698] " mikpe at it dot uu dot se
2010-04-09  6:57 ` mikpe at it dot uu dot se
2010-04-09  7:02 ` ramana at gcc dot gnu dot org
2010-04-09  7:38 ` ramana at gcc dot gnu dot org
2010-04-09  7:49 ` ramana at gcc dot gnu dot org [this message]
2010-04-09  8:05 ` siarhei dot siamashka at gmail dot com
2010-04-09  8:42 ` [Bug target/43698] [4.5/4.6 Regression] " rguenth at gcc dot gnu dot org
2010-04-12  8:38 ` ramana at gcc dot gnu dot org
2010-04-12  9:34 ` siarhei dot siamashka at gmail dot com
2010-04-12  9:51   ` Ramana Radhakrishnan
2010-04-12  9:51 ` ramana dot radhakrishnan at arm dot com
2010-05-17 18:48 ` siarhei dot siamashka at gmail dot com
2010-05-19 12:25 ` rguenth at gcc dot gnu dot org
2010-07-03 16:06 ` armin76 at gentoo dot org
2010-07-19 13:54 ` [Bug target/43698] [4.5/4.6 Regression] Wrong use of ARMv6 REV instruction for endian bytewapping with -Os or -O2 optimizations siarhei dot siamashka at gmail dot com
2010-07-22  8:31 ` ramana at gcc dot gnu dot org
2010-07-22 20:54 ` siarhei dot siamashka at gmail dot com
2010-07-23 12:22 ` ramana at gcc dot gnu dot org
2010-07-23 12:28 ` rguenther at suse dot de
2010-07-30 22:36 ` ramana at gcc dot gnu dot org
2010-07-30 22:39 ` ramana at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100409074857.26540.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).