[Bug middle-end/43793] New: [4.6 Regression] tree check: expected tree that contains ‘decl minimal’ structure, have ‘indirect_ref’ in gfc_trans_array_bound_check

[Bug middle-end/43793] New: [4.6 Regression] tree check: expected tree that contains ‘decl minimal’ structure, have ‘indirect_ref’ in gfc_trans_array_bound_check

[jv244 at cam dot ac dot uk]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

A recent regression on CP2K for

gcc version 4.6.0 20100419 (experimental) [trunk revision 158504] (GCC)

with the attached testcase and 'gfortran -c -fbounds-check':

1075.f90: In function ‘sparse_alltoall’:
1075.f90:544:0: internal compiler error: tree check: expected tree that
contains ‘decl minimal’ structure, have ‘indirect_ref’ in
gfc_trans_array_bound_check, at fortran/trans-array.c:2339
Please submit a full bug report,

reduced testcase to be attached.


-- 
           Summary: [4.6 Regression] tree check: expected tree that contains
                    ‘decl minimal’ structure, have ‘indirect_ref’ in
                    gfc_trans_array_bound_check
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jv244 at cam dot ac dot uk


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug middle-end/43793] [4.6 Regression] tree check: expected tree that contains ‘decl minimal’ structure, have ‘indirect_ref’ in gfc_trans_array_bound_check

[jv244 at cam dot ac dot uk]

------- Comment #1 from jv244 at cam dot ac dot uk  2010-04-19 07:52 -------
small enough for pasting:

> cat bug.f90
MODULE fft_tools
  INTEGER, PARAMETER :: sp=4, dp=8
  INTEGER, PARAMETER :: lp = dp
CONTAINS
  SUBROUTINE sparse_alltoall ( rs, scount, sreq, rq, rcount, rreq, group )
    COMPLEX(KIND=lp), DIMENSION(:, :), &
      POINTER                                :: rs
    COMPLEX(KIND=lp), DIMENSION(:, :), &
      POINTER                                :: rq
    IF ( rcount(pos) /= 0 ) THEN
       rq(1:rcount(pos),pos) = rs(1:rcount(pos),pos)
    END IF
  END SUBROUTINE sparse_alltoall
END MODULE fft_tools


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug middle-end/43793] [4.6 Regression] tree check: expected tree that contains ‘decl minimal’ structure, have ‘indirect_ref’ in gfc_trans_array_bound_check

[dominiq at lps dot ens dot fr]

------- Comment #2 from dominiq at lps dot ens dot fr  2010-04-19 08:52 -------
Confirmed, probably introduced/uncovered between revisions 158215 (no ICE) and
158486 (ICE).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug middle-end/43793] [4.6 Regression] tree check: expected tree that contains ‘decl minimal’ structure, have ‘indirect_ref’ in gfc_trans_array_bound_check

[jv244 at cam dot ac dot uk]

------- Comment #3 from jv244 at cam dot ac dot uk  2010-04-19 09:23 -------
Dominique, you should ask for 'bugzilla confirmation rights' which will allow
to touch the 'Confirm' fields etc...


-- 

jv244 at cam dot ac dot uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
      Known to fail|                            |4.6.0
      Known to work|                            |4.5.0
   Last reconfirmed|0000-00-00 00:00:00         |2010-04-19 09:23:45
               date|                            |
   Target Milestone|---                         |4.6.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug middle-end/43793] [4.6 Regression] tree check: expected tree that contains ‘decl minimal’ structure, have ‘indirect_ref’ in gfc_trans_array_bound_check

[dominiq at lps dot ens dot fr]

------- Comment #4 from dominiq at lps dot ens dot fr  2010-04-19 09:30 -------
> Dominique, you should ask for 'bug zilla confirmation rights' which will allow
> to touch the 'Confirm' fields etc...

Do you WHO I should ask for 'bug zilla confirmation rights'?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug middle-end/43793] [4.6 Regression] tree check: expected tree that contains ‘decl minimal’ structure, have ‘indirect_ref’ in gfc_trans_array_bound_check

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2010-04-19 09:50 -------
(In reply to comment #4)
> > Dominique, you should ask for 'bug zilla confirmation rights' which will allow
> > to touch the 'Confirm' fields etc...
> 
> Do you WHO I should ask for 'bug zilla confirmation rights'?

If you have svn write access you have full bugzilla rights if you use
a bugzilla account with your @gcc.gnu.org address.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug middle-end/43793] [4.6 Regression] tree check: expected tree that contains ‘decl minimal’ structure, have ‘indirect_ref’ in gfc_trans_array_bound_check

[dominiq at lps dot ens dot fr]

------- Comment #6 from dominiq at lps dot ens dot fr  2010-04-19 09:56 -------
> If you have svn write access you have full bugzilla rights if you use
> a bugzilla account with your @gcc.gnu.org address.

Indeed I don't have "svn write access" and I am not planning to ask for it in a
near future. Is there other ways to 'bugzilla confirmation rights'?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug middle-end/43793] [4.6 Regression] tree check: expected tree that contains ‘decl minimal’ structure, have ‘indirect_ref’ in gfc_trans_array_bound_check

[jv244 at cam dot ac dot uk]

------- Comment #7 from jv244 at cam dot ac dot uk  2010-04-19 11:56 -------
(In reply to comment #6)
> > If you have svn write access you have full bugzilla rights if you use
> > a bugzilla account with your @gcc.gnu.org address.
> 
> Indeed I don't have "svn write access" and I am not planning to ask for it in a
> near future. Is there other ways to 'bugzilla confirmation rights'?
> 

Nor do I have svn write access (afaik), but I can confirm/close/etc bugs. I
think this was something tobias burnus enabled? 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug fortran/43793] [4.6 Regression] tree check: expected tree that contains �decl minimal� structure, have �indirect_ref� in gfc_trans_array_bound_check

[pinskia at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]



------- Comment #8 from pinskia at gcc dot gnu dot org  2010-04-20 03:14 -------
It was introduced by:
2010-04-15  Steven G. Kargl  <kargl@gcc.gnu.org>

        PR fortran/30073
        * trans-array.c (gfc_trans_array_bound_check): Eliminate a redundant
        block of code.  Set name to the variable associated with the
descriptor.

Which added the following code:
+  if (descriptor->base.code != COMPONENT_REF)
+    name = IDENTIFIER_POINTER (DECL_NAME (descriptor));

It should check to see if descriptor is a DECL rather than if it is not 
COMPONENT_REF.  Also it should not be using ->base.code directly but use
TREE_CODE :).


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu dot org
          Component|middle-end                  |fortran
            Summary|[4.6 Regression] tree check:|[4.6 Regression] tree check:
                   |expected tree that contains |expected tree that contains
                   |‘decl minimal’ structure,   |�decl minimal�
                   |have ‘indirect_ref’ in      |structure, have
                   |gfc_trans_array_bound_check |�indirect_ref� in
                   |                            |gfc_trans_array_bound_check


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug fortran/43793] [4.6 Regression] tree check: expected tree that contains �decl minimal� structure, have �indirect_ref� in gfc_trans_array_bound_check

[jv244 at cam dot ac dot uk]

------- Comment #9 from jv244 at cam dot ac dot uk  2010-04-20 17:53 -------
yawn.... valid testcase here ftp://ftp.berlios.de/pub/cp2k/cp2k.tar.gz


-- 

jv244 at cam dot ac dot uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|ice-on-invalid-code         |ice-on-valid-code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug fortran/43793] [4.6 Regression] tree check: expected tree that contains �decl minimal� structure, have �indirect_ref� in gfc_trans_array_bound_check

[kargl at gcc dot gnu dot org]

------- Comment #10 from kargl at gcc dot gnu dot org  2010-04-20 18:01 -------
The submitted testcase is invalid. See R729.


-- 

kargl at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|ice-on-valid-code           |ice-on-invalid-code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug fortran/43793] [4.6 Regression] tree check: expected tree that contains �decl minimal� structure, have �indirect_ref� in gfc_trans_array_bound_check

[kargl at gcc dot gnu dot org]

-- 

kargl at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |kargl at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2010-04-19 09:23:45         |2010-04-20 18:30:35
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug fortran/43793] [4.6 Regression] tree check: expected tree that contains �decl minimal� structure, have �indirect_ref� in gfc_trans_array_bound_check

[kargl at gcc dot gnu dot org]

------- Comment #11 from kargl at gcc dot gnu dot org  2010-04-20 20:44 -------
I have a patch that prevents the ICE on the invalid code in comment #1.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug fortran/43793] [4.5/4.6 Regression] tree check: expected tree that contains �decl minimal� structure, have �indirect_ref� in gfc_trans_array_bound_check

[jv244 at cam dot ac dot uk]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2122 bytes --]



------- Comment #12 from jv244 at cam dot ac dot uk  2010-04-24 12:25 -------
This was also ported back to 4.5.1, causing a regression there. This is against
the policy of 'open for regression and documentation fixes'. It was also never
approved for the branch only trunk.

2010-04-16  Steven G. Kargl  <kargl@gcc.gnu.org>

        PR fortran/30073
        * trans-array.c (gfc_trans_array_bound_check): Eliminate a redundant
        block of code.  Set name to the variable associated with the
descriptor.

Just for completeness, this testcase again emphasizes that this is an ICE on
valid code.

MODULE fft_tools
  IMPLICIT NONE
  INTEGER, PARAMETER :: sp=4, dp=8
  INTEGER, PARAMETER :: lp = dp
CONTAINS
  SUBROUTINE sparse_alltoall ( rs, rq, rcount, rreq, group )
    COMPLEX(KIND=lp), DIMENSION(:, :), &
      POINTER                                :: rs
    COMPLEX(KIND=lp), DIMENSION(:, :), &
      POINTER                                :: rq
    INTEGER, DIMENSION(:) :: rcount,rreq
    INTEGER :: group, pos
    IF ( rcount(pos) /= 0 ) THEN
       rq(1:rcount(pos),pos) = rs(1:rcount(pos),pos)
    END IF
  END SUBROUTINE sparse_alltoall
END MODULE fft_tools


-- 

jv244 at cam dot ac dot uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenther at suse dot de
           Keywords|ice-on-invalid-code         |ice-on-valid-code
      Known to fail|4.6.0                       |4.5.1 4.6.0
            Summary|[4.6 Regression] tree check:|[4.5/4.6 Regression] tree
                   |expected tree that contains |check: expected tree that
                   |�decl minimal�          |contains �decl minimal�
                   |structure, have             |structure, have
                   |�indirect_ref� in       |�indirect_ref� in
                   |gfc_trans_array_bound_check |gfc_trans_array_bound_check
   Target Milestone|4.6.0                       |4.5.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug fortran/43793] [4.5/4.6 Regression] tree check: expected tree that contains �decl minimal� structure, have �indirect_ref� in gfc_trans_array_bound_check

[kargl at gcc dot gnu dot org]

------- Comment #13 from kargl at gcc dot gnu dot org  2010-04-24 16:56 -------
(In reply to comment #12)
> 
> Just for completeness, this testcase again emphasizes that this is an ICE on
> valid code.
> 
> MODULE fft_tools
>   IMPLICIT NONE
>   INTEGER, PARAMETER :: sp=4, dp=8
>   INTEGER, PARAMETER :: lp = dp
> CONTAINS
>   SUBROUTINE sparse_alltoall ( rs, rq, rcount, rreq, group )
>     COMPLEX(KIND=lp), DIMENSION(:, :), &
>       POINTER                                :: rs
>     COMPLEX(KIND=lp), DIMENSION(:, :), &
>       POINTER                                :: rq
>     INTEGER, DIMENSION(:) :: rcount,rreq
>     INTEGER :: group, pos
>     IF ( rcount(pos) /= 0 ) THEN
>        rq(1:rcount(pos),pos) = rs(1:rcount(pos),pos)
>     END IF
>   END SUBROUTINE sparse_alltoall
> END MODULE fft_tools

For even more completeness, the code in comment #12 is still
invalid.  Don't worry I'll fix it before I eventually commit
the patch as noted in comment #11.


-- 

kargl at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|rguenther at suse dot de    |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug fortran/43793] [4.5/4.6 Regression] tree check: expected tree that contains �decl minimal� structure, have �indirect_ref� in gfc_trans_array_bound_check

[jv244 at cam dot ac dot uk]

------- Comment #14 from jv244 at cam dot ac dot uk  2010-04-24 17:58 -------
(In reply to comment #13)

> For even more completeness, the code in comment #12 is still
> invalid.

do you mind to clarify ?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug fortran/43793] [4.5/4.6 Regression] tree check: expected tree that contains �decl minimal� structure, have �indirect_ref� in gfc_trans_array_bound_check

[kargl at gcc dot gnu dot org]

------- Comment #15 from kargl at gcc dot gnu dot org  2010-04-24 18:03 -------
(In reply to comment #14)
> (In reply to comment #13)
> 
> > For even more completeness, the code in comment #12 is still
> > invalid.
> 
> do you mind to clarify ?
> 

pos is undefined.

Here's the testcase I will be committing.module fft_tools
  implicit none
  integer, parameter :: lp = 8
contains
  subroutine sparse_alltoall (rs, rq, rcount)
    complex(kind=lp), dimension(:, :), pointer :: rs, rq
    integer, dimension(:) :: rcount
    integer :: pos
    pos = 1
    if (rcount(pos) /= 0) then
       rq(1:rcount(pos),pos) = rs(1:rcount(pos),pos)
    end if
  end subroutine sparse_alltoall
end module fft_tools


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug fortran/43793] [4.5/4.6 Regression] tree check: expected tree that contains �decl minimal� structure, have �indirect_ref� in gfc_trans_array_bound_check

[jv244 at cam dot ac dot uk]

------- Comment #16 from jv244 at cam dot ac dot uk  2010-04-24 18:12 -------
(In reply to comment #15)
> 
> pos is undefined.
> 

Ah, we're at that level.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug fortran/43793] [4.5/4.6 Regression] tree check: expected tree that contains �decl minimal� structure, have �indirect_ref� in gfc_trans_array_bound_check

[kargl at gcc dot gnu dot org]

------- Comment #17 from kargl at gcc dot gnu dot org  2010-04-24 18:38 -------
Patch is here:

http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01518.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug fortran/43793] [4.5/4.6 Regression] tree check: expected tree that contains �decl minimal� structure, have �indirect_ref� in gfc_trans_array_bound_check

[kargl at gcc dot gnu dot org]

------- Comment #18 from kargl at gcc dot gnu dot org  2010-04-24 20:32 -------
Subject: Bug 43793

Author: kargl
Date: Sat Apr 24 20:32:04 2010
New Revision: 158692

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=158692
Log:
2010-04-24  Steven G. Kargl  <kargl@gcc.gnu.org>

        PR fortran/30073
        PR fortran/43793
        * trans-array.c (gfc_trans_array_bound_check): Use TREE_CODE instead
        of mucking with a tree directly.

2010-04-24  Steven G. Kargl  <kargl@gcc.gnu.org>

        PR fortran/30073
        PR fortran/43793
        gfortran.dg/pr43793.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/pr43793.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-array.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug fortran/43793] [4.5/4.6 Regression] tree check: expected tree that contains �decl minimal� structure, have �indirect_ref� in gfc_trans_array_bound_check

[kargl at gcc dot gnu dot org]

------- Comment #19 from kargl at gcc dot gnu dot org  2010-04-24 21:47 -------
Subject: Bug 43793

Author: kargl
Date: Sat Apr 24 21:46:45 2010
New Revision: 158693

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=158693
Log:
010-04-24  Steven G. Kargl  <kargl@gcc.gnu.org>

        PR fortran/30073
        PR fortran/43793
        * trans-array.c (gfc_trans_array_bound_check): Use TREE_CODE instead
        of mucking with a tree directly.

2010-04-24  Steven G. Kargl  <kargl@gcc.gnu.org>

        PR fortran/30073
        PR fortran/43793
        gfortran.dg/pr43793.f90: New test.

Added:
    branches/gcc-4_5-branch/gcc/testsuite/gfortran.dg/pr43793.f90
Modified:
    branches/gcc-4_5-branch/gcc/fortran/ChangeLog
    branches/gcc-4_5-branch/gcc/fortran/trans-array.c
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793

[Bug fortran/43793] [4.5/4.6 Regression] tree check: expected tree that contains �decl minimal� structure, have �indirect_ref� in gfc_trans_array_bound_check

[kargl at gcc dot gnu dot org]

------- Comment #20 from kargl at gcc dot gnu dot org  2010-04-24 21:48 -------
Fix.


-- 

kargl at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43793