[Bug c++/43905] New: duplicate __PRETTY_FUNCTION__ symbol for functions differing in const-ness

[Bug c++/43905] New: duplicate __PRETTY_FUNCTION__ symbol for functions differing in const-ness

[wjp at usecode dot org]

When compiling the attached lll.ii file (from lll.c from the gfan maths package
at http://www.math.tu-berlin.de/~jensen/software/gfan/gfan.html ) with g++
4.5.0, I get the following error message:

g++  -O2 lll.ii -c -o lll.o
/tmp/ccRt1FUj.s: Assembler messages:
/tmp/ccRt1FUj.s:5145: Error: symbol
`_ZZN6MatrixIiEixEPiPP6VektorIiEiE19__PRETTY_FUNCTION__' is already defined


The error is not triggered with -O1, but it is triggered with -O1 -fipa-sra.

Looking at the generated .s, the problem appears to be that the same
XXX__PRETTY_FUNCTION__ symbol is generated for both an operator[] and its const
version.


g++ -v:

Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/local/gcc-4.5.0/libexec/gcc/x86_64-unknown-linux-gnu/4.5.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: /usr/local/gcc-4.5.0/src/gcc-4.5.0/configure
--enable-languages=c,c++,fortran --with-gnu-as
--with-gnu-as=/usr/local/binutils-2.20.1/bin/as --with-gnu-ld
--with-ld=/usr/local/binutils-2.20.1/bin/ld --with-gmp=/usr/local/mpir-1.2.2
--with-mpfr=/usr/local/mpfr-2.4.2 --with-mpc=/usr/local/mpc-0.8.1
--prefix=/usr/local/gcc-4.5.0
Thread model: posix
gcc version 4.5.0 (GCC)


-- 
           Summary: duplicate __PRETTY_FUNCTION__ symbol for functions
                    differing in const-ness
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: wjp at usecode dot org
 GCC build triplet: x86_64-unknown-linux-gnu
  GCC host triplet: x86_64-unknown-linux-gnu
GCC target triplet: x86_64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43905

[Bug c++/43905] duplicate __PRETTY_FUNCTION__ symbol for functions differing in const-ness

[wjp at usecode dot org]

------- Comment #1 from wjp at usecode dot org  2010-04-27 00:48 -------
Created an attachment (id=20498)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20498&action=view)
preprocessed source file


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43905

[Bug tree-optimization/43905] duplicate __PRETTY_FUNCTION__ symbol for functions differing in const-ness

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2010-04-27 00:52 -------
Matrix<int>::operator[](int*, Vektor<int>**, int)::__PRETTY_FUNCTION__


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43905

[Bug tree-optimization/43905] duplicate __PRETTY_FUNCTION__ symbol for functions differing in const-ness

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2010-04-27 02:08 -------
Very reduced testcase:
 extern void sf ( __const char *);
struct Matrix{
   int operator[](int n){
   sf ( __PRETTY_FUNCTION__);
 }
   int operator[](int n)const{
   sf ( __PRETTY_FUNCTION__);
 }
 };
 void calcmy(Matrix const &b, Matrix &c, int k){
 b[k];
 c[k];
 }


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |assemble-failure, wrong-code
   Last reconfirmed|0000-00-00 00:00:00         |2010-04-27 02:08:44
               date|                            |
   Target Milestone|---                         |4.5.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43905

[Bug tree-optimization/43905] [4.5/4.6 Regression] duplicate __PRETTY_FUNCTION__ symbol for functions differing in const-ness

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2010-04-27 09:30 -------
local statics need to be mangled before SRA changes the function signature.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jamborm at gcc dot gnu dot
                   |                            |org
            Summary|duplicate                   |[4.5/4.6 Regression]
                   |__PRETTY_FUNCTION__ symbol  |duplicate
                   |for functions differing in  |__PRETTY_FUNCTION__ symbol
                   |const-ness                  |for functions differing in
                   |                            |const-ness


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43905

[Bug tree-optimization/43905] [4.5/4.6 Regression] duplicate __PRETTY_FUNCTION__ symbol for functions differing in const-ness

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43905

[Bug tree-optimization/43905] [4.5/4.6 Regression] duplicate __PRETTY_FUNCTION__ symbol for functions differing in const-ness

[jamborm at gcc dot gnu dot org]

------- Comment #5 from jamborm at gcc dot gnu dot org  2010-06-10 21:39 -------
Mine 


-- 

jamborm at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jamborm at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2010-04-27 02:08:44         |2010-06-10 21:39:19
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43905

[Bug tree-optimization/43905] [4.5/4.6 Regression] duplicate __PRETTY_FUNCTION__ symbol for functions differing in const-ness

[jamborm at gcc dot gnu dot org]

------- Comment #6 from jamborm at gcc dot gnu dot org  2010-06-14 12:44 -------
Patch submitted to the mailing list:
http://gcc.gnu.org/ml/gcc-patches/2010-06/msg01146.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43905

[Bug tree-optimization/43905] [4.5/4.6 Regression] duplicate __PRETTY_FUNCTION__ symbol for functions differing in const-ness

[jamborm at gcc dot gnu dot org]

------- Comment #7 from jamborm at gcc dot gnu dot org  2010-06-16 12:22 -------
Subject: Bug 43905

Author: jamborm
Date: Wed Jun 16 12:21:56 2010
New Revision: 160832

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=160832
Log:
2010-06-16  Martin Jambor  <mjambor@suse.cz>

        PR tree-optimization/43905
        * tree-sra.c: Include tree-inline.h.
        (create_abstract_origin): Removed.
        (modify_function): Version the call graph node instead of creating
        abstract origins and dealing with same_body aliases.
        * tree-sra.c (ipa_sra_preliminary_function_checks): Check whether the
        function is versionable.
        * Makefile.in (tree-sra.o): Add TREE_INLINE_H to dependencies.

        * testsuite/g++.dg/torture/pr43905.C: New test.


Added:
    trunk/gcc/testsuite/g++.dg/torture/pr43905.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/Makefile.in
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-sra.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43905

[Bug tree-optimization/43905] [4.5 Regression] duplicate __PRETTY_FUNCTION__ symbol for functions differing in const-ness

[jakub at gcc dot gnu dot org]

------- Comment #8 from jakub at gcc dot gnu dot org  2010-06-24 11:58 -------
Fixed on the trunk.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.5/4.6 Regression]        |[4.5 Regression] duplicate
                   |duplicate                   |__PRETTY_FUNCTION__ symbol
                   |__PRETTY_FUNCTION__ symbol  |for functions differing in
                   |for functions differing in  |const-ness
                   |const-ness                  |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43905

[Bug tree-optimization/43905] [4.5 Regression] duplicate __PRETTY_FUNCTION__ symbol for functions differing in const-ness

[jamborm at gcc dot gnu dot org]

------- Comment #9 from jamborm at gcc dot gnu dot org  2010-06-29 13:16 -------
4.5 patch submitted to the mailing list:
http://gcc.gnu.org/ml/gcc-patches/2010-06/msg02896.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43905

[Bug tree-optimization/43905] [4.5 Regression] duplicate __PRETTY_FUNCTION__ symbol for functions differing in const-ness

[jamborm at gcc dot gnu dot org]

------- Comment #10 from jamborm at gcc dot gnu dot org  2010-06-30 13:27 -------
Subject: Bug 43905

Author: jamborm
Date: Wed Jun 30 13:26:17 2010
New Revision: 161604

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=161604
Log:
2010-06-30  Martin Jambor  <mjambor@suse.cz>

        PR tree-optimization/43905
        * tree-sra.c (encountered_recursive_call): Removed with all its uses.
        (convert_callers): Do not handle recursive calls specially.
        (create_abstract_origin): Removed.
        (modify_function): Version the call graph node instead of creating
        abstract origins and dealing with same_body aliases.
        (ipa_sra_preliminary_function_checks): Check whether the function
        is versionable.
        * Makefile.in (tree-sra.o): Add TREE_INLINE_H to dependencies.

        * testsuite/g++.dg/torture/pr43905.C: New test.


Added:
    branches/gcc-4_5-branch/gcc/testsuite/g++.dg/torture/pr43905.C
Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/Makefile.in
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_5-branch/gcc/tree-sra.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43905

[Bug tree-optimization/43905] [4.5 Regression] duplicate __PRETTY_FUNCTION__ symbol for functions differing in const-ness

[jamborm at gcc dot gnu dot org]

------- Comment #11 from jamborm at gcc dot gnu dot org  2010-07-02 13:28 -------
This is now fixed on both the trunk and the 4.5 branch.


-- 

jamborm at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43905